rubocop-jbuilder 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65d8956a31b6c1e7a41da5b6f141d6e87ad3c57aaaf177001a309309966cb1f1
-  data.tar.gz: 3aecca35e0f09f13d09336918a3d4337f9f5968434cf2cba837489ef6a7a0b10
+  metadata.gz: 7643a97e9b823f3197b2c8b1330dc168860c864d8c24fd07e7c3cca98d9d63fe
+  data.tar.gz: e92acc7906a5b0e4d1a5eecdb939bab8e1318540da1025b3c5fa80b056f67d6b
 SHA512:
-  metadata.gz: 93dc1a5baab5301e85af4f4261d22dbda7c100a8f01160fbbc750666aa3a297d0db6916436e70aea7bcee874479010fc6c2ad752e6150be474dd096bc4d3fb70
-  data.tar.gz: 420c7475ea90388c43174aa979bd71c61e6aceb1a37668d47cdb372b4f6d87078cab6bd6924f7fcfb537ef9fcf107a101045c5b3bfa213258ea3323ca6b680db
+  metadata.gz: 7ea81e6dc735622da7c99d21b5c0c4d8cc9b92f930aba1faa3d00947d06250269cbe32d7d20ec072146985111a46316e7c240d2477617270b551ea38a555824c
+  data.tar.gz: 2862246d08ca05e6e155bb7facc515cba9d59e41a21586004c2318197af217541c318470bf19e5c267d7f83d0b7d71322651b94298a2036794fa3b86af7ccc9a

data/CHANGELOG.md

@@ -1,4 +1,6 @@
 ## [Unreleased]
+- Fix PartialExists to search for multiple local paths
+- Fix PartialExists to search partials without `.json`
 
 ## [0.1.0] - 2024-01-08
 

data/lib/rubocop/cop/jbuilder/partial_exists.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathname'
+require "pathname"
 
 TEST_FILENAME = File.join(Dir.pwd, "app/views/testing/nested/show.json.jbuilder")
 
@@ -19,37 +19,37 @@ module RuboCop
 
         def on_send(node)
           has_partial?(node) do |actual|
-            all_paths = get_view_paths_from(actual)
+            all_globs = get_view_globs_from(actual)
 
-            return if all_paths.any? { |full_path| File.exist?(full_path) }
+            return if all_globs.any? { |glob| Dir.glob(glob).any? }
 
             base_path = rails_root_dirname(node)
-            relative_paths = all_paths.map { |full_path| relative_path(full_path, base_path) }
+            relative_paths = all_globs.map { |glob| relative_path(glob, base_path) }
             add_offense(actual, message: format(MSG, paths: relative_paths.join(", ")))
           end
         end
 
         private
 
-        def get_view_paths_from(node)
+        def get_view_globs_from(node)
           partial = node.source[1..-2]
           segments = partial.split("/")
-          segments.last.sub!(/.*/, '_\&.json.jbuilder')
+          segments.last.sub!(/.*/, '_\&*.jbuilder')
 
           specific_path = segments.count != 1
           return [File.join(rails_views_dirname(node), *segments)] if specific_path
 
-          paths = []
+          globs = []
           current_dirname = sut_dirname(node)
           while current_dirname != rails_views_dirname(node)
-            paths << File.join(current_dirname, *segments)
+            globs << File.join(current_dirname, *segments)
             current_dirname = File.expand_path("..", current_dirname)
           end
-          paths
+          globs
         end
 
-        def relative_path(full_path, base_path)
-          full = Pathname.new(full_path)
+        def relative_path(glob, base_path)
+          full = Pathname.new(glob.sub("*", ""))
           base = Pathname.new(base_path)
           full.relative_path_from(base).to_s
         end

data/lib/rubocop/jbuilder/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Jbuilder
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-jbuilder
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Carlos Molina A
@@ -41,7 +41,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- app/views/testing/_exists.json.jbuilder
+- app/views/testing/_exists.jbuilder
 - config/default.yml
 - lib/rubocop-jbuilder.rb
 - lib/rubocop/cop/jbuilder/partial_exists.rb