rubocop-intum 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91663a3b40a2838cc3a322c54c3fda8d8c1aca73a634e38a96665c3aa38786ee
-  data.tar.gz: 606e19e9eebea1d97a0e29d956fcd9b0ed18f230a3624eecc8ad37f21d1b1a78
+  metadata.gz: ec034bca9d1a04edb711e9122f2f831f7457b3018160eee272d978b16bc1372d
+  data.tar.gz: 8e811d95a43b87696f4e47213670509324e79f052cac18955f87b7b182f4448d
 SHA512:
-  metadata.gz: 5a86e39529cc2c51e9ed1ea161987e529685e8cbfce793b82f3e9d26b2e3219502a2910e40387a9f1a70ff090ab28fae53a3c6571f2346be7e5a8945e99fc2c6
-  data.tar.gz: 169baffde8d49aa0e6f62a0cd150fc530d696f8e0d1909afe806e05a27149bd21451b2cd98eeb03b70db15a9b8589535ff97a35b515757ff0912f4619854dd39
+  metadata.gz: 883138750e81dc556b3918daa9de3572841a8ba34e23e5ea6bd9e2e7ed6c0913f9d1468d0bfdba8465341cbd5aca790b1fe30c4bd96ff8dbe864d2f6d41f3326
+  data.tar.gz: c85b8294ded5ca2c851d90958bec706d6bd00b21fffb2ed46085e8c6621d5e10310f8dec5049b9724f89304ec9397fa4e295c297b2f1305b2ca368ee6509b9d6

data/.rubocop.yml

@@ -111,3 +111,17 @@ Metrics/PerceivedComplexity:
   IgnoredMethods: []
   Max: 20
 
+Metrics/AbcSize:
+  Description: >-
+                 A calculated magnitude based on number of assignments,
+                 branches, and conditions.
+  Reference:
+    - http://c2.com/cgi/wiki?AbcMetric
+    - https://en.wikipedia.org/wiki/ABC_Software_Metric
+  Enabled: true
+  VersionAdded: '0.27'
+  VersionChanged: '0.81'
+  # The ABC size is a calculated magnitude, so this number can be an Integer or
+  # a Float.
+  AllowedMethods: []
+  Max: 50

data/lib/rubocop/intum/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Intum
-    VERSION = "0.1.4"
+    VERSION = "0.1.5"
   end
 end

data/rubocop.yml

@@ -1,9 +1,13 @@
+# v0.1.5
+# https://github.com/intum/rubocop-intum/blob/main/rubocop.yml
+
 # tu wpisujemy tylko różnice w odniesieniu od domyślnych reguł z pliku:
 # https://github.com/rubocop-hq/rubocop/blob/master/config/default.yml
-# https://github.com/Shopify/ruby-style-guide/blob/v2.8.0/rubocop.yml
+# https://github.com/Shopify/ruby-style-guide/blob/main/rubocop.yml
 
 inherit_gem:
   rubocop-shopify: rubocop.yml
+# inherit_from: rubocop-shopify.yml
 
 require:
   - rubocop-minitest
@@ -65,21 +69,21 @@ Layout/FirstHashElementIndentation:
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
-Layout/SpaceBeforeBlockBraces:
-  Description: >-
-                 Checks that the left block brace has or doesn't have space
-                 before it.
-  Enabled: false
-  VersionAdded: '0.49'
-  EnforcedStyle: space
-  SupportedStyles:
-    - space
-    - no_space
-  EnforcedStyleForEmptyBraces: space
-  SupportedStylesForEmptyBraces:
-    - space
-    - no_space
-  VersionChanged: '0.52.1'
+# Layout/SpaceBeforeBlockBraces:
+#   Description: >-
+#                  Checks that the left block brace has or doesn't have space
+#                  before it.
+#   Enabled: false
+#   VersionAdded: '0.49'
+#   EnforcedStyle: no_space
+#   SupportedStyles:
+#     - space
+#     - no_space
+#   EnforcedStyleForEmptyBraces: space
+#   SupportedStylesForEmptyBraces:
+#     - space
+#     - no_space
+#   VersionChanged: '0.52.1'
 
 Layout/SpaceInsideHashLiteralBraces:
   Description: "Use spaces inside hash literal braces - or don't."
@@ -107,28 +111,17 @@ Layout/TrailingWhitespace:
   VersionChanged: '0.83'
   AllowInHeredoc: true # TO CHECK
 
-Metrics/AbcSize:
-  Description: >-
-                 A calculated magnitude based on number of assignments,
-                 branches, and conditions.
-  Reference:
-    - http://c2.com/cgi/wiki?AbcMetric
-    - https://en.wikipedia.org/wiki/ABC_Software_Metric
-  Enabled: true
-  VersionAdded: '0.27'
-  VersionChanged: '0.81'
-  # The ABC size is a calculated magnitude, so this number can be an Integer or
-  # a Float.
-  AllowedMethods: []
-  Max: 50
-
+Layout/ParameterAlignment:
+  EnforcedStyle: with_fixed_indentation
 
+# wyjaśnienie: nie wiem dlaczego get w prefixie metody jest zle
 Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
   StyleGuide: '#accessor_mutator_method_names'
   Enabled: false
   VersionAdded: '0.50'
 
+# wyjaśnienie: można to włączyć
 Naming/PredicateName:
   Description: 'Check the names of predicate methods.'
   StyleGuide: '#bool-methods-qmark'
@@ -158,6 +151,12 @@ Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
 
+# wyjaśnienie: railsy nie spełniają
+Naming/InclusiveLanguage:
+  Enabled: false
+
+# Naming/BlockForwarding:
+#   Enabled: false
 
 Style/AndOr:
   Description: 'Use &&/|| instead of and/or.'
@@ -172,14 +171,13 @@ Style/AndOr:
     - always
     - conditionals
 
-
-Style/AsciiComments:
-  Description: 'Use only ascii symbols in comments.'
-  StyleGuide: '#english-comments'
-  Enabled: false
-  VersionAdded: '0.9'
-  VersionChanged: '0.52'
-  AllowedChars: []
+# Style/AsciiComments:
+#   Description: 'Use only ascii symbols in comments.'
+#   StyleGuide: '#english-comments'
+#   Enabled: false
+#   VersionAdded: '0.9'
+#   VersionChanged: '0.52'
+#   AllowedChars: []
 
 Style/BlockDelimiters:
   Description: >-
@@ -302,7 +300,7 @@ Style/ClassAndModuleChildren:
   # have the knowledge to perform either operation safely and thus requires
   # manual oversight.
   SafeAutoCorrect: false
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.19'
   #
   # Basically there are two different styles:
@@ -318,25 +316,25 @@ Style/ClassAndModuleChildren:
   #   end
   #
   # The compact style is only forced, for classes or modules with one child.
-  EnforcedStyle: nested
+  EnforcedStyle: compact
   SupportedStyles:
     - nested
     - compact
 
-Style/CommentedKeyword:
-  Description: 'Do not place comments on the same line as certain keywords.'
-  Enabled: false
-  VersionAdded: '0.51'
+# Style/CommentedKeyword:
+#   Description: 'Do not place comments on the same line as certain keywords.'
+#   Enabled: false
+#   VersionAdded: '0.51'
 
 Style/ConditionalAssignment:
   Description: >-
                  Use the return value of `if` and `case` statements for
                  assignment to a variable and variable comparison instead
                  of assigning that variable inside of each branch.
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.36'
   VersionChanged: '0.47'
-  EnforcedStyle: assign_to_condition
+  EnforcedStyle: assign_inside_condition
   SupportedStyles:
     - assign_to_condition
     - assign_inside_condition
@@ -347,16 +345,15 @@ Style/ConditionalAssignment:
   # will only register an offense for assignment to a condition that has
   # at least one multiline branch.
   SingleLineConditionsOnly: true
-  IncludeTernaryExpressions: true
-
-Style/Documentation:
-  Description: 'Document classes and non-namespace modules.'
-  Enabled: false
-  VersionAdded: '0.9'
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
+  IncludeTernaryExpressions: false
 
+# Style/Documentation:
+#   Description: 'Document classes and non-namespace modules.'
+#   Enabled: false
+#   VersionAdded: '0.9'
+#   Exclude:
+#     - 'spec/**/*'
+#     - 'test/**/*'
 
 Style/EmptyMethod:
   Description: 'Checks the formatting of empty method definitions.'
@@ -405,10 +402,10 @@ Style/FrozenStringLiteralComment:
   Description: >-
                  Add the frozen_string_literal comment to the top of files
                  to help transition to frozen string literals by default.
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.36'
   VersionChanged: '0.79'
-  EnforcedStyle: always
+  EnforcedStyle: never
   SupportedStyles:
     # `always` will always add the frozen string literal comment to a file
     # regardless of the Ruby version or if `freeze` or `<<` are called on a
@@ -424,37 +421,38 @@ Style/FrozenStringLiteralComment:
   SafeAutoCorrect: false
 
 
-Style/IfUnlessModifier:
-  Description: >-
-                 Favor modifier if/unless usage when you have a
-                 single-line body.
-  StyleGuide: '#if-as-a-modifier'
-  Enabled: false
-  VersionAdded: '0.9'
-  VersionChanged: '0.30'
+# Style/IfUnlessModifier:
+#   Description: >-
+#                  Favor modifier if/unless usage when you have a
+#                  single-line body.
+#   StyleGuide: '#if-as-a-modifier'
+#   Enabled: false
+#   VersionAdded: '0.9'
+#   VersionChanged: '0.30'
 
 Style/MultilineMethodSignature:
   Description: 'Avoid multi-line method signatures.'
   Enabled: true
   VersionAdded: '0.59'
 
-Style/MutableConstant:
-  Description: 'Do not assign mutable objects to constants.'
-  Enabled: false
-  VersionAdded: '0.34'
-  VersionChanged: '0.65'
-  EnforcedStyle: literals
-  SupportedStyles:
-    # literals: freeze literals assigned to constants
-    # strict: freeze all constants
-    # Strict mode is considered an experimental feature. It has not been updated
-    # with an exhaustive list of all methods that will produce frozen objects so
-    # there is a decent chance of getting some false positives. Luckily, there is
-    # no harm in freezing an already frozen object.
-    - literals
-    - strict
+# Style/MutableConstant:
+#   Description: 'Do not assign mutable objects to constants.'
+#   Enabled: false
+#   VersionAdded: '0.34'
+#   VersionChanged: '0.65'
+#   EnforcedStyle: literals
+#   SupportedStyles:
+#     # literals: freeze literals assigned to constants
+#     # strict: freeze all constants
+#     # Strict mode is considered an experimental feature. It has not been updated
+#     # with an exhaustive list of all methods that will produce frozen objects so
+#     # there is a decent chance of getting some false positives. Luckily, there is
+#     # no harm in freezing an already frozen object.
+#     - literals
+#     - strict
 
 
+# wyjaśnienie: generalnie jestem przeciwnikiem `unless`
 Style/NegatedIf:
   Description: >-
                  Favor unless over if for negative conditions
@@ -475,24 +473,24 @@ Style/NegatedIf:
 Style/NilComparison:
   Description: 'Prefer x.nil? to x == nil.'
   StyleGuide: '#predicate-methods'
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.12'
   VersionChanged: '0.59'
-  EnforcedStyle: predicate
+  EnforcedStyle: comparison
   SupportedStyles:
     - predicate
     - comparison
 
-Style/NumericLiterals:
-  Description: >-
-                 Add underscores to large numeric literals to improve their
-                 readability.
-  StyleGuide: '#underscores-in-numerics'
-  Enabled: false
-  VersionAdded: '0.9'
-  VersionChanged: '0.48'
-  MinDigits: 5
-  Strict: false
+# Style/NumericLiterals:
+#   Description: >-
+#                  Add underscores to large numeric literals to improve their
+#                  readability.
+#   StyleGuide: '#underscores-in-numerics'
+#   Enabled: false
+#   VersionAdded: '0.9'
+#   VersionChanged: '0.48'
+#   MinDigits: 5
+#   Strict: false
 
 
 Style/NumericPredicate:
@@ -535,6 +533,7 @@ Style/PercentLiteralDelimiters:
     '%W': '[]'
   VersionChanged: '0.48.1'
 
+# wyjaśnienie: do przemyślenia (choć self. wydaje mi się ok)
 Style/RedundantSelf:
   Description: "Don't use self where it's not needed."
   StyleGuide: '#no-self-unless-required'
@@ -560,19 +559,19 @@ Style/StringLiterals:
 #   # use the same type of quotes on each line.
 #   ConsistentQuotesInMultiline: false
 
+# Style/SymbolArray:
+#   Description: 'Use %i or %I for arrays of symbols.'
+#   StyleGuide: '#percent-i'
+#   Enabled: false
+#   VersionAdded: '0.9'
+#   VersionChanged: '0.49'
+#   EnforcedStyle: percent
+#   MinSize: 2
+#   SupportedStyles:
+#     - percent
+#     - brackets
 
-Style/SymbolArray:
-  Description: 'Use %i or %I for arrays of symbols.'
-  StyleGuide: '#percent-i'
-  Enabled: false
-  VersionAdded: '0.9'
-  VersionChanged: '0.49'
-  EnforcedStyle: percent
-  MinSize: 2
-  SupportedStyles:
-    - percent
-    - brackets
-
+# wyjaśnienie: to przemyślenia
 Style/SymbolProc:
   Description: 'Use symbols as procs instead of blocks when possible.'
   Enabled: false
@@ -643,11 +642,12 @@ Style/GuardClause:
   # needs to have to trigger this cop
   MinBodyLength: 4
 
-Lint/DuplicateBranch:
-  Description: Checks that there are no repeated bodies within `if/unless`, `case-when` and `rescue` constructs.
-  Enabled: false
-  VersionAdded: '1.3'
+# Lint/DuplicateBranch:
+#   Description: Checks that there are no repeated bodies within `if/unless`, `case-when` and `rescue` constructs.
+#   Enabled: false
+#   VersionAdded: '1.3'
 
+# wyjaśnienie: lepsze jest `var_name = $2 || $1` niż `var_name = ::Regexp.last_match(2) || ::Regexp.last_match(1)`
 Style/PerlBackrefs:
   Description: 'Avoid Perl-style regex back references.'
   StyleGuide: '#no-perl-regexp-last-matchers'
@@ -656,23 +656,24 @@ Style/PerlBackrefs:
 
 Style/ZeroLengthPredicate:
   Description: 'Use #empty? when testing for objects of length 0.'
-  Enabled: false
-  Safe: false
+  Enabled: true
+  Safe: true
   VersionAdded: '0.37'
   VersionChanged: '0.39'
 
-Style/AccessModifierDeclarations:
-  Description: 'Checks style of how access modifiers are used.'
-  Enabled: false
-  VersionAdded: '0.57'
-  VersionChanged: '0.81'
-  EnforcedStyle: inline
-  SupportedStyles:
-    - inline
-    - group
-  AllowModifiersOnSymbols: true
-Style/MapToHash:
-  Enabled: false
+# Style/AccessModifierDeclarations:
+#   Description: 'Checks style of how access modifiers are used.'
+#   Enabled: false
+#   VersionAdded: '0.57'
+#   VersionChanged: '0.81'
+#   EnforcedStyle: inline
+#   SupportedStyles:
+#     - inline
+#     - group
+#   AllowModifiersOnSymbols: true
+
+# Style/MapToHash:
+#   Enabled: false
 
 # Style/RegexpLiteral:
 #   Description: 'Use / or %r around regular expressions.'
@@ -692,6 +693,31 @@ Style/MapToHash:
 #   # are found in the regexp string.
 #   AllowInnerSlashes: false
 
+Style/HashSyntax:
+  EnforcedShorthandSyntax: 'either'
+
+# Style/FetchEnvVar:
+#   Enabled: false
+
+# wyjaśnienie: do włączenia
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
+  # AllowedMethods:
+  # - require
+  # - require_relative
+  # - require_dependency
+  # - yield
+  # - raise
+  # - puts
+  # Exclude:
+  # - "/**/Gemfile"
+
+Style/ClassMethodsDefinitions:
+  EnforcedStyle: def_self
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: no_comma
+
 
 ###### RAILS ######
 ###### RAILS ######
@@ -707,15 +733,18 @@ Rails/UnknownEnv:
       - development
       - test
 
-Rails/FilePath:
-  Enabled: false
+# Rails/FilePath:
+#   Enabled: false
 
+# wyjaśnienie: zwykla metoda wydaje sie lepsza niz nowa skladnia `delegate`
 Rails/Delegate:
   Enabled: false
 
+# wyjaśnienie: lepiej wygląda `![a:, :b].include?(:a)` niż `[:a, :b].exclude?(:a)`
 Rails/NegateInclude:
   Enabled: false
 
+# wyjaśnienie: do ustalenia
 Rails/SkipsModelValidations:
   Enabled: false
 
@@ -723,68 +752,32 @@ Rails/SkipsModelValidations:
 #   Enabled: true
 #   SafeAutoCorrect: false
 
-## MINITEST
-
-Minitest/TestMethodName:
-  Enabled: false
-
-Minitest/AssertWithExpectedArgument:
-  Enabled: false
-
-Minitest/MultipleAssertions:
-  Enabled: false
-
-## PERFORMANCE
-
-Performance/CollectionLiteralInLoop:
+# wyjaśnienie: do ustalenia
+Rails/ReversibleMigration:
   Enabled: false
 
-Naming/InclusiveLanguage:
-  Enabled: false
+Rails/WhereExists:
+  EnforcedStyle: where
 
-Rails/ReversibleMigration:
-  Enabled: false
+## MINITEST
 
-# ruby 3.1 (na razie wyłączamy)
+# Minitest/TestMethodName:
+#   Enabled: false
 
-Style/HashSyntax:
-  EnforcedShorthandSyntax: 'either'
+# Minitest/AssertWithExpectedArgument:
+#   Enabled: false
 
-Naming/BlockForwarding:
+Minitest/MultipleAssertions:
   Enabled: false
 
 Minitest/AssertPredicate:
   Enabled: false
 
-# TODO: do włączenia
-Rails/I18nLocaleTexts:
+Minitest/AssertInDelta:
   Enabled: false
 
-Style/FetchEnvVar:
-  Enabled: false
-
-Layout/ParameterAlignment:
-  EnforcedStyle: with_fixed_indentation
+## PERFORMANCE
 
-Style/MethodCallWithArgsParentheses:
+Performance/CollectionLiteralInLoop:
   Enabled: false
-  # AllowedMethods:
-  # - require
-  # - require_relative
-  # - require_dependency
-  # - yield
-  # - raise
-  # - puts
-  # Exclude:
-  # - "/**/Gemfile"
 
-Rails/WhereExists:
-  EnforcedStyle: where
-  Enabled: true
-
-Style/ClassMethodsDefinitions:
-  EnforcedStyle: def_self
-  Enabled: true
-
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: no_comma

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-intum
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Marcin
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-23 00:00:00.000000000 Z
+date: 2022-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop-shopify