rubocop-infinum 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8880040332319a24731a15c229bf9ec8959c2f3b0a1307be6ff3104ddbf2caeb
-  data.tar.gz: e276673139e2486ab42e3787aac4844543c5fb7516f809f533654e7f9c6ffa89
+  metadata.gz: 4fc4711fd647610ed8335a849d8b9304fcef2e29c591db3f624b72edd9f2136c
+  data.tar.gz: c443ad3f100d2b96dae4b3cfb8be49949cfd68324633a2c940e9f3f13b335fef
 SHA512:
-  metadata.gz: f8869b6c02708ed18e174a91a723af17c652badb5f1022b78f2d2485945afa81945216a59940968cd679e855db4abb646adfe3bf21c3d1bee05d5c7e88ca9a0b
-  data.tar.gz: 816242140887f448de62cb9ef450345870780225e7a572a8047b1e05a9c126a949534a578fd659c293a0a0913811f12a011b035db3be7734c7d1243f0672f102
+  metadata.gz: a85ead5e9b4035c4261c4f72923a9ff460087db466aff4c74dee2fa1727412c327310bb0fb133c70cbb32f8e5db322f28a5c6e14234b1c2b514298b836c83095
+  data.tar.gz: 83ef437f62cc8fa3c48dfd046e8aee50cdee83784ba200bece3f83f3c26e76b96cac188224f0a079ab4e72973df2d5f8002c3ca0645df1f880f9660dad32334c

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # RuboCop Infinum Change Log
 
+## 0.1.0 (Sep 8th, 2020)
+
+- add autocorrect method to `Rails/AttributeDefaultBlockValue`
+- refactor cop `Rails/AttributeDefaultBlockValue` cop
+
+
 ## 0.0.1 (Aug 28th, 2020)
 
 - create custom cop `Rails/AttributeDefaultBlockValue`

data/README.md

@@ -12,7 +12,9 @@ And add to the top of your project's RuboCop configuration file:
 
   ~~~yml
   inherit_gem:
-    rubocop-infinum: rubocop.yml
+    rubocop-infinum: .rubocop.yml
+
+  require: rubocop-infinum
   ~~~
 
 If you dislike some rules, please check [RuboCop's documentation](https://rubocop.readthedocs.io/en/latest/configuration/#inheriting-configuration-from-a-dependency-gem) on inheriting configuration from a gem.

data/lib/rubocop/cop/infinum/attribute_default_block_value.rb

@@ -5,8 +5,8 @@ require 'rubocop'
 module RuboCop
   module Cop
     module Infinum
-      # This cop looks for `attribute` class methods that don't
-      # specify a `:default` option inside a block.
+      # This cop looks for `attribute` class methods that specify a `:default` option
+      # and pass it a method without a block.
       #
       # @example
       #   # bad
@@ -19,36 +19,28 @@ module RuboCop
       #     attribute :confirmed_at, :datetime, default: -> { Time.zone.now }
       #   end
       class AttributeDefaultBlockValue < ::RuboCop::Cop::Cop
-        MSG = 'Pass a block to `:default` option.'
+        MSG = 'Pass method in a block to `:default` option.'
 
-        def_node_search :active_resource_class?, <<~PATTERN
-          (const (const nil? :ActiveResource) :Base)
+        def_node_matcher :default_attribute, <<~PATTERN
+          (send nil? :attribute _ _ (hash <$#attribute ...>))
         PATTERN
 
-        def_node_matcher :attribute?, '(send nil? :attribute _ _ $hash)'
+        def_node_matcher :attribute, '(pair (sym :default) $_)'
 
         def on_send(node)
-          return if active_resource?(node.parent)
+          default_attribute(node) do |attribute|
+            value = attribute.children.last
 
-          attribute?(node) do |third_arg|
-            default_attribute = default_attribute(third_arg)
-
-            unless [:block, :true, :false].include?(default_attribute.children.last.type) # rubocop:disable Lint/BooleanSymbol
-              add_offense(node, location: default_attribute)
-            end
+            add_offense(node, location: value) if value.send_type?
           end
         end
 
-        private
-
-        def active_resource?(node)
-          return false if node.nil?
+        def autocorrect(node)
+          expression = default_attribute(node).children.last
 
-          active_resource_class?(node)
-        end
-
-        def default_attribute(node)
-          node.children.first
+          lambda do |corrector|
+            corrector.replace(expression, "-> { #{expression.source} }")
+          end
         end
       end
     end

data/lib/rubocop/infinum/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Infinum
-    VERSION = '0.0.1'
+    VERSION = '0.1.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-infinum
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Marko Ćilimković
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-28 00:00:00.000000000 Z
+date: 2020-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-byebug