rubocop-greppable_rails 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: f1be36eb13930a87a25368cd98c5967555905e4839296eadc2c97071057d1f1c
+  data.tar.gz: 6891e48304da1a776bd5a15d2b30c69742b590f081efa85a608904895f6cbc4b
+SHA512:
+  metadata.gz: b8f1255afa149ed4f39338747feba0b1168c7a2f3c6a3a4c852826cc62abc526d986176fa9d315663c6a42375217b8f824a5002965af680070fa7770aad889b1
+  data.tar.gz: d0043669fa145fb392a94b97197a100b4f81fc4a0326ff03806911b2443c33765ba97e9e730bb0d9aba33562f2e10d7d89c5df429c3078dd7abbc17866cfd6f3

data/.github/workflows/main.yml

@@ -0,0 +1,19 @@
+name: Ruby
+
+on: [push,pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.7', '3.0' ]
+    name: Test on Ruby ${{ matrix.ruby }}
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: Execute test & rubocop
+      run: bundle exec rake

data/.gitignore

@@ -0,0 +1,10 @@
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+/spec/examples.txt
+Gemfile.lock

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,24 @@
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: disable
+  SuggestExtensions: false
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Layout/LineLength:
+  Max: 120
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/
+  Max: 100
+
+Naming/FileName:
+  Exclude:
+    - lib/rubocop-greppable_rails.rb

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,84 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at rise.shia@gmail.com. All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior,  harassment of an individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0,
+available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations.

data/Gemfile

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+# Specify your gem's dependencies in rubocop-greppable_rails.gemspec
+gemspec
+
+gem "rake", "~> 13.0"
+gem "rspec"
+
+gem "rubocop", "~> 1.7"

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2021 Shia
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -0,0 +1,39 @@
+# Rubocop::GreppableRails
+
+Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/rubocop/greppable_rails`. To experiment with that code, run `bin/console` for an interactive prompt.
+
+TODO: Delete this and the text above, and describe your gem
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'rubocop-greppable_rails'
+```
+
+And then execute:
+
+    $ bundle install
+
+Or install it yourself as:
+
+    $ gem install rubocop-greppable_rails
+
+## Usage
+
+TODO: Write usage instructions here
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/riseshia/rubocop-greppable_rails. This project is intended to be a safe, welcoming space for collaboration.
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+require "bundler/gem_tasks"
+require "rubocop/rake_task"
+
+RuboCop::RakeTask.new
+
+task default: :rubocop

data/bin/console

@@ -0,0 +1,15 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require "bundler/setup"
+require "rubocop-greppable_rails"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start(__FILE__)

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/config/default.yml

@@ -0,0 +1,24 @@
+# Common configuration.
+
+inherit_mode:
+  merge:
+    - Exclude
+
+GreppableRails/DontIncludeInHelper:
+  Description: 'Prohibit include in Helper.'
+  Enabled: true
+  VersionAdded: '0.1.0'
+  Include:
+    - app/helper/**/*.rb
+
+GreppableRails/UseInlineAccessModifier:
+  Description: 'Use inline style access modifier.'
+  Enabled: true
+  VersionAdded: '0.1.0'
+
+GreppableRails/DontCallHelperInController:
+  Description: 'Prohibit include helper via call helper in Controller.'
+  Enabled: true
+  VersionAdded: '0.1.0'
+  Include:
+    - app/controllers/**/*.rb

data/lib/rubocop-greppable_rails.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+require_relative "rubocop/greppable_rails"
+require_relative "rubocop/cop/greppable_rails_cops"

data/lib/rubocop/cop/greppable_rails/dont_call_helper_in_controller.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GreppableRails
+      # @example
+      #   # bad
+      #   class FooController
+      #     helper :bar
+      #   end
+      class DontCallHelperInController < Base
+        MSG = "Don't include helper via call helper in Controller."
+
+        RESTRICT_ON_SEND = %i[helper].freeze
+
+        def_node_matcher :helper_call?, <<~PATTERN
+          (send nil? {:helper} (sym _))
+        PATTERN
+
+        def on_send(node)
+          parent_node = node.parent
+          return unless parent_node.type == :class
+
+          class_name = parent_node.children.first.children.last.to_s
+          return unless class_name.end_with?("Controller")
+
+          add_offense(node) if offense?(node)
+        end
+
+        private
+
+        def offense?(node)
+          return true if node.arguments.empty?
+
+          node.arguments.first.type == :sym
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/greppable_rails/dont_include_in_helper.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GreppableRails
+      # This cop looks for include Helper execution.
+      # Including Helper, in most cases, makes:
+      # - hard to find out some helper method is used or not.
+      # - constant dependency more complex, which causes changing code how impact to be unpredictable.
+      #
+      # @example
+      #   # bad
+      #   # app/helpers/post_helper.rb
+      #   module PostHelper
+      #     def some_post_link(post)
+      #       # make some awesome link...
+      #     end
+      #   end
+      #
+      #   # app/helpers/top_helper.rb
+      #   module TopHelper
+      #     include PostHelper
+      #
+      #     def some_link(posts)
+      #       some_post_link(post)
+      #     end
+      #   end
+      #
+      #   # good
+      #   # app/helpers/post_link_tag.rb
+      #   module PostLinkTag
+      #     module_function
+      #
+      #     def some_post_link(post)
+      #       # make some awesome link...
+      #     end
+      #   end
+      #
+      #   # app/helpers/top_helper.rb
+      #   module TopHelper
+      #     def some_link(posts)
+      #       PostLinkTag.some_post_link(post)
+      #     end
+      #   end
+      #
+      class DontIncludeInHelper < Base
+        MSG = "Do not include in Helper."
+        RESTRICT_ON_SEND = %i[include].freeze
+
+        def_node_matcher :render_with_inline_option?, <<~PATTERN
+          (send _ :include (const _ _))
+        PATTERN
+
+        def on_send(node)
+          parent_node = node.parent
+          return unless parent_node.type == :module
+
+          module_name = parent_node.children.first.children.last.to_s
+          return unless module_name.end_with?("Helper")
+
+          add_offense(node) if render_with_inline_option?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/greppable_rails/use_inline_access_modifier.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GreppableRails
+      # @example
+      #   # bad
+      #   class Foo
+      #     def bar; end
+      #     private :bar
+      #
+      #     private
+      #     def baz; end
+      #   end
+      #
+      #   # good
+      #   class Foo
+      #     private def bar; end
+      #     private def baz; end
+      #   end
+      class UseInlineAccessModifier < Base
+        MSG = "Use inline style access modifier."
+
+        RESTRICT_ON_SEND = %i[private protected].freeze
+
+        def_node_matcher :access_modifier_with_symbol?, <<~PATTERN
+          (send nil? {:private :protected} (sym _))
+        PATTERN
+
+        def on_send(node)
+          return unless node.access_modifier?
+          return if node.parent&.pair_type?
+
+          add_offense(node) if offense?(node)
+        end
+
+        private
+
+        def offense?(node)
+          return true if node.arguments.empty?
+
+          node.arguments.first.type == :sym
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/greppable_rails_cops.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+require_relative "greppable_rails/dont_call_helper_in_controller"
+require_relative "greppable_rails/dont_include_in_helper"
+require_relative "greppable_rails/use_inline_access_modifier"

data/lib/rubocop/greppable_rails.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require_relative "greppable_rails/version"
+
+module Rubocop
+  # Root module for GreppableRails
+  module GreppableRails
+  end
+end

data/lib/rubocop/greppable_rails/version.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Rubocop
+  module GreppableRails
+    VERSION = "0.1.0"
+  end
+end

data/rubocop-greppable_rails.gemspec

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path("lib", __dir__)
+
+require "rubocop/greppable_rails/version"
+
+Gem::Specification.new do |spec|
+  spec.name          = "rubocop-greppable_rails"
+  spec.version       = Rubocop::GreppableRails::VERSION
+  spec.authors       = ["Shia"]
+  spec.email         = ["rise.shia@gmail.com"]
+
+  spec.summary       = "rubocop/ReadableRails"
+  spec.description   = "For greppable rails"
+  spec.homepage      = "https://github.com/riseshia/rubocop-greppable_rails"
+  spec.license       = "MIT"
+  spec.required_ruby_version = ">= 2.7.0"
+
+  # spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"
+
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/riseshia/rubocop-greppable_rails"
+  spec.metadata["changelog_uri"] = "https://github.com/riseshia/rubocop-greppable_rails"
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{\A(?:test|spec|features)/}) }
+  end
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  # Uncomment to register a new dependency of your gem
+  # spec.add_dependency "example-gem", "~> 1.0"
+
+  # For more information and examples about making a new gem, checkout our
+  # guide at: https://bundler.io/guides/creating_gem.html
+end

metadata

@@ -0,0 +1,66 @@
+--- !ruby/object:Gem::Specification
+name: rubocop-greppable_rails
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Shia
+autorequire:
+bindir: exe
+cert_chain: []
+date: 2021-07-30 00:00:00.000000000 Z
+dependencies: []
+description: For greppable rails
+email:
+- rise.shia@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".github/workflows/main.yml"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- CODE_OF_CONDUCT.md
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- bin/console
+- bin/setup
+- config/default.yml
+- lib/rubocop-greppable_rails.rb
+- lib/rubocop/cop/greppable_rails/dont_call_helper_in_controller.rb
+- lib/rubocop/cop/greppable_rails/dont_include_in_helper.rb
+- lib/rubocop/cop/greppable_rails/use_inline_access_modifier.rb
+- lib/rubocop/cop/greppable_rails_cops.rb
+- lib/rubocop/greppable_rails.rb
+- lib/rubocop/greppable_rails/version.rb
+- rubocop-greppable_rails.gemspec
+homepage: https://github.com/riseshia/rubocop-greppable_rails
+licenses:
+- MIT
+metadata:
+  homepage_uri: https://github.com/riseshia/rubocop-greppable_rails
+  source_code_uri: https://github.com/riseshia/rubocop-greppable_rails
+  changelog_uri: https://github.com/riseshia/rubocop-greppable_rails
+post_install_message:
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.7.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubygems_version: 3.2.3
+signing_key:
+specification_version: 4
+summary: rubocop/ReadableRails
+test_files: []