rubocop-graphql 1.0.0 → 1.0.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/lib/rubocop/cop/graphql/field_definitions.rb +2 -2
- data/lib/rubocop/cop/graphql/field_hash_key.rb +2 -2
- data/lib/rubocop/cop/graphql/field_method.rb +2 -2
- data/lib/rubocop/cop/graphql/not_authorized_node_type.rb +15 -1
- data/lib/rubocop/cop/graphql/unused_argument.rb +1 -1
- data/lib/rubocop/graphql/field.rb +4 -1
- data/lib/rubocop/graphql/heredoc.rb +1 -1
- data/lib/rubocop/graphql/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: a7531302386361a75baf74bcb65e70041bf5b414fb55151c1bcb6eb9e40bbb92
|
4
|
+
data.tar.gz: 43943f69aacfebc7ea8060af236796c499b671ac8825853a77961105bc57afe5
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: e67d5bba4243ca1e4122af69449871465e9e8124574d0a379e2125f4e0b13ce05a6d48f0c44f129ad8fbcc3fb4af692bb5e366ce4fa9d1b8c125d276d1f17e53
|
7
|
+
data.tar.gz: c6020f17e1828c0fe135e7ca398c36b8ed322ff9daf86d3616ade152b8391e213565a6b1a5c1b185a436c0f2b9d68c805135c39973f18e0fbb0e58d4ccab3895
|
@@ -220,7 +220,7 @@ module RuboCop
|
|
220
220
|
|
221
221
|
def remove_old_resolver(corrector, resolver_definition)
|
222
222
|
range_to_remove = range_with_surrounding_space(
|
223
|
-
range: resolver_definition.
|
223
|
+
range: resolver_definition.source_range, side: :left
|
224
224
|
)
|
225
225
|
corrector.remove(range_to_remove)
|
226
226
|
|
@@ -229,7 +229,7 @@ module RuboCop
|
|
229
229
|
return unless resolver_signature
|
230
230
|
|
231
231
|
range_to_remove = range_with_surrounding_space(
|
232
|
-
range: resolver_signature.
|
232
|
+
range: resolver_signature.source_range, side: :left
|
233
233
|
)
|
234
234
|
corrector.remove(range_to_remove)
|
235
235
|
end
|
@@ -74,11 +74,11 @@ module RuboCop
|
|
74
74
|
suggested_hash_key_name = hash_key_to_use(method_definition)
|
75
75
|
|
76
76
|
corrector.insert_after(
|
77
|
-
node.
|
77
|
+
node.source_range, ", hash_key: #{suggested_hash_key_name.inspect}"
|
78
78
|
)
|
79
79
|
|
80
80
|
range = range_with_surrounding_space(
|
81
|
-
range: method_definition.
|
81
|
+
range: method_definition.source_range, side: :left
|
82
82
|
)
|
83
83
|
|
84
84
|
corrector.remove(range)
|
@@ -68,10 +68,10 @@ module RuboCop
|
|
68
68
|
method_definition = suggest_method_name_for(field)
|
69
69
|
suggested_method_name = method_to_use(method_definition)
|
70
70
|
|
71
|
-
corrector.insert_after(node.
|
71
|
+
corrector.insert_after(node.source_range, ", method: :#{suggested_method_name}")
|
72
72
|
|
73
73
|
range = range_with_surrounding_space(
|
74
|
-
range: method_definition.
|
74
|
+
range: method_definition.source_range, side: :left
|
75
75
|
)
|
76
76
|
corrector.remove(range)
|
77
77
|
end
|
@@ -20,6 +20,20 @@ module RuboCop
|
|
20
20
|
# end
|
21
21
|
# end
|
22
22
|
#
|
23
|
+
# # good
|
24
|
+
#
|
25
|
+
# class UserType < BaseType
|
26
|
+
# implements GraphQL::Types::Relay::Node
|
27
|
+
#
|
28
|
+
# field :uuid, ID, null: false
|
29
|
+
#
|
30
|
+
# class << self
|
31
|
+
# def authorized?(object, context)
|
32
|
+
# super && object.owner == context[:viewer]
|
33
|
+
# end
|
34
|
+
# end
|
35
|
+
# end
|
36
|
+
#
|
23
37
|
# # bad
|
24
38
|
#
|
25
39
|
# class UserType < BaseType
|
@@ -42,7 +56,7 @@ module RuboCop
|
|
42
56
|
|
43
57
|
# @!method has_authorized_method?(node)
|
44
58
|
def_node_matcher :has_authorized_method?, <<~PATTERN
|
45
|
-
`(:defs (:self) :authorized? ...)
|
59
|
+
{`(:defs (:self) :authorized? ...) | `(:sclass (:self) `(:def :authorized? ...))}
|
46
60
|
PATTERN
|
47
61
|
|
48
62
|
def on_class(node)
|
@@ -84,7 +84,10 @@ module RuboCop
|
|
84
84
|
end
|
85
85
|
|
86
86
|
def root_node?(node)
|
87
|
-
node.parent.nil? ||
|
87
|
+
node.parent.nil? ||
|
88
|
+
node.module_type? && node.children.none?(&:module_type?) ||
|
89
|
+
node.class_type? ||
|
90
|
+
root_with_siblings?(node.parent)
|
88
91
|
end
|
89
92
|
|
90
93
|
def root_with_siblings?(node)
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: rubocop-graphql
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 1.0.
|
4
|
+
version: 1.0.1
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Dmitry Tsepelev
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2023-
|
11
|
+
date: 2023-03-13 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: bundler
|