rubocop-grape 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 590df7af3dec0374453d4f8ba4282b6d2981492c4e25d0ea537dd9e7b1de8eca
-  data.tar.gz: d52f772ffb08ba797df64f30298362ce04872477b36544614430e7dd157540d4
+  metadata.gz: 0a10e156b9a117d1d9bd4eb1e3d0c559268669f410d80c786d5c4b38ca79d508
+  data.tar.gz: '0287d909c47e61e540fcc98edf2303b97f43ebad7a6fc244fa14444661dbc77f'
 SHA512:
-  metadata.gz: 32c44eac0eee98cee4c97de9e3ff829c7f7d65ef532ee5066985804cc430aff642c93402712240023b430a5a02578806f9a2864e1550147dbc6e9a12e56dbf0c
-  data.tar.gz: 6692df01c1c324431ba0625d5f2042447afb7b882977dd36fa3f556a9bf448f79cf5e9884240a66f9af1263d04b31e70ec8a1fd212975b6e0758816e9d899b29
+  metadata.gz: f01ca9109f953bc9f7f74bebad5a468004fb9db4b738b4d9e01ef0d9265325159e4d6397d16ca35453b3ae5784df27523e7ceea01413de9f030358b4101d9f4e
+  data.tar.gz: e1acec347d818fe04be34f01a012ebd7961730091b00cc370aa720e6097a783eb59b5de54bb2aada39f2f21d7b393b1e26e696d56298ce762ba43243fff3d3a3

data/config/default.yml

@@ -19,6 +19,10 @@ Grape/FieldName:
     - snake_case
     - camelCase
 
+Grape/RouteParamGrouping:
+  Enabled: true
+  VersionAdded: '0.4.3'
+
 Grape/RouteParamType:
   Enabled: true
   Safe: false

data/lib/rubocop/cop/grape/route_param_grouping.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Grape
+      #
+      # @example
+      #
+      #   # bad
+      #   get ':id' do
+      #   end
+      #
+      #   # good
+      #   route_param :id, type: Integer do
+      #     get do
+      #     end
+      #   end
+      #
+      class RouteParamGrouping < Base
+        include EndpointHelper
+
+        MSG = 'Use route_param for route parameter'
+
+        def on_block(node)
+          return unless (method_send_node = http_method_node?(node))
+          return unless (first_argument_node = method_send_node.arguments.first)
+          return unless first_argument_node.value.match?(/:\w/)
+
+          add_offense(first_argument_node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/grape_cops.rb

@@ -7,4 +7,5 @@ require_relative 'grape/field_name'
 require_relative 'grape/ivar'
 require_relative 'grape/params_position'
 require_relative 'grape/present_with'
+require_relative 'grape/route_param_grouping'
 require_relative 'grape/route_param_type'

data/lib/rubocop/cop/mixin/endpoint_helper.rb

@@ -7,7 +7,7 @@ module RuboCop
       extend NodePattern::Macros
 
       def_node_matcher :http_method_node?, <<~PATTERN
-        (block (send _ {:get :post :put :patch :delete} ...) ...)
+        (block $(send _ {:get :post :put :patch :delete} ...) ...)
       PATTERN
 
       def_node_matcher :params_node?, <<~PATTERN

data/lib/rubocop/grape/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Grape
-    VERSION = '0.4.2'
+    VERSION = '0.4.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-grape
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Akito Hikasa
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-04 00:00:00.000000000 Z
+date: 2024-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -49,6 +49,7 @@ files:
 - lib/rubocop/cop/grape/ivar.rb
 - lib/rubocop/cop/grape/params_position.rb
 - lib/rubocop/cop/grape/present_with.rb
+- lib/rubocop/cop/grape/route_param_grouping.rb
 - lib/rubocop/cop/grape/route_param_type.rb
 - lib/rubocop/cop/grape_cops.rb
 - lib/rubocop/cop/mixin/endpoint_helper.rb