rubocop-govuk 3.17.2 → 4.0.0.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b616c24ca10792345f9270f1eda98ba66a75a4d1672cf1a917db76596ec8ffd1
-  data.tar.gz: 672788da8bcbd07a06a544acb7b746a34cc697446d72c76cf7fd745ffc0e3454
+  metadata.gz: 884a324d47c9f299b7cc0c72c2cb40b2bb61d5fae4385a14ac380da58d9585c6
+  data.tar.gz: ee81a830fb4d49f7caf8df86161e7df83df2502c122f4512eed9e6403c9fc38b
 SHA512:
-  metadata.gz: 2ea901cf52031d78896105a99c1792eb47c2c2d90ce8b14f3ac76c2767e74fed7b6570b309f1a429f5c6416eb51dee99aa90af1faa9b168748337e466f7bd7d0
-  data.tar.gz: 1a0373d4ad1b24899a92b916214cc0f8fc097ba1dd2b2962e44a193d28fb7f1c910df1bef8a48f62cb6baddd62a952cd2501decd6c3af9d8d0bbe7817ec8718c
+  metadata.gz: ad5c46c656afc890833c05899851f0288529957d6d0f0b0f7f1b7a246a5c34b0d8cd1e7b02c98f330c96643a0f1ce667b2378a0037ca41da9bdc0b15cb61cee7
+  data.tar.gz: 78732fc5680817d9cdacd6b27469d03bea5bfae201d1cf6cba568e1e716258d16ae302945bf23917e8fe026aaaf9fe3b0885d5d73c0d008d2240833c69b92cea

data/CHANGELOG.md

@@ -1,3 +1,27 @@
+# 4.0.0.pre.1
+
+- Released as a pre-release to try surface any issues before wider rollout,
+  use https://github.com/alphagov/rubocop-govuk/issues/129 to record any
+  problems
+- BREAKING: Upgraded from Rubocop 0.x to 1.x which introduces lots of new
+  cops
+- Update rubocop to 1.10.0
+- Update rubocop-ast to 1.4.0
+- Update rubocop-rails to 2.9.1
+- Update rubocop-rspec to 2.2.0
+- Make stable dependencies (>= 1.0) less strict on patch version
+- Disable `SuggestExtensions` to stop Rubocop suggesting additional
+  extensions at runtime
+- Explicitly set target Ruby version to `>= 2.6` in gemspec
+- Downgrade local Ruby version to `2.6.6` to capture lowest supported
+  Ruby version
+- Fix namespace change of `Capybara/FeatureMethods`
+- Disable `Naming/VariableNumbers`
+
+# 4.0.0.pre.pre.1
+
+- Mistakenly named release, same as 4.0.0.pre.1
+
 # 3.17.2
 
 - Rename Blacklist to ForbiddenMethods to fix rubocop-rails warnings

data/README.md

@@ -8,7 +8,7 @@ Add `rubocop-govuk` to your Gemfile and then run `bundle install`:
 
 ```ruby
 # Gemfile
-gem 'rubocop-govuk'
+gem 'rubocop-govuk', require: false
 ```
 
 Then inherit the default rules by adding the following in your project:

data/config/capybara.yml

@@ -1,5 +1,5 @@
 # Within GOV.UK we use Capybara test method syntax of feature,
 # scenario. We don't want this outside of feature specs though.
-Capybara/FeatureMethods:
+RSpec/Capybara/FeatureMethods:
   Exclude:
     - 'spec/features/**/*.rb'

data/config/default.yml

@@ -1,5 +1,6 @@
 AllCops:
   NewCops: disable
+  SuggestExtensions: false
   Exclude:
     - 'bin/**'
     - 'config.ru'

data/config/naming.yml

@@ -19,3 +19,10 @@ Naming/AccessorMethodName:
 # repos, which would require manual intervention.
 Naming/PredicateName:
   Enabled: false
+
+# This rule can cause readability issues when applied (for example
+# `born_on_or_before_6_april_1935` becomes `born_on_or_before_6april1935`)
+# and would require lots of amends to apply either `normalcase`
+# or `snake_case` to projects. It is not auto-correctable.
+Naming/VariableNumber:
+  Enabled: false

data/config/rspec.yml

@@ -10,6 +10,11 @@ inherit_from:
 RSpec/ExampleLength:
   Enabled: false
 
+# We should avoid cops that are based on heuristics, since
+# it's not clear what action to take to fix an issue.
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 # We have common cases, such as rake tasks, where we do not
 # use a class to the describe the test.
 RSpec/DescribeClass:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.17.2
+  version: 4.0.0.pre.1
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-14 00:00:00.000000000 Z
+date: 2021-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -28,44 +28,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
   name: rubocop-ast
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -84,16 +84,16 @@ dependencies:
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 2.2.0
 description: Shared RuboCop rules for Ruby projects in GOV.UK
 email:
 - govuk-dev@digital.cabinet-office.gov.uk
@@ -125,14 +125,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.11
 signing_key: 
 specification_version: 4
 summary: RuboCop GOV.UK