rubocop-govuk 3.6.0 → 3.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7ae8ec9e6faad9588c63a5f5ba23d6f81e6a902e6f9051b5619f78cc346f9e8
-  data.tar.gz: 3c0d65c5e8b25e0a6067ef266451080f777930a53b9f69f2085a44b400ae4665
+  metadata.gz: 9460cb1bd124d0db3bad61e69a4fca8fea76d1b58197766820aca957f4241854
+  data.tar.gz: 13319b8ceece3b49c2c4363f23c418cebd5f87db081fe1eecb63afb777c88194
 SHA512:
-  metadata.gz: 8e20bb705063e2982eeab5943ec63597fe2093f87ca287238bcd1f1b7891e27dd26b025a95addc87a688655d5d745f916ba98e3c162affa2937af0da4beb3e30
-  data.tar.gz: ec7b6f473f7dc57946f4cf3d50a952beabfc74a910ad9000f2c52724d9e0f3cce90344607577c2abb098d5c3f638921d17c68fd8714f8a108770a8c63ec715b6
+  metadata.gz: 981c47d318c535003c5e3b5206ca85ead3fda8895c770d4957cc4ee19f698d4bd04ad3483c17d064b079b87e9276c188ce06f478413dc2ed11ee8b2ec2b61c7c
+  data.tar.gz: 127e187db28bad0c6803c1fb8e8208277d55617698aef72befcddb4285449a62a65ee91836808b252f2a75c78fb40699d7b66ab0d4804cb523306d281866838a

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 3.7.0
+
+* Turn a load of Cops back on (#52)
+
 # 3.6.0
 
 * Remove config that matches RuboCop defaults (#47)

data/config/layout.yml

@@ -1,9 +1,3 @@
-# TODO: unclear why this is here!
-# https://github.com/alphagov/govuk-lint/pull/38
-Layout/ClosingParenthesisIndentation:
-  Description: 'Checks the indentation of hanging closing parentheses.'
-  Enabled: false
-
 # Part of the orignal GDS styleguide
 # "Use empty lines between defs and to break up a method into logical paragraphs."
 # https://github.com/alphagov/styleguides/blob/6395a10d41c3938f4c147cda443fd83f854c3e7a/ruby.md#general
@@ -34,34 +28,6 @@ Layout/AccessModifierIndentation:
   Enabled: true
   EnforcedStyle: outdent
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/HashAlignment:
-  Description: >-
-    Align the elements of a hash literal if they span more than
-    one line.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/ParameterAlignment:
-  Description: >-
-    Align the parameters of a method call if they span more
-    than one line.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/CommentIndentation:
-  Description: 'Indentation of comments.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/DotPosition:
-  Description: 'Checks the position of the dot in multi-line method calls.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here! Suggest enabling this with
 # "EnforcedStyle: consistent".
@@ -78,34 +44,8 @@ Layout/FirstHashElementIndentation:
   Description: 'Checks the indentation of the first key in a hash literal.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/LeadingCommentSpace:
-  Description: 'Comments should start with a space.'
-  Enabled: false
-
 # Introduced in: 9b2a744ab119d7797aaf423abcec914360f4208e
 # "More lenient on multi-line operations"
 # TODO: unclear why this is here!
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/SpaceAroundKeyword:
-  Description: 'Use spaces after if/elsif/unless/while/until/case/when.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/SpaceAfterNot:
-  Description: Tracks redundant space after the ! operator.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Layout/SpaceBeforeComment:
-  Description: >-
-    Checks for missing space between code and a comment on the
-    same line.
-  Enabled: false

data/config/rails.yml

@@ -19,12 +19,6 @@ Rails/ActionFilter:
   Description: 'Enforces consistent use of action filter methods.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Rails/Delegate:
-  Description: 'Prefer delegate method for delegations.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Rails/HasAndBelongsToMany:
@@ -37,24 +31,12 @@ Rails/Output:
   Description: 'Checks for calls to puts, print, etc.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Rails/ReadWriteAttribute:
-  Description: 'Checks for read_attribute(:attr) and write_attribute(:attr, val).'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Rails/ScopeArgs:
   Description: 'Checks the arguments of ActiveRecord scopes.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Rails/Validation:
-  Description: 'Use sexy validations.'
-  Enabled: false
-
 # Introduced in: 91d7bf4895db12727582ad7bf47bdcb20ab178f7
 # TODO: unclear (in any real detail) why this is here!
 Rails/SkipsModelValidations:

data/config/style.yml

@@ -86,36 +86,18 @@ Style/Alias:
   Description: 'Use alias_method instead of alias.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/ArrayJoin:
-  Description: 'Use Array#join instead of Array#*.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/AsciiComments:
   Description: 'Use only ascii symbols in comments.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/Attr:
-  Description: 'Checks for uses of Module#attr.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/BeginBlock:
   Description: 'Avoid the use of BEGIN blocks.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/BlockComments:
-  Description: 'Do not use block comments.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/BlockDelimiters:
@@ -131,32 +113,12 @@ Style/CaseEquality:
   Description: 'Avoid explicit use of the case equality operator(===).'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/CharacterLiteral:
-  Description: 'Checks for uses of character literals.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/ClassAndModuleChildren:
   Description: 'Checks style of children classes and modules.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/ColonMethodCall:
-  Description: 'Do not use :: for method call.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/CommentAnnotation:
-  Description: >-
-    Checks formatting of special comments
-    (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/PreferredHashMethods:
@@ -178,36 +140,12 @@ Style/DoubleNegation:
   Description: 'Checks for uses of double negation (!!).'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/EachWithObject:
-  Description: 'Prefer `each_with_object` over `inject` or `reduce`.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/EmptyLiteral:
-  Description: 'Prefer literals to Array.new/Hash.new/String.new.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/Encoding:
   Description: 'Use UTF-8 as the source file encoding.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/EndBlock:
-  Description: 'Avoid the use of END blocks.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/EvenOdd:
-  Description: 'Favor the use of Fixnum#even? && Fixnum#odd?'
-  Enabled: false
-
 # TODO: duplicate (other-excludes.yml), remove
 Style/FormatString:
   Description: 'Enforce the use of Kernel#sprintf, Kernel#format or String#%.'
@@ -247,14 +185,6 @@ Style/LambdaCall:
   Description: 'Use lambda.call(...) instead of lambda.(...).'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/LineEndConcatenation:
-  Description: >-
-    Use \ instead of + or << to concatenate two string literals at
-    line end.
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/MethodDefParentheses:
@@ -277,12 +207,6 @@ Style/NegatedIf:
     (or control flow or).
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NegatedWhile:
-  Description: 'Favor until over while for negative conditions.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/Next:
@@ -295,18 +219,6 @@ Style/NilComparison:
   Description: 'Prefer x.nil? to x == nil.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NonNilCheck:
-  Description: 'Checks for redundant nil checks.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/Not:
-  Description: 'Use ! instead of not.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/NumericLiterals:
@@ -315,24 +227,6 @@ Style/NumericLiterals:
     readability.
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/PercentLiteralDelimiters:
-  Description: 'Use `%`-literal delimiters consistently'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/PerlBackrefs:
-  Description: 'Avoid Perl-style regex back references.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/Proc:
-  Description: 'Use proc instead of Proc.new.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here! Suggest enabling with
 # "EnforcedStyle: compact"
@@ -340,24 +234,6 @@ Style/RaiseArgs:
   Description: 'Checks the arguments passed to raise/fail.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/RedundantBegin:
-  Description: "Don't use begin blocks when they are not needed."
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/RedundantException:
-  Description: "Checks for an obsolete RuntimeException argument in raise/fail."
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/RedundantSelf:
-  Description: "Don't use self where it's not needed."
-  Enabled: false
-
 # Analog of: 736b3d295f88b9ba6676fc168b823535582388c2
 # "Disable opinionated cops"
 #
@@ -371,12 +247,6 @@ Style/RegexpLiteral:
     `MaxSlashes` '/' character.
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/RescueModifier:
-  Description: 'Avoid using rescue in its modifier form.'
-  Enabled: false
-
 # Introduced in: 7aaebf4dbdf2a8d677b4000d3cd3512d4fb91e99
 # "This is a relatively new Ruby feature and is not mentioned in the Style
 # guide, so this commit disables it by default."
@@ -387,18 +257,6 @@ Style/SafeNavigation:
     existance of the object to safe navigation (`&.`).
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/SelfAssignment:
-  Description: 'Checks for places where self-assignment shorthand should have been used.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/Semicolon:
-  Description: "Don't use semicolons to terminate expressions."
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/SignalException:
@@ -412,52 +270,12 @@ Style/SingleLineMethods:
   Description: 'Avoid single-line methods.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/SpecialGlobalVars:
-  Description: 'Avoid Perl-style global variables.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/RedundantCapitalW:
-  Description: 'Checks for %W when interpolation is not needed.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/CommandLiteral:
   Description: 'Checks for %x when `` would do.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/VariableInterpolation:
-  Description: >-
-    Don't interpolate global, instance and class variables
-    directly in strings.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/WhenThen:
-  Description: 'Use when x then ... for one-line cases.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/WhileUntilDo:
-  Description: 'Checks for redundant do after while or until.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/WhileUntilModifier:
-  Description: >-
-    Favor modifier while/until usage when you have a
-    single-line body.
-  Enabled: false
-
 # Introduced in: b171d652d3e434b74ddc621df3b5be24c49bc7e8
 # This cop was added in preperation for a Ruby feature
 # that is no longer likely to become part of the language.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 3.7.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-28 00:00:00.000000000 Z
+date: 2020-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake