rubocop-govuk 3.16.0 → 3.17.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +8 -0
  3. data/config/rails.yml +13 -0
  4. data/config/style.yml +8 -0
  5. metadata +6 -6
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: bbde5e0b6a71966c3c76a712077229e4be9de9ab400a3ad54e43ce55a98d2920
4
- data.tar.gz: f09db889982c986669ce7a6ab535f3d8011d2725ee65aa5aa92df451e2cb406a
3
+ metadata.gz: 9af3af6d23a64db34fb0e3713513b75a2666647c18b60c92379a8d000cf3bcca
4
+ data.tar.gz: 87cae9593714f68d179f0588a340d0d6792495a295043eef258f09d79cefd9ae
5
5
  SHA512:
6
- metadata.gz: bed4ce6b4dc5eb4633258405831b182e72f495738b3152eca931623069a35cbf37322e3788da43c616960cfe1a668871ba41b26d9104e98416853d86ba03b83a
7
- data.tar.gz: b299bbdb9ec85294230c07239cec79e256d39f3203257ba2fe6ae8ef1c2da53a64ea93911564d2de01b3c3174e5bb602949da656f27240b3c144f9c1f190fabd
6
+ metadata.gz: e3c33dab371549df141d65ec957462d79d5d9f3de28206c2f4842fd692c0e58b417bf24cef2238a7539ea141f1364639f6db9032d3d62c60c5082164399b244a
7
+ data.tar.gz: 89c6ac7ca0daf85714140b5f6ce4d3b9e6d02646267ff4a4f848f63d191450691e79dea222ca494ffbce13cee24119010722f772b65e537bef5f283507c7a6fd
data/CHANGELOG.md CHANGED
@@ -1,3 +1,11 @@
1
+ # 3.17.0
2
+
3
+ - Enable Rails/SaveBang
4
+ - Enable Style/DateTime
5
+ - Enforce strict Time.zone.now
6
+ - Bump rubocop to 0.87.1
7
+ - Bump rubocop-rspec to 1.42.0
8
+
1
9
  # 3.16.0
2
10
 
3
11
  - Bump and lock rubocop-rails to 2.6.0
data/config/rails.yml CHANGED
@@ -79,3 +79,16 @@ Rails/HasManyOrHasOneDependent:
79
79
  # little value to many developers.
80
80
  Rails/OutputSafety:
81
81
  Enabled: false
82
+
83
+ # We seldom check the return value of 'update' to see if
84
+ # the operation was successful. Since we assume success, we
85
+ # should raise an exception if this is not the case.
86
+ Rails/SaveBang:
87
+ Enabled: true
88
+
89
+ # We should avoid unnecessary ambiguity between 'Time.current'
90
+ # and 'Time.zone.now', where 'Time.current' behaves differently
91
+ # depending on application config. We should always be explicit
92
+ # about whether we mean 'Time[.zone].now'.
93
+ Rails/TimeZone:
94
+ EnforcedStyle: "strict"
data/config/style.yml CHANGED
@@ -145,3 +145,11 @@ Style/SafeNavigation:
145
145
  # https://github.com/rubocop-hq/rubocop/issues/7197
146
146
  Style/FrozenStringLiteralComment:
147
147
  Enabled: false
148
+
149
+ # We should only use DateTime when it's necessary to account
150
+ # for ancient calendar changes. Otherwise, the arbitrary use
151
+ # of this class in place of Date or Time is confusing.
152
+ #
153
+ # https://rubystyle.guide/#no-datetime
154
+ Style/DateTime:
155
+ Enabled: true
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocop-govuk
3
3
  version: !ruby/object:Gem::Version
4
- version: 3.16.0
4
+ version: 3.17.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Government Digital Service
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2020-06-10 00:00:00.000000000 Z
11
+ date: 2020-07-20 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rake
@@ -30,14 +30,14 @@ dependencies:
30
30
  requirements:
31
31
  - - '='
32
32
  - !ruby/object:Gem::Version
33
- version: 0.85.1
33
+ version: 0.87.1
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - '='
39
39
  - !ruby/object:Gem::Version
40
- version: 0.85.1
40
+ version: 0.87.1
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rubocop-rails
43
43
  requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
72
72
  requirements:
73
73
  - - '='
74
74
  - !ruby/object:Gem::Version
75
- version: 1.39.0
75
+ version: 1.42.0
76
76
  type: :runtime
77
77
  prerelease: false
78
78
  version_requirements: !ruby/object:Gem::Requirement
79
79
  requirements:
80
80
  - - '='
81
81
  - !ruby/object:Gem::Version
82
- version: 1.39.0
82
+ version: 1.42.0
83
83
  description: Shared RuboCop rules for Ruby projects in GOV.UK
84
84
  email:
85
85
  - govuk-dev@digital.cabinet-office.gov.uk