rubocop-govuk 3.13.0 → 3.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62dc759573252798424f235663c439372ba78633ddfc4c364a56c2c990bd0d81
-  data.tar.gz: 9db1279a3a90e925dca92097c850ca80be8f7192767c0ae9904244d83fabd5e3
+  metadata.gz: 248e60260a8647aef347016c34f825328544408b2d6805dd19b82105570663f1
+  data.tar.gz: 55966fee3db3a3c27aa56f087629c560dbfd47e6b31945885abce3569c98dc14
 SHA512:
-  metadata.gz: 7c161b73b6ef22befd230cfc80c014feabe843f129ccaad1f06d47ee95f7d354af51521dab59e623d68f4b296891fc6ac7b010365a0fd035e7da6beac9ecff35
-  data.tar.gz: 2ea28a10f3244ee3527a9d0adbe7e07f7c3c6f9a0416a2ecd5ddb6b52034fdb0541ada3e0daaa74b9c2b9b6c67b24ccbac3033198b698a77b1eff3e74716f236
+  metadata.gz: 927073b5c07e0efd223e2a9d3a1bfe726cbbb09f8592171178efb04f0462d025b25615c4164c856523e53f5746eb62c223225c0a5d6d942a1b4c51402e8d274c
+  data.tar.gz: d3244ce4fdbbbcd3cbdb3e6ea5076dc84f9fcf662d624fec9b5486214ca2fb4125379d33a5c3b14cbeea4b75b5bedc0030441d77393f1586e0e73d631246aee6

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 3.14.0
+
+- Disable Rails/InverseOf
+- Disable Rails/HasManyOrHasOneDependent
+- Disable Rails/OutputSafety
+
 # 3.13.0
 
 - Disable Layout/FirstMethodArgumentLineBreak (#79)

data/config/rails.yml

@@ -40,3 +40,31 @@ Rails/SkipsModelValidations:
 # relationships are just # many-to-many, and that's it.
 Rails/HasAndBelongsToMany:
   Enabled: false
+
+# While using 'inverse_of' can reduce DB queries, we have
+# not found this to be a problem in practice. The advantage
+# of turning this on would be that we make the inverse
+# behaviour explicit everywhere ActiveRecord can't apply it
+# automatically, but this is rarely a surprise for developers.
+# We also don't want to add 'inverse_of: false' everywhere;
+# at the time of writing, there is no auto-correct for this.
+Rails/InverseOf:
+  Enabled: false
+
+# This is incompatible with the more robust use of foreign
+# key constraints, which provide the same behaviour.
+#
+# Example: https://github.com/alphagov/content-publisher/blob/f26d9b551842fdf2084159b5b7f1bb078da56936/db/schema.rb#L396
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+# We commonly want to render HTML without escaping it, which
+# is what 'html_safe' is for. In many cases, the content we
+# render has already been sanitised (e.g. through Govspeak),
+# or is otherwise trusted e.g. from a content item. We trust
+# that developers will use 'html_safe' responsibly, and prefer
+# the default, escaped output otherwise. At the time of writing,
+# this Cop is disabled in a lot of repos, indicating it offers
+# little value to many developers.
+Rails/OutputSafety:
+  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.13.0
+  version: 3.14.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-21 00:00:00.000000000 Z
+date: 2020-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake