rubocop-google_ads 1.0.0 → 2.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (9) hide show
  1. checksums.yaml +4 -4
  2. data/.circleci/config.yml +2 -2
  3. data/.github/workflows/auto-update-get-methods.yml +1 -1
  4. data/Gemfile.lock +46 -40
  5. data/Rakefile +0 -2
  6. data/bin/deprecated_methods_generator +6 -1
  7. data/lib/rubocop/cop/google_ads/deprecated_get_methods.yml +6 -0
  8. data/lib/rubocop/google_ads/version.rb +1 -1
  9. metadata +3 -3
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: d4e0a865b3338073d426c12dd819ae2bcd577bf0faf3ac3da55db8beae2c94d1
4
- data.tar.gz: 62aff4f7cdf5ad5ec9b4b7335ff79e14165e7c7121d93122aabf303afe9f959c
3
+ metadata.gz: 0054fe93ba0665d2925e999de8a8d3b711388ebb4f8025b62facfe6547a63683
4
+ data.tar.gz: cf0c4f2204c7fc66083c632d349e4a17d71b96a82a461f3bb332ff5d7e369afd
5
5
  SHA512:
6
- metadata.gz: 7d1cc12fcf7108e4d43acb96a34477d8a8f60e76e7d87b095f2a3c6080a44fb0d55481456cfd12473c79aa97ff80be20d6310f86aa25405be11792aa01fe178f
7
- data.tar.gz: 661115b7ccace975324c1d4f26fd5416208e4bad730a854e6c996bf3417bf69092befa07a27501eea7bd22102a95690c4daa1623873b6c3d63ccc6e5bed071b2
6
+ metadata.gz: '081b882cb1828d5f41cec452aaa4004483d8290501302009335e73b5efeb4f01b5779d50f3ddc5135a48aa05decc0dcd842daae4191e13abf8a4839e1644ba6f'
7
+ data.tar.gz: 3de7c4813ec38916832f55e3cbc02329e45f856f72b555279e52acc5f745efca751ef8e7532040acc09d4543903d9a694ad9591f676856848b96798f72dc53c9
data/.circleci/config.yml CHANGED
@@ -1,11 +1,11 @@
1
1
  version: 2.1
2
2
  orbs:
3
- ruby: circleci/ruby@1.1.0
3
+ ruby: circleci/ruby@1.1.2
4
4
 
5
5
  jobs:
6
6
  build:
7
7
  docker:
8
- - image: circleci/ruby:2.7.1
8
+ - image: circleci/ruby:2.7.2
9
9
  executor: ruby/default
10
10
  steps:
11
11
  - checkout
data/.github/workflows/auto-update-get-methods.yml CHANGED
@@ -12,7 +12,7 @@ jobs:
12
12
  - uses: actions/checkout@v2
13
13
  - uses: ruby/setup-ruby@v1
14
14
  with:
15
- ruby-version: 2.6
15
+ ruby-version: 2.7
16
16
  - name: Install dependencies
17
17
  run: bundle install
18
18
  - name: Generate new list file of deprecated get methods
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- rubocop-google_ads (0.1.0)
4
+ rubocop-google_ads (1.0.0)
5
5
  rubocop
6
6
 
7
7
  GEM
@@ -12,43 +12,48 @@ GEM
12
12
  ast (2.4.1)
13
13
  byebug (11.1.3)
14
14
  coderay (1.1.2)
15
- diff-lcs (1.3)
16
- faraday (1.0.1)
15
+ diff-lcs (1.4.4)
16
+ faraday (1.1.0)
17
17
  multipart-post (>= 1.2, < 3)
18
- google-ads-googleads (6.0.0)
19
- google-gax (~> 1.6)
20
- google-protobuf (= 3.11.4)
21
- google-gax (1.8.1)
22
- google-protobuf (~> 3.9)
18
+ ruby2_keywords
19
+ gapic-common (0.3.4)
20
+ google-protobuf (~> 3.12, >= 3.12.2)
23
21
  googleapis-common-protos (>= 1.3.9, < 2.0)
22
+ googleapis-common-protos-types (>= 1.0.4, < 2.0)
24
23
  googleauth (~> 0.9)
25
- grpc (~> 1.24)
26
- rly (~> 0.2.3)
27
- google-protobuf (3.11.4)
24
+ grpc (~> 1.25)
25
+ google-ads-googleads (8.1.0)
26
+ gapic-common (~> 0.3.0)
27
+ google-protobuf (~> 3.12)
28
+ google-protobuf (3.14.0)
29
+ google-protobuf (3.14.0-x86_64-linux)
28
30
  googleapis-common-protos (1.3.10)
29
31
  google-protobuf (~> 3.11)
30
32
  googleapis-common-protos-types (>= 1.0.5, < 2.0)
31
33
  grpc (~> 1.27)
32
34
  googleapis-common-protos-types (1.0.5)
33
35
  google-protobuf (~> 3.11)
34
- googleauth (0.13.0)
36
+ googleauth (0.14.0)
35
37
  faraday (>= 0.17.3, < 2.0)
36
38
  jwt (>= 1.4, < 3.0)
37
39
  memoist (~> 0.16)
38
40
  multi_json (~> 1.11)
39
41
  os (>= 0.9, < 2.0)
40
42
  signet (~> 0.14)
41
- grpc (1.28.0)
42
- google-protobuf (~> 3.11)
43
+ grpc (1.34.0)
44
+ google-protobuf (~> 3.13)
45
+ googleapis-common-protos-types (~> 1.0)
46
+ grpc (1.34.0-x86_64-linux)
47
+ google-protobuf (~> 3.13)
43
48
  googleapis-common-protos-types (~> 1.0)
44
- jwt (2.2.1)
49
+ jwt (2.2.2)
45
50
  memoist (0.16.2)
46
51
  method_source (1.0.0)
47
52
  multi_json (1.15.0)
48
53
  multipart-post (2.1.1)
49
- os (1.1.0)
50
- parallel (1.19.2)
51
- parser (2.7.1.4)
54
+ os (1.1.1)
55
+ parallel (1.20.1)
56
+ parser (3.0.0.0)
52
57
  ast (~> 2.4.1)
53
58
  pry (0.13.1)
54
59
  coderay (~> 1.1)
@@ -56,39 +61,39 @@ GEM
56
61
  pry-byebug (3.9.0)
57
62
  byebug (~> 11.0)
58
63
  pry (~> 0.13.0)
59
- public_suffix (4.0.5)
64
+ public_suffix (4.0.6)
60
65
  rainbow (3.0.0)
61
- rake (13.0.1)
62
- regexp_parser (1.7.1)
66
+ rake (13.0.3)
67
+ regexp_parser (2.0.2)
63
68
  rexml (3.2.4)
64
- rly (0.2.3)
65
- rspec (3.9.0)
66
- rspec-core (~> 3.9.0)
67
- rspec-expectations (~> 3.9.0)
68
- rspec-mocks (~> 3.9.0)
69
- rspec-core (3.9.1)
70
- rspec-support (~> 3.9.1)
71
- rspec-expectations (3.9.0)
69
+ rspec (3.10.0)
70
+ rspec-core (~> 3.10.0)
71
+ rspec-expectations (~> 3.10.0)
72
+ rspec-mocks (~> 3.10.0)
73
+ rspec-core (3.10.0)
74
+ rspec-support (~> 3.10.0)
75
+ rspec-expectations (3.10.0)
72
76
  diff-lcs (>= 1.2.0, < 2.0)
73
- rspec-support (~> 3.9.0)
74
- rspec-mocks (3.9.1)
77
+ rspec-support (~> 3.10.0)
78
+ rspec-mocks (3.10.0)
75
79
  diff-lcs (>= 1.2.0, < 2.0)
76
- rspec-support (~> 3.9.0)
77
- rspec-support (3.9.2)
80
+ rspec-support (~> 3.10.0)
81
+ rspec-support (3.10.0)
78
82
  rspec_junit_formatter (0.4.1)
79
83
  rspec-core (>= 2, < 4, != 2.12.0)
80
- rubocop (0.89.0)
84
+ rubocop (1.7.0)
81
85
  parallel (~> 1.10)
82
- parser (>= 2.7.1.1)
86
+ parser (>= 2.7.1.5)
83
87
  rainbow (>= 2.2.2, < 4.0)
84
- regexp_parser (>= 1.7)
88
+ regexp_parser (>= 1.8, < 3.0)
85
89
  rexml
86
- rubocop-ast (>= 0.1.0, < 1.0)
90
+ rubocop-ast (>= 1.2.0, < 2.0)
87
91
  ruby-progressbar (~> 1.7)
88
92
  unicode-display_width (>= 1.4.0, < 2.0)
89
- rubocop-ast (0.3.0)
90
- parser (>= 2.7.1.4)
93
+ rubocop-ast (1.3.0)
94
+ parser (>= 2.7.1.5)
91
95
  ruby-progressbar (1.10.1)
96
+ ruby2_keywords (0.0.2)
92
97
  signet (0.14.0)
93
98
  addressable (~> 2.3)
94
99
  faraday (>= 0.17.3, < 2.0)
@@ -98,6 +103,7 @@ GEM
98
103
 
99
104
  PLATFORMS
100
105
  ruby
106
+ x86_64-linux
101
107
 
102
108
  DEPENDENCIES
103
109
  google-ads-googleads
@@ -108,4 +114,4 @@ DEPENDENCIES
108
114
  rubocop-google_ads!
109
115
 
110
116
  BUNDLED WITH
111
- 2.1.4
117
+ 2.2.0
data/Rakefile CHANGED
@@ -7,8 +7,6 @@ RSpec::Core::RakeTask.new(:spec)
7
7
 
8
8
  task default: :spec
9
9
 
10
- require 'rspec/core/rake_task'
11
-
12
10
  RSpec::Core::RakeTask.new(:spec) do |spec|
13
11
  spec.pattern = FileList['spec/**/*_spec.rb']
14
12
  end
data/bin/deprecated_methods_generator CHANGED
@@ -10,7 +10,12 @@ get_methods = []
10
10
 
11
11
  methods.each do |m|
12
12
  begin
13
- get_method_name = client.service.send(m).instance_variables.find { |v| v.to_s.include?('@get_') }
13
+ get_method_name = client
14
+ .service
15
+ .send(m)
16
+ .send(:service)
17
+ .public_methods
18
+ .find { |v| v.start_with?('get_') }
14
19
 
15
20
  if get_method_name
16
21
  get_methods << get_method_name
data/lib/rubocop/cop/google_ads/deprecated_get_methods.yml CHANGED
@@ -24,6 +24,7 @@
24
24
  - get_bidding_strategy
25
25
  - get_billing_setup
26
26
  - get_campaign
27
+ - get_campaign_asset
27
28
  - get_campaign_audience_view
28
29
  - get_campaign_bid_modifier
29
30
  - get_campaign_budget
@@ -38,8 +39,10 @@
38
39
  - get_carrier_constant
39
40
  - get_change_status
40
41
  - get_click_view
42
+ - get_combined_audience
41
43
  - get_conversion_action
42
44
  - get_currency_constant
45
+ - get_custom_audience
43
46
  - get_custom_interest
44
47
  - get_customer
45
48
  - get_customer_client
@@ -49,6 +52,7 @@
49
52
  - get_customer_label
50
53
  - get_customer_manager_link
51
54
  - get_customer_negative_criterion
55
+ - get_customer_user_access
52
56
  - get_detail_placement_view
53
57
  - get_display_keyword_view
54
58
  - get_distance_view
@@ -58,6 +62,8 @@
58
62
  - get_extension_feed_item
59
63
  - get_feed
60
64
  - get_feed_item
65
+ - get_feed_item_set
66
+ - get_feed_item_set_link
61
67
  - get_feed_item_target
62
68
  - get_feed_mapping
63
69
  - get_feed_placeholder_view
data/lib/rubocop/google_ads/version.rb CHANGED
@@ -2,6 +2,6 @@
2
2
 
3
3
  module RuboCop
4
4
  module GoogleAds
5
- VERSION = '1.0.0'
5
+ VERSION = '2.0.0'
6
6
  end
7
7
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocop-google_ads
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.0
4
+ version: 2.0.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - hanocha
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2020-08-08 00:00:00.000000000 Z
11
+ date: 2020-12-27 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
77
77
  - !ruby/object:Gem::Version
78
78
  version: '0'
79
79
  requirements: []
80
- rubygems_version: 3.0.3
80
+ rubygems_version: 3.1.2
81
81
  signing_key:
82
82
  specification_version: 4
83
83
  summary: Custom cops for Google Ads API Ruby Client Library