rubocop-github 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 01a43ac030793e95e3a335bc67ba74c70b16458c
-  data.tar.gz: a2a30083e9282c76625c20cf0409acefa21f3f58
+SHA256:
+  metadata.gz: 58ddfb6fbfe780a05b368dea76dc36274bc05065088e606592ba87dd82372e65
+  data.tar.gz: 209ce2b5181fa610a44a704df33b2571ad8034c1eb0e0be7620530f31ba707bb
 SHA512:
-  metadata.gz: b3ff7a090f8e44d261b65437e8e5eda5b9698fc01fc1b257aeb26f19971414b8e583e66a8791ec6d4ace5fcee0ce2235801578549b3706796d39d76b0b4d2272
-  data.tar.gz: 4d0dcb8096da4fd18437da5ef483452df9924b170bd4507b194baf2faadeb4549bdb7fd310561e0369fd849f357098fb39063e1a0f51c4d41e38284eaa94e3a3
+  metadata.gz: 36d6bfbc4936221bd01eeffa1667a5f421aca8039b134d3918e9587be3b8778819062d42e4f464b93c62ff3caecb297d4ace38c3d214b94289a1a02c69b9d81a
+  data.tar.gz: dadce863318b8ca16f6f3f5a0fd8e9827cc992df3f1e925d57f5711e12d79bff79996a451f0fa81ae795d46971ea8a17fb727d4db6756a8194449228b8310f90

data/README.md

@@ -19,6 +19,11 @@ inherit_gem:
     - config/rails.yml
 ```
 
+## Testing
+
+`bundle install`
+`bundle exec rake test`
+
 ## The Cops
 
 All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github), and contain examples/documentation.

data/config/default.yml

@@ -1,4 +1,6 @@
-require: rubocop/cop/github
+require: 
+  - rubocop/cop/github
+  - rubocop-performance
 
 AllCops:
   DisabledByDefault: true
@@ -115,6 +117,9 @@ Lint/EndInMethod:
 Lint/EnsureReturn:
   Enabled: true
 
+Lint/FlipFlop:
+  Enabled: true
+
 Lint/FloatOutOfRange:
   Enabled: true
 
@@ -226,9 +231,6 @@ Performance/EndWith:
 Performance/FlatMap:
   Enabled: true
 
-Performance/LstripRstrip:
-  Enabled: true
-
 Performance/RangeInclude:
   Enabled: false
 
@@ -239,15 +241,9 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 1
 
-Performance/RedundantSortBy:
-  Enabled: true
-
 Performance/ReverseEach:
   Enabled: true
 
-Performance/Sample:
-  Enabled: true
-
 Performance/Size:
   Enabled: true
 
@@ -284,9 +280,6 @@ Style/DefWithParentheses:
 Style/EndBlock:
   Enabled: true
 
-Style/FlipFlop:
-  Enabled: true
-
 Style/For:
   Enabled: true
 
@@ -318,9 +311,18 @@ Style/Not:
 Style/OneLineConditional:
   Enabled: true
 
+Style/RedundantSortBy:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
 Style/StabbyLambdaParentheses:
   Enabled: true
 
 Style/StringLiterals:
   Enabled: true
   EnforcedStyle: double_quotes
+
+Style/Strip:
+  Enabled: true

data/config/rails.yml

@@ -116,3 +116,7 @@ Layout/TrailingBlankLines:
 Layout/TrailingWhitespace:
   Exclude:
     - 'app/views/**/*.erb'
+
+Layout/InitialIndentation:
+  Exclude:
+    - 'app/views/**/*.erb'

data/lib/rubocop/cop/github/rails_controller_render_literal.rb

@@ -20,6 +20,10 @@ module RuboCop
           (send nil? :render ({str sym} $_) $...)
         PATTERN
 
+        def_node_matcher :render_const?, <<-PATTERN
+          (send nil? :render (const _ _) ...)
+        PATTERN
+
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...))
         PATTERN
@@ -63,7 +67,7 @@ module RuboCop
         def on_send(node)
           return unless render?(node)
 
-          if render_literal?(node)
+          if render_literal?(node) || render_const?(node)
           elsif option_pairs = render_with_options?(node)
             option_pairs = option_pairs.reject { |pair| options_key?(pair) }
 

data/lib/rubocop/cop/github/rails_view_render_literal.rb

@@ -20,6 +20,10 @@ module RuboCop
           (send nil? :render ({str sym} $_) $...)
         PATTERN
 
+        def_node_matcher :render_const?, <<-PATTERN
+          (send nil? :render (const _ _) ...)
+        PATTERN
+
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...) ...)
         PATTERN
@@ -33,6 +37,7 @@ module RuboCop
         def_node_matcher :partial_key?, <<-PATTERN
           (pair (sym {
             :file
+            :template
             :layout
             :partial
           }) $_)
@@ -41,7 +46,7 @@ module RuboCop
         def on_send(node)
           return unless render?(node)
 
-          if render_literal?(node)
+          if render_literal?(node) || render_const?(node)
           elsif option_pairs = render_with_options?(node)
             if option_pairs.any? { |pair| ignore_key?(pair) }
               return

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.13.0
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-18 00:00:00.000000000 Z
+date: 2019-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.59'
+        version: '0.70'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.59'
+        version: '0.70'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
@@ -103,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.3.6
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -111,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: RuboCop GitHub