rubocop-flexport 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46325f36546cf5f9699b05f0e921a74a35637ff273508dd089edc74351295f80
-  data.tar.gz: b9bbdfd40c25d9ba9523b6e317c7ec89a9394cec7ffde496264096ce70237467
+  metadata.gz: 611e7d0841b96380210c5b9c0e69e1faa39714f485c7534a3c99f55a9567a854
+  data.tar.gz: 0300627c5f7459c722941ce9f7bf6bf594cbb8c6eb6a1e26791ceeeff8651f86
 SHA512:
-  metadata.gz: 43c422a8725dfe88de02a0f422f0ae63e5c0faa335e6fbb291c71123a5232702ff0bb8ab955a15a6c765d94baae64ad2a4a011f6b4babf3108e8068af12512ba
-  data.tar.gz: e04ca19560e033f6fe541489c33a57cb4da52b809a6f85eef06aa9426519537d76486f96203ea80ded0b2f8e6ddb8fcd9c963a74333c72988470a4600c9407f7
+  metadata.gz: b23d6b05fe8ad73bd029a38b2fa9c5e957ac50433510e0b7f4b37ee94b1ac3148b8f477a4de297c194fc7f136d40168182f1c0a1442218e27aa9070b60c20e5c
+  data.tar.gz: 0b855624ddcfae29e8d211a2e05e54d401a0d06cbfd5e4a118ad6a3bccef1200e409d22f35380cbbf44ec3fc180ed99b34111978042437674675d30e864c651c

data/README.md

@@ -43,7 +43,7 @@ like below and then run `bundle install`:
 gem "rubocop-flexport", path: "/Users/<user>/rubocop-flexport"
 ```
 
-To release a new version, update the version number in `version.rb`, and then
+To release a new version, update the version number in `lib/rubocop/flexport/version.rb`, and then
 run `bundle exec rake release`, which will create a git tag for the version,
 push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 

data/lib/rubocop/cop/flexport/engine_api_boundary.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   will be accessible outside your engine. For example, adding
       #   `api/foo_service.rb` will allow code outside your engine to
       #   invoke eg `MyEngine::Api::FooService.bar(baz)`.
-      # - Create a `_whitelist.rb` file in `api/`. Modules listed in
+      # - Create an `_allowlist.rb` or `_whitelist.rb` file in `api/`. Modules listed in
       #   this file are accessible to code outside the engine. The file
       #   must have this name and a particular format (see below).
       #
@@ -268,7 +268,7 @@ module RuboCop
           (
             in_legacy_dependent_file?(accessed_engine) ||
             through_api?(node) ||
-            whitelisted?(node, accessed_engine)
+            allowlisted?(node, accessed_engine)
           )
         end
 
@@ -326,15 +326,16 @@ module RuboCop
           node.parent&.const_type? && node.parent.children.last == :Api
         end
 
-        def whitelisted?(node, engine)
-          whitelist = read_api_file(engine, :whitelist)
-          return false if whitelist.empty?
+        def allowlisted?(node, engine)
+          allowlist = read_api_file(engine, :allowlist)
+          allowlist = read_api_file(engine, :whitelist) if allowlist.empty?
+          return false if allowlist.empty?
 
           depth = 0
           max_depth = 5
           while node.const_type? && depth < max_depth
             full_const_name = remove_leading_colons(node.source)
-            return true if whitelist.include?(full_const_name)
+            return true if allowlist.include?(full_const_name)
 
             node = node.parent
             depth += 1

data/lib/rubocop/cop/mixin/engine_api.rb

@@ -10,9 +10,13 @@ module RuboCop
       extend NodePattern::Macros
 
       API_FILE_DETAILS = {
+        allowlist: {
+          file_basename: '_allowlist.rb',
+          array_matcher: :allowlist_array
+        },
         whitelist: {
           file_basename: '_whitelist.rb',
-          array_matcher: :whitelist_array
+          array_matcher: :allowlist_array
         },
         legacy_dependents: {
           file_basename: '_legacy_dependents.rb',
@@ -108,7 +112,7 @@ module RuboCop
         end
       end
 
-      def_node_matcher :whitelist_array, <<-PATTERN
+      def_node_matcher :allowlist_array, <<-PATTERN
           (casgn nil? {:PUBLIC_MODULES :PUBLIC_SERVICES :PUBLIC_CONSTANTS :PUBLIC_TYPES} {$array (send $array ...)})
       PATTERN
 

data/lib/rubocop/flexport/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Flexport
-    VERSION = '0.8.0'
+    VERSION = '0.9.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-flexport
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Flexport Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport