rubocop-flexport 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 163dbf64bd5550b4f890d2125230be59ba2c1d87e5bf59c513ae206f171852f7
-  data.tar.gz: f7a597e3f5f770d217ea3be631a95cc8b3b16c73e683ef67b775e5195b95ebcd
+  metadata.gz: 1affaedaabe7b84350802f0d4222c052e94d19120c92e556250df045d9f36cc5
+  data.tar.gz: efed93fb328d46330498aa2298e3aa5ff872faaab01dae64b06ab279f764d36e
 SHA512:
-  metadata.gz: '0444612966a40c981dad3f31b02738232d186a112fc06ba167f93f93630346e72ea14ab3bae765c3336bc17797885d604d87ab30935880941d7c7163b47df34c'
-  data.tar.gz: 056f32d4e6da4c4eeabaa41340fa096fc87592a8fe3bf4358357b733a380f667ed21112104bb1e6fec26d66bdb14e71223e6085c0c31e784ebfa16e6947d1652
+  metadata.gz: 0737a98974780066c5b8a0822825a7a9372cf6b3c155d4b5734fafed971b023e8559e6a77d29f16c9213389b9162f61ea24948d8a2a7dd3f5aeadf820577ab9d
+  data.tar.gz: b01a9c75229f63ce3bfef495e622c8c53450fa0cf5ac0cb1f4afddfca21785b8760c3428c90d5bb7144de4e4124112f9843d212d494cc988ddfa6b4963b428a5

data/lib/rubocop/cop/flexport/engine_api_boundary.rb

@@ -251,7 +251,7 @@ module RuboCop
         end
 
         def sending_method_to_namespace_itself?(node)
-          node.parent.send_type?
+          node.parent&.send_type?
         end
 
         def valid_engine_access?(node, accessed_engine)
@@ -364,11 +364,22 @@ module RuboCop
         end
 
         def engine_specific_override?(node)
-          module_name = node.parent.source
-          module_names_allowed_by_override = overrides_by_engine[current_engine]
-          return false unless module_names_allowed_by_override
+          return false unless overrides_for_current_engine
 
-          module_names_allowed_by_override.include?(module_name)
+          depth = 0
+          max_depth = 5
+          while node&.const_type? && depth < max_depth
+            module_name = node.source
+            return true if overrides_for_current_engine.include?(module_name)
+
+            node = node.parent
+            depth += 1
+          end
+          false
+        end
+
+        def overrides_for_current_engine
+          overrides_by_engine[current_engine]
         end
 
         def strongly_protected_engines

data/lib/rubocop/cop/mixin/engine_node_context.rb

@@ -15,7 +15,7 @@ module RuboCop
       def in_module_or_class_declaration?(node)
         depth = 0
         max_depth = 10
-        while node.const_type? && depth < max_depth
+        while node.const_type? && node.parent && depth < max_depth
           node = node.parent
           depth += 1
         end

data/lib/rubocop/flexport/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Flexport
-    VERSION = '0.6.0'
+    VERSION = '0.7.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-flexport
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Flexport Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-21 00:00:00.000000000 Z
+date: 2020-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport