rubocop-discourse 3.7.0 → 3.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d347009b4a77b64450a20ef3afc5ca102dd361c60e3fbde2e5fd0ea976469cd
-  data.tar.gz: c98b24bd73f783f154320e337e44f6859e050c43ff9219cfa0be6f63a891fc13
+  metadata.gz: eb795aa24e9b2d88571ef2140d2dce87afd493b20c5d1d643b8a58b3d7b97fd5
+  data.tar.gz: 7950d13ba0da8dbeb2a690f48f33f1df8e72dbfd00240f4da07172dfbe3f91c6
 SHA512:
-  metadata.gz: 98c56b4b42703f8fc1fe0b3f68344507e2001d7a71d5530c89b8f21a29b5276fc518542b445e9dd9a902cb30be38ce0d4df18218b2cf08bfb50465411d7c7d77
-  data.tar.gz: f7f5f50325374fe530a26c20ed113b4cb827ed7541a8a9f6dbae1a81c0dca29be2cc7073c8f543b5200dab2e2238617984a7f4dbd87d838ff8a1d4cfa8da0db6
+  metadata.gz: f47590c8de489ac68e8ca6d4d5ec012a5cf07455ad63c123aa14963c6ef6dec3d9f934a5106b45f01fbdca5b34e70542ac77fe9e0b46d9bb828b06d21a934d41
+  data.tar.gz: be49ff2f39df90a0dec57f813b621570b7fe895656ac7b65f54e4938490bc6714fdbc9fb0b9b92fe19b82fa26fe1997ceae6c3cf2734eb637714e9880569ba97

data/lib/rubocop/cop/discourse/fabricator_shorthand.rb

@@ -26,9 +26,12 @@ module RuboCop
       # # good
       # fab!(:another_user) { Fabricate(:user) }
       class FabricatorShorthand < Base
+        extend AutoCorrector
+        include IgnoredNode
+
         def_node_matcher :offending_fabricator?, <<-MATCHER
           (block
-            (send nil? :fab!
+            $(send nil? :fab!
               (sym $_identifier))
             (args)
             (send nil? :Fabricate
@@ -36,15 +39,22 @@ module RuboCop
         MATCHER
 
         def on_block(node)
-          offending_fabricator?(node) do |identifier|
-            add_offense(node, message: message(identifier))
+          offending_fabricator?(node) do |expression, _identifier|
+            add_offense(
+              node,
+              message: message(expression.source)
+            ) do |corrector|
+              next if part_of_ignored_node?(node)
+              corrector.replace(node, expression.source)
+            end
+            ignore_node(node)
           end
         end
 
         private
 
-        def message(identifier)
-          "Use the fabricator shorthand: `fab!(:#{identifier})`"
+        def message(expression)
+          "Use the fabricator shorthand: `#{expression}`"
         end
       end
     end

data/rubocop-discourse.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop-discourse"
-  s.version = "3.7.0"
+  s.version = "3.7.1"
   s.summary = "Custom rubocop cops used by Discourse"
   s.authors = ["Discourse Team"]
   s.license = "MIT"

data/spec/lib/rubocop/cop/fabricator_shorthand_spec.rb

@@ -31,4 +31,19 @@ describe RuboCop::Cop::Discourse::FabricatorShorthand, :config do
       end
     RUBY
   end
+
+  it "supports autocorrect" do
+    expect_offense(<<~RUBY)
+      RSpec.describe "Foo" do
+        fab!(:foo) { Fabricate(:foo) }
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Discourse/FabricatorShorthand: Use the fabricator shorthand: `fab!(:foo)`
+      end
+    RUBY
+
+    expect_correction(<<~RUBY)
+      RSpec.describe "Foo" do
+        fab!(:foo)
+      end
+    RUBY
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 3.7.0
+  version: 3.7.1
 platform: ruby
 authors:
 - Discourse Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-28 00:00:00.000000000 Z
+date: 2024-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport