rubocop-discourse 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 829d3722889a6cda57c4d83a8531fb72d041c868b958f0ce95eac9c66f9fcf3d
-  data.tar.gz: 9d51dd30c4e5a03ade1e948fd720f5804f3a787e6fa3f21ef0949e07e7e61e6a
+  metadata.gz: c437452f89089230f8ab04486bbe351745b094292c80f838671fdcd33d83bdab
+  data.tar.gz: d4438004c26aee64eff9e6a2f0d335767b412ab2563e5e9d3bdbc1833be1a678
 SHA512:
-  metadata.gz: 323f7c0b2994ccccfa9e5d75cc431caefa7de8cf7f6738c2e87030d8b4ee0454349faa7102bc8c9e2a0eafb76ad0597f1ef58d3afb8b7aff223216b20a2ab774
-  data.tar.gz: 8c262ddadf1dd0d78340093a01a181962c1123f49305bd2c20a34ce1669948d7bd1de9f2c9f950f0f5739234fb308b6c86ff368d18b915b9a6220c7dba95af83
+  metadata.gz: 3a19afd24871782b52660905e0f211287fa41779994c21160baeb5c5e3963ea63482d7ea980ac9398a86b0f40c37056fdf82f982afc851bd6632fc6458d803ed
+  data.tar.gz: 6b6ee9c891637c8c2355bc1cf451d96245960700ef3d8f859a0845ee3a258eae70cf7c85b19493a2d32f7277a69bd4adbc4a16527eaf4e4c1f96509f14fbb64d

data/rubocop-discourse.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop-discourse"
-  s.version = "3.2.0"
+  s.version = "3.3.0"
   s.summary = "Custom rubocop cops used by Discourse"
   s.authors = ["Discourse Team"]
   s.license = "MIT"

data/rubocop-rspec.yml

@@ -73,7 +73,7 @@ RSpec/EmptyLineAfterHook:
   Enabled: false # TODO
 
 RSpec/EmptyLineAfterSubject:
-  Enabled: false # TODO
+  Enabled: true
 
 RSpec/ExampleLength:
   Enabled: false # To be decided
@@ -130,7 +130,7 @@ RSpec/IteratedExpectation:
   Enabled: false # To be decided
 
 RSpec/LeadingSubject:
-  Enabled: false # TODO
+  Enabled: true
 
 RSpec/LeakyConstantDeclaration:
   Enabled: false # To be decided
@@ -157,7 +157,7 @@ RSpec/MultipleSubjects:
   Enabled: true
 
 RSpec/NamedSubject:
-  Enabled: false # To be decided
+  Enabled: true
 
 RSpec/NestedGroups:
   Enabled: false # To be decided

data/spec/lib/rubocop/cop/no_add_reference_active_record_migrations_spec.rb

@@ -5,20 +5,21 @@ require "spec_helper"
 describe RuboCop::Cop::Discourse::NoAddReferenceOrAliasesActiveRecordMigration,
          :config do
   subject(:cop) { described_class.new(config) }
+
   let(:config) { RuboCop::Config.new }
 
   it "raises an offense if add_reference is used, with or without arguments" do
     inspect_source(<<~RUBY)
       add_reference :posts, :users, foreign_key: true, null: false
     RUBY
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if add_belongs_to is used, with or without arguments" do
     inspect_source(<<~RUBY)
       add_belongs_to :posts, :users, foreign_key: true, null: false
     RUBY
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if t.references, or any variable.references is used, with or without arguments" do
@@ -31,7 +32,7 @@ describe RuboCop::Cop::Discourse::NoAddReferenceOrAliasesActiveRecordMigration,
       end
     RUBY
     expect(cop.offenses.count).to eq(2)
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if t.belongs_to, or any variable.belongs_to is used, with or without arguments" do
@@ -44,6 +45,6 @@ describe RuboCop::Cop::Discourse::NoAddReferenceOrAliasesActiveRecordMigration,
       end
     RUBY
     expect(cop.offenses.count).to eq(2)
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 end

data/spec/lib/rubocop/cop/no_mixing_multisite_and_standard_specs_spec.rb

@@ -16,7 +16,7 @@ describe RuboCop::Cop::Discourse::NoMixingMultisiteAndStandardSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if there are multiple multisite and standard top-level describes" do
@@ -31,7 +31,7 @@ describe RuboCop::Cop::Discourse::NoMixingMultisiteAndStandardSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "does not raise an offense if there are only multisite describes" do

data/spec/lib/rubocop/cop/no_mocking_jobs_enqueue_spec.rb

@@ -12,7 +12,7 @@ describe RuboCop::Cop::Discourse::NoMockingJobs, :config do
     Jobs.expects(:enqueue)
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to end_with(described_class::MSG)
   end
 
   it "raises an offense if Jobs is mocked with :enqueue_in" do
@@ -20,7 +20,7 @@ describe RuboCop::Cop::Discourse::NoMockingJobs, :config do
     Jobs.expects(:enqueue_in)
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to end_with(described_class::MSG)
   end
 
   it "does not raise an offense if Jobs is not mocked with :enqueue or :enqueue_in" do

data/spec/lib/rubocop/cop/no_reset_column_information_migrations_spec.rb

@@ -8,6 +8,8 @@ describe RuboCop::Cop::Discourse::NoResetColumnInformationInMigrations,
 
   let(:config) { RuboCop::Config.new }
 
+  before { config["Discourse/NoResetColumnInformationInMigrations"]["Enabled"] = true }
+
   it "raises an offense if reset_column_information is used" do
     inspect_source(<<~RUBY)
       class SomeMigration < ActiveRecord::Migration[6.0]
@@ -17,7 +19,7 @@ describe RuboCop::Cop::Discourse::NoResetColumnInformationInMigrations,
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raise an offense if reset_column_information is used without AR model" do
@@ -29,6 +31,6 @@ describe RuboCop::Cop::Discourse::NoResetColumnInformationInMigrations,
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 end

data/spec/lib/rubocop/cop/only_top_level_multisite_specs_spec.rb

@@ -15,7 +15,7 @@ describe RuboCop::Cop::Discourse::OnlyTopLevelMultisiteSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if multisite config option is used in a sub-describe (RSpec const version)" do
@@ -26,7 +26,7 @@ describe RuboCop::Cop::Discourse::OnlyTopLevelMultisiteSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if multisite config option is used in an example" do
@@ -40,7 +40,7 @@ describe RuboCop::Cop::Discourse::OnlyTopLevelMultisiteSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "raises an offense if multisite config option is used in a context" do
@@ -51,7 +51,7 @@ describe RuboCop::Cop::Discourse::OnlyTopLevelMultisiteSpecs, :config do
       end
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "does not raise an offense if multisite config option is used on top-level describe" do

data/spec/lib/rubocop/cop/time_eq_matcher_spec.rb

@@ -12,7 +12,7 @@ describe RuboCop::Cop::Discourse::TimeEqMatcher, :config do
     expect(user.created_at).to eq(Time.zone.now)
     RUBY
 
-    expect(cop.offenses.first.message).to eq(described_class::MSG)
+    expect(cop.offenses.first.message).to match(described_class::MSG)
   end
 
   it "passes if a timestamp is compared using `eq_time`" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Discourse Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-14 00:00:00.000000000 Z
+date: 2023-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop