rubocop-discourse 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 954b3ae3f59036a9880d2d055c37e97e5bbc0d454207638cc390efb41cfde649
-  data.tar.gz: 7b5607256ae2d3190a9d7d1ef7d95f73deb23964139a8a10c3fb628663912d96
+  metadata.gz: ab3bab04445e93feec2c095fbd6f2c39c4a2df8e304727bd61138205fe32aa6f
+  data.tar.gz: 0b5727aa611459b01ccc2f5c664c8944f97682079dd698434b6b90468c99929e
 SHA512:
-  metadata.gz: 4916ff3fcd7569705f59ced1716acbbeec52d763eff392e6eb148d5bc72d4fe6cff5644a0dfedc89353b4f856d77e609159d178b2b2d9643f904bed88d59cb4a
-  data.tar.gz: 8c1a20229b96ef6b69085147c95c5b799c6f7c9b0d38e8dc63c5cb5dc07931a332c231771f45fe656bd03c563fd3fa85f8f1c2bf79d9d64ad96415ce6ce764e3
+  metadata.gz: c4b717bce864cf92b1e3340f826e6671df6bc1fe3d1eecb5488ce1775c42fd8e321e345f728ef8c5852136e43d97f8a0605656b8b22b14b30637791b8666866b
+  data.tar.gz: 445c4334c24ee08db442ac0dd7f6b24908f206797d60613b8a22cce5f672753da955d8f084928f9cd8556aca5e3e4e853fbc23f7db1e90008a2914ee306ee496

data/lib/rubocop/cop/discourse/no_mocking_jobs.rb

@@ -4,15 +4,20 @@ module RuboCop
   module Cop
     module Discourse
       class NoMockingJobs < Cop
-        MSG = "Use the test helpers provided by Sidekiq instead of mocking `Jobs`."
+        MSG = "Use the test helpers provided by Sidekiq instead of mocking `Jobs.expects(:enqueue)`."
 
-        def_node_matcher :mocking_jobs?, <<~MATCHER
-        (send (const nil? :Jobs) :expects ...)
+        def_node_matcher :mocking_jobs_enqueue?, <<~MATCHER
+        (send (const nil? :Jobs) :expects (:sym :enqueue))
+        MATCHER
+
+        def_node_matcher :mocking_jobs_enqueue_in?, <<~MATCHER
+        (send (const nil? :Jobs) :expects (:sym :enqueue_in))
         MATCHER
 
         def on_send(node)
-          return unless mocking_jobs?(node)
-          add_offense(node, message: MSG)
+          if mocking_jobs_enqueue?(node) || mocking_jobs_enqueue_in?(node)
+            add_offense(node, message: MSG)
+          end
         end
       end
     end

data/rubocop-discourse.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "rubocop-discourse"
-  s.version     = "2.3.0"
+  s.version     = "2.3.1"
   s.summary     = "Custom rubocop cops used by Discourse"
   s.authors     = ["David Taylor"]
   s.files       = `git ls-files`.split($/)

data/spec/lib/rubocop/cop/{no_mocking_jobs_spec.rb → no_mocking_jobs_enqueue_spec.rb}

@@ -9,7 +9,7 @@ describe RuboCop::Cop::Discourse::NoMockingJobs, :config do
     RuboCop::Config.new
   end
 
-  it "raises an offense if Jobs is mocked" do
+  it "raises an offense if Jobs is mocked with :enqueue" do
     inspect_source(<<~RUBY)
     Jobs.expects(:enqueue)
     RUBY
@@ -17,7 +17,15 @@ describe RuboCop::Cop::Discourse::NoMockingJobs, :config do
     expect(cop.offenses.first.message).to eq(described_class::MSG)
   end
 
-  it "does not raise an offense if Jobs is not mocked" do
+  it "raises an offense if Jobs is mocked with :enqueue_in" do
+    inspect_source(<<~RUBY)
+    Jobs.expects(:enqueue_in)
+    RUBY
+
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "does not raise an offense if Jobs is not mocked with :enqueue or :enqueue_in" do
     inspect_source(<<~RUBY)
     Jobs.enqueue(:some_job)
     RUBY

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - David Taylor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-21 00:00:00.000000000 Z
+date: 2020-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -99,7 +99,7 @@ files:
 - rubocop-discourse.gemspec
 - rubocop-rspec.yml
 - spec/lib/rubocop/cop/no_add_reference_active_record_migrations_spec.rb
-- spec/lib/rubocop/cop/no_mocking_jobs_spec.rb
+- spec/lib/rubocop/cop/no_mocking_jobs_enqueue_spec.rb
 - spec/lib/rubocop/cop/no_reset_column_information_migrations_spec.rb
 - spec/spec_helper.rb
 homepage: