rubocop-definition_validator 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 323773610745ff80ea1a50e0f36d01372f82c121
+  data.tar.gz: d870c1d0acfe7c9ea7ddd79dac8981140ee1b30c
+SHA512:
+  metadata.gz: 445590d63bd3e6dbb99dba525a3e6615679d0d92de6f1a5b8e694a0e568f93202ee8b9472aad63301d32882b9382f81bd4c74f410207239f581e0001510ee73b
+  data.tar.gz: 48c8d95450b59208818449954b8182c5d029558ae3a5f68d6a042370f72e58fd80876ed0b2edb03789cfad9bbf5dfdb9636669b86bf1735824cfdaa49189a841

data/.gitignore

@@ -0,0 +1,9 @@
+/.bundle/
+/.yardoc
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/

data/.gitmodules

@@ -0,0 +1,3 @@
+[submodule "vendor/rubocop"]
+	path = vendor/rubocop
+	url = git@github.com:bbatsov/rubocop.git

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,467 @@
+AllCops:
+  Exclude:
+    - 'vendor/**/*'
+  DisplayCopNames: true
+  TargetRubyVersion: 2.3
+
+Style/AccessModifierIndentation:
+  Enabled: false
+
+Style/AccessorMethodName:
+  Enabled: false
+
+Style/Alias:
+  Enabled: false
+
+Style/AlignArray:
+  Enabled: false
+
+Style/AlignHash:
+  Enabled: false
+
+Style/AlignParameters:
+  Enabled: false
+
+Style/AndOr:
+  Enabled: false
+
+Style/ArrayJoin:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/AsciiIdentifiers:
+  Enabled: false
+
+Style/Attr:
+  Enabled: false
+
+Style/BeginBlock:
+  Enabled: false
+
+Style/BarePercentLiterals:
+  Enabled: false
+
+Style/BlockComments:
+  Enabled: false
+
+Style/BlockEndNewline:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Style/CaseEquality:
+  Enabled: true
+
+Style/CaseIndentation:
+  Enabled: false
+
+Style/CharacterLiteral:
+  Enabled: false
+
+Style/ClassAndModuleCamelCase:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/ClassCheck:
+  Enabled: false
+
+Style/ClassMethods:
+  Enabled: false
+
+Style/ClassVars:
+  Enabled: false
+
+Style/ColonMethodCall:
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
+
+Style/CommentIndentation:
+  Enabled: false
+
+Style/ConstantName:
+  Enabled: false
+
+Style/DefWithParentheses:
+  Enabled: false
+
+Style/DeprecatedHashMethods:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DotPosition:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/EachWithObject:
+  Enabled: false
+
+Style/ElseAlignment:
+  Enabled: false
+
+Style/EmptyElse:
+  Enabled: false
+
+Style/EmptyLineBetweenDefs:
+  Enabled: false
+
+Style/EmptyLines:
+  Enabled: false
+
+Style/EmptyLinesAroundAccessModifier:
+  Enabled: false
+
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+Style/EmptyLinesAroundMethodBody:
+  Enabled: false
+
+Style/EmptyLiteral:
+  Enabled: false
+
+Style/EndBlock:
+  Enabled: false
+
+Style/EndOfLine:
+  Enabled: false
+
+Style/EvenOdd:
+  Enabled: false
+
+Style/FileName:
+  Enabled: false
+
+Style/FirstParameterIndentation:
+  Enabled: false
+
+Style/FlipFlop:
+  Enabled: false
+
+Style/For:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/GlobalVars:
+  Enabled: true
+
+Style/GuardClause:
+  Enabled: false
+
+Style/HashSyntax:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/IfWithSemicolon:
+  Enabled: false
+
+Style/IndentationConsistency:
+  Enabled: false
+
+Style/IndentationWidth:
+  Enabled: false
+
+Style/IndentArray:
+  Enabled: false
+
+Style/IndentHash:
+  Enabled: false
+
+Style/InfiniteLoop:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/LambdaCall:
+  Enabled: false
+
+Style/LeadingCommentSpace:
+  Enabled: false
+
+Style/LineEndConcatenation:
+  Enabled: false
+
+Style/MethodCallParentheses:
+  Enabled: false
+
+Style/MethodDefParentheses:
+  Enabled: false
+
+Style/MethodName:
+  Enabled: false
+
+Style/ModuleFunction:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/MultilineBlockLayout:
+  Enabled: false
+
+Style/MultilineIfThen:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+Style/MultilineTernaryOperator:
+  Enabled: false
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/NegatedWhile:
+  Enabled: false
+
+Style/NestedTernaryOperator:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/NilComparison:
+  Enabled: false
+
+Style/NonNilCheck:
+  Enabled: false
+
+Style/Not:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/OneLineConditional:
+  Enabled: false
+
+Style/OpMethod:
+  Enabled: false
+
+Style/ParenthesesAroundCondition:
+  Enabled: false
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+Style/PercentQLiterals:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false
+
+Style/PredicateName:
+  Enabled: false
+
+Style/Proc:
+  Enabled: false
+
+Style/RaiseArgs:
+  Enabled: false
+
+Style/RedundantBegin:
+  Enabled: false
+
+Style/RedundantException:
+  Enabled: false
+
+Style/RedundantReturn:
+  Enabled: false
+
+Style/RedundantSelf:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+Style/SelfAssignment:
+  Enabled: false
+
+Style/Semicolon:
+  Enabled: false
+
+Style/SignalException:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/SingleLineMethods:
+  Enabled: false
+
+Style/SpaceBeforeFirstArg:
+  Enabled: false
+
+Style/SpaceAfterColon:
+  Enabled: false
+
+Style/SpaceAfterComma:
+  Enabled: false
+
+Style/SpaceAroundKeyword:
+  Enabled: false
+
+Style/SpaceAfterMethodName:
+  Enabled: false
+
+Style/SpaceAfterNot:
+  Enabled: false
+
+Style/SpaceAfterSemicolon:
+  Enabled: false
+
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+Style/SpaceBeforeComma:
+  Enabled: false
+
+Style/SpaceBeforeComment:
+  Enabled: false
+
+Style/SpaceBeforeSemicolon:
+  Enabled: false
+
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+Style/SpaceAroundBlockParameters:
+  Enabled: false
+
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+
+Style/SpaceAroundOperators:
+  Enabled: false
+
+Style/SpaceInsideBrackets:
+  Enabled: false
+
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+Style/SpaceInsideParens:
+  Enabled: false
+
+Style/SpaceInsideRangeLiteral:
+  Enabled: false
+
+Style/SpecialGlobalVars:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+Style/StructInheritance:
+  Enabled: false
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/Tab:
+  Enabled: false
+
+Style/TrailingBlankLines:
+  Enabled: false
+
+Style/TrailingCommaInLiteral:
+  Enabled: false
+
+Style/TrailingWhitespace:
+  Enabled: false
+
+Style/TrivialAccessors:
+  Enabled: false
+
+Style/UnlessElse:
+  Enabled: false
+
+Style/UnneededCapitalW:
+  Enabled: false
+
+Style/UnneededPercentQ:
+  Enabled: false
+
+Style/UnneededPercentX:
+  Enabled: false
+
+Style/VariableInterpolation:
+  Enabled: false
+
+Style/VariableName:
+  Enabled: false
+
+Style/WhenThen:
+  Enabled: false
+
+Style/WhileUntilDo:
+  Enabled: false
+
+Style/WhileUntilModifier:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Lint/DeprecatedClassMethods:
+  Enabled: false
+
+Lint/StringConversionInInterpolation:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

data/Guardfile

@@ -0,0 +1,54 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+guard :bundler do
+  require 'guard/bundler'
+  require 'guard/bundler/verify'
+  helper = Guard::Bundler::Verify.new
+
+  files = ['Gemfile']
+  files += Dir['*.gemspec'] if files.any? { |f| helper.uses_gemspec?(f) }
+
+  # Assume files are symlinked from somewhere
+  files.each { |file| watch(helper.real_path(file)) }
+end
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/README.md

@@ -0,0 +1,37 @@
+# Rubocop::DefinitionValidator
+
+This tool detects omission of modification of callers when the name of a method, number of arguments, or the name of a keyword argument is modified.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'rubocop-definition_validator'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install rubocop-definition_validator
+
+## Usage
+
+```sh
+$ git diff TARGET_COMMIT > ./.rubocop-definition_validator.diff
+$ rubocop -r rubocop/definition_validator
+```
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/actcat/rubocop-definition_validator.
+

data/Rakefile

@@ -0,0 +1,2 @@
+require "bundler/gem_tasks"
+task :default => :spec

data/bin/console

@@ -0,0 +1,11 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "rubocop/diff"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+require "pry"
+Pry.start

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/config/default.yml

@@ -0,0 +1,4 @@
+Lint/DefinitionValidator:
+  Description: 'TODO'
+  Enabled: true
+  Min: 6

data/lib/rubocop/cop/lint/definition_validator.rb

@@ -0,0 +1,31 @@
+module RuboCop
+  module Cop
+    module Lint
+      class DefinitionValidator < Cop
+        def on_send(node)
+          name = node.method_name.to_s
+          args = node.method_args
+          min = cop_config['Min']
+
+          msg = nil
+          Rubocop::DefinitionValidator::ChangeDetector.changed_methods.each do |m|
+            old, new = m[:removed], m[:added]
+
+            next if old.name.size <= min
+
+            old_callable, _ = old.callable?(name, args)
+            next unless old_callable
+
+            new_callable, reason = new.callable?(name, args)
+            next if new_callable
+
+            msg = reason.respond_to?(:call) ? reason.(old, new) : reason
+          end
+
+          return unless msg
+          add_offense(node, :expression, msg)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/definition_validator.rb

@@ -0,0 +1,16 @@
+require 'git_diff_parser'
+
+require 'rubocop'
+require "rubocop/definition_validator/version"
+require 'rubocop/definition_validator/inject'
+
+RuboCop::DefinitionValidator::Inject.defaults!
+
+
+require 'rubocop/definition_validator/line'
+require 'rubocop/definition_validator/patch'
+require 'rubocop/definition_validator/reason'
+require 'rubocop/definition_validator/method'
+require 'rubocop/definition_validator/change_detector'
+
+require 'rubocop/cop/lint/definition_validator'

data/lib/rubocop/definition_validator/change_detector.rb

@@ -0,0 +1,34 @@
+module Rubocop::DefinitionValidator::ChangeDetector
+  class << self
+    attr_reader :changed_methods
+
+    def init(diff_path)
+      unless File.exist?(diff_path)
+        @changed_methods = []
+        return
+      end
+
+      diff = File.read(diff_path)
+      parsed = GitDiffParser::Patches.parse(diff)
+      patches = parsed.map{|orig_patch| patch = Rubocop::DefinitionValidator::Patch.new(orig_patch)}
+      # [
+      #   {added: Method, removed: Method}
+      # ]
+      @changed_methods = patches
+        .map{|patch| patch.changed_method_codes}
+        .flatten
+        .map{|code|
+        code.map{|k, v|
+          begin
+            [k, Rubocop::DefinitionValidator::Method.new(v.body)]
+          rescue Rubocop::DefinitionValidator::Method::InvalidAST
+            nil
+          end
+        }.compact.to_h
+      }
+    end
+  end
+end
+
+# XXX: 暫定的に .rubocop-definition_validator.diff からdiffを読む
+Rubocop::DefinitionValidator::ChangeDetector.init('./.rubocop-definition_validator.diff')

data/lib/rubocop/definition_validator/inject.rb

@@ -0,0 +1,23 @@
+# This file is copied from rubocop-rspec
+require 'yaml'
+
+module RuboCop
+  module DefinitionValidator
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration.
+    module Inject
+      DEFAULT_FILE = File.expand_path(
+        '../../../../config/default.yml', __FILE__
+      )
+
+      def self.defaults!
+        path = File.absolute_path(DEFAULT_FILE)
+        hash = ConfigLoader.send(:load_yaml_configuration, path)
+        config = Config.new(hash, path)
+        puts "configuration from #{DEFAULT_FILE}" if ConfigLoader.debug?
+        config = ConfigLoader.merge_with_default(config, path)
+        ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

data/lib/rubocop/definition_validator/line.rb

@@ -0,0 +1,13 @@
+class Rubocop::DefinitionValidator::Line < GitDiffParser::Line
+  attr_reader :content
+
+  # trim `+` or `-` prefix
+  def body
+    content[1..-1]
+  end
+
+  # @return [String] + or -
+  def type
+    content[0]
+  end
+end

data/lib/rubocop/definition_validator/method.rb

@@ -0,0 +1,191 @@
+require 'ripper'
+
+module Rubocop::DefinitionValidator
+  class Method
+    class InvalidAST < ArgumentError; end
+
+    attr_reader :name
+
+    # @param [String] definition
+    #
+    # Definition Example:
+    #   def f(a, b, c, m = 1, n = 1, *rest, x, y, z, k: 1, **kwrest, &blk)
+    #
+    # AST Example:
+    #   [:program,
+    #    [[:def,
+    #      [:@ident, "f", [1, 4]],
+    #      [:paren,
+    #       [:params,
+    #        [[:@ident, "a", [1, 6]], [:@ident, "b", [1, 9]], [:@ident, "c", [1, 12]]],
+    #        [[[:@ident, "m", [1, 15]], [:@int, "1", [1, 19]]], [[:@ident, "n", [1, 22]], [:@int, "1", [1, 26]]]],
+    #        [:rest_param, [:@ident, "rest", [1, 30]]],
+    #        [[:@ident, "x", [1, 36]], [:@ident, "y", [1, 39]], [:@ident, "z", [1, 42]]],
+    #        [[[:@label, "k:", [1, 45]], [:@int, "1", [1, 48]]]],
+    #        [:@ident, "kwrest", [1, 53]],
+    #        [:blockarg, [:@ident, "blk", [1, 62]]]]],
+    #      [:bodystmt, [[:void_stmt]], nil, nil, nil]]]]
+    #
+    def initialize(definition)
+      code = "#{definition}; end"
+      ast = Ripper.sexp(code)
+
+      begin
+        params = ast[1][0][2]
+        name = ast[1][0][1][1]
+      rescue NoMethodError => ex
+        raise InvalidAST, "Can't parse AST. \nAST: #{ast}\nError: #{ex}"
+      end
+
+      if params[0] == :paren
+        params = params[1]
+      end
+
+      @params = params[1..-1]
+      @name = name
+    end
+
+    # @param [Array<RuboCop::Node>] args
+    # @return [Boolean] callable
+    # @return [Proc] cause
+    def callable?(name, args)
+      return false, Reason.method_name unless name == @name
+
+      args = args.dup
+
+      # 通常の引数分shift
+      normal_params_size = (normal_params || []).size
+      received_normal_params_size = args.shift(normal_params_size).size
+      unless received_normal_params_size == normal_params_size
+        return false, Reason.not_enough_arguments(
+          received_normal_params_size,
+          normal_params_size,
+          :normal_params,
+        )
+      end
+
+      if has_required_keyword_params?
+        decide_with_required_keyword_params(args)
+      elsif has_keyword_params?
+        decide_with_keyword_params(args)
+      else
+        decide_rest_args(args)
+      end
+    end
+
+
+    %i[
+      normal_params
+      default_value_params
+      rest_params
+      normal_params_after_rest
+      keyword_params
+      keyword_rest_params
+    ].each.with_index do |name, idx|
+      eval <<-CODE
+  def #{name}
+    @params[#{idx}]
+  end
+      CODE
+    end
+
+
+    private
+
+    # decide default_value_params, rest_params, normal_params_after_rest
+    # @param [Array<RuboCop::Node>] args
+    # @return [Boolean]
+    def decide_rest_args(args)
+      normal_params_after_rest_size = (normal_params_after_rest || []).size
+      given_normal_params_after_rest_size = args.pop(normal_params_after_rest_size).size
+      unless given_normal_params_after_rest_size == normal_params_after_rest_size
+        return false, Reason.not_enough_arguments(
+          given_normal_params_after_rest_size,
+          normal_params_after_rest_size,
+          :normal_params_after_rest
+        )
+      end
+
+      # rest引数があれば全て呑み込むためtrue
+      return true if rest_params
+      # デフォルト値付き引数の数だけは呑み込める
+      if default_value_params
+        return true if args.size <= default_value_params.size
+        # XXX: optimize message.
+        return false, "Too many argument"
+      end
+      return true if args.empty?
+      return false, "Too many argument"
+    end
+
+    def decide_with_required_keyword_params(args)
+      kwparam = args.pop(1)
+      usable, reason = usable_as_keyword_param?(kwparam[0])
+      return false, reason unless usable
+
+      return decide_rest_args(args)
+    end
+
+    def decide_with_keyword_params(args)
+      ok, _ = decide_rest_args(args.dup)
+      return true if ok
+
+      return decide_with_required_keyword_params(args)
+    end
+
+
+    def has_keyword_params?
+      !!((keyword_params && !keyword_params.empty?) ||
+        keyword_rest_params)
+    end
+
+    def has_required_keyword_params?
+      (keyword_params && !keyword_params.empty?) &&
+        keyword_params.any?{|p| p[1] == false}
+    end
+
+
+    # @param [RuboCop::Node] arg
+    def usable_as_keyword_param?(arg)
+      # should be hash
+      return false, "Keyword params is required." unless arg
+      return false, "Keyword params should be hash. But got #{arg.loc.expression.source}" unless arg.hash_type? || !arg.literal?
+
+      # should have specified keyword
+      return true unless arg.hash_type?
+
+      required_keyword_names = keyword_params
+        .select{|x| x[1] == false}
+        .map{|x| x[0][1]}
+        .map{|x| x.chop.to_sym}
+
+      received_keyword_names = arg
+        .children
+        .map(&:children)
+        .map{|x| x.first}
+        .map(&:children)
+        .map{|x| x.first}
+
+      not_fould_requireds = required_keyword_names.select do |name|
+        not received_keyword_names.include?(name)
+      end
+      unless not_fould_requireds.empty?
+        return false, "The following keyword parameters are required. But not received. #{not_fould_requireds.join(', ')}"
+      end
+
+      return true if keyword_rest_params
+
+      allowed_keyword_names = keyword_params
+        .map{|x| x[0][1]}
+        .map{|x| x.chop.to_sym}
+
+      unexpected_keywords =  received_keyword_names.select do |name|
+        not allowed_keyword_names.include?(name)
+      end
+      unless unexpected_keywords.empty?
+        return false, "The following keyword parameters are not expected. But received. #{unexpected_keywords}"
+      end
+      return true
+    end
+  end
+end

data/lib/rubocop/definition_validator/patch.rb

@@ -0,0 +1,63 @@
+#
+# This class override `changed_lines` method.
+# The original method retuns only added lines.
+# However we want added and removed lines.
+#
+class Rubocop::DefinitionValidator::Patch < GitDiffParser::Patch
+  ADDED_LINE   = -> (line) { line.start_with?('+') && line !~ /^\+\+\+/ }
+  REMOVED_LINE = -> (line) { line.start_with?('-') && line !~ /^\-\-\-/ }
+
+  def initialize(original_patch)
+    @body = original_patch.body
+    @file = original_patch.file
+    @secure_hash = original_patch.secure_hash
+  end
+
+  # @return [Array<Line>] changed lines
+  def changed_lines
+    line_number = 0
+    removed_line_offset = 0
+
+    lines.each_with_index.inject([]) do |lines, (content, patch_position)|
+      case content
+      when RANGE_INFORMATION_LINE
+        line_number = Regexp.last_match[:line_number].to_i
+        removed_line_offset = 0
+      when ADDED_LINE
+        line = Rubocop::DefinitionValidator::Line.new(
+          content: content,
+          number: line_number,
+          patch_position: patch_position
+        )
+        lines << line
+        line_number += 1
+        removed_line_offset = 0
+      when REMOVED_LINE
+        line = Rubocop::DefinitionValidator::Line.new(
+          content: content,
+          number: line_number + removed_line_offset,
+          patch_position: patch_position
+        )
+        lines << line
+        removed_line_offset +=1
+      when NOT_REMOVED_LINE
+        line_number += 1
+        removed_line_offset = 0
+      end
+
+      lines
+    end
+  end
+
+  def changed_method_codes
+    lines = changed_lines
+    lines
+      .group_by{|l| l.number}
+      .values
+      .select{|l| l.size == 2}
+      .select{|l| t = l.map(&:type); t.include?('-') && t.include?('+')}
+      .select{|l| l.all?{|x| x.content =~ /def\s+\w+/}}
+      .map{|l| l.sort_by(&:type)}
+      .map{|l| {added: l.first, removed: l.last}}
+  end
+end

data/lib/rubocop/definition_validator/reason.rb

@@ -0,0 +1,20 @@
+module Rubocop::DefinitionValidator::Reason
+  class << self
+    # @return [Proc]
+    def method_name
+      -> (old, new) { "#{old.name} is undefined. Did you mean? #{new.name}" }
+    end
+
+    # @param [Integer] given given args size.
+    # @param [Integer] expected expected args size.
+    # @param [Symbol] kind normal_params or normal_params_after_rest
+    # @return [Proc]
+    def not_enough_arguments(given, expected, kind)
+      n = expected - given
+      -> (_old, new) {
+        not_enough_arg_names = new.__send__(kind).dup.pop(n).map{|x| x[1]}
+        "Not enough arguments. Did you forget the following arguments? [#{not_enough_arg_names.join(', ')}]"
+      }
+    end
+  end
+end

data/lib/rubocop/definition_validator/version.rb

@@ -0,0 +1,5 @@
+module Rubocop
+  module DefinitionValidator
+    VERSION = "0.1.0"
+  end
+end

data/rubocop-definition_validator.gemspec

@@ -0,0 +1,35 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'rubocop/definition_validator/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "rubocop-definition_validator"
+  spec.version       = Rubocop::DefinitionValidator::VERSION
+  spec.authors       = ["Masataka Kuwabara"]
+  spec.email         = ["p.ck.t22@gmail.com"]
+
+  spec.summary       = %q{This tool detects omission of modification of callers when the name of a method, number of arguments, or the name of a keyword argument is modified.}
+  spec.description   = %q{This tool detects omission of modification of callers when the name of a method, number of arguments, or the name of a keyword argument is modified.}
+  spec.homepage      = "https://github.com/actcat/rubocop-definition_validator"
+
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+  # TODO: License
+
+  spec.add_runtime_dependency 'rubocop', '>= 0.31.0'
+  spec.add_runtime_dependency 'git_diff_parser', '>= 2.2.0'
+
+  spec.add_development_dependency "bundler", "~> 1.11"
+  spec.add_development_dependency "rake", "~> 10.0"
+
+  spec.add_development_dependency "rspec", "~> 3.4.0"
+  spec.add_development_dependency 'guard', '~> 2.13.0'
+  spec.add_development_dependency 'guard-rspec', '~> 4.6.5'
+  spec.add_development_dependency 'guard-bundler', '~> 2.1.0'
+  spec.add_development_dependency 'pry', '~> 0.10.3'
+  spec.add_development_dependency 'rspec-power_assert', '~> 0.3.0'
+  spec.add_development_dependency 'pry_testcase', '~> 0.3.0'
+end

metadata

@@ -0,0 +1,220 @@
+--- !ruby/object:Gem::Specification
+name: rubocop-definition_validator
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Masataka Kuwabara
+autorequire: 
+bindir: exe
+cert_chain: []
+date: 2016-06-01 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.31.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.31.0
+- !ruby/object:Gem::Dependency
+  name: git_diff_parser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.11'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.0
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.13.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.13.0
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.6.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.6.5
+- !ruby/object:Gem::Dependency
+  name: guard-bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.3
+- !ruby/object:Gem::Dependency
+  name: rspec-power_assert
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+- !ruby/object:Gem::Dependency
+  name: pry_testcase
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+description: This tool detects omission of modification of callers when the name of
+  a method, number of arguments, or the name of a keyword argument is modified.
+email:
+- p.ck.t22@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".gitmodules"
+- ".rspec"
+- ".rubocop.yml"
+- Gemfile
+- Guardfile
+- README.md
+- Rakefile
+- bin/console
+- bin/setup
+- config/default.yml
+- lib/rubocop/cop/lint/definition_validator.rb
+- lib/rubocop/definition_validator.rb
+- lib/rubocop/definition_validator/change_detector.rb
+- lib/rubocop/definition_validator/inject.rb
+- lib/rubocop/definition_validator/line.rb
+- lib/rubocop/definition_validator/method.rb
+- lib/rubocop/definition_validator/patch.rb
+- lib/rubocop/definition_validator/reason.rb
+- lib/rubocop/definition_validator/version.rb
+- rubocop-definition_validator.gemspec
+homepage: https://github.com/actcat/rubocop-definition_validator
+licenses: []
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.5.1
+signing_key: 
+specification_version: 4
+summary: This tool detects omission of modification of callers when the name of a
+  method, number of arguments, or the name of a keyword argument is modified.
+test_files: []