rubocop-daemon 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c5579693de992c601188ad58c5ea7e3e5988ac40e6b3d2344000e454ae48f566
-  data.tar.gz: b2e0ffca2fa243fe6bfc687b1710871317f9e358850ea4ebe7c42903f885372b
+  metadata.gz: 5b7fc85bc8f0d4eec8c3e059c0dfd63131165881e99b9df8f675569cc9f482d5
+  data.tar.gz: 8ac1b60ad89d68fd52b9bae1ce5d5f9f2579307e4f68934726077efb4669fa1f
 SHA512:
-  metadata.gz: a992d260d61f322ce081554e10e64330cc01e3ec868134da73a8c2c5fa79f472470b4de54b122399cd5db7812d37f2ee4c0b5b6be6d86e260f42b5366b15e5de
-  data.tar.gz: 555be81d6ae5c2a6b8b0e0b465caaffdb227faa769e9214165d1d616799d81f17ec1993aca274475179bb1f177622728254da219ccb820c9ee28662e8402d092
+  metadata.gz: 4ee5f72d514f94b91b5ddddee5a68db28627367e09639e017b80a73500b0343c78f6d4ebee344ed17f88ce3a99558b17b232f75cf8d45541bd733b46db9dc0d8
+  data.tar.gz: cabc9bca1782ec0b20425b76ca4494e7b887135b0b8f50729044055d7795ba4698a3f355c9ca89fb62b33e931b01c07187198d0dabbf74c310741603a9113df1

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.2
 
 Style/FrozenStringLiteralComment:
   EnforcedStyle: always

data/README.md

@@ -1,17 +1,15 @@
 # rubocop-daemon
 
-`rubocop-daemon` makes RuboCop faster.
+[![Gem](https://img.shields.io/gem/v/rubocop-daemon.svg)](https://rubygems.org/gems/rubocop-daemon)
 
-**This tool is beta version.**
+`rubocop-daemon` makes RuboCop faster.
 
 ## Installation
 
-`rubocop-daemon` is not released on rubygems.org yet, but you can try `rubocop-daemon`:
+Install `rubocop-daemon` via rubygems.org:
 
 ```sh
-git clone https://github.com/fohte/rubocop-daemon.git && cd rubocop-daemon
-bundle install
-bundle exec rake install
+gem install rubocop-daemon
 ```
 
 ## Usage

data/lib/rubocop/daemon.rb

@@ -13,7 +13,7 @@ module RuboCop
     autoload :SocketReader, 'rubocop/daemon/socket_reader'
 
     def self.running?
-      Cache.dir.exist?
+      Cache.dir.exist? && Cache.pid_path.file? && Cache.pid_running?
     end
   end
 end

data/lib/rubocop/daemon/cache.rb

@@ -6,8 +6,8 @@ module RuboCop
   module Daemon
     class Cache
       def self.dir
-        Pathname.new(File.expand_path('~/.cache/rubocop-daemon')).tap do |d|
-          d.mkdir unless d.exist?
+        Pathname.new(File.join(File.expand_path('~/.cache/rubocop-daemon'), Dir.pwd[1..-1].tr('/', '+'))).tap do |d|
+          d.mkpath unless d.exist?
         end
       end
 
@@ -23,6 +23,12 @@ module RuboCop
         dir.join('pid')
       end
 
+      def self.pid_running?
+        Process.kill 0, pid_path.read.to_i
+      rescue Errno::ESRCH
+        false
+      end
+
       def self.make_server_file(port:, token:)
         port_path.write(port)
         token_path.write(token)

data/lib/rubocop/daemon/cli.rb

@@ -15,6 +15,7 @@ module RuboCop
       def run(argv = ARGV)
         parser.order!(argv)
         return if argv.empty?
+
         create_subcommand_instance(argv)
       rescue OptionParser::InvalidOption => e
         warn "error: #{e.message}"

data/lib/rubocop/daemon/client_command/start.rb

@@ -6,7 +6,7 @@ module RuboCop
       class Start < Base
         def run
           parser.parse(@argv)
-          Server.new.start(@options.fetch(:port, 0))
+          Server.new(@options.fetch(:no_daemon, false)).start(@options.fetch(:port, 0))
         end
 
         private
@@ -16,6 +16,7 @@ module RuboCop
             p.banner = 'usage: rubocop-daemon start [options]'
 
             p.on('-p', '--port [PORT]') { |v| @options[:port] = v }
+            p.on('--no-daemon', 'Starts server in foreground with debug information') { @options[:no_daemon] = true }
           end
         end
       end

data/lib/rubocop/daemon/server.rb

@@ -7,12 +7,14 @@ require 'securerandom'
 module RuboCop
   module Daemon
     class Server
+      attr_reader :verbose
+
       def self.token
         @token ||= SecureRandom.hex(4)
       end
 
-      def self.start(port)
-        new.start(port)
+      def initialize(verbose)
+        @verbose = verbose
       end
 
       def token
@@ -21,24 +23,30 @@ module RuboCop
 
       def start(port)
         require 'rubocop'
-        @server = TCPServer.open('127.0.0.1', port)
-
+        start_server(port)
+        Process.daemon(true) unless verbose
         Cache.make_server_file(port: @server.addr[1], token: token) do
-          Process.daemon(true)
           read_socket(@server.accept) until @server.closed?
         end
       end
 
       private
 
+      def start_server(port)
+        @server = TCPServer.open('127.0.0.1', port)
+        puts "Server listen on port #{@server.addr[1]}" if verbose
+      end
+
       def read_socket(socket)
-        SocketReader.new(socket).read!
+        SocketReader.new(socket, verbose).read!
       rescue InvalidTokenError
         socket.puts 'token is not valid.'
       rescue ServerStopRequest
         @server.close
       rescue UnknownServerCommandError => e
         socket.puts e.message
+      rescue Errno::EPIPE => e
+        p e if verbose
       rescue StandardError => e
         socket.puts e.full_message
       ensure

data/lib/rubocop/daemon/socket_reader.rb

@@ -6,8 +6,9 @@ module RuboCop
       Request = Struct.new(:header, :body)
       Header = Struct.new(:token, :cwd, :command, :args)
 
-      def initialize(socket)
+      def initialize(socket, verbose)
         @socket = socket
+        @verbose = verbose
       end
 
       def read!
@@ -25,6 +26,7 @@ module RuboCop
       private
 
       def parse_request(content)
+        puts content if @verbose
         raw_header, *body = content.lines
         Request.new(parse_header(raw_header), body.join)
       end

data/lib/rubocop/daemon/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Daemon
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.2.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-daemon
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Hayato Kawai
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-04 00:00:00.000000000 Z
+date: 2018-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -125,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Makes RuboCop faster