rubocop-config-umbrellio 0.48.1.4 → 0.49.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dd320abf4cf90666b05e7c0e53ed77ac865a304
-  data.tar.gz: d88f866190a523d0edf74b3ed1e4b7bf43f30663
+  metadata.gz: 63a8e29dcb90d667437a4124643f82a3770030ca
+  data.tar.gz: a2fc71a17848d3c3d25b9656d11f5487f0f69770
 SHA512:
-  metadata.gz: 1ef8262b121e3d87af87ac786e680e4e26da1882f3a7b2153b80d64de3b7b5ef89dc96d8ba13971f62763f005205b7698eeb7797c3939be424da03e0bc700066
-  data.tar.gz: 58d1e57742936c4ea3eb6152c3a5aff074e20513ca1fb77e2cbf08f3489764c70a9cb84756264d9689737cab21a50ee2f95636a64ae9dce8a952a33eff7381af
+  metadata.gz: 72d7ae643721830f49730e7221ac87c07c029bd7556e7ada016bf9ed8287cef6a66c3db0575295963a44bba60c9f0625dcc51e2e35b5cc806250bbe97b7cb2fc
+  data.tar.gz: ce47e67b863e95bb29e117f646ff1041f561e3d987a23112c4fb79b56c848411be73b905ae2da05e3d56ca322e5d7f1729d11ec088ca13e097137d6d32fb1336

data/lib/rubocop.rails.yml

@@ -25,6 +25,13 @@ Metrics/MethodLength:
 Rails:
   Enabled: true
 
+Rails/ApplicationJob:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  # Use it even you use Sequel
+  Enabled: true
+
 Rails/Delegate:
   Enabled: false
 

data/lib/rubocop.yml

@@ -4,7 +4,24 @@ AllCops:
   Exclude:
     - bin/**/*
 
-# LINT
+# Layout
+
+Layout/AlignParameters:
+  Enabled: true
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+
+Layout/MultilineOperationIndentation:
+  Enabled: false
+
+Layout/SpaceInLambdaLiteral:
+  EnforcedStyle: require_space
+
+Layout/SpaceInsideBrackets:
+  Enabled: false
+
+# Lint
 
 Lint/AmbiguousBlockAssociation:
   # `scope :name, -> (param) { ... }` is a valid syntax
@@ -19,9 +36,17 @@ Lint/NonLocalExitFromIterator:
 Lint/HandleExceptions:
   Enabled: false
 
+Lint/RescueType:
+  # It's generally useless, but why not?
+  Enabled: true
+
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
+Lint/ScriptPermission:
+  # checks +x on scripts
+  Enabled: true
+
 # Metrics
 
 Metrics/AbcSize:
@@ -50,6 +75,9 @@ Metrics/PerceivedComplexity:
 
 # Performance
 
+Performance/Caller:
+  Enabled: true
+
 Performance/Casecmp:
   Enabled: false
 
@@ -70,6 +98,9 @@ RSpec/DescribedClass:
 RSpec/DescribeMethod:
   Enabled: false
 
+RSpec/FilePath:
+  Enabled: false
+
 RSpec/LetSetup:
   Enabled: false
 
@@ -97,9 +128,6 @@ Style/AccessorMethodName:
   # This cop assumes every method is accessor
   Enabled: false
 
-Style/AlignParameters:
-  Enabled: true
-
 Style/AndOr:
   # `do_something and return`
   Enabled: false
@@ -131,6 +159,18 @@ Style/EmptyElse:
 Style/Encoding:
   Enabled: false
 
+Style/FormatStringToken:
+  # Bad
+  # [7] pry(main)> format "%{foo}", foo: 123
+  # => "123"
+  # Good
+  # [8] pry(main)> format "%<foo>s", foo: 123
+  # => "123"
+  # Also good
+  # [9] pry(main)> format "%<foo>f", foo: 123
+  # => "123.000000"
+  Enabled: true
+
 Style/IfUnlessModifier:
   Enabled: true
 
@@ -143,15 +183,18 @@ Style/LambdaCall:
 Style/ModuleFunction:
   Enabled: false
 
-Style/MultilineMethodCallIndentation:
-  Enabled: false
-
-Style/MultilineOperationIndentation:
-  Enabled: false
-
 Style/MultilineTernaryOperator:
   Enabled: false
 
+Style/MultipleComparison:
+  # Bad
+  # if foo == 1 || foo == 2
+  # Good
+  # [1, 2].include?(foo)
+  # With activesupport, this is better
+  # foo.in? [1, 2]
+  Enabled: true
+
 Style/NumericLiterals:
   Description: 'Use indent in groups of 3 unlesss you meet project-specific rule'
   Enabled: false
@@ -179,8 +222,6 @@ Style/RegexpLiteral:
 Style/RescueModifier:
   Enabled: false
 
-Style/SpaceInLambdaLiteral:
-  EnforcedStyle: require_space
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
@@ -195,9 +236,6 @@ Style/SingleLineBlockParams:
 Style/StringLiteralsInInterpolation:
   Enabled: false
 
-Style/SpaceInsideBrackets:
-  Enabled: false
-
 Style/TrailingCommaInArguments:
   EnforcedStyleForMultiline: comma
 
@@ -207,3 +245,7 @@ Style/TrailingCommaInLiteral:
 Style/TrivialAccessors:
   AllowPredicates: true
   Enabled: false
+
+Style/YodaCondition:
+  # REVIEW: i sure that we don't need it
+  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-umbrellio
 version: !ruby/object:Gem::Version
-  version: 0.48.1.4
+  version: 0.49.1.0
 platform: ruby
 authors:
 - JelF
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-16 00:00:00.000000000 Z
+date: 2017-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 0.49.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 0.49.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.0
+        version: 1.15.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.0
+        version: 1.15.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -94,8 +94,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: This gem provides default rubocop settings for Umbrellio projects
 test_files: []
+has_rdoc: