rubocop-config-captive 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5db06e7a52b7907e189fecdc71175cfe6104549157407176742a9a88823ce089
-  data.tar.gz: 4d58098dec20640412ae545175374d52beab914b6f2f9951c30bc9c84bd1eedd
+  metadata.gz: 35d02218cee724fa93a32f80e654db067e2009706748d88863a09280398d2a79
+  data.tar.gz: 1eb89c57a0a20fae019e0431d002b60097be12822bf9191827364d52c48d8c02
 SHA512:
-  metadata.gz: 72f86d66b9754c40049530fd3acef65883c642f4a3f30f352a1fa42f49edd283c00f5115a0a037e4492984ae42119af01adc1f744b4c22c0dd01695372140503
-  data.tar.gz: 04e0c1a8742603cdb2096072523ac9f5a286631ade79e2e1c978aa24504cbea89f641b3a600786c1622337553a2f38f62a5472fbb8cdc0cc50894301136c8ef3
+  metadata.gz: 9fb77596cecdebf4e6a4b89f49b03c50d9876d676b3f201e53da14f8a35890660b40685007e3694ce199dc957b36f6dce426ba479fef56178b730642302fd804
+  data.tar.gz: 5b8069af3175f7c484028867a652ec7b2de31e0af9f75d4b3630ef39fd5c358cd467deaa52272343b9ad89c9fbafbe46736409fde1bb2e694f916b313e09004f

data/README.md

@@ -34,21 +34,66 @@ inherit_gem:
 
 ## Common Errors
 
-### My project has too many errors
+<details>
+  <summary>
+    <strong>😩 My project has too many errors</strong>
+  </summary>
+  
+## Explanation
 
-Firstly, you can use `bundle exec rubocop -a` to auto-correct your project
+the configuration is very strict, it is normal to have many errors
 
-Then if you have too many warnings, you can use the command line :
+## Solution
 
-`bundle exec rubocop --auto-gen-config` to create `.rubocop_todo.yml` file that ignore these errors
+### Solution 1 : Auto-correct all errors
 
-### `Gemfile` has lots of `Bundler/GemVersion` errors
+```shell
+bundle exec rubocop -a
+```
+
+### Solution 2 : Ignore errors and progressively fix them
+
+```shell
+bundle exec rubocop --auto-gen-config
+```
+
+Will create `.rubocop_todo.yml` will all non passing rules. It is advised to fix them later, rule by rule.
+</details>
+
+<details>
+  <summary>
+    <strong>📍 <code>Gemfile</code> has lots of <code>Bundler/GemVersion</code> errors </strong>
+  </summary>
+
+## Explanation
+
+Each dependency should be explicitly set in the `Gemfile` and `bundle update` is strongly discouraged.
+
+## Solution
+
+### Solution 1 : Use bundle-locker
+
+1. Install bundle-locker globally
+
+  ```shell
+  gem install bundle-locker
+  ```
+
+2. Pin Gemfile using `Gemfile.lock`
+
+  ```shell
+  bundle-locker ./Gemfile
+  ```
+
+3. Manually edit `Gemfile` and adjust constraints `"x.x.x"`, `"~> x.x.x"`,  etc
+
+4. Update `Gemfile.lock`
 
-Explanation : Each dependency should be explicitly set in the `Gemfile` and `bundle update` is strongly discouraged.
-Workaround :
+  ```shell
+  bundle install
+  ```
 
-1. Install gem bundle-locker : `gem install bundle-locker`
-1. Pin Gemfile using Gemfile.lock : `bundle-locker ./Gemfile`
+</details>
 
 ## Contributing
 

data/config/__private__/rubocop-rspec.yml

@@ -246,9 +246,3 @@ RSpec/VerifiedDoubles:
 RSpec/VoidExpect:
   Description: This cop checks void `expect()`.
   Enabled: false
-RSpec/FactoryBot/AttributeDefinedStatically:
-  Description: Always declare attribute values as blocks.
-  Enabled: false
-RSpec/FactoryBot/CreateList:
-  Description: Checks for create_list usage.
-  Enabled: true

data/config/default.yml

@@ -41,6 +41,7 @@ inherit_from:
   - './rubocop-bundler.yml'
   - './rubocop-capybara.yml'
   - './rubocop-captive.yml'
+  - './rubocop-factory_bot.yml'
   - './rubocop-gemspec.yml'
   - './rubocop-layout.yml'
   - './rubocop-lint.yml'

data/config/rubocop-factory_bot.yml

@@ -0,0 +1,2 @@
+require:
+  - rubocop-factory_bot

data/config/rubocop-rails.yml

@@ -1,3 +1,156 @@
 inherit_from:
   # @see https://github.com/airbnb/ruby/blob/main/rubocop-airbnb/config/rubocop-rails.yml
   - ./__private__/rubocop-rails.yml
+
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
+
+Rails/ActionControllerTestCase:
+  Enabled: false
+
+Rails/ActionOrder:
+  Enabled: true
+
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+Rails/ActiveSupportOnLoad:
+  Enabled: true
+
+Rails/AddColumnIndex:
+  Enabled: true
+
+Rails/AfterCommitOverride:
+  Enabled: true
+
+Rails/AttributeDefaultBlockValue:
+  Enabled: true
+
+Rails/CompactBlank:
+  Enabled: true
+
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: true
+
+Rails/DotSeparatedKeys:
+  Enabled: true
+
+Rails/DuplicateAssociation:
+  Enabled: true
+
+Rails/DuplicateScope:
+  Enabled: true
+
+Rails/EagerEvaluationLogMessage:
+  Enabled: false
+
+Rails/ExpandedDateRange:
+  Enabled: true
+
+Rails/FindById:
+  Enabled: true
+
+Rails/DurationArithmetic:
+  Enabled: true
+
+Rails/FreezeTime:
+  Enabled: true
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+Rails/I18nLocaleAssignment:
+  Enabled: true
+
+Rails/I18nLocaleTexts:
+  Enabled: true
+
+Rails/IgnoredColumnsAssignment:
+  Enabled: false
+
+Rails/Inquiry:
+  Enabled: true
+
+Rails/MailerName:
+  Enabled: true
+
+Rails/MatchRoute:
+  Enabled: false
+
+Rails/MigrationClassName:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: false
+
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckInWhere:
+  Enabled: true
+
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: false
+
+Rails/RedundantTravelBack:
+  Enabled: true
+
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: true
+
+Rails/ResponseParsedBody:
+  Enabled: true
+
+Rails/RootJoinChain:
+  Enabled: true
+
+Rails/RootPathnameMethods:
+  Enabled: true
+
+Rails/RootPublicPath:
+  Enabled: true
+
+Rails/ShortI18n:
+  Enabled: true
+
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
+Rails/StripHeredoc:
+  Enabled: true
+
+Rails/TimeZoneAssignment:
+  Enabled: true
+
+Rails/ToFormattedS:
+  Enabled: true
+
+Rails/ToSWithArgument:
+  Enabled: true
+
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
+
+Rails/TransactionExitStatement:
+  Enabled: true
+
+Rails/UnusedIgnoredColumns:
+  Enabled: true
+
+Rails/WhereEquals:
+  Enabled: true
+
+Rails/WhereExists:
+  Enabled: true
+
+Rails/WhereMissing:
+  Enabled: true
+
+Rails/WhereNot:
+  Enabled: true
+
+Rails/WhereNotWithMultipleConditions:
+  Enabled: true

data/config/rubocop-rspec.yml

@@ -3,4 +3,13 @@ inherit_from:
   - ./__private__/rubocop-rspec.yml
 
 RSpec/Focus:
-  Enabled: true
+  Enabled: true
+
+# exclue certains fichiers pour simplifier l'utilisation de rswag
+RSpec/ScatteredSetup:
+  Exclude:
+    - 'spec/requests/**/*'
+
+Rspec/RepeatedExample:
+  Exclude:
+    - 'spec/requests/**/*'

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = '1.3.0'
+    VERSION = '1.4.0'
   end
 end

data/rubocop-config-captive.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.email = ['julien.polo@captive.fr']
   gem.homepage = 'https://github.com/Captive-Studio/rubocop-config'
   gem.license = 'MIT'
-  gem.required_ruby_version = '>= 2.5'
+  gem.required_ruby_version = '>= 2.6'
 
   gem.files = Dir[
     '{config,lib}/**/*',
@@ -25,12 +25,13 @@ Gem::Specification.new do |gem|
   # ⚠️ Instead of depending on rubocop-airbnb we copy sources
   #
   # gem.add_dependency('rubocop-airbnb', '~> 4.0.0')
-  gem.add_dependency('rubocop', '~> 1.49.0')
-  gem.add_dependency('rubocop-performance', '~> 1.16.0 ')
+  gem.add_dependency('rubocop', '~> 1.51.0')
+  gem.add_dependency('rubocop-performance', '~> 1.17.1 ')
   gem.add_dependency('rubocop-rake', '~> 0.6.0')
   gem.add_dependency('rubocop-rails', '~> 2.18.0')
-  gem.add_dependency('rubocop-rspec', '~> 2.19.0')
+  gem.add_dependency('rubocop-rspec', '~> 2.22.0')
   gem.add_dependency('rubocop-capybara', '~> 2.18.0')
+  gem.add_dependency('rubocop-factory_bot', '~> 2.23.1')
   gem.add_development_dependency('rspec', '~> 3.12')
   # gem.metadata['rubygems_mfa_required'] = 'true'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,28 +18,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.49.0
+        version: 1.51.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.49.0
+        version: 1.51.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 1.17.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 1.17.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -74,14 +74,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.19.0
+        version: 2.22.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.19.0
+        version: 2.22.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
@@ -96,6 +96,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.18.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.23.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.23.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -137,6 +151,7 @@ files:
 - config/rubocop-bundler.yml
 - config/rubocop-captive.yml
 - config/rubocop-capybara.yml
+- config/rubocop-factory_bot.yml
 - config/rubocop-gemspec.yml
 - config/rubocop-layout.yml
 - config/rubocop-lint.yml
@@ -171,7 +186,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="