rubocop-config-captive 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e81a471fa3598969b05e170d8e0c4306d92e23c3cbd94004a04fe5b158974ce
-  data.tar.gz: 22035f11b13c2d090985a2ae076f79622e6ab2924db3010283539a4a96fb2b25
+  metadata.gz: b503af1733f071e5c225a59a847816f26d0875946d448922b6cc3b2a2ae6d9f2
+  data.tar.gz: e20df47f5ee50dc31edebc772837db84d83041bc6c825fa10e1cbf5c3c0f30d8
 SHA512:
-  metadata.gz: e5e5960449fab282489dd89f18d7d0c4d03aafb413c64144519d2009ba811587f18c3a158da27349ad435976f8608c7e7eab6942a22e3f31e8caacdc9ba14440
-  data.tar.gz: 743c84ce65acf593a6a11d7712a451f53a096545686d61a1f42428553dc9ad6d7eff7f5d24a28dad80b7fd84c4913d7bd33a3ce59c6c8ef6e589e81d42cd7338
+  metadata.gz: 462270c228e9abb16e6a204bcbd35f46051e71343688333b968ac2e3b347ed344c160d150ba4f58a0adcb56527db72067ae96810964164321c1d2f474aaaa1a6
+  data.tar.gz: 4aa2cad847ffb5f47859cd15288693cfa0bfb5fbd20eb2adc56689e181e65099aa393b181367c5ceb9d8813405739842c2c3e5e517a442b804f570fd12c3a490

data/config/rubocop-captive.yml

@@ -8,6 +8,7 @@ require:
   - ../lib/rubocop/cop/captive/rails/migration_methods.rb
   - ../lib/rubocop/cop/captive/rails/no_email_from_controller.rb
   - ../lib/rubocop/cop/captive/rails/no_float_price_columns.rb
+  - ../lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
   - ../lib/rubocop/cop/captive/string_where_in_scope.rb
   - ../lib/rubocop/cop/captive/no_app_env.rb
 
@@ -39,30 +40,31 @@ Captive/RSpec/SpecifyBeforeParameter:
   Include:
     - 'spec/**/*'
 
-# Rails
 Captive/Rails/ForceSslEnabledInProduction:
   Description: "Ensures SSL is forced in production, so that secure cookies are used."
   Include:
     - 'config/environments/production.rb'
 
-# Rails
 Captive/Rails/MigrationMethods:
   Description: "Avoid using ActiveRecord::Migration methods in `up` and `down` methods. Use `change` instead."
   Include:
     - 'db/migrate/**/*'
 
-# Rails
 Captive/Rails/NoEmailFromController:
   Description: "Do not send emails from controllers. Because it doesn't follow the MVC standard"
   Include:
     - 'app/controllers/**/*'
 
-# Rails
 Captive/Rails/NoFloatPriceColumns:
   Description: "Avoid using `float` type for price columns. Use `decimal, precision: 10, scale: 2` instead."
   Include:
     - 'db/migrate/**/*'
 
+Captive/Rails/NoFindByInScope:
+  Description: "Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record."
+  Include:
+    - 'app/models/**/*'
+
 # other
 Captive/StringWhereInScope:
   Description: 'The `where` method should be used in a scope in a model.'

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = "1.12.0"
+    VERSION = "1.13.0"
   end
 end

data/lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        # Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record.
+        class NoFindByInScope < RuboCop::Cop::Cop
+          MSG = "Avoid using `find_by` in a scope. Use `where` to return \
+            a collection or define a class method if you need a single record."
+
+          def_node_matcher :find_by_in_scope?, <<~PATTERN
+            (block
+              (send nil? :scope ...)
+              (args ...)
+              (send nil? :find_by ...))
+          PATTERN
+
+          def on_block(node)
+            find_by_in_scope?(node) do
+              add_offense(node, message: MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-16 00:00:00.000000000 Z
+date: 2024-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -187,6 +187,7 @@ files:
 - lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
 - lib/rubocop/cop/captive/rails/migration_methods.rb
 - lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+- lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
 - lib/rubocop/cop/captive/rails/no_float_price_columns.rb
 - lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
 - lib/rubocop/cop/captive/string_where_in_scope.rb