rubocop-capybara 2.23.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d1c9d6e62bd38cf7ef34d42dcf3eabcc49cbb2ad1cb23ea96ddfb6d7b964ef0
-  data.tar.gz: 5fe88f1d98cb8b1068c9604648f1ef18517fcd27b3552a7525913f5bcd30490d
+  metadata.gz: 984aeaf86c3452b30f2eab372f0ec1e1a6dcd3fb3a2efe6e6d60f4e435a9d84d
+  data.tar.gz: d5336d9300145f0803d3883c195cbcbdcecb0a8de54660d3fcf682166d4e8cd0
 SHA512:
-  metadata.gz: 5f1652a43814b536fd98975128b51468b453f2665f32f97e8eb8ba9940ff92b7dd03093d29a738356bf50e11349d6b11c7e225cc23e4306bac1d94da48fd0948
-  data.tar.gz: 9045ef2ed4d00354ca9888158c6dc6088361f476aef5105dfb120421951252d101470cdd68bdcaf71b0ae2fbebe265fab86f6b1ca0fb863603b5465f8a5c3ccb
+  metadata.gz: 2c08f6500d0ce4907ebea18f476a6da57411bd35b3e8c7ebe2be619efd2ef8b03999c7c5724eab4013e7febe656d043e9dd341f2cf1e4dfe8e81b945369d2e57
+  data.tar.gz: 578287adeb808e1c534134f17dbf2ebf4e7fe91433b90344f0704168deccc98328da9aca3210b4c653960437b788e36f067bee0b4bf7b85d5d926fbeda00b59a

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Edge (Unreleased)
 
+## 3.0.0 (2026-06-22)
+
+- Enable pending cops by default for the 3.0 release. ([@ydah])
+- Remove the deprecated `Capybara/ClickLinkOrButtonStyle` cop. ([@ydah])
+- Remove obsolete cop name migration config for the 2.x to 3.0 transition. ([@ydah])
+
 ## 2.23.0 (2026-04-30)
 
 - Bump RuboCop requirement to +1.81. ([@ydah])

data/README.md

@@ -76,7 +76,7 @@ In your `.rubocop.yml`, you may treat the Capybara cops just like any other
 cop. For example:
 
 ```yaml
-Capybara/SpecificMatcher:
+Capybara/RSpec/SpecificMatcher:
   Exclude:
     - spec/my_spec.rb
 ```

data/config/default.yml

@@ -17,45 +17,38 @@ Capybara/AmbiguousClick:
 
 Capybara/AssertStyle:
   Description: Checks for usage of deprecated assert style method.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/AssertStyle
 
-Capybara/ClickLinkOrButtonStyle:
-  Description: Checks for methods of button or link clicks.
-  Enabled: false
-  VersionAdded: '2.19'
-  VersionChanged: '2.22'
-  EnforcedStyle: link_or_button
-  SupportedStyles:
-    - link_or_button
-    - strict
-  Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/ClickLinkOrButtonStyle
-
 Capybara/FindAllFirst:
   Description: Enforces use of `first` instead of `all` with `first` or `[0]`.
-  Enabled: pending
+  Enabled: true
   SafeAutoCorrect: false
   VersionAdded: '2.22'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/FindAllFirst
 
 Capybara/RedundantWithinFind:
   Description: Checks for redundant `within find(...)` calls.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.20'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RedundantWithinFind
 
 Capybara/SpecificActions:
   Description: Checks for there is a more specific actions offered by Capybara.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.14'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/SpecificActions
 
 Capybara/SpecificFinders:
   Description: Checks if there is a more specific finder offered by Capybara.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.13'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/SpecificFinders
 
 Capybara/RSpec:
@@ -64,35 +57,38 @@ Capybara/RSpec:
 
 Capybara/RSpec/CurrentPathExpectation:
   Description: Checks that no expectations are set on Capybara's `current_path`.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '1.18'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/CurrentPathExpectation
 
 Capybara/RSpec/HaveContent:
   Description: Checks for usage of `have_content` and `have_no_content`.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/HaveContent
 
 Capybara/RSpec/HaveSelector:
   Description: Use `have_css` or `have_xpath` instead of `have_selector`.
-  Enabled: pending
+  Enabled: true
   DefaultSelector: css
   VersionAdded: '2.19'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/HaveSelector
 
 Capybara/RSpec/MatchStyle:
   Description: Checks for usage of deprecated style methods in RSpec matchers.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/MatchStyle
 
 Capybara/RSpec/NegationMatcher:
   Description: Enforces use of `have_no_*` or `not_to` for negated expectations.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.14'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   EnforcedStyle: have_no
   SupportedStyles:
     - have_no
@@ -101,14 +97,14 @@ Capybara/RSpec/NegationMatcher:
 
 Capybara/RSpec/NegationMatcherAfterVisit:
   Description: Do not allow negative matchers to be used immediately after `visit`.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.22'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/NegationMatcherAfterVisit
 
 Capybara/RSpec/PredicateMatcher:
   Description: Prefer using predicate matcher over using predicate method directly.
-  Enabled: pending
+  Enabled: true
   Strict: true
   EnforcedStyle: inflected
   AllowedExplicitMatchers: []
@@ -116,18 +112,19 @@ Capybara/RSpec/PredicateMatcher:
     - inflected
     - explicit
   VersionAdded: '2.19'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/PredicateMatcher
 
 Capybara/RSpec/SpecificMatcher:
   Description: Checks for there is a more specific matcher offered by Capybara.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '2.12'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/SpecificMatcher
 
 Capybara/RSpec/VisibilityMatcher:
   Description: Checks for boolean visibility in Capybara finders.
-  Enabled: pending
+  Enabled: true
   VersionAdded: '1.39'
-  VersionChanged: '2.23'
+  VersionChanged: '3.0'
   Reference: https://www.rubydoc.info/gems/rubocop-capybara/RuboCop/Cop/Capybara/RSpec/VisibilityMatcher

data/lib/rubocop/capybara/plugin.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'pathname'
+
 require 'lint_roller'
 
 module RuboCop
@@ -24,9 +26,6 @@ module RuboCop
       def rules(_context)
         project_root = Pathname.new(__dir__).join('../../..')
 
-        obsoletion = project_root.join('config', 'obsoletion.yml')
-        ConfigObsoletion.files << obsoletion if obsoletion.exist?
-
         LintRoller::Rules.new(
           type: :path,
           config_format: :rubocop,

data/lib/rubocop/capybara/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Capybara
     # Version information for the Capybara RuboCop plugin.
     module Version
-      STRING = '2.23.0'
+      STRING = '3.0.0'
     end
   end
 end

data/lib/rubocop/cop/capybara_cops.rb

@@ -12,7 +12,6 @@ require_relative 'capybara/rspec/visibility_matcher'
 
 require_relative 'capybara/ambiguous_click'
 require_relative 'capybara/assert_style'
-require_relative 'capybara/click_link_or_button_style'
 require_relative 'capybara/find_all_first'
 require_relative 'capybara/redundant_within_find'
 require_relative 'capybara/specific_actions'

data/lib/rubocop-capybara.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require 'pathname'
-require 'yaml'
-
 require 'rubocop'
 
 require_relative 'rubocop/capybara/plugin'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-capybara
 version: !ruby/object:Gem::Version
-  version: 2.23.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Yudai Takada
@@ -51,7 +51,6 @@ files:
 - MIT-LICENSE.md
 - README.md
 - config/default.yml
-- config/obsoletion.yml
 - lib/rubocop-capybara.rb
 - lib/rubocop/capybara/config_formatter.rb
 - lib/rubocop/capybara/cop/generator.rb
@@ -60,7 +59,6 @@ files:
 - lib/rubocop/capybara/version.rb
 - lib/rubocop/cop/capybara/ambiguous_click.rb
 - lib/rubocop/cop/capybara/assert_style.rb
-- lib/rubocop/cop/capybara/click_link_or_button_style.rb
 - lib/rubocop/cop/capybara/find_all_first.rb
 - lib/rubocop/cop/capybara/mixin/capybara_help.rb
 - lib/rubocop/cop/capybara/mixin/css_attributes_parser.rb
@@ -100,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Code style checking for Capybara test files
 test_files: []

data/config/obsoletion.yml

@@ -1,18 +0,0 @@
-#
-# Configuration of obsolete/deprecated cops used by `ConfigObsoletion`.
-#
-# See: https://docs.rubocop.org/rubocop/extensions.html#config-obsoletions
-#
-
-renamed:
-  Capybara/CurrentPathExpectation: Capybara/RSpec/CurrentPathExpectation
-  Capybara/NegationMatcher: Capybara/RSpec/NegationMatcher
-  Capybara/NegationMatcherAfterVisit: Capybara/RSpec/NegationMatcherAfterVisit
-  Capybara/SpecificMatcher: Capybara/RSpec/SpecificMatcher
-  Capybara/VisibilityMatcher: Capybara/RSpec/VisibilityMatcher
-
-split:
-  Capybara/MatchStyle:
-    alternatives:
-      - Capybara/AssertStyle
-      - Capybara/RSpec/MatchStyle

data/lib/rubocop/cop/capybara/click_link_or_button_style.rb

@@ -1,87 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Capybara
-      # Checks for methods of button or link clicks.
-      #
-      # This cop is deprecated.
-      # We plan to remove this in the next major version update to 3.0.
-      #
-      # The migration target is `Capybara/AmbiguousClick`.
-      # It is only migration target when `EnforcedStyle: strict`.
-      # If you are using this cop, please plan for migration.
-      # There is no migration target when `EnforcedStyle: link_or_button`.
-      #
-      # By default, prefer to use `click_link_or_button` or `click_on`.
-      # These methods offer a weaker coupling between the test and HTML,
-      # allowing for a more faithful reflection of how the user behaves.
-      #
-      # You can set `EnforcedStyle: strict` to prefer the use of
-      # `click_link` and `click_button`, but this is a deprecated setting.
-      #
-      # @example EnforcedStyle: link_or_button (default)
-      #   # bad
-      #   click_link('foo')
-      #   click_button('foo')
-      #
-      #   # good
-      #   click_link_or_button('foo')
-      #   click_on('foo')
-      #
-      # @example EnforcedStyle: strict
-      #   # bad
-      #   click_link_or_button('foo')
-      #   click_on('foo')
-      #
-      #   # good
-      #   click_link('foo')
-      #   click_button('foo')
-      #
-      class ClickLinkOrButtonStyle < ::RuboCop::Cop::Base
-        include ConfigurableEnforcedStyle
-
-        MSG_STRICT =
-          'Use `click_link` or `click_button` instead of `%<method>s`.'
-        MSG_CLICK_LINK_OR_BUTTON =
-          'Use `click_link_or_button` or `click_on` instead of `%<method>s`.'
-        STRICT_METHODS = %i[click_link click_button].freeze
-        CLICK_LINK_OR_BUTTON = %i[click_link_or_button click_on].freeze
-        RESTRICT_ON_SEND = (STRICT_METHODS + CLICK_LINK_OR_BUTTON).freeze
-
-        def on_send(node)
-          return unless offense?(node)
-
-          add_offense(node, message: offense_message(node))
-        end
-
-        private
-
-        def offense?(node)
-          (style == :strict && !strict_method?(node)) ||
-            (style == :link_or_button && !link_or_button_method?(node))
-        end
-
-        def offense_message(node)
-          if style == :strict
-            format(MSG_STRICT, method: node.method_name)
-          elsif style == :link_or_button
-            format(MSG_CLICK_LINK_OR_BUTTON, method: node.method_name)
-          else
-            # :nocov:
-            :noop
-            # :nocov:
-          end
-        end
-
-        def strict_method?(node)
-          STRICT_METHODS.include?(node.method_name)
-        end
-
-        def link_or_button_method?(node)
-          CLICK_LINK_OR_BUTTON.include?(node.method_name)
-        end
-      end
-    end
-  end
-end