rubocop-betterment 2.0.0.pre → 2.0.0.pre2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96a0df612891f48475152a6781a39050feef3610798324133f10c4b24a0824aa
-  data.tar.gz: 44f3e440dfd7630c9c32fb46d081389e6176f282bda8734e5507647e4d452ae9
+  metadata.gz: 43b05fbd08387b00251df695ed3c9de3bbd38592195ef2dbea370f637ca2acdd
+  data.tar.gz: 55dfe59749ca808f49b442d5a0634b959c0492db4386eccb64f3a0d8fdfbcc82
 SHA512:
-  metadata.gz: 268ce6ed38e7a5f13b2f2963d20c468cfbb0e244e7b88c216dce45030fae9959bdde561b85eef4f65601c64957b3e4cc8ee1f6baae4a468b7da35a1f5db7f5ef
-  data.tar.gz: f375ef9abdb496a97a9affaf9a0b34f637d773ef13094740e7a0999de4b3923f7b967bdc0993c10ee848a479f59bb418c1ede958ace15974e3fe33094a718a15
+  metadata.gz: cfb9ebd2aa93032848cbf4e27ab8bb3e69c82f2047d788833c76fce9b2f811d184e2d72a6d1186b711de9ae0e3546e6dc0f40870890ccc908ba151ede6c50e9f
+  data.tar.gz: '0294e0f6655280cd462aae9da70e79d830be6879a9b2b5a529d352fba13b9c0d1221ead2c44045bd4a33dfbdc1cea108c3ee5b85d96b314349617249660d8018'

data/lib/rubocop/cop/betterment/authorization_in_controller.rb

@@ -86,7 +86,7 @@ module RuboCop
 
         # Flags objects being created/updated with unsafe
         # params indirectly from params or through params.permit
-        def flag_indirect_param_use(node) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity
+        def flag_indirect_param_use(node) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity
           name = Utils::Parser.get_root_token(node)
           # extracted_params contains parameters used like:
           # def create
@@ -115,8 +115,8 @@ module RuboCop
             # def indirect_params
             #   params[:user_id]
             # end
-            if ret.method?(:[])
-              internal_params = ret.arguments.map(&:value)
+            if ret.send_type? && ret.method?(:[])
+              internal_params = ret.arguments.select { |x| x.sym_type? || x.str_type? }.map(&:value)
             else
               internal_returns = Utils::MethodReturnTable.get_method(Utils::Parser.get_root_token(ret)) || []
               internal_params = internal_returns.flat_map { |x| Utils::Parser.get_extracted_parameters(x, param_aliases: @param_wrappers) }

data/lib/rubocop/cop/betterment/utils/parser.rb

@@ -87,7 +87,11 @@ module RuboCop
           parameter_names = []
           param_aliases << :params
 
-          return node.arguments.map(&:value) if node.method?(:[]) && param_aliases.include?(get_root_token(node))
+          if node.method?(:[]) && param_aliases.include?(get_root_token(node))
+            return node.arguments.select { |x|
+                     x.sym_type? || x.str_type?
+                   }.map(&:value)
+          end
 
           children = node.descendants.select do |child|
             child.send_type? && param_aliases.include?(child.method_name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-betterment
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre
+  version: 2.0.0.pre2
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-22 00:00:00.000000000 Z
+date: 2021-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop