rubocop-betterment 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b6ae27fccfc7b1e8dc8aefdb9822f54ea623342
-  data.tar.gz: fc6ff9090037f1d181c50630935fdaee2e9ed7f8
+  metadata.gz: 5a8e6e836b70797730769203cc1f58e341cce95e
+  data.tar.gz: d28f3bc8399c4778f7e29cf0815c44808951ede9
 SHA512:
-  metadata.gz: a7220b89d221787ea823b648a4ddca7d4212f8dd754f79283292e211f27f1215527df35815936c5d5550e967121323abea0d1b46db1731c365e21b0ff96d5ce6
-  data.tar.gz: 7d6abfa5b94ad179925c08b4fb355b067ef18788b5d142de596b6f4034a0c3f2e54dfe65aca5bd70b501c6dd63245be60ce635fa39bcfb242a02eefa4674dc61
+  metadata.gz: 2b605a6a49483f80ae71a00540075adc516e4478c9bd4ff8f28e2b258201a484445044cf01953f36cd73c215b544abf40b99ac3a0c01bdd5f195d21602effb1d
+  data.tar.gz: b8081a6defeb7207bd158934c762965be285e6db38b25cf620c956f0fe997875bdee136648760482dffa592ba38338194954ca095321fe409377fa56787e8bd6

data/config/default.yml

@@ -54,10 +54,6 @@ Lint/BooleanSymbol:
   Exclude:
     - 'spec/**/*'
 
-# cop is removed on unreleased rubocop master https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md#master-unreleased
-Lint/SplatKeywordArguments:
-  Enabled: false
-
 Metrics/AbcSize:
   Exclude:
     - 'spec/**/*'

data/lib/rubocop/cop/betterment/memoization_with_arguments.rb

@@ -0,0 +1,33 @@
+module RuboCop
+  module Cop
+    module Betterment
+      class MemoizationWithArguments < Cop
+        MSG = 'Memoized method `%<method>s` accepts arguments, ' \
+          'which may cause it to return a stale result. ' \
+          'Remove memoization or refactor to remove arguments.'.freeze
+
+        def self.node_pattern
+          memo_assign = '(or_asgn $(ivasgn _) _)'
+          memoized_at_end_of_method = "(begin ... #{memo_assign})"
+          instance_method =
+            "(def $_ _ {#{memo_assign} #{memoized_at_end_of_method}})"
+          class_method =
+            "(defs self $_ _ {#{memo_assign} #{memoized_at_end_of_method}})"
+          "{#{instance_method} #{class_method}}"
+        end
+
+        private_class_method :node_pattern
+        def_node_matcher :memoized?, node_pattern
+
+        def on_def(node)
+          (method_name, ivar_assign) = memoized?(node)
+          return if ivar_assign.nil? || node.arguments.length.zero?
+
+          msg = format(MSG, method: method_name)
+          add_offense(node, location: ivar_assign.source_range, message: msg)
+        end
+        alias on_defs on_def
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -1 +1,2 @@
 require 'rubocop/cop/betterment/timeout'
+require 'rubocop/cop/betterment/memoization_with_arguments'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-betterment
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Development
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-15 00:00:00.000000000 Z
+date: 2018-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -91,6 +91,7 @@ files:
 - STYLEGUIDE.md
 - config/default.yml
 - lib/rubocop/cop/betterment.rb
+- lib/rubocop/cop/betterment/memoization_with_arguments.rb
 - lib/rubocop/cop/betterment/timeout.rb
 homepage: 
 licenses: