rubocop-betterment 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfc81280ce15b5ff44ba5f45345bf8ec461c34d4058135b2d86b2bb9a5f48600
-  data.tar.gz: fc53b65409351b9604cefff382add3a95c09ae5d98d93d3979ac935fee31c4b1
+  metadata.gz: 8239d7858cb48ea9f9d93ee9f84ad1619b85eba879b9d426ee6170013b8fa822
+  data.tar.gz: b3543e852dd249fa2be8ee46d12a8742a2c9de750a1a77847a7a22cb4c47a98b
 SHA512:
-  metadata.gz: cd1bb04b824fbc3386b0ecbe1755820aad68748aa91ad5339a92ceaac2adf08cb4d5cf4cefb7ed94fd972430b359fbb71b924bec0cad14e5d9ec87b7f1d1a96f
-  data.tar.gz: 96453a9b868b7c492712fdd733f1cf39a11e9c5a42136d663edec81405581eca70f019afca25b3c8a5801a06396379ee204bc8649286608a78322690dae28c3c
+  metadata.gz: f2195af7a4f7c629cfee631d365854d507791fa5aa96fbdcbcbab0dadb6e0d70f13c6908fd5949ba3be565527098a37112cdc55dc8dd1b1b13664c3f489d9298
+  data.tar.gz: 5cda689379c9b1ba9d5508120b0a6479a73f06f158273ef67b0039e64f7c56a2199f23658204b3c873f2623b99f2d54580cf930e51002a84addc8767805134d6

data/lib/rubocop/cop/betterment.rb

@@ -9,3 +9,4 @@ require 'rubocop/cop/betterment/site_prism_loaded'
 require 'rubocop/cop/betterment/spec_helper_required_outside_spec_dir'
 require 'rubocop/cop/betterment/implicit_redirect_type'
 require 'rubocop/cop/betterment/active_job_performable'
+require 'rubocop/cop/betterment/allowlist_blocklist'

data/lib/rubocop/cop/betterment/allowlist_blocklist.rb

@@ -0,0 +1,38 @@
+# rubocop:disable Betterment/AllowlistBlocklist
+module RuboCop
+  module Cop
+    module Betterment
+      class AllowlistBlocklist < Cop
+        MSG = <<-DOC.freeze
+          Betterment has moved away from usages of whitelist & blacklist in favor of more inclusive terms.
+          Replace any instances of these terms with more inclusive terms like allowlist, blocklist, denylist,
+          ignorelist, warnlist, safelist, etc. We generally use allowlist and blocklist and prefer consistency where
+          possible, but other terms may be more appropriate depending on your use case.
+
+          This is part of a larger initiative to replace exclusionary / harmful language and anti-bias tools and products.
+        DOC
+
+        def on_class(node)
+          evaluate_node(node)
+        end
+
+        private
+
+        def evaluate_node(node)
+          return unless should_use_allowlist?(node) || should_use_blocklist?(node)
+
+          add_offense(node, message: MSG)
+        end
+
+        def should_use_allowlist?(node)
+          node.to_s.downcase.include?('whitelist')
+        end
+
+        def should_use_blocklist?(node)
+          node.to_s.downcase.include?('blacklist')
+        end
+      end
+    end
+  end
+end
+# rubocop:enable Betterment/AllowlistBlocklist

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-betterment
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - Development
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -92,6 +92,7 @@ files:
 - config/default.yml
 - lib/rubocop/cop/betterment.rb
 - lib/rubocop/cop/betterment/active_job_performable.rb
+- lib/rubocop/cop/betterment/allowlist_blocklist.rb
 - lib/rubocop/cop/betterment/authorization_in_controller.rb
 - lib/rubocop/cop/betterment/dynamic_params.rb
 - lib/rubocop/cop/betterment/implicit_redirect_type.rb