rubocop-airbnb 3.0.2 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 141798fe044dbd21e96c3495a051ada08333669e
-  data.tar.gz: 11dcbb417edd30319f34390ee51d8b8e3c879449
+SHA256:
+  metadata.gz: 9d15fbaae4390350367ffaf63eb8983bfd6b3f5b20b204a84396b1e52f7f6509
+  data.tar.gz: eb4b2cb7e6b3fb6a347c8c8aa1d3c189a5787d14b0d59db5a5993d4fe400a299
 SHA512:
-  metadata.gz: 308b022b2a0dd0f32e729e9ff86df78fe404e1c1365f73a4277506d78b46666e2cd25421e1c4193f7c45754034d110e5898d73f3eef2dd201bad1a330cbaea2b
-  data.tar.gz: 45b22abbe58c34ca5473ac3332cef3769b9b86168c98047c441afde95c42654f3ffd914614abfee8c0a8de3d61d64430d6f14bc9f05c92af019bbf66c795767c
+  metadata.gz: bc207a5af59c1eecfeaba405a3a216fae0afa3b54288b35249de115b9f6c1d5036f9ae3f692823ee0a5a3af64718cd7aef072f0e6402c6c4b305b7f6f13bdd5f
+  data.tar.gz: e99bd2c461379d8a13f20a880b2963b0d0241d8affa7028d67cff807573ffe9fe8053bd7d8bbe65174bf0d3021dd9c7a75c4456f9dd1c58e5fe340280554d5d0

data/CHANGELOG.md

@@ -1,4 +1,15 @@
-# 3.02
+# 4.0.0
+* Add support for Ruby 3.0
+* Run CI against Ruby 2.7
+* Drop support for Ruby 2.3
+* Update rubocop to 0.93.1
+* Update rubocop-performance to 1.10.2
+* Update rubocop-rails to 2.9.1
+* Update rubocop-rspec to 1.44.1
+* Disable Style/BracesAroundHashParameters
+* Set `DisabledByDefault: true` to disable any new rubocop cops that have not yet been evaluated for this style guide
+
+# 3.0.2
 * Moves `require`s for `rubocop-performance` and `rubocop-rails` to library code for better transitivity.
 
 # 3.0.1

data/config/default.yml

@@ -24,6 +24,15 @@ AllCops:
     - spec/factories/**/*.rb
     - features/support/factories/**/*.rb
 
+  # While Rubocop has released a bunch of new cops, not all of these cops have been evaluated as
+  # part of this styleguide. To prevent new, unevaluated cops from imposing on this styleguide, we
+  # are marking these new cops as disabled. Note that as a consumer of this styleguide, you can
+  # always override any choices here by setting `Enabled: true` on any cops that you would like to
+  # have be enabled, even if we have explicitly disabled them (or if they are new and we have yet
+  # to evaluate them). For more on this configuration parameter, see
+  # https://github.com/rubocop/rubocop/blob/1e55b1aa5e4c5eaeccad5d61f08b7930ed6bc341/config/default.yml#L89-L101
+  DisabledByDefault: true
+
 inherit_from:
   - './rubocop-airbnb.yml'
   - './rubocop-bundler.yml'

data/config/rubocop-layout.yml

@@ -11,13 +11,13 @@ Layout/AccessModifierIndentation:
   - indent
 
 # Supports --auto-correct
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: Align the elements of an array literal if they span more than one line.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#align-multiline-arrays
   Enabled: true
 
 # Supports --auto-correct
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: Align the elements of a hash literal if they span more than one line.
   Enabled: true
   EnforcedHashRocketStyle: key
@@ -30,7 +30,7 @@ Layout/AlignHash:
   - ignore_explicit
 
 # Supports --auto-correct
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: Align the parameters of a method call if they span more than one line.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-double-indent
   Enabled: true
@@ -227,7 +227,7 @@ Layout/FirstMethodParameterLineBreak:
   Enabled: false
 
 # Supports --auto-correct
-Layout/IndentFirstArgument:
+Layout/FirstArgumentIndentation:
   Description: Checks the indentation of the first parameter in a method call.
   Enabled: true
   EnforcedStyle: consistent
@@ -238,19 +238,19 @@ Layout/IndentFirstArgument:
   - special_for_inner_method_call_in_parentheses
 
 # Supports --auto-correct
-Layout/IndentFirstArrayElement:
+Layout/FirstArrayElementIndentation:
   Description: Checks the indentation of the first element in an array literal.
   Enabled: true
   EnforcedStyle: consistent
 
 # Supports --auto-correct
-Layout/IndentAssignment:
+Layout/AssignmentIndentation:
   Description: Checks the indentation of the first line of the right-hand-side of a
     multi-line assignment.
   Enabled: true
 
 # Supports --auto-correct
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   Description: Checks the indentation of the first key in a hash literal.
   Enabled: true
   EnforcedStyle: consistent
@@ -258,7 +258,7 @@ Layout/IndentFirstHashElement:
   - special_inside_parentheses
   - consistent
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 # Supports --auto-correct
@@ -268,7 +268,7 @@ Layout/IndentationConsistency:
   EnforcedStyle: normal
   SupportedStyles:
   - normal
-  - rails
+  - indented_internal_methods
 
 # Supports --auto-correct
 Layout/IndentationWidth:
@@ -282,7 +282,7 @@ Layout/InitialIndentation:
   Description: Checks the indentation of the first non-blank non-comment line in a file.
   Enabled: true
 
-Layout/LeadingBlankLines:
+Layout/LeadingEmptyLines:
   Enabled: true
 
 # Supports --auto-correct
@@ -531,13 +531,13 @@ Layout/SpaceInsideStringInterpolation:
   - no_space
 
 # Supports --auto-correct
-Layout/Tab:
+Layout/IndentationStyle:
   Description: No hard tabs.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation
   Enabled: true
 
 # Supports --auto-correct
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: Checks trailing blank lines and final newline.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#newline-eof
   Enabled: true
@@ -552,5 +552,10 @@ Layout/TrailingWhitespace:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-trailing-whitespace
   Enabled: true
 
-Layout/IndentFirstParameter:
+Layout/FirstParameterIndentation:
   Enabled: true
+
+# Supports --auto-correct
+Layout/LineLength:
+  Max: 100
+  AllowURI: true

data/config/rubocop-lint.yml

@@ -45,7 +45,7 @@ Lint/DuplicateMethods:
   Description: Check for duplicate methods calls.
   Enabled: true
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Description: Check for duplicate keys in hash literals.
   Enabled: true
 
@@ -68,10 +68,6 @@ Lint/EmptyInterpolation:
 Lint/EmptyWhen:
   Enabled: false
 
-Lint/EndInMethod:
-  Description: END blocks should not be placed inside method definitions.
-  Enabled: false
-
 Lint/EnsureReturn:
   Description: Do not use return in an ensure block.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-return-ensure
@@ -93,7 +89,7 @@ Lint/FormatParameterMismatch:
   Description: The number of parameters to format/sprint must match the fields.
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#dont-hide-exceptions
   Enabled: false
@@ -144,7 +140,10 @@ Lint/MissingCopEnableDirective:
   Description: 'Checks for a `# rubocop:enable` after `# rubocop:disable`'
   Enabled: true
 
-Lint/MultipleCompare:
+Lint/MissingSuper:
+  Enabled: false
+
+Lint/MultipleComparison:
   Enabled: false
 
 Lint/NestedMethodDefinition:
@@ -230,7 +229,7 @@ Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
 # Supports --auto-correct
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: Checks for Object#to_s usage in string interpolation.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-to-s
   Enabled: true
@@ -289,7 +288,7 @@ Lint/UselessAssignment:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#underscore-unused-vars
   Enabled: true
 
-Lint/UselessComparison:
+Lint/BinaryOperatorWithIdenticalOperands:
   Description: Checks for comparison of something with itself.
   Enabled: true
 

data/config/rubocop-metrics.yml

@@ -21,10 +21,6 @@ Metrics/CyclomaticComplexity:
   Enabled: false
   Max: 6
 
-Metrics/LineLength:
-  Max: 100
-  AllowURI: true
-
 Metrics/MethodLength:
   Enabled: false
 

data/config/rubocop-naming.yml

@@ -55,18 +55,18 @@ Naming/PredicateName:
   - is_
   - has_
   - have_
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
   - is_
   - has_
   - have_
 
-Naming/UncommunicativeBlockParamName:
+Naming/BlockParameterName:
   Description: >-
               Checks for block parameter names that contain capital letters,
               end in numbers, or do not meet a minimal length.
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Description: >-
               Checks for method parameter names that contain capital letters,
               end in numbers, or do not meet a minimal length.

data/config/rubocop-rails.yml

@@ -212,3 +212,7 @@ Rails/IgnoredSkipActionFilterOption:
 
 Rails/ReflectionClassName:
   Enabled: true
+
+Rails/RakeEnvironment:
+  Description: Ensures that rake tasks depend on :environment
+  Enabled: false

data/config/rubocop-style.yml

@@ -134,16 +134,6 @@ Style/BlockDelimiters:
     - proc
     - it
 
-# Supports --auto-correct
-Style/BracesAroundHashParameters:
-  Description: Enforce braces style around hash parameters.
-  Enabled: false
-  EnforcedStyle: no_braces
-  SupportedStyles:
-  - braces
-  - no_braces
-  - context_dependent
-
 Style/CaseEquality:
   Description: Avoid explicit use of the case equality operator(===).
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-case-equality
@@ -357,8 +347,9 @@ Style/FrozenStringLiteralComment:
   Enabled: false
   SupportedStyles:
   - always
+  - always_true
   - never
-  EnforcedStyle: always
+  EnforcedStyle: always_true
 
 Style/GlobalVars:
   Description: Do not introduce global variables.
@@ -458,9 +449,6 @@ Style/MethodDefParentheses:
   - require_parentheses
   - require_no_parentheses
 
-Style/MethodMissingSuper:
-  Enabled: false
-
 Style/MissingRespondToMissing:
   Enabled: false
 
@@ -824,6 +812,21 @@ Style/SpecialGlobalVars:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-cryptic-perlisms
   Enabled: true
 
+Style/HashEachMethods:
+  Description: Enforce use of each_key and each_value Hash methods.
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehasheachmethods
+  Enabled: false
+
+Style/HashTransformKeys:
+  Description: Enforce use of transform_keys Hash methods. Not suggested for use below ruby 2.5
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehashtransformkeys
+  Enabled: false
+
+Style/HashTransformValues:
+  Description: Enforce use of transform_values Hash methods. Not suggested for use below ruby 2.5
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehashtransformvalues
+  Enabled: false
+
 Style/StabbyLambdaParentheses:
   Description: Check for the usage of parentheses around stabby lambda arguments.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#stabby-lambda-with-args

data/lib/rubocop/airbnb/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Airbnb
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = '3.0.2'
+    VERSION = '4.0.0'
   end
 end

data/lib/rubocop/cop/airbnb/continuation_slash.rb

@@ -14,7 +14,7 @@ module RuboCop
         alias on_send enforce_violation
         alias on_if enforce_violation
 
-        RuboCop::AST::Node::ASSIGNMENTS.each do |type|
+        ::RuboCop::AST::Node::ASSIGNMENTS.each do |type|
           define_method("on_#{type}") do |node|
             enforce_violation(node)
           end

data/rubocop-airbnb.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.license = 'MIT'
   spec.version = RuboCop::Airbnb::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = '>= 2.4'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
     'Gemfile',
   ]
 
-  spec.add_dependency('rubocop', '~> 0.76.0')
-  spec.add_dependency('rubocop-performance', '~> 1.5.0')
-  spec.add_dependency('rubocop-rails', '~> 2.3.2')
-  spec.add_dependency('rubocop-rspec', '~> 1.30.0')
+  spec.add_dependency('rubocop', '~> 0.93.1')
+  spec.add_dependency('rubocop-performance', '~> 1.10.2')
+  spec.add_dependency('rubocop-rails', '~> 2.9.1')
+  spec.add_dependency('rubocop-rspec', '~> 1.44.1')
   spec.add_development_dependency('rspec', '~> 3.5')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-airbnb
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 4.0.0
 platform: ruby
 authors:
 - Airbnb Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-15 00:00:00.000000000 Z
+date: 2021-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.76.0
+        version: 0.93.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.76.0
+        version: 0.93.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.10.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.10.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.2
+        version: 2.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.2
+        version: 2.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.44.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.44.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -163,15 +163,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Custom code style checking for Airbnb.