rt-watchman 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6268d12059b4dcce2e1884056fb5e3f9a58ccc8
-  data.tar.gz: fc3e6c4d5fedf0a396779871a93dcbbbbc875ead
+  metadata.gz: 2518ea25e48bd1335da7036b1f356abe99707b95
+  data.tar.gz: 8761422a4906f54a9a90a1cb0555d60173036e0f
 SHA512:
-  metadata.gz: 681b25d34ff7c9d87f667c772f998f7484cdef2b6480865440773163e60ae4e7151de217433f58479856781d3558f2fb21ccc8e165f6d032575a7f865f483271
-  data.tar.gz: c1647d66696b54332c9d7ebed2a1a86041120a88ceeb8c4e1aee40bbe1d824c5fae6a206473700a2e0430a16ca7874e01d0bb9ceb62742c8bf48c811170613b7
+  metadata.gz: 910ff071eebce01b84107f71db699907b4a4eb29f680a2f5749143b2320cf8ecd12d6aefde11f00b93be8445839240772e336e26c76529a50120d2a2d93fac3f
+  data.tar.gz: 26f3715758b471d21d25678a49bd9d9d2a680321abcaf2c02b73995876e8c3fbe2314fc8449b0c120675bcfb21a5da19d0cc3e0a3bc1194611435503e55fbc28

data/README.md

@@ -36,26 +36,9 @@ end
 To submit a time value in miliseconds:
 
 ``` ruby
-Watchman.submit("number.of.kittens", 30, type: :timing)
+Watchman.submit("number.of.kittens", 30, :timing)
 ```
 
-## Tags
-
-If you want to use a variable that changes often, don't use this:
-
-``` ruby
-Watchman.submit("user.#{id}", 30)
-```
-
-Use tags. A list of tags is an optional last parameter of `:submit`, `:benchmark`,
-`:increment` and `:decrement` methods.
-
-``` ruby
-Watchman.submit("user", 30, tags: ["#{id}"])
-```
-
-Tags list is limited to 3 values.
-
 ## Global metric prefix
 
 If you want to prepend all the metric names with a prefix, do the following:

data/lib/watchman/version.rb

@@ -1,3 +1,3 @@
 class Watchman
-  VERSION = "0.8.0"
+  VERSION = "0.9.0"
 end

data/lib/watchman.rb

@@ -12,11 +12,8 @@ class Watchman
     attr_accessor :port
     attr_accessor :test_mode
 
-    def submit(name, value, args = {})
-      type = args[:type] || :gauge
-      tags = args[:tags] || []
-
-      metric = metric_name_with_prefix(name, tags)
+    def submit(name, value, type = :gauge)
+      metric = metric_name_with_prefix(name)
 
       case type
       when :gauge  then statsd_client.gauge(metric, value)
@@ -26,30 +23,24 @@ class Watchman
       end
     end
 
-    def benchmark(name, args = {})
-      tags = args[:tags] || []
-
+    def benchmark(name)
       result = nil
 
       time = Benchmark.measure do
         result = yield
       end
 
-      submit(name, (time.real * 1000).floor, type: :timing, tags: tags)
+      submit(name, (time.real * 1000).floor, :timing)
 
       result
     end
 
-    def increment(name, args = {})
-      tags = args[:tags] || []
-
-      submit(name, 1, type: :count, tags: tags)
+    def increment(name)
+      submit(name, 1, :count)
     end
 
-    def decrement(name, args = {})
-      tags = args[:tags] || []
-
-      submit(name, -1, type: :count, tags: tags)
+    def decrement(name)
+      submit(name, -1, :count)
     end
 
     private
@@ -62,20 +53,12 @@ class Watchman
       end
     end
 
-    def metric_name_with_prefix(name, tags)
-      full_name = []
-      full_name << "tagged"
-      full_name << @prefix if @prefix
-      full_name << tags_string(tags)
-      full_name << name
-      full_name.join(".")
-    end
-
-    def tags_string(tags)
-      tags
-        .fill("no_tag", tags.length, [3 - tags.length, 0].max)
-        .first(3)
-        .join(".")
+    def metric_name_with_prefix(name)
+      if @prefix
+        "#{@prefix}.#{name}"
+      else
+        name
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rt-watchman
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Rendered Text