rstyx 0.4.1 → 0.4.2

data/History.txt

@@ -1,4 +1,9 @@
 
+== 0.4.2
+
+This is a bugfix release. Unit testing uncovered many serious bugs
+in the server code.
+
 == 0.4.1
 
 Clarified licensing issues to LGPLv3 and Ruby License.  Set up some

data/lib/rstyx/common.rb

@@ -5,7 +5,7 @@
 # Homepage:: http://rstyx.rubyforge.org/
 # License:: GNU Lesser General Public License / Ruby License
 #
-# $Id: common.rb 280 2007-09-19 07:24:51Z dido $
+# $Id: common.rb 298 2007-09-21 08:52:12Z dido $
 #
 #----------------------------------------------------------------------------
 #
@@ -33,10 +33,10 @@ module RStyx
   ORCLOSE = 0x40
 
   # Constants related to the file type
-  DMDIR = 0x80000000            # directory
+  DMDIR =    0x80000000         # directory
   DMAPPEND = 0x40000000         # append-only file
-  DMEXCL = 0x20000000           # exclusive use file
-  DMAUTH = 0x8000000            # file used for authentication
+  DMEXCL =   0x20000000         # exclusive use file
+  DMAUTH =   0x08000000         # file used for authentication
 
   # Maximum FID numbers and the NOFID constant.
   MAX_FID = 0xfffffffe

data/lib/rstyx/server.rb

@@ -5,7 +5,7 @@
 # Homepage:: http://rstyx.rubyforge.org/
 # License:: GNU Lesser General Public License / Ruby License
 #
-# $Id: server.rb 278 2007-09-19 07:22:37Z dido $
+# $Id: server.rb 302 2007-09-24 03:01:10Z dido $
 #
 #----------------------------------------------------------------------------
 #
@@ -364,7 +364,8 @@ module RStyx
 
         # Create the file in the directory, add it to the directory tree,
         # and associate the new file with the given fid
-        new_file = dir.newfile(msg.name, realperm, isdir, isapponly, isexcl)
+        new_file = dir.newfile(msg.name, realperm, isdir, isapponly,
+                               isexclusive)
         dir << new_file
         @session[msg.fid] = new_file
         new_file.add_client(SFileClient.new(@session, msg.fid, msg.mode))
@@ -435,7 +436,7 @@ module RStyx
         sf.synchronize do
           @session.clunk(msg.fid)
           parent = sf.parent
-          if @session.writable?(parent)
+          unless @session.writable?(parent)
             raise StyxException.new("permission denied")
           end
 
@@ -470,7 +471,7 @@ module RStyx
             unless @session.writable?(dir)
               raise StyxException.new("write permissions required on parent directory to change file name")
             end
-            unless dir.has_child?(nstat.name)
+            if dir.has_child?(nstat.name)
               raise StyxException.new("cannot rename file to the name of an existing file")
             end
             sf.can_setname?(nstat.name)
@@ -479,10 +480,10 @@ module RStyx
           # Check if we are changing the length of a file
           if nstat.size != -1
             # Check if we have write permission on the file
-            if @session.writable?(sf)
+            unless @session.writable?(sf)
               raise StyxException.new("write permissions required to change file length")
             end
-            sf.can_setlength?(sf.size)
+            sf.can_setlength?(nstat.size)
           end
 
           # Check if we are changing the mode of a file
@@ -493,7 +494,7 @@ module RStyx
             end
 
             # Can't change the directory bit
-            if ((nstat.mode & DMDIR == DMDIR) != sf.directory?)
+            if ((nstat.mode & DMDIR == DMDIR) && !sf.directory?)
               raise StyxException.new("can't change a file to a directory")
             end
             sf.can_setmode?(nstat.mode)
@@ -547,7 +548,7 @@ module RStyx
           end
 
           if nstat.size != -1
-            sf.length = nstat.length
+            sf.length = nstat.size
           end
 
           if nstat.mode != MAXUINT
@@ -598,7 +599,7 @@ module RStyx
           # In this case, we can't reply with an error to the client,
           # since the tag used was invalid!  If debug level is high
           # enough, simply print out an error.
-          @log.error("#{@peername} #{e.to_s} #{msg.to_s}")
+          @log.error("#{@peername} #{e.class.to_s} #{msg.to_s}")
         rescue FidNotFoundException => e
           @log.error("#{@peername} unknown fid in message #{msg.to_s}")
           reply(Message::Rerror.new(:ename => "Unknown fid #{e.fid}"), tag)
@@ -607,6 +608,7 @@ module RStyx
           reply(Message::Rerror.new(:ename => "Error: #{e.message}"), tag)
         rescue Exception => e
           @log.error("#{@peername} internal error #{e.message} for #{e.to_s} at #{e.backtrace}")
+          reply(Message::Rerror.new(:ename => "Internal RStyx Error: #{e.message}"), tag)
         end
 
       end

data/lib/rstyx/version.rb

@@ -5,7 +5,7 @@
 # Homepage:: http://rstyx.rubyforge.org/
 # License:: GNU Lesser General Public License / Ruby License
 #
-# $Id: version.rb 285 2007-09-19 07:32:56Z dido $
+# $Id: version.rb 303 2007-09-24 03:02:11Z dido $
 #
 #----------------------------------------------------------------------------
 #
@@ -29,7 +29,7 @@ module RStyx
 
     MAJOR = 0
     MINOR = 4
-    TINY = 1
+    TINY = 2
 
     # The version of RStyx in use.
     STRING = [ MAJOR, MINOR, TINY ].join(".")

data/tests/tc_styxservproto.rb

@@ -5,7 +5,7 @@
 # Homepage:: http://rstyx.rubyforge.org/
 # License:: GNU Lesser General Public License / Ruby License
 #
-# $Id: tc_styxservproto.rb 289 2007-09-19 07:38:07Z dido $
+# $Id: tc_styxservproto.rb 301 2007-09-24 03:00:14Z dido $
 #
 #----------------------------------------------------------------------------
 #
@@ -23,7 +23,7 @@
 #
 require 'test/unit'
 require 'flexmock'
-require 'flexmock/test_unit'
+require 'flexmock'
 require 'rstyx/server'
 
 ##
@@ -62,6 +62,14 @@ module RStyx
         return(@@mock.has_fid?(fid))
       end
 
+      def add_tag(t)
+        return(@@mock.add_tag(t))
+      end
+
+      def has_tag?(tag)
+        return(@@mock.has_tag?(tag))
+      end
+
       def execute?(styxfile)
         return(@@mock.execute?(styxfile))
       end
@@ -90,6 +98,10 @@ module RStyx
         return(@@mock.confirm_open(sf, mode))
       end
 
+      def user
+        return(@@mock.user)
+      end
+
       def iounit
         return(@@mock.iounit)
       end
@@ -135,6 +147,7 @@ class FakeConnection
 end
 
 class TestStyxServProto < Test::Unit::TestCase
+  include FlexMock::TestCase
   def test_tversion
     sessmock1 = flexmock
     selfmock = flexmock(:get_peername => nil)
@@ -153,8 +166,8 @@ class TestStyxServProto < Test::Unit::TestCase
     serv = FakeConnection.new(selfmock, sessmock, nil)
     resp = serv.tversion(RStyx::Message::Tversion.new(:version => "foo",
                                                       :msize => 1024))
-    assert_equal(RStyx::Message::Rerror, resp.class)
-    assert_equal("Unsupported protocol version foo (must be 9P2000)", resp.ename)
+    assert_equal(RStyx::Message::Rversion, resp.class)
+    assert_equal("unknown", resp.version)
   end
 
   def test_tauth
@@ -165,7 +178,7 @@ class TestStyxServProto < Test::Unit::TestCase
                                                 :uname => "foo",
                                                 :aname => "bar"))
     assert_equal(RStyx::Message::Rerror, resp.class)
-    assert_equal("Authentication methods through auth messages are not used.", resp.ename)
+    assert_equal("Authentication methods through auth messages are not supported.", resp.ename)
   end
 
   def test_tattach
@@ -443,13 +456,47 @@ class TestStyxServProto < Test::Unit::TestCase
       end
     end
 
-    # Third, successful creation.
+    # Third, try to create a file with DMAUTH set.
+    FlexMock.use("sessmock") do |sessmock|
+      FlexMock.use("filemock") do |filemock|
+        sessmock.should_receive(:[]).with(42).returns(filemock)
+        filemock.should_receive(:directory?).returns(true)
+        sessmock.should_receive(:writable?).returns(true)
+        filemock.should_receive(:permissions).returns(0777)
+        serv = FakeConnection.new(selfmock, sessmock, nil)
+        assert_raises(RStyx::StyxException) do
+          resp = serv.tcreate(RStyx::Message::Tcreate.new(:fid => 42,
+                                                          :mode => RStyx::OREAD,
+                                                          :perm => RStyx::DMAUTH | 0644))
+        end
+      end
+    end
+
+    # Fourth, try to create a directory in a mode besides OREAD.
+    FlexMock.use("sessmock") do |sessmock|
+      FlexMock.use("filemock") do |filemock|
+        sessmock.should_receive(:[]).with(42).returns(filemock)
+        filemock.should_receive(:directory?).returns(true)
+        sessmock.should_receive(:writable?).returns(true)
+        filemock.should_receive(:permissions).returns(0777)
+        serv = FakeConnection.new(selfmock, sessmock, nil)
+        assert_raises(RStyx::StyxException) do
+          resp = serv.tcreate(RStyx::Message::Tcreate.new(:fid => 42,
+                                                          :mode => RStyx::OTRUNC,
+                                                          :perm => RStyx::DMDIR | 0755))
+        end
+      end
+    end
+
+    # Finally, successful creation.
     FlexMock.use("sessmock") do |sessmock|
       FlexMock.use("filemock") do |filemock|
         sessmock.should_receive(:[]).with(42).returns(filemock)
         filemock.should_receive(:directory?).returns(true)
         sessmock.should_receive(:writable?).returns(true)
-        filemock.should_receive(:newfile).with("foo", 0644).returns(filemock)
+        filemock.should_receive(:permissions).returns(0777)
+        filemock.should_receive(:newfile).with("foo", 0644, false,
+                                               false, false).returns(filemock)
         filemock.should_receive(:<<).with(filemock)
         sessmock.should_receive(:[]=).with(42, filemock)
         filemock.should_receive(:add_client)
@@ -618,4 +665,514 @@ class TestStyxServProto < Test::Unit::TestCase
     assert_equal(RStyx::Message::Rclunk, resp.class)
   end
 
+  def test_tremove_permission_denied
+    # Permission denied
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:clunk).with(Integer).returns do |f|
+      assert_equal(42, f)
+    end
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(false)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.tremove(RStyx::Message::Tremove.new(:fid => 42))
+    end
+  end
+
+  def test_tremove_not_empty
+    # Directory not empty
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:clunk).with(Integer).returns do |f|
+      assert_equal(42, f)
+    end
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(true)
+    filemock.should_receive(:instance_of?).with(RStyx::Server::SDirectory).returns(true)
+    filemock.should_receive(:child_count).returns(42)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.tremove(RStyx::Message::Tremove.new(:fid => 42))
+    end
+  end
+
+  def test_tremove_success
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:clunk).with(Integer).returns do |f|
+      assert_equal(42, f)
+    end
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(true)
+    filemock.should_receive(:remove)
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:set_mtime).with(Time, String).returns { |t,s| assert_equal("foo", s) }
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.tremove(RStyx::Message::Tremove.new(:fid => 42))
+    assert_equal(RStyx::Message::Rremove, resp.class)
+  end
+
+  def test_tstat
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    filemock.should_receive(:stat)
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.tstat(RStyx::Message::Tstat.new(:fid => 42))
+    assert_equal(RStyx::Message::Rstat, resp.class)
+  end
+
+  def test_twstat_name_change_nowrite
+    # Test twstat for name change with no write permissions to
+    # parent directory
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(false)
+    stat = RStyx::Message::Stat.new
+    stat.name = "foo"
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+  end
+
+  def test_twstat_name_change_conflict
+    # Test twstat for name change to a name of a file already
+    # present in the parent directory
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(true)
+    filemock.should_receive(:has_child?).with("foo").returns(true)
+    stat = RStyx::Message::Stat.new
+    stat.name = "foo"
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+  end
+
+  def test_twstat_name_change_success
+    # test twstat for successful name change
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    filemock.should_receive(:parent).returns(filemock)
+    sessmock.should_receive(:writable?).with(filemock).returns(true)
+    filemock.should_receive(:has_child?).with("foo").returns(false)
+    stat = RStyx::Message::Stat.new
+    stat.name = "foo"
+    stat.size = -1
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = RStyx::MAXUINT
+    stat.dtype = 0xffff
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    filemock.should_receive(:can_setname?)
+    filemock.should_receive(:name=).with(String).returns { |s| assert_equal("foo", s) }
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    assert_equal(RStyx::Message::Rwstat, resp.class)
+  end
+
+  def test_twstat_size_noperm
+    # permission denied for file size change
+    # Test twstat for name change with no write permissions to
+    # parent directory
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:writable?).with(filemock).returns(false)
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = 42
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+  end
+
+  def test_twstat_size_success
+    # test twstat for successful size change
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:writable?).with(filemock).returns(true)
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = 42
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = RStyx::MAXUINT
+    stat.dtype = 0xffff
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    filemock.should_receive(:can_setlength?).with(Integer).returns { |s| assert_equal(42, s) }
+    filemock.should_receive(:length=).with(Integer).returns { |s| assert_equal(42, s) }
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    assert_equal(RStyx::Message::Rwstat, resp.class)
+  end
+
+  def test_twstat_mode_not_owner
+    # test twstat error condition, where mode changer is not the owner of
+    # the file.
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:uid).returns("bar")
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = 0644
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+  end
+
+  def test_twstat_mode_add_dirbit
+    # test twstat error condition, where the mode of an ordinary file is
+    # to be changed to that of a directory.
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:uid).returns("foo")
+    filemock.should_receive(:directory?).returns(false)
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = 0644 | RStyx::DMDIR
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+  end
+
+  def test_twstat_mode_success
+    # test twstat for successful mode change
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:uid).returns("foo")
+    filemock.should_receive(:directory?).returns(false)
+    filemock.should_receive(:can_setmode?)
+    filemock.should_receive(:mode=).with(Integer).returns { |m| assert_equal(0644, m) }
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = 0644
+    stat.mtime = RStyx::MAXUINT
+    stat.dtype = 0xffff
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+  end
+
+  def test_twstat_mtime_not_owner
+    # test twstat error condition, where mtime changer is not the owner of
+    # the file.
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:uid).returns("bar")
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = Time.now.to_i
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+  end
+
+  def test_twstat_mtime_success
+    # test twstat for successful mtime change
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    sessmock.should_receive(:user).returns("foo")
+    filemock.should_receive(:uid).returns("foo")
+    filemock.should_receive(:directory?).returns(false)
+    filemock.should_receive(:can_setmtime?)
+    filemock.should_receive(:mtime=).with(Integer).returns { |m| assert_equal(1190545938, m) }
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = 1190545938
+    stat.dtype = 0xffff
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    assert_equal(RStyx::Message::Rwstat, resp.class)
+  end
+
+  def test_twstat_misc_failures
+    # test twstat for miscellaneous failure modes
+    # Try to change group ID (not permitted by an RStyx server)
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    filemock = flexmock
+    sessmock.should_receive(:[]).with(42).returns(filemock)
+    filemock.should_receive(:synchronize).with(Proc).returns { |block| block.call }
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = RStyx::MAXUINT
+    stat.dtype = 0xfffff
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = "foo"
+    stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # Try changing dtype
+    stat = RStyx::Message::Stat.new
+    stat.name = ""
+    stat.size = -1
+    stat.mode = RStyx::MAXUINT
+    stat.mtime = RStyx::MAXUINT
+    stat.dtype = 0xff00
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.gid = stat.uid = stat.muid = ""
+    stat.atime = 0xffffffff
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # Try changing dev
+    stat.dtype = 0xffff
+    stat.dev = 0xdeadbeef
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # Try changing Qid
+    stat.dev = 0xffffffff
+    stat.qid = RStyx::Message::Qid.new(0xfe, 0xf000baaa, 0xdeadbeeff00baaa)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # Try changing atime
+    stat.qid = RStyx::Message::Qid.new(0xff, 0xffffffff,
+                                       0xffffffffffffffff)
+    stat.atime = Time.now.to_i
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # try changing uid
+    stat.atime = 0xffffffff
+    stat.uid = "foo"
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # try changing muid
+    stat.uid = ""
+    stat.muid = "foo"
+    assert_raises(RStyx::StyxException) do
+      resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    end
+
+    # Try an empty change
+    stat.muid = ""
+    resp = serv.twstat(RStyx::Message::Twstat.new(:stat => stat, :fid => 42))
+    assert_equal(RStyx::Message::Rwstat, resp.class)
+  end
+
+  def test_reply
+    msg = RStyx::Message::Rversion.new(:version => "9P2000",
+                                       :msize => 8216)
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    sessmock.should_receive(:has_tag?).returns(true)
+    selfmock.should_receive(:send_data).with(String).returns do |msg|
+      umsg = RStyx::Message::StyxMessage.from_bytes(msg)
+      assert_equal(RStyx::Message::Rversion, umsg.class)
+      assert_equal("9P2000", umsg.version)
+      assert_equal(8216, umsg.msize)
+      assert_equal(42, umsg.tag)
+    end
+    sessmock.should_receive(:release_tag).with(Integer).returns { |t| assert_equal(42, t) }
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    resp = serv.reply(msg, 42)    
+  end
+
+  def test_process_styxmsg_badtag
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    logmock = flexmock
+    sessmock.should_receive(:add_tag).with(Integer).returns do |t|
+      assert_equal(42, t)
+      raise RStyx::TagInUseException.new(t)
+    end
+    logmock.should_receive(:error).with(String).returns do |s|
+      assert_equal("(unknown peer) RStyx::TagInUseException (Tversion :tag=>\"42\" :msize=>\"8216\" :version=>\"9P2000\")", s)
+    end
+    msg = RStyx::Message::Tversion.new(:version => "9P2000",
+                                       :msize => 8216,
+                                       :tag => 42)
+    serv = FakeConnection.new(selfmock, sessmock, nil, logmock)
+    serv.process_styxmsg(msg)
+  end
+
+  def test_process_styxmsg_badfid
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    sessmock.should_receive(:add_tag).with(Integer).returns do |t|
+      assert_equal(42, t)
+    end
+    sessmock.should_receive(:[]).with(Integer).returns do |t|
+      assert_equal(42, t)
+      raise RStyx::FidNotFoundException.new(t)
+    end
+    msg = RStyx::Message::Twrite.new(:fid => 42,
+                                     :tag => 42)
+    sessmock.should_receive(:has_tag?).returns(true)
+    selfmock.should_receive(:send_data).with(String).returns do |msg|
+      umsg = RStyx::Message::StyxMessage.from_bytes(msg)
+      assert_equal(RStyx::Message::Rerror, umsg.class)
+    end
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    sessmock.should_receive(:release_tag).with(Integer).returns { |t| assert_equal(42, t) }
+
+    serv.process_styxmsg(msg)
+  end
+
+  def test_process_styxmsg_emptyreply
+    msgmock = flexmock
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    sessmock.should_receive(:add_tag).with(42)
+    sessmock.should_receive(:[]).with(Integer).returns do |t|
+      assert_equal(42, t)
+      raise RStyx::FidNotFoundException.new(t)
+    end
+    sessmock.should_receive(:has_tag?).returns(true)
+    selfmock.should_receive(:send_data).with(String).returns do |msg|
+      umsg = RStyx::Message::StyxMessage.from_bytes(msg)
+      assert_equal(RStyx::Message::Rerror, umsg.class)
+    end
+    selfmock.should_receive(:flexmock).returns(nil)
+    msgmock.should_receive(:tag).returns(42)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    sessmock.should_receive(:release_tag).with(Integer).returns { |t| assert_equal(42, t) }
+
+    serv.process_styxmsg(msgmock)
+  end
+
+  def test_process_styxmsg_internalerror
+    msgmock = flexmock
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    sessmock.should_receive(:add_tag).with(42)
+    sessmock.should_receive(:[]).with(Integer).returns do |t|
+      assert_equal(42, t)
+      raise RStyx::FidNotFoundException.new(t)
+    end
+    selfmock.should_receive(:absorber).returns(nil)
+    sessmock.should_receive(:has_tag?).returns(true)
+    selfmock.should_receive(:send_data).with(String).returns do |msg|
+      umsg = RStyx::Message::StyxMessage.from_bytes(msg)
+      assert_equal(RStyx::Message::Rerror, umsg.class)
+    end
+    selfmock.should_receive(:flexmock).returns { raise "error" }
+    msgmock.should_receive(:tag).returns(42)
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    sessmock.should_receive(:release_tag).with(Integer).returns { |t| assert_equal(42, t) }
+
+    serv.process_styxmsg(msgmock)
+  end
+
+  def test_process_styxmsg_success
+    selfmock = flexmock(:get_peername => nil)
+    sessmock = flexmock
+    sessmock.should_receive(:add_tag).with(Integer).returns do |t|
+      assert_equal(42, t)
+    end
+    sessmock.should_receive(:[]).with(Integer).returns do |t|
+      assert_equal(42, t)
+    end
+    msg = RStyx::Message::Tclunk.new(:fid => 42, :tag => 42)
+    sessmock.should_receive(:clunk).with(42)
+    sessmock.should_receive(:has_tag?).returns(true)
+    selfmock.should_receive(:send_data).with(String).returns do |msg|
+      umsg = RStyx::Message::StyxMessage.from_bytes(msg)
+      assert_equal(RStyx::Message::Rclunk, umsg.class)
+    end
+    serv = FakeConnection.new(selfmock, sessmock, nil)
+    sessmock.should_receive(:release_tag).with(Integer).returns { |t| assert_equal(42, t) }
+
+    serv.process_styxmsg(msg)
+  end
+
 end

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: rstyx
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
-date: 2007-09-19 00:00:00 +08:00
+  version: 0.4.2
+date: 2007-09-24 00:00:00 +08:00
 summary: RStyx is a Ruby implementation of the 9P2000/Styx distributed file protocol used on Plan 9 and Inferno.
 require_paths: 
 - lib