rspreadsheet 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdaab0a6bad4e406aa6e180c1a0b5d21d7f1e01586d0275449e6a824852d07c6
-  data.tar.gz: 83f64bbd8b7c94c924ce0b75794995c4f90f2d14630f5a87b2f96d2fae80a6cc
+  metadata.gz: b2c92247a04812100d02a3145ee69d112aa434b6ea2365c6f416a7be5d399eef
+  data.tar.gz: 728f3fb25da67aa9cd4b31f5d1ddec687b9ddc7bc749f6baefe4bb926048b2ca
 SHA512:
-  metadata.gz: 324d95798062e62cdb99a8039b48e46b80ddd33c31a6963e6c51af5da01f0858db51fd737937b1744b33d8b085a4b03e0ed81c92d4523e20a961ba7c437bda55
-  data.tar.gz: 60445dbdb2965e661db8e0b1213039aa89ad0b8a53ac61de4aa7e2005a9b4274bfd8bdad66cc6a494f4bc331e06c0f2012eab2150787859e018f977e6fd68214
+  metadata.gz: 73dc5875e271ff2fd0e67997ced78078538147d8beeec3c2d61e3eb2bcde0f60a3b80a758f1e1e396c76347fea2bfe1d1db0a727c13d75f8e01218291010a5b3
+  data.tar.gz: 637a92a312e621f4482499bfb27235ffcdb57e8a936834b7f492024b67284a8b89884429c6eaf40cb94a67b523a6b52f7b4479c6d1f672e649635c5ec551ef89

data/DEVEL_BLOG.md

@@ -9,6 +9,8 @@ After you have cloned the source run `bundle` command in gem directory to instal
 
 ## Ideas/wishlist
 
+  * refactor Style and AutomaticStyle objects from CellFormat.
+  * introduce "speedup" option, which can for example skip all "safetest" (or it can be named $prudent = true/false)
   * make it configurable whether Time or DateTime will be used.
   * In future inntroduce syntax like `sheet.range('C3:E4')` for mass operations.
   * Trying to make row Enumerable - perhaps skipping empty or undefined cells.

data/GUIDE.md

@@ -3,42 +3,42 @@
 
 You can open ODS file (OpenDocument Spreadsheet) like this
 ````ruby
-@workbook = Rspreadsheet.open('./test.ods')
+workbook = Rspreadsheet.open('./test.ods')
 ````
 and access its first sheet like this
 ````ruby
-@sheet = @workbook.worksheet(1)
+sheet = workbook.worksheet(1)
 ````
 ### Accessing cells
 
 you can get and set contents of cells using "verbatim" syntax like
 ````ruby
-@sheet.row(5).cell(4).value 
-@sheet.row(5).cell(4).value = 10
+sheet.row(5).cell(4).value 
+sheet.row(5).cell(4).value = 10
 ````
 or using "brief" syntax like
 ````ruby
-@sheet[5,4]
-@sheet[5,4] = 10
+sheet[5,4]
+sheet[5,4] = 10
 ````
 
 You can mix these two at will, for example like this
 ````ruby
-@row = @sheet.row(5)
-@row[4] = 10
+row = sheet.row(5)
+row[4] = 10
 ````
 
 ### Working with images
-@sheet.insert_image_to('10.21mm','15mm','image.png')
-i = @sheet.images.first
+sheet.insert_image_to('10.21mm','15mm','image.png')
+i = sheet.images.first
 i.move_to('100mm','99.98mm')
 
 ### Saving 
 The file needs to be saved after doing changes. 
 ````ruby
-@workbook.save
-@workbook.save('new_filename.ods')   # changes filename and saves
-@workbook.save(any_io_object)        # file can be saved to any IO like object as well
+workbook.save
+workbook.save('new_filename.ods')   # changes filename and saves
+workbook.save(any_io_object)        # file can be saved to any IO like object as well
 ````
 ### Date and Time
 OpenDocument and ruby have different models of date, time and datetime. Ruby containg three different objects. Time and DateTime cover all cases, Date covers dates only. OpenDocument distinguishes two groups - time of a day (time) and everything else (date). To simplify things a little we return cell values containg time of day as Time object and cell values containg datetime of date as DateTime. I am aware that this is very arbitrary choice, but it is very practical. This way and to some extend the types of values from OpenDocument are preserved when read from files, beeing acted upon and written back to spreadshhet.
@@ -54,5 +54,5 @@ OpenDocument and ruby have different models of date, time and datetime. Ruby con
   * with numeric coordinates row always comes before col as in  (row,col)
   * with alphanumerical col always comes before row as in F12
   * Shorter syntax worksheet[x,y] returns value, longer syntax worksheet.cell(x,y) return cell objects. This allows to work conviniently with values using short syntax and access the cell object if needed (to access formatting for example).
-  * Note: currently plural and singular like sheet/sheets, row/rows, cell/cells can be used intergangebly, but there is a (discussion)[https://github.com/gorn/rspreadsheet/issues/10] about this and in future versions we might use singular style for methods and plural for array style.
+  * Singular and plural like sheet/sheets, row/rows, cell/cells can be used intergangebly.
 

data/lib/rspreadsheet/cell_format.rb

@@ -2,14 +2,6 @@
 # @author Jakub Tesinsky
 # @title rspreadsheet Cell
 
-# require 'andand'
-# require 'rspreadsheet/xml_tied_item'
-# require 'date'
-# require 'time'            # extended functions for time like Time.strptime
-# require 'bigdecimal'
-# require 'bigdecimal/util' # for to_d method
-# require 'helpers/class_extensions'
-
 module Rspreadsheet
 using ClassExtensions if RUBY_VERSION > '2.1'
 
@@ -28,43 +20,73 @@ class CellFormat
   end
   def cellnode; @cell.xmlnode end
   
-  # text style attribute readers
+  # @!group text style attribute readers
   def bold;      get_text_style_node_attribute('font-weight') == 'bold' end
   alias :bold? :bold 
   def italic;    get_text_style_node_attribute('font-style') == 'italic' end
   def color;     get_text_style_node_attribute('color') end
   def font_size; get_text_style_node_attribute('font-size') end
-  def get_text_style_node_attribute(attribute_name)
-    text_style_node.nil? ? nil : Tools.get_ns_attribute_value(text_style_node,'fo',attribute_name)
-  end
   def background_color; get_cell_style_node_attribute('background-color') end
-  def get_cell_style_node_attribute(attribute_name)
-    cell_style_node.nil? ? nil : Tools.get_ns_attribute_value(cell_style_node,'fo',attribute_name)
+  def currency
+    Tools.get_ns_attribute_value(cellnode,'office','currency',nil) 
   end
   
-  # text style attribute writers
+  # @!group text style attribute writers
   def bold=(value);     set_text_style_node_attribute('font-weight', value ? 'bold' : 'normal') end
   def italic=(value);   set_text_style_node_attribute('font-style',  value ? 'italic' : 'normal') end
   def color=(value);    set_text_style_node_attribute('color',  value) end
   def font_size=(value);set_text_style_node_attribute('font-size',  value) end
+  def background_color=(value); set_cell_style_node_attribute('background-color',  value) end
+    
+  
+  # @!group border related
+  def top;    @top    ||= Border.new(self,:top)  end
+  def bottom; @bottom ||= Border.new(self,:bottom) end
+  def left;   @left   ||= Border.new(self,:left) end
+  def right;  @right  ||= Border.new(self,:right) end
+  alias :border_top :top
+  alias :border_right :right
+  alias :border_bottom :bottom
+  alias :border_left :left
+      
+  # @!group manipulation of style related nodes
+  def get_text_style_node_attribute(attribute_name)
+    text_style_node.nil? ? nil : Tools.get_ns_attribute_value(text_style_node,'fo',attribute_name)
+  end
+  def get_cell_style_node_attribute(attribute_name)
+    cell_style_node.nil? ? nil : Tools.get_ns_attribute_value(cell_style_node,'fo',attribute_name)
+  end
   def set_text_style_node_attribute(attribute_name,value)
-    @cell.detach if @cell.mode != :regular
+    make_sure_styles_are_not_shared
     if text_style_node.nil?
       self.create_text_style_node
-      raise 'Style node was not correctly initialized' if text_style_node.nil?
+      raise 'Text style node was not correctly initialized' if text_style_node.nil?
     end
     Tools.set_ns_attribute(text_style_node,'fo',attribute_name,value)
   end
-  def background_color=(value); set_cell_style_node_attribute('background-color',  value) end
   def set_cell_style_node_attribute(attribute_name,value)
-    @cell.detach if @cell.mode != :regular
+    make_sure_styles_are_not_shared
     if cell_style_node.nil?
       self.create_cell_style_node
-      raise 'Style node was not correctly initialized' if cell_style_node.nil?
+      raise 'Cell style node was not correctly initialized' if cell_style_node.nil?
     end
     Tools.set_ns_attribute(cell_style_node,'fo',attribute_name,value)
   end
-  
+  def make_sure_styles_are_not_shared  # with another cell (prevent issue #40)
+    # if cell is reapeated, we must detach it first
+    @cell.detach if @cell.mode != :regular   
+    # if style node is shared, we must create our own first
+    if style_shared?
+      new_style_name = unused_cell_style_name
+      
+      new_style_node = style_node.copy(true)
+      Tools.set_ns_attribute(new_style_node,'style','name',new_style_name)
+      style_node.next = new_style_node
+      self.style_name = new_style_name
+      raise 'Unsucessfull unsharing of styles' if style_shared?
+    end
+  end
+
  # @!group initialization of style related nodes, if they do not exist
   def create_text_style_node
     create_style_node if style_name.nil? or style_node.nil?
@@ -83,13 +105,14 @@ class CellFormat
       raise 'Style name was not correctly initialized' if style_name!=proposed_style_name
     end
     anode =  Tools.prepare_ns_node('style','style')
-    Tools.set_ns_attribute(anode, 'style', 'name', proposed_style_name)
+    Tools.set_ns_attribute(anode, 'style', 'name', style_name)
     Tools.set_ns_attribute(anode, 'style', 'family', 'table-cell')
     Tools.set_ns_attribute(anode, 'style', 'parent-style-name', 'Default')
     automatic_styles_node << anode
     raise 'Style node was not correctly initialized' if style_node.nil?
   end
   
+  # @!group other style node related routines
   def unused_cell_style_name
     last = (cellnode.nil? ? [] : cellnode.doc.root.find('./office:automatic-styles/style:style')).
       collect {|node| node['name']}.
@@ -106,27 +129,25 @@ class CellFormat
     return nil if cellnode.nil?
     cellnode.doc.root.find("./office:automatic-styles#{xpath}").first 
   end
-  def currency
-    Tools.get_ns_attribute_value(cellnode,'office','currency',nil) 
+  
+  # how many cells are using this style. repeated cells are counted only once
+  def style_shared_count
+    cellnode.doc.root.find("//table:table-cell[@table:style-name=\"#{style_name}\"]").size
+  end
+  def style_shared?
+    style_shared_count>1
   end
-  #returns object representing top border of the cell
-  def top;    @top    ||= Border.new(self,:top)  end
-  def bottom; @bottom ||= Border.new(self,:bottom) end
-  def left;   @left   ||= Border.new(self,:left) end
-  def right;  @right  ||= Border.new(self,:right) end
-  alias :border_top :top
-  alias :border_right :right
-  alias :border_bottom :bottom
-  alias :border_left :left
   
+  # @!group other routines
   def inspect
-    "#<Rspreadsheet::CellFormat bold:#{bold?.inspect}, borders:#{top.get_value_string.inspect} #{right.get_value_string.inspect} #{bottom.get_value_string.inspect} #{left.get_value_string.inspect}>"
+    "#<Rspreadsheet::CellFormat bold:#{bold?.inspect}, borders: #{top.get_border_string || 'none'}, #{right.get_border_string || 'none'}, #{bottom.get_border_string || 'none'}, #{left.get_border_string || 'none'}>"
   end
-  # experimental. Allows to assign a style to cell.
+  
+  # experimental. Allows to assign a style to cell. Currenty used only for automatic styles.
   def style_name=(value)
-    Tools.set_ns_attribute_value(cellnode,'table','style-name',value)
+    Tools.set_ns_attribute(cellnode,'table','style-name',value)
   end
-  
+
 end
 
 # represents one of the borders of a cell
@@ -148,11 +169,10 @@ class Border
   def delete
     @cellformat.set_cell_style_node_attribute(attribute_name, 'none')
   end
-    
-    
+  
   ## internals  
    
-  # set parth-th part of string which represents the border. String looks like "0.06pt solid #00ee00"
+  # set part-th part of string which represents the border. String looks like "0.06pt solid #00ee00"
   # part is 1 for width, 2 for style or 3 for color
   def set_border_string_part(part,value)
     current_value = @cellformat.get_cell_style_node_attribute(attribute_name)
@@ -167,19 +187,19 @@ class Border
     @cellformat.set_cell_style_node_attribute(attribute_name, value_array.join(' '))
   end
   
-  def get_border_string_part(part)
-    current_value = @cellformat.get_cell_style_node_attribute(attribute_name) || @cellformat.get_cell_style_node_attribute('border')
-    if current_value.nil? or (current_value=='none')
-      return nil
-    else
-      value_array = current_value.split(' ')  
-      raise 'Strange border attribute value. Does not have 3 parts' unless value_array.length == 3
-      return value_array[part-1]
-    end
+  def get_border_string
+    result = @cellformat.get_cell_style_node_attribute(attribute_name) || @cellformat.get_cell_style_node_attribute('border')
+    result = nil if result=='none'
+    result
   end
   
-  def get_value_string
-    @cellformat.get_cell_style_node_attribute(attribute_name)
+  def get_border_string_part(part)
+    border_string = get_border_string
+    return nil if border_string.nil?
+      
+    value_array = border_string.split(' ')  
+    raise 'Strange border attribute value. Does not have 3 parts' unless value_array.length == 3
+    return value_array[part-1]
   end
   
 end

data/lib/rspreadsheet/version.rb

@@ -1,3 +1,3 @@
 module Rspreadsheet
-  VERSION = "0.4.7"
+  VERSION = "0.4.8"
 end

data/lib/rspreadsheet/xml_tied_repeatable.rb

@@ -7,7 +7,7 @@ using ClassExtensions if RUBY_VERSION > '2.1'
 
 
 # Abstract class similar to XMLTiedArray but with support to "repeatable" items. This is notion specific
-# to OpenDocument files - whnewer a row repeats more times (or a cell), one can either make many identical
+# to OpenDocument files - whenewer a row repeats more times (or a cell), one can either make many identical
 # copies of the same xml or only make one xml representing one item and add attribute xml_repeated.
 #
 # This class is made to be included, not subclassed - the reason is in delete method which calls super.

data/spec/cell_format_spec.rb

@@ -0,0 +1,157 @@
+require 'spec_helper'
+
+# tests for graphical formats (value formats are elsewhere)
+describe Rspreadsheet::Cell do
+  before do 
+    book1 = Rspreadsheet.new
+    @sheet1 = book1.create_worksheet
+    book2 = Rspreadsheet.new($test_filename)
+    @sheet2 = book2.worksheets(1)
+  end
+  it 'can have different formats' do
+    @cell = @sheet2.cell(6,3)
+    @cell.format.bold.should == true
+    @cell = @sheet2.cell(6,4)
+    @cell.format.bold.should == false
+    @cell.format.italic.should == true
+    @cell = @sheet2.cell(6,5)
+    @cell.format.italic.should == false
+    @cell.format.color.should == '#ff3333'
+    @cell = @sheet2.cell(6,6)
+    @cell.format.color.should_not == '#ff3333'
+    @cell.format.background_color.should == '#6666ff'
+    @cell = @sheet2.cell(6,7)
+    @cell.format.font_size.should == '7pt'
+        
+    # after fresh create
+    @cell.xmlnode.attributes['style-name'].should_not be_nil
+  end
+  it 'can set formats of the cell in new file' do
+    @cell = @sheet1.cell(1,1)
+    @cell.value = '1'
+    # bold
+    @cell.format.bold.should be_falsey
+    @cell.format.bold = true
+    @cell.format.bold.should be_truthy
+    # italic
+    @cell.format.italic.should be_falsey
+    @cell.format.italic = true
+    @cell.format.italic.should be_truthy
+    # color
+    @cell.format.color.should be_nil
+    @cell.format.color = '#AABBCC'
+    @cell.format.color.should eq '#AABBCC'
+    # background_color
+    @cell.format.background_color.should be_nil
+    @cell.format.background_color = '#AABBCC'
+    @cell.format.style_name.should_not eq 'cell'
+    @cell.format.background_color.should eq '#AABBCC'
+    # font_size
+    @cell.format.font_size.should be_nil
+    @cell.format.font_size = '11pt'
+    @cell.format.font_size.should eq '11pt'
+  end
+  it 'setting format in new file detaches the cell' do
+    @cell = @sheet1.cell(1,1)
+    # bold
+    @cell.format.bold.should be_falsey
+    @cell.format.bold = true
+    @cell.format.bold.should be_truthy
+    @cell.mode.should eq :regular
+
+    @cell = @sheet1.cell(2,2)
+    @cell.format.background_color = '#ffeeaa'
+    @cell.format.background_color.should == '#ffeeaa'
+    @cell.mode.should eq :regular
+  end
+  it 'is possible to manipulate borders of cells' do
+    @cell = @sheet1.cell(1,1)
+    
+    [@cell.format.top,@cell.format.left,@cell.format.right,@cell.format.bottom].each do |border|
+      border.style = 'dashed'
+      border.style.should == 'dashed'
+      border.width = 0.5 
+      border.width.should == 0.5
+      border.color = '#005500'
+      border.color.should == '#005500'
+    end    
+  end
+  it 'returns correct border parameters for the cell' do
+    @sheet2.cell('C8').format.top.style.should == 'solid'
+    @sheet2.cell('E8').format.left.color.should == '#ff3333'
+    @sheet2.cell('E8').format.left.style.should == 'solid'
+    @sheet2.cell('F8').format.top.color.should == '#009900'
+    @sheet2.cell('F8').format.top.style.should == 'dotted'
+  end
+  it 'modifies borders correctly' do
+    ## initially solid everywhere
+    @sheet2.cell('C8').format.top.style.should == 'solid'
+    @sheet2.cell('C8').format.bottom.style.should == 'solid'
+    @sheet2.cell('C8').format.left.style.should == 'solid'
+    @sheet2.cell('C8').format.right.style.should == 'solid'
+    ## change top and right to dotted and observe
+    @sheet2.cell('C8').format.top.style = 'dotted'
+    @sheet2.cell('C8').format.right.style = 'dotted'
+    @sheet2.cell('C8').format.bottom.style.should == 'solid'
+    @sheet2.cell('C8').format.left.style.should == 'solid'
+    @sheet2.cell('C8').format.top.style.should == 'dotted'
+    @sheet2.cell('C8').format.right.style.should == 'dotted'
+  end
+  it 'deletes borders correctly', :pending=> 'consider how to deal with deleted borders' do
+    @cell = @sheet1.cell(1,1)
+    
+    [@cell.format.top,@cell.format.left,@cell.format.right,@cell.format.bottom].each do |border|
+      border.style = 'dashed'
+      border.should_not be_nil
+      border.delete
+      border.should be_nil
+    end 
+    
+    # delete right border in existing file and observe
+    @sheet2.cell('C8').format.right.delete
+    @sheet2.cell('C8').format.right.should == nil
+  end
+  
+  it 'can delete borders in many ways', :pending => 'consider what syntax to support' do
+    @cell=@sheet2.cell('C8')
+    @cell.border_right.should_not be_nil
+    @cell.border_right.delete
+    @cell.border_right.should be_nil
+    
+    @cell.border_left.should_not be_nil
+    @cell.border_left = nil
+    @cell.border_left.should be_nil
+    
+    @cell.format.top.should_not_be_nil
+    @cell.format.top.style = 'none'
+    @cell.border_top.should_not be_nil ## ?????
+  end
+  
+  it 'does not have issue 40 - coloring other cells, when they have similar borders' do
+    sheet = Rspreadsheet.open('./spec/testfile-issue-40.ods').worksheet(1)
+    sheet[1,1] = 'ahoj'
+    sheet.cell(1,1).format.background_color = '#FF0000'
+
+    sheet.cell(1,1).format.background_color.should == '#FF0000'
+    sheet.cell('B3').format.background_color.should_not == '#FF0000'
+  end
+  
+  it 'automatically creates new style, if a style is automatic, some of its attributes changes and there are several cells pointing to it', :focus do
+    sheet = Rspreadsheet.open('./spec/testfile-issue-40.ods').worksheet(1)
+    cell1 = sheet.cell(1,1)
+    cell2 = sheet.cell('B3')
+    
+    cell1.xmlnode.attributes['style-name'].should == cell2.xmlnode.attributes['style-name']
+    cell1.format.background_color = '#FF0000'
+    
+    cell1.xmlnode.attributes['style-name'].should_not == cell2.xmlnode.attributes['style-name']
+  end
+  
+  it 'recognizes correctly that style is shared with other cell' do
+    sheet = Rspreadsheet.open('./spec/testfile-issue-40.ods').worksheet(1)
+    
+    sheet.cell(1,1).format.style_shared_count.should == 2
+    sheet.cell(1,1).format.style_shared?.should == true
+  end
+  
+end

data/spec/cell_spec.rb

@@ -182,49 +182,6 @@ describe Rspreadsheet::Cell do
     @sheet2.insert_cell_before(1,1)
     @sheet2.rows(1).cell(1).should be_kind_of(Rspreadsheet::Cell)
   end
-  it 'can have different formats' do
-    @cell = @sheet2.cell(6,3)
-    @cell.format.bold.should == true
-    @cell = @sheet2.cell(6,4)
-    @cell.format.bold.should == false
-    @cell.format.italic.should == true
-    @cell = @sheet2.cell(6,5)
-    @cell.format.italic.should == false
-    @cell.format.color.should == '#ff3333'
-    @cell = @sheet2.cell(6,6)
-    @cell.format.color.should_not == '#ff3333'
-    @cell.format.background_color.should == '#6666ff'
-    @cell = @sheet2.cell(6,7)
-    @cell.format.font_size.should == '7pt'
-        
-    # after fresh create
-    @cell.xmlnode.attributes['style-name'].should_not be_nil
-  end
-  it 'can set formats of the cell in new file' do
-    @cell = @sheet1.cell(1,1)
-    @cell.value = '1'
-    # bold
-    @cell.format.bold.should be_falsey
-    @cell.format.bold = true
-    @cell.format.bold.should be_truthy
-    # italic
-    @cell.format.italic.should be_falsey
-    @cell.format.italic = true
-    @cell.format.italic.should be_truthy
-    # color
-    @cell.format.color.should be_nil
-    @cell.format.color = '#AABBCC'
-    @cell.format.color.should eq '#AABBCC'
-    # background_color
-    @cell.format.background_color.should be_nil
-    @cell.format.background_color = '#AABBCC'
-    @cell.format.style_name.should_not eq 'cell'
-    @cell.format.background_color.should eq '#AABBCC'
-    # font_size
-    @cell.format.font_size.should be_nil
-    @cell.format.font_size = '11pt'
-    @cell.format.font_size.should eq '11pt'
-  end
   it 'method cells without arguments returns array of cells' do
     @a = @sheet2.rows(1).cells
     @a.should be_kind_of(Array)
@@ -326,19 +283,6 @@ describe Rspreadsheet::Cell do
     @sheet2.cell('BA177').should be @sheet2.cell(177,53)
     @sheet2.cell('ADA2').should be @sheet2.cell(2,781)
   end
-  it 'setting format in new file detaches the cell' do
-    @cell = @sheet1.cell(1,1)
-    # bold
-    @cell.format.bold.should be_falsey
-    @cell.format.bold = true
-    @cell.format.bold.should be_truthy
-    @cell.mode.should eq :regular
-
-    @cell = @sheet1.cell(2,2)
-    @cell.format.background_color = '#ffeeaa'
-    @cell.format.background_color.should == '#ffeeaa'
-    @cell.mode.should eq :regular
-  end
   it 'remembers formula when set' do
     @cell = @sheet1.cell(1,1)
     @cell.formula.should be_nil
@@ -386,72 +330,6 @@ describe Rspreadsheet::Cell do
     @cell.type.should eq :currency
     @cell.format.currency.should == 'CZK'
   end
-  it 'is possible to manipulate borders of cells' do
-    @cell = @sheet1.cell(1,1)
-    
-    [@cell.format.top,@cell.format.left,@cell.format.right,@cell.format.bottom].each do |border|
-      border.style = 'dashed'
-      border.style.should == 'dashed'
-      border.width = 0.5 
-      border.width.should == 0.5
-      border.color = '#005500'
-      border.color.should == '#005500'
-    end    
-  end
-  it 'returns correct border parameters for the cell' do
-    @sheet2.cell('C8').format.top.style.should == 'solid'
-    @sheet2.cell('E8').format.left.color.should == '#ff3333'
-    @sheet2.cell('E8').format.left.style.should == 'solid'
-    @sheet2.cell('F8').format.top.color.should == '#009900'
-    @sheet2.cell('F8').format.top.style.should == 'dotted'
-  end
-  it 'modifies borders correctly' do
-    ## initially solid everywhere
-    @sheet2.cell('C8').format.top.style.should == 'solid'
-    @sheet2.cell('C8').format.bottom.style.should == 'solid'
-    @sheet2.cell('C8').format.left.style.should == 'solid'
-    @sheet2.cell('C8').format.right.style.should == 'solid'
-    ## change top and right to dotted and observe
-    @sheet2.cell('C8').format.top.style = 'dotted'
-    @sheet2.cell('C8').format.right.style = 'dotted'
-    @sheet2.cell('C8').format.bottom.style.should == 'solid'
-    @sheet2.cell('C8').format.left.style.should == 'solid'
-    @sheet2.cell('C8').format.top.style.should == 'dotted'
-    @sheet2.cell('C8').format.right.style.should == 'dotted'
-  end
-  it 'deletes borders correctly', :pending=> 'consider how to deal with deleted borders' do
-    @cell = @sheet1.cell(1,1)
-    
-    [@cell.format.top,@cell.format.left,@cell.format.right,@cell.format.bottom].each do |border|
-      border.style = 'dashed'
-      border.should_not be_nil
-      border.delete
-      border.should be_nil
-    end 
-    
-    # delete right border in existing file and observe
-    @sheet2.cell('C8').format.right.delete
-    @sheet2.cell('C8').format.right.should == nil
-  end
-  
-  it 'can delete borders in many ways', :pending => 'consider what syntax to support' do
-    @cell=@sheet2.cell('C8')
-    @cell.border_right.should_not be_nil
-    @cell.border_right.delete
-    @cell.border_right.should be_nil
-    
-    @cell.border_left.should_not be_nil
-    @cell.border_left = nil
-    @cell.border_left.should be_nil
-    
-    @cell.format.top.should_not_be_nil
-    @cell.format.top.style = 'none'
-    @cell.border_top.should_not be_nil ## ?????
-  end
-  
-  it 'automatically creates new style, if a style is automatic, some of its attributes changes and there are several cells pointing to it', :pending=>'' do
-  
-  end
   
   it 'gracefully accepts nil in assignement' do
     expect {

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@ require 'bundler/setup'
 Bundler.setup
 
 RSpec.configure do |config|
-  config.fail_fast = true
+#   config.fail_fast = 4
 #   config.warnings = true
   
   # so i can run individual test just by appending :focus to them

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspreadsheet
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Jakub A.Těšínský
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-24 00:00:00.000000000 Z
+date: 2019-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -157,6 +157,7 @@ files:
 - lib/rspreadsheet/xml_tied_repeatable.rb
 - reinstall_local_gem.sh
 - rspreadsheet.gemspec
+- spec/cell_format_spec.rb
 - spec/cell_spec.rb
 - spec/class_extensions_spec.rb
 - spec/column_spec.rb
@@ -169,6 +170,7 @@ files:
 - spec/spec_helper.rb.template
 - spec/test-image-blue.png
 - spec/test-image.png
+- spec/testfile-issue-40.ods
 - spec/testfile1.ods
 - spec/testfile2-images.ods
 - spec/tools_spec.rb
@@ -201,6 +203,7 @@ specification_version: 4
 summary: Manipulating LibreOffice Calc (OpenDocument Spreadsheet) files from Ruby
   (read / create / modify).
 test_files:
+- spec/cell_format_spec.rb
 - spec/cell_spec.rb
 - spec/class_extensions_spec.rb
 - spec/column_spec.rb
@@ -213,6 +216,7 @@ test_files:
 - spec/spec_helper.rb.template
 - spec/test-image-blue.png
 - spec/test-image.png
+- spec/testfile-issue-40.ods
 - spec/testfile1.ods
 - spec/testfile2-images.ods
 - spec/tools_spec.rb