rspice 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58dd033ff1703ef7332f30c29da74199a5e2d189866d3521ab7d22ffd69b6226
-  data.tar.gz: 52843b9f1b591ac03958d303e71bd3a17be19771a0a8e7ad3c8cfdda6afc61e5
+  metadata.gz: 651dd42d3b2abbb823d0cf946f2de5a641873756939e1af717f5e1632c673386
+  data.tar.gz: 5c23a2024c0402571e8144c8c38e2ae08a228ffe47cf1b846a5fa9b59abe91dd
 SHA512:
-  metadata.gz: c64381474bb2a67827046d3eca9b8232ce5c0fcc0c75674e2f0fe023bede31abf6b3a3d2c40b0c9301567a47246e62933e2f4d12503bf88832b0655027f546ae
-  data.tar.gz: 3f84d07780ca87d314eb77dd590bcd0baaa0041b346405f83ce6c9d6fa7af69c3aed6cf86eea6dbe7699501a3a5d6d19720c7f04c422ddb6baceec1df02529a1
+  metadata.gz: d7736fb620d39207483fbb5f8e243917d56cdec97d71d72702c40729b91d87057975164dbf94a55bfdcfa6d295b0d11faac3e16897c35a0a09f5dd7e06d97dde
+  data.tar.gz: 1f96d00331b565a1dfddf321067a6e89151f41c122a3c5a0b1698d60e4b570e04de09e9c09b8b1b8215ac1a298b912fe89b38b379f1d78cf3a7934e3d81e7ddd

data/lib/rspice/shared_examples.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
 require "rspice/shared_examples/a_class_pass_method"
+require "rspice/shared_examples/a_versioned_spicerack_gem"

data/lib/rspice/shared_examples/a_class_pass_method.rb

@@ -1,36 +1,46 @@
 # frozen_string_literal: true
 
-# TODO: Jank - this should use Method#parameters, not Method#arity
-
 RSpec.shared_examples_for "a class pass method" do |method|
   subject do
-    if takes_options?
-      test_class.public_send(method, *arguments, **options)
+    if accepts_block?
+      test_class.public_send(method, *arguments, &block)
     else
       test_class.public_send(method, *arguments)
     end
   end
 
   let(:test_class) { described_class }
-  let(:initialize_arity) { test_class.instance_method(:initialize).arity }
-  let(:takes_options?) { (initialize_arity < 0) }
-  let(:argument_arity) { takes_options? ? (initialize_arity.abs - 1) : initialize_arity }
+
+  let(:method_parameters) { test_class.instance_method(:initialize).parameters }
+  let(:argument_arity) { method_parameters.map(&:first).select { |type| type.in?(%i[req opt]) }.length }
+  let(:option_keys) { method_parameters.select { |param| param.first.in?(%i[key keyreq]) }.map(&:last) }
+  let(:accepts_block?) { method_parameters.any? { |param| param.first == :block } }
 
   let(:arguments) do
-    Array.new(argument_arity) { double }
+    Array.new(argument_arity) { double }.tap do |array|
+      array << options if options.present?
+    end
   end
-  let(:options) { takes_options? ? Hash[*Faker::Lorem.words(2 * rand(1..2))].symbolize_keys : nil }
+  let(:options) { option_keys.each_with_object({}) { |key, hash| hash[key] = Faker::Lorem.word } }
+  let(:block) { -> {} }
   let(:instance) { instance_double(test_class) }
   let(:output) { double }
 
   before do
     allow(instance).to receive(method).and_return(output)
-    if takes_options?
-      allow(test_class).to receive(:new).with(*arguments, **options).and_return(instance)
-    else
+
+    if accepts_block?
+      allow(test_class).to receive(:new).with(*arguments, &block).and_return(instance)
+    elsif arguments.any?
       allow(test_class).to receive(:new).with(*arguments).and_return(instance)
+    else
+      allow(test_class).to receive(:new).with(no_args).and_return(instance)
     end
   end
 
   it { is_expected.to eq output }
+
+  it "has matching parameters with initialize" do
+    expect(test_class.method(method).parameters).to eq test_class.instance_method(:initialize).parameters
+  end
 end

data/lib/rspice/shared_examples/a_versioned_spicerack_gem.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples_for "a versioned spicerack gem" do
+  it "has a version number" do
+    expect(described_class::VERSION).to be_a String
+    expect(described_class::VERSION).not_to be_blank
+    expect(described_class::VERSION).to eq Spicerack::VERSION
+  end
+end

data/lib/rspice/version.rb

@@ -2,5 +2,5 @@
 
 module Rspice
   # This constant is managed by spicerack
-  VERSION = "0.4.3"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspice
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Eric Garside
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-10 00:00:00.000000000 Z
+date: 2018-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -57,6 +57,7 @@ files:
 - lib/rspice/shared_context/with_an_example_descendant_class.rb
 - lib/rspice/shared_examples.rb
 - lib/rspice/shared_examples/a_class_pass_method.rb
+- lib/rspice/shared_examples/a_versioned_spicerack_gem.rb
 - lib/rspice/version.rb
 homepage: https://www.freshly.com
 licenses: