rspec_telemetry 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a39ae80facd19b25cfcbb59d34bde9ad51d47cb815d1ea5bfec9b3a344cead99
-  data.tar.gz: 031a509323010facb690d5cedbc53eb3e318087cbb69439832426b24673efa98
+  metadata.gz: 5c0f4a3e6ec69cd97b7aa3c4a5160d354339e30cdd0f9954dee2866674fdef68
+  data.tar.gz: f5ceb63cd260c16f06fb9b51e6ce843c89f141b9f9ae2ae246cc559e0d41022e
 SHA512:
-  metadata.gz: 8158f6494ea9a691a3c52c236320cfffd6b32986258ab578a87dc708940c800a5f7fde9342187240fb254158d24bed74edf7d39963856c39488ce468f78f898a
-  data.tar.gz: 6d962956bde3f0a320aec11562d584380da45c9c6372a589c1e12cfc5d6361965327624cdfbd6eea08cc6333e7688530095cb91964cce9c8204e2ff2dd3ed611
+  metadata.gz: 1070d3497148bcaf1241ce4b30228c3b6089327194b93c52ec94aff5ccd720af11dc6c10d9fda5d4e9dd868298861aff712345c8104d1d0f3af7a26db9cb3c0c
+  data.tar.gz: ee999d564466cac64f328b95503f1e3161fbd850b1badff30691b99d48baae5e357491b64a0dfb84c134b92a3abff4e5990c6e2b5f5d601c4670adfce7286c9a

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [Unreleased]
+
+## [0.4.0] - 2026-06-30
+
+### Added
+- `rspec-telemetry-compare --by-factory` to combine strategies (create/build)
+  and compare by factory name only. Works together with `--all-depths`.
+- `rspec-telemetry-compare` now prints a `TOTAL` row summing all factories.
+
+### Changed
+- `rspec-telemetry-compare` now reuses `FactoryAggregation` and keys rows by
+  `factory:strategy`, so create and build of the same factory are compared
+  separately.
+
 ## [0.3.0] - 2026-06-25
 
 ### Added
@@ -30,6 +44,8 @@
 
 First public release.
 
-[Unreleased]: https://github.com/takahashim/rspec_telemetry/compare/v0.2.0...HEAD
+[Unreleased]: https://github.com/takahashim/rspec_telemetry/compare/v0.4.0...HEAD
+[0.4.0]: https://github.com/takahashim/rspec_telemetry/compare/v0.3.0...v0.4.0
+[0.3.0]: https://github.com/takahashim/rspec_telemetry/compare/v0.2.0...v0.3.0
 [0.2.0]: https://github.com/takahashim/rspec_telemetry/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/takahashim/rspec_telemetry/releases/tag/v0.1.0

data/README.md

@@ -120,6 +120,10 @@ $ bundle exec rspec-telemetry-compare \
     tmp/rspec_telemetry.after.ndjson
 ```
 
+Factories are grouped by `factory:strategy`, so `user:create` and `user:build`
+are compared separately. Use `--by-factory` to combine strategies and compare by
+factory name only (e.g. one `user` row).
+
 By default, only root factory events (`depth == 0`) are counted, and their
 inclusive `duration_ms` is compared.
 
@@ -131,6 +135,8 @@ counting while showing the actual number and cost of associated factories.
 rspec-telemetry-compare --sort count BEFORE AFTER
 rspec-telemetry-compare --sort factory BEFORE AFTER
 rspec-telemetry-compare --all-depths BEFORE AFTER
+rspec-telemetry-compare --by-factory BEFORE AFTER     # combine create/build
+rspec-telemetry-compare --all-depths --by-factory BEFORE AFTER
 ```
 
 ## TUI viewer: `rspec-telemetry-viewer`

data/lib/rspec_telemetry/compare_cli.rb

@@ -3,6 +3,7 @@
 require "optparse"
 
 require_relative "factory_comparison"
+require_relative "formatting"
 
 module RSpecTelemetry
   class CompareCLI
@@ -10,7 +11,7 @@ module RSpecTelemetry
       @argv = argv
       @out = out
       @err = err
-      @options = {all_depths: false, sort: "duration"}
+      @options = {all_depths: false, by_factory: false, sort: "duration"}
     end
 
     def run
@@ -20,9 +21,13 @@ module RSpecTelemetry
         return 1
       end
 
-      comparison = FactoryComparison.new(paths[0], paths[1], all_depths: @options[:all_depths])
+      comparison = FactoryComparison.new(
+        paths[0], paths[1],
+        all_depths: @options[:all_depths],
+        by_factory: @options[:by_factory]
+      )
       rows = sort_rows(comparison.rows)
-      @out.puts(render(rows, duration_label: comparison.all_depths ? "Self(ms)" : "Total(ms)"))
+      @out.puts(render(rows, duration_label: comparison.duration_label, label_heading: label_heading))
       0
     rescue Errno::ENOENT => e
       @err.puts("File not found: #{e.message}")
@@ -40,6 +45,9 @@ module RSpecTelemetry
         options.on("--all-depths", "Include nested FactoryBot events") do
           @options[:all_depths] = true
         end
+        options.on("--by-factory", "Combine strategies (create/build) per factory") do
+          @options[:by_factory] = true
+        end
         options.on(
           "--sort KEY",
           %w[duration count factory],
@@ -59,17 +67,21 @@ module RSpecTelemetry
     def sort_rows(rows)
       case @options[:sort]
       when "count"
-        rows.sort_by { |row| [-row.count_diff.abs, row.factory] }
+        rows.sort_by { |row| [-row.count_diff.abs, row.label] }
       when "factory"
-        rows.sort_by(&:factory)
+        rows.sort_by(&:label)
       else
-        rows.sort_by { |row| [-row.duration_diff_ms.abs, row.factory] }
+        rows.sort_by { |row| [-row.duration_diff_ms.abs, row.label] }
       end
     end
 
-    def render(rows, duration_label:)
+    def label_heading
+      @options[:by_factory] ? "Factory" : "Factory:Strategy"
+    end
+
+    def render(rows, duration_label:, label_heading:)
       headings = [
-        "Factory",
+        label_heading,
         "Before",
         "After",
         "Diff",
@@ -79,51 +91,61 @@ module RSpecTelemetry
         "Diff(ms)",
         "Change"
       ]
-      body = rows.map do |row|
-        [
-          row.factory,
-          row.before_count.to_s,
-          row.after_count.to_s,
-          signed_integer(row.count_diff),
-          percent(row.count_change_percent),
-          decimal(row.before_duration_ms),
-          decimal(row.after_duration_ms),
-          signed_decimal(row.duration_diff_ms),
-          percent(row.duration_change_percent)
-        ]
-      end
+      body = rows.map { |row| columns_for(row) }
+      total = columns_for(totals_row(rows))
 
       widths = headings.each_index.map do |index|
-        ([headings[index]] + body.map { |columns| columns[index] }).map(&:length).max
+        ([headings[index]] + (body + [total]).map { |columns| columns[index] }).map(&:length).max
       end
 
       lines = []
       lines << format_row(headings, widths)
-      lines << widths.map { |width| "-" * width }.join("-+-")
+      lines << separator(widths)
       body.each { |columns| lines << format_row(columns, widths) }
+      lines << separator(widths)
+      lines << format_row(total, widths)
       lines.join("\n")
     end
 
-    def format_row(columns, widths)
-      columns.each_with_index.map do |value, index|
-        index.zero? ? value.ljust(widths[index]) : value.rjust(widths[index])
-      end.join(" | ")
+    def columns_for(row)
+      [
+        row.label,
+        row.before_count.to_s,
+        row.after_count.to_s,
+        Formatting.signed_integer(row.count_diff),
+        percent(row.count_change_percent),
+        Formatting.fixed(row.before_duration_ms),
+        Formatting.fixed(row.after_duration_ms),
+        Formatting.signed_fixed(row.duration_diff_ms),
+        percent(row.duration_change_percent)
+      ]
     end
 
-    def signed_integer(value)
-      format("%+d", value)
+    # Reuse Row so the total's diff/percent math matches every other line.
+    def totals_row(rows)
+      FactoryComparison::Row.new(
+        label: "TOTAL",
+        before_count: rows.sum(&:before_count),
+        after_count: rows.sum(&:after_count),
+        before_duration_ms: rows.sum(&:before_duration_ms),
+        after_duration_ms: rows.sum(&:after_duration_ms)
+      )
     end
 
-    def decimal(value)
-      format("%.1f", value)
+    def separator(widths)
+      widths.map { |width| "-" * width }.join("-+-")
     end
 
-    def signed_decimal(value)
-      format("%+.1f", value)
+    def format_row(columns, widths)
+      columns.each_with_index.map do |value, index|
+        index.zero? ? value.ljust(widths[index]) : value.rjust(widths[index])
+      end.join(" | ")
     end
 
+    # "-" marks a missing baseline (before count/duration was zero), which is a
+    # table rule rather than number formatting, so it stays here.
     def percent(value)
-      value ? format("%+.1f%%", value) : "-"
+      value ? Formatting.signed_percent(value) : "-"
     end
   end
 end

data/lib/rspec_telemetry/console_report.rb

@@ -1,16 +1,15 @@
 # frozen_string_literal: true
 
+require_relative "formatting"
+
 module RSpecTelemetry
   class ConsoleReport
     module Helpers
       module_function
 
-      def fmt(ms)
-        ms = ms.to_f
-        ms >= 1000 ? format("%.2fs", ms / 1000.0) : format("%.1fms", ms)
-      end
+      def fmt(ms) = Formatting.duration(ms)
 
-      def pct(ratio) = format("%.1f%%", ratio * 100)
+      def pct(ratio) = Formatting.percent(ratio * 100)
 
       def truncate(str, len) = str.length > len ? "#{str[0, len - 1]}…" : str
 

data/lib/rspec_telemetry/factory_comparison.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 require_relative "ndjson"
+require_relative "factory_aggregation"
 
 module RSpecTelemetry
   class FactoryComparison
-    FactoryStat = Struct.new(:count, :duration_ms)
     Row = Struct.new(
-      :factory,
+      :label,
       :before_count,
       :after_count,
       :before_duration_ms,
@@ -38,47 +38,75 @@ module RSpecTelemetry
       end
     end
 
-    attr_reader :before_path, :after_path, :all_depths
+    attr_reader :before_path, :after_path, :all_depths, :by_factory
 
-    def initialize(before_path, after_path, all_depths: false)
+    def initialize(before_path, after_path, all_depths: false, by_factory: false)
       @before_path = before_path
       @after_path = after_path
       @all_depths = all_depths
+      @by_factory = by_factory
+    end
+
+    def duration_label
+      all_depths ? "Self(ms)" : "Total(ms)"
     end
 
     def rows
       before = aggregate(before_path)
       after = aggregate(after_path)
 
-      (before.keys | after.keys).sort.map do |factory|
-        before_stat = before.fetch(factory, empty_stat)
-        after_stat = after.fetch(factory, empty_stat)
+      (before.keys | after.keys).sort.map do |key|
+        before_stat = before[key]
+        after_stat = after[key]
 
         Row.new(
-          factory: factory,
-          before_count: before_stat.count,
-          after_count: after_stat.count,
-          before_duration_ms: before_stat.duration_ms,
-          after_duration_ms: after_stat.duration_ms
+          label: key,
+          before_count: before_stat&.count || 0,
+          after_count: after_stat&.count || 0,
+          before_duration_ms: duration_for(before_stat),
+          after_duration_ms: duration_for(after_stat)
         )
       end
     end
 
     private
 
+    # Reuse the shared accumulator so counts, durations, and the factory:strategy
+    # granularity stay identical to the live summary, CLI report, and viewer.
+    # create and build are kept as separate keys (e.g. "user:create") unless
+    # by_factory rolls every strategy up under the bare factory name.
     def aggregate(path)
-      stats = Hash.new { |hash, factory| hash[factory] = FactoryStat.new(0, 0.0) }
+      acc = FactoryAggregation::Accumulator.new
 
       File.foreach(path) do |line|
         event = Ndjson.parse(line)
         next unless factory_event?(event)
 
-        stat = stats[event["factory"].to_s]
-        stat.count += 1
-        stat.duration_ms += duration_ms(event)
+        acc.add(
+          factory: event["factory"],
+          strategy: event["strategy"],
+          duration_ms: event["duration_ms"],
+          self_duration_ms: event["self_duration_ms"]
+        )
       end
 
-      stats
+      stats = by_factory ? merge_by_factory(acc.stats) : acc.stats
+      stats.to_h { |stat| [stat.key, stat] }
+    end
+
+    # Collapse create/build/etc. into a single row keyed by the factory name.
+    def merge_by_factory(stats)
+      stats.group_by(&:factory).map do |factory, group|
+        FactoryAggregation::Stat.new(
+          key: factory,
+          factory: factory,
+          strategy: nil,
+          count: group.sum(&:count),
+          total_ms: group.sum(&:total_ms),
+          self_total_ms: group.sum(&:self_total_ms),
+          max_ms: group.map(&:max_ms).max
+        )
+      end
     end
 
     def factory_event?(event)
@@ -89,13 +117,12 @@ module RSpecTelemetry
       event["depth"].to_i.zero?
     end
 
-    def duration_ms(event)
-      key = all_depths ? "self_duration_ms" : "duration_ms"
-      event[key].to_f
-    end
+    # Default mode compares inclusive time on root events; --all-depths compares
+    # self time so nested children are not double-counted.
+    def duration_for(stat)
+      return 0.0 unless stat
 
-    def empty_stat
-      FactoryStat.new(0, 0.0)
+      all_depths ? stat.self_total_ms : stat.total_ms
     end
   end
 end

data/lib/rspec_telemetry/formatting.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module RSpecTelemetry
+  # Single source of truth for how telemetry numbers are rendered, so the decimal
+  # places, sign convention, and ms/s threshold stay consistent across the console
+  # report, the comparison table, and the live summary.
+  module Formatting
+    module_function
+
+    # Human-friendly duration: seconds past 1000ms, otherwise milliseconds.
+    def duration(ms)
+      ms = ms.to_f
+      ms >= 1000 ? format("%.2fs", ms / 1000.0) : format("%.1fms", ms)
+    end
+
+    def fixed(value) = format("%.1f", value.to_f)
+
+    def signed_fixed(value) = format("%+.1f", value.to_f)
+
+    def signed_integer(value) = format("%+d", value.to_i)
+
+    def percent(value) = format("%.1f%%", value.to_f)
+
+    def signed_percent(value) = format("%+.1f%%", value.to_f)
+  end
+end

data/lib/rspec_telemetry/recorder.rb

@@ -2,6 +2,8 @@
 
 require "time"
 
+require_relative "summary"
+
 module RSpecTelemetry
   class Recorder
     # FactoryBot notifications read this to attach themselves to the active example.
@@ -43,7 +45,6 @@ module RSpecTelemetry
     def finish
       return unless @started
 
-      SummaryPrinter.print(@summary, @config) if @config.print_summary
       @writer.close
       @started = false
     end

data/lib/rspec_telemetry/summary.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "factory_aggregation"
+require_relative "formatting"
 
 module RSpecTelemetry
   class Summary
@@ -102,10 +103,10 @@ module RSpecTelemetry
       tops.each_with_index do |f, i|
         lines << "#{i + 1}. #{f.key}"
         lines << "   count: #{f.count}"
-        lines << "   self_total: #{round(f.self_total_ms)}ms"
-        lines << "   total: #{round(f.total_ms)}ms"
-        lines << "   avg: #{round(f.avg_ms)}ms"
-        lines << "   max: #{round(f.max_ms)}ms"
+        lines << "   self_total: #{Formatting.fixed(f.self_total_ms)}ms"
+        lines << "   total: #{Formatting.fixed(f.total_ms)}ms"
+        lines << "   avg: #{Formatting.fixed(f.avg_ms)}ms"
+        lines << "   max: #{Formatting.fixed(f.max_ms)}ms"
         lines << ""
       end
 
@@ -119,16 +120,12 @@ module RSpecTelemetry
       lines = ["Slow examples:", ""]
       slow.each_with_index do |e, i|
         lines << "#{i + 1}. #{e.example_id}"
-        lines << "   duration: #{round(e.duration_ms)}ms"
-        lines << "   factory_bot_total: #{round(e.factory_bot_total_ms)}ms (#{e.factory_bot_count} calls)"
+        lines << "   duration: #{Formatting.fixed(e.duration_ms)}ms"
+        lines << "   factory_bot_total: #{Formatting.fixed(e.factory_bot_total_ms)}ms (#{e.factory_bot_count} calls)"
         lines << ""
       end
 
       lines
     end
-
-    def round(value)
-      value.to_f.round(1)
-    end
   end
 end

data/lib/rspec_telemetry/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RSpecTelemetry
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/lib/rspec_telemetry.rb

@@ -32,7 +32,13 @@ module RSpecTelemetry
     end
 
     def finish!
-      @recorder&.finish
+      active = @recorder
+      if active&.started?
+        # Printing the end-of-run summary is a reporting concern owned by the
+        # lifecycle, not by the Recorder (which only records events).
+        SummaryPrinter.print(active.summary, config)
+      end
+      active&.finish
       unsubscribe!
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec_telemetry
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - takahashimm
@@ -63,6 +63,7 @@ files:
 - lib/rspec_telemetry/factory_aggregation.rb
 - lib/rspec_telemetry/factory_comparison.rb
 - lib/rspec_telemetry/formatter.rb
+- lib/rspec_telemetry/formatting.rb
 - lib/rspec_telemetry/ndjson.rb
 - lib/rspec_telemetry/recorder.rb
 - lib/rspec_telemetry/subscribers/factory_bot.rb