rspec 1.2.8 → 1.2.9

data/History.rdoc

@@ -1,4 +1,43 @@
-=== Version 1.2.8 / 2008-07-16
+=== Version 1.2.9 / 2009-10-05
+
+* enhancements
+  * manage backtrace-ignore patterns with Spec::Runner.configure (Martin
+    Emde). Closes #870.
+  * friendly mock argument expectation failure message (Tim Harper). Closes
+    #868.
+  * added double() as alias for stub() and mock()
+  * failure messages for doubles, mocks and stubs use the right name
+  * add let() method to assign memoized attributes (suggestion from Stuart
+    Halloway). Closes #857.
+  * add its method so you can say:
+      describe Array do
+        its(:length) { should == 0 }
+    (Stephen Touset). Closes #833
+  * spec command automatically uses spec/spec.opts if it is present
+    (suggestion from Yehuda Katz)
+  * rspec now adds PROJECT_ROOT/lib and PROJECT_ROOT/spec to the load path
+    * determines PROJECT_ROOT by recursing up until it finds a directory
+      that has a ./spec directory (thanks to Scott Taylor)
+    * supports require 'spec_helper'
+    * supports running specs from the PROJECT_ROOT or any directory
+      below it
+    * closes #733
+  * better handling of determining test names in test/unit/interop mode
+    * Joe Ferris
+    * closes #854
+    
+* bug fixes
+
+  * Fixed problem with colorized output when writing to a file
+    * Corey Ehmke
+    * closes #777
+
+* not really a bug fix or enhancement
+  * temporarily moved heckle feature to features-pending (waiting to see what
+    happens with
+    http://rubyforge.org/tracker/index.php?func=detail&aid=26786&group_id=1513&atid=5921)
+
+=== Version 1.2.8 / 2009-07-16
 
 * enhancements
   * better messages for should[_not] be_nil (Chad Humphries and Rob Sanheim)
@@ -56,7 +95,7 @@
   * add stub_chain method
     * also alias_method :stub, :stub!, so you can stub with less bang
   * added options to example_group_proxy
-    
+
 * bug fixes
 
   * ensure correct handling of ordered message expectations with duplicate

data/Manifest.txt

@@ -23,7 +23,6 @@ examples/failing/partial_mock_example.rb
 examples/failing/pending_example.rb
 examples/failing/predicate_example.rb
 examples/failing/raising_example.rb
-examples/failing/spec_helper.rb
 examples/failing/syntax_error_example.rb
 examples/failing/team_spec.rb
 examples/failing/timeout_behaviour.rb
@@ -50,7 +49,6 @@ examples/passing/predicate_example.rb
 examples/passing/shared_example_group_example.rb
 examples/passing/shared_stack_examples.rb
 examples/passing/simple_matcher_example.rb
-examples/passing/spec_helper.rb
 examples/passing/stack.rb
 examples/passing/stack_spec.rb
 examples/passing/stack_spec_with_nested_example_groups.rb
@@ -60,6 +58,7 @@ examples/ruby1.9.compatibility/access_to_constants_spec.rb
 features/before_and_after_blocks/before_and_after_blocks.feature
 features/command_line/line_number_option.feature
 features/command_line/line_number_option_with_example_with_no_name.feature
+features/example_groups/define_example_attribute.feature
 features/example_groups/example_group_with_should_methods.feature
 features/example_groups/implicit_docstrings.feature
 features/example_groups/nested_groups.feature
@@ -68,15 +67,17 @@ features/expectations/expect_change.feature
 features/expectations/expect_error.feature
 features/extensions/custom_example_group.feature
 features/formatters/custom_formatter.feature
-features/heckle/heckle.feature
 features/interop/examples_and_tests_together.feature
 features/interop/rspec_output.feature
 features/interop/test_but_not_test_unit.feature
 features/interop/test_case_with_should_methods.feature
+features/load_paths/add_lib_to_load_path.feature
+features/load_paths/add_spec_to_load_path.feature
 features/matchers/define_diffable_matcher.feature
 features/matchers/define_matcher.feature
 features/matchers/define_matcher_outside_rspec.feature
 features/matchers/define_matcher_with_fluent_interface.feature
+features/matchers/define_wrapped_matcher.feature
 features/mock_framework_integration/use_flexmock.feature
 features/mock_framework_integration/use_mocha.feature
 features/mock_framework_integration/use_rr.feature
@@ -84,6 +85,7 @@ features/mocks/mix_stubs_and_mocks.feature
 features/mocks/stub_implementation.feature
 features/pending/pending_examples.feature
 features/runner/specify_line_number.feature
+features/spec_helper/spec_helper.feature
 features/step_definitions/running_rspec_steps.rb
 features/subject/explicit_subject.feature
 features/subject/implicit_subject.feature
@@ -164,6 +166,7 @@ lib/spec/mocks/argument_expectation.rb
 lib/spec/mocks/argument_matchers.rb
 lib/spec/mocks/error_generator.rb
 lib/spec/mocks/errors.rb
+lib/spec/mocks/example_methods.rb
 lib/spec/mocks/extensions.rb
 lib/spec/mocks/extensions/object.rb
 lib/spec/mocks/framework.rb
@@ -173,7 +176,6 @@ lib/spec/mocks/mock.rb
 lib/spec/mocks/order_group.rb
 lib/spec/mocks/proxy.rb
 lib/spec/mocks/space.rb
-lib/spec/mocks/spec_methods.rb
 lib/spec/rake/spectask.rb
 lib/spec/rake/verify_rcov.rb
 lib/spec/ruby.rb
@@ -220,7 +222,6 @@ spec/autotest/autotest_matchers.rb
 spec/autotest/discover_spec.rb
 spec/autotest/failed_results_re_spec.rb
 spec/autotest/rspec_spec.rb
-spec/rspec_suite.rb
 spec/ruby_forker.rb
 spec/spec.opts
 spec/spec/dsl/main_spec.rb
@@ -251,6 +252,7 @@ spec/spec/interop/test/unit/resources/spec_with_options_hash.rb
 spec/spec/interop/test/unit/resources/test_case_that_fails.rb
 spec/spec/interop/test/unit/resources/test_case_that_passes.rb
 spec/spec/interop/test/unit/resources/test_case_with_errors.rb
+spec/spec/interop/test/unit/resources/test_case_with_various_names.rb
 spec/spec/interop/test/unit/resources/testsuite_adapter_spec_with_test_unit.rb
 spec/spec/interop/test/unit/spec_spec.rb
 spec/spec/interop/test/unit/test_unit_spec_helper.rb
@@ -283,6 +285,7 @@ spec/spec/matchers/simple_matcher_spec.rb
 spec/spec/matchers/throw_symbol_spec.rb
 spec/spec/mocks/any_number_of_times_spec.rb
 spec/spec/mocks/argument_expectation_spec.rb
+spec/spec/mocks/argument_matchers_spec.rb
 spec/spec/mocks/at_least_spec.rb
 spec/spec/mocks/at_most_spec.rb
 spec/spec/mocks/bug_report_10260_spec.rb
@@ -296,6 +299,7 @@ spec/spec/mocks/bug_report_7805_spec.rb
 spec/spec/mocks/bug_report_8165_spec.rb
 spec/spec/mocks/bug_report_8302_spec.rb
 spec/spec/mocks/bug_report_830_spec.rb
+spec/spec/mocks/double_spec.rb
 spec/spec/mocks/failing_argument_matchers_spec.rb
 spec/spec/mocks/hash_including_matcher_spec.rb
 spec/spec/mocks/hash_not_including_matcher_spec.rb
@@ -332,9 +336,6 @@ spec/spec/runner/formatter/base_formatter_spec.rb
 spec/spec/runner/formatter/base_text_formatter_spec.rb
 spec/spec/runner/formatter/failing_example_groups_formatter_spec.rb
 spec/spec/runner/formatter/failing_examples_formatter_spec.rb
-spec/spec/runner/formatter/html_formatted-1.8.4.html
-spec/spec/runner/formatter/html_formatted-1.8.5-jruby.html
-spec/spec/runner/formatter/html_formatted-1.8.5.html
 spec/spec/runner/formatter/html_formatted-1.8.6-jruby.html
 spec/spec/runner/formatter/html_formatted-1.8.6.html
 spec/spec/runner/formatter/html_formatted-1.8.7.html
@@ -345,7 +346,7 @@ spec/spec/runner/formatter/profile_formatter_spec.rb
 spec/spec/runner/formatter/progress_bar_formatter_spec.rb
 spec/spec/runner/formatter/snippet_extractor_spec.rb
 spec/spec/runner/formatter/specdoc_formatter_spec.rb
-spec/spec/runner/formatter/text_mate_formatted-1.8.4.html
+spec/spec/runner/formatter/text_mate_formatted-1.8.6-jruby.html
 spec/spec/runner/formatter/text_mate_formatted-1.8.6.html
 spec/spec/runner/formatter/text_mate_formatted-1.8.7.html
 spec/spec/runner/formatter/text_mate_formatted-1.9.1.html
@@ -371,6 +372,6 @@ spec/spec/runner/spec.opts
 spec/spec/runner/spec_drb.opts
 spec/spec/runner/spec_spaced.opts
 spec/spec/runner_spec.rb
-spec/spec/spec_classes.rb
 spec/spec_helper.rb
 spec/support/macros.rb
+spec/support/spec_classes.rb

data/Rakefile

@@ -2,24 +2,26 @@
 gem 'hoe', '>=2.0.0'
 require 'hoe'
 
-$:.unshift(File.join(File.dirname(__FILE__), 'lib'))
+$:.unshift 'lib'
 
 require 'spec/version'
 require 'spec/rake/spectask'
+require 'spec/ruby'
 require 'cucumber/rake/task'
 
-Hoe.spec('rspec') do |hoe|
-  hoe.version = Spec::VERSION::STRING
-  hoe.summary = Spec::VERSION::SUMMARY
-  hoe.description = "Behaviour Driven Development for Ruby."
-  hoe.rubyforge_name = 'rspec'
-  hoe.developer('RSpec Development Team', 'rspec-devel@rubyforge.org')
-  hoe.extra_dev_deps = [["cucumber",">= 0.2.2"]]
-  hoe.remote_rdoc_dir = "rspec/#{Spec::VERSION::STRING}"
-  hoe.rspec_options = ['--options', 'spec/spec.opts']
-  hoe.history_file = 'History.rdoc'
-  hoe.readme_file  = 'README.rdoc'
-  hoe.post_install_message = <<-POST_INSTALL_MESSAGE
+Hoe.spec 'rspec' do
+  self.version = Spec::VERSION::STRING
+  self.summary = Spec::VERSION::SUMMARY
+  self.description = "Behaviour Driven Development for Ruby."
+  self.rubyforge_name = 'rspec'
+  self.developer('RSpec Development Team', 'rspec-devel@rubyforge.org')
+  self.extra_dev_deps << ["cucumber",">=0.3"] << ["bmabey-fakefs",">=0.1.1"] << ["syntax",">=1.0"] << ["diff-lcs",">=1.1.2"]
+  self.extra_dev_deps << ["heckle",">=1.4.3"] unless Spec::Ruby.version >= "1.9"
+  self.remote_rdoc_dir = "rspec/#{Spec::VERSION::STRING}"
+  self.rspec_options = ['--options', 'spec/spec.opts']
+  self.history_file = 'History.rdoc'
+  self.readme_file  = 'README.rdoc'
+  self.post_install_message = <<-POST_INSTALL_MESSAGE
 #{'*'*50}
 
   Thank you for installing rspec-#{Spec::VERSION::STRING}
@@ -40,31 +42,54 @@ task :post_blog do
 end
 
 # Some of the tasks are in separate files since they are also part of the website documentation
-load File.dirname(__FILE__) + '/resources/rake/examples.rake'
-load File.dirname(__FILE__) + '/resources/rake/examples_with_rcov.rake'
-load File.dirname(__FILE__) + '/resources/rake/failing_examples_with_html.rake'
-load File.dirname(__FILE__) + '/resources/rake/verify_rcov.rake'
+load 'resources/rake/examples.rake'
+load 'resources/rake/examples_with_rcov.rake'
+load 'resources/rake/failing_examples_with_html.rake'
+load 'resources/rake/verify_rcov.rake'
+
+task :cleanup_rcov_files do
+  rm_rf 'coverage.data'
+end
+
 
 if RUBY_VERSION =~ /^1.8/
-  task :default => [:verify_rcov, :features]
+  task :default => [:cleanup_rcov_files, :features, :verify_rcov]
 else
   task :default => [:spec, :features]
 end
 
 namespace :spec do
+
   desc "Run all specs with rcov"
-  Spec::Rake::SpecTask.new('rcov') do |t|
+  Spec::Rake::SpecTask.new(:rcov) do |t|
     t.spec_files = FileList['spec/**/*_spec.rb']
     t.spec_opts = ['--options', 'spec/spec.opts']
     t.rcov = true
     t.rcov_dir = 'coverage'
-    t.rcov_opts = ['--exclude', "kernel,load-diff-lcs\.rb,instance_exec\.rb,lib/spec.rb,lib/spec/runner.rb,^spec/*,bin/spec,examples,/gems,/Library/Ruby,\.autotest,#{ENV['GEM_HOME']}"]
+    t.rcov_opts = ['--exclude', "features,kernel,load-diff-lcs\.rb,instance_exec\.rb,lib/spec.rb,lib/spec/runner.rb,^spec/*,bin/spec,examples,/gems,/Library/Ruby,\.autotest,#{ENV['GEM_HOME']}"]
+    t.rcov_opts << '--sort coverage --text-summary --aggregate coverage.data'
+  end
+  
+  desc "Run files listed in spec/spec_files.txt"
+  Spec::Rake::SpecTask.new(:focus) do |t|
+    if File.exists?('spec/spec_files.txt')
+      t.spec_files = File.readlines('spec/spec_files.txt').collect{|f| f.chomp}
+    end
   end
 end
 
 desc "Run Cucumber features"
-task :features do
-  sh(RUBY_VERSION =~ /^1.8/ ? "cucumber" : "cucumber --profile no_heckle")
+if RUBY_VERSION =~ /^1.8/
+  Cucumber::Rake::Task.new :features do |t|
+    t.rcov = true
+    t.rcov_opts = ['--exclude', "features,kernel,load-diff-lcs\.rb,instance_exec\.rb,lib/spec.rb,lib/spec/runner.rb,^spec/*,bin/spec,examples,/gems,/Library/Ruby,\.autotest,#{ENV['GEM_HOME']}"]
+    t.rcov_opts << '--no-html --aggregate coverage.data'
+    t.cucumber_opts = %w{--format progress}
+  end
+else
+  task :features do
+    sh 'cucumber --profile no_heckle'
+  end
 end
 
 desc "Run failing examples (see failure output)"

data/Ruby1.9.rdoc

@@ -1,7 +1,6 @@
 = RSpec and Ruby 1.9
 
-Currently, RSpec (core) is mostly compatible with Ruby 1.9.1. There are still
-outstanding issues, some of which we plan to address and some we don't.
+RSpec runs on Ruby 1.9.1 with the following caveats.
 
 == Test::Unit
 

data/Upgrade.rdoc

@@ -1,3 +1,52 @@
+= Upgrade to rspec-1.2.9
+
+== What's new
+
+=== spec/spec.opts
+
+If you have a spec/spec.opts file, the spec command will now use that
+automatically as long as you don't include any options on the command line.
+
+=== let()
+
+Writing specs tends to follow a regular pattern of using local variables, discovering duplication, and then having to convert to local variables to instance variables by adding an "@" symbol. The let() method assigns the result of a lazy eval'd block as the return value of an instance method using
+the same name. This way you can go from this:
+
+    describe Subscription do
+      it "does something" do
+        subscription = Subscription.create :limit => 1
+        subscription...
+      end
+
+      it "does something else" do
+        subscription = Subscription.create :limit => 1
+        subscription...
+      end
+    end
+
+to this:
+
+    describe Subscription do
+      let(:subscription) { Subscription.create :limit => 1 }
+
+      it "does something" do
+        subscription...
+      end
+
+      it "does something else" do
+        subscription...
+      end
+    end
+
+=== its()
+
+If you're in the habit of writing one-liners using implicit subject, this new
+its() feature is for you. Here's the basic idea:
+
+    describe Array do
+      its(:length) { should == 0 }
+    end
+
 = Upgrade to rspec-1.2.3-1.2.7
 
 == What's Changed
@@ -17,11 +66,11 @@ If you're not familiar with this feature, don't worry about it. If you have anyt
 that looks like this:
 
     predicate_matchers[:swim] = :can_swim?
-  
+
 Or this
 
     config.predicate_matchers[:swim] = :can_swim?
-  
+
 Change it to this:
 
     Spec::Matchers.define :swim do
@@ -63,12 +112,12 @@ information.
 
 We'll be separating this out to its own gem for rspec 2.0, but for now, just install
 rspec >= 1.2.1 and add the following to your <tt>test_helper</tt> file:
-  
+
     require 'spec/expectations'
     class Test::Unit::TestCase
       include Spec::Matchers
     end
-    
+
 This will add <tt>should()</tt> and <tt>should_not()</tt> to your objects, make all of
 rspec's built-in matchers available to your tests, INCLUDING rspec's DSL for
 creating matchers (see below, under Upgrade to rspec-1.2.0)
@@ -81,11 +130,11 @@ in your code:
     # some code .....
     debugger
     # some more code ....
-    
+
 ... and using the <tt>--debugger</tt> or <tt>-u</tt> command line option.
 
     spec path/to/file.rb --debugger
-    
+
 = Upgrade to rspec-1.2.0
 
 == What's Changed
@@ -107,7 +156,7 @@ in your code:
 
 * The matcher protocol has been improved. The old protocol is still supported,
   but we added support for two new methods that speak a bit more clearly:
-  
+
     failure_message          => failure_message_for_should
     negative_failure_message => failure_message_for_should_not
 

data/bin/spec

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
-$LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__) + "/../lib"))
+rspec_dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(rspec_dir) unless $LOAD_PATH.include?(rspec_dir)
 require 'spec/autorun'
 exit ::Spec::Runner::CommandLine.run

data/cucumber.yml

@@ -1,3 +1,5 @@
-default: --require features features
+default: --require features features -t ~@wip
 pending: --require features features-pending
 no_heckle: --require features features --exclude heckle
+focus: --require features features -t focus
+wip: --require features features -t @wip

data/examples/failing/README.txt

@@ -1,7 +1,11 @@
 "Why have failing examples?", you might ask.
 
-They allow us to see failure messages. RSpec wants to provide meaningful and helpful failure messages. The failures in this directory not only provide you a way of seeing the failure messages, but they provide RSpec's own specs a way of describing what they should look like and ensuring they stay correct.
+They allow us to see failure messages. RSpec wants to provide meaningful and
+helpful failure messages. The failures in this directory not only provide you
+a way of seeing the failure messages, but they provide RSpec's own specs a way
+of describing what they should look like and ensuring they stay correct.
 
-To see the types of messages you can expect, stand in this directory and run:
+To see the types of messages you can expect, stand in the root directory and
+run:
 
-../bin/spec ./*.rb
+bin/spec examples/failing/*.rb

data/examples/failing/failing_implicit_docstrings_example.rb

@@ -1,5 +1,3 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
 # Run spec w/ -fs to see the output of this file
 
 describe "Failing examples with no descriptions" do

data/examples/failing/mocking_example.rb

@@ -1,5 +1,3 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
 describe "Mocker" do
 
   it "should be able to call mock()" do

data/examples/failing/partial_mock_example.rb

@@ -1,5 +1,3 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
 class MockableClass
   def self.find id
     return :original_return

data/examples/failing/pending_example.rb

@@ -1,5 +1,3 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
 describe "pending example (which is fixed)" do
   it %Q|reports "FIXED ... Expected ... to fail.  No Error was raised."| do
     pending("for some reason") do