rspec-xml 0.0.9 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa4790e15a330a52a75a38666cdcf5e2d97587b9
-  data.tar.gz: acde529945aaa1e92570da8cace1f252ede78683
+  metadata.gz: 8075c76f23702fb1e2ed80385cd102bfc92d507b
+  data.tar.gz: a024df842466d9e389e636ac5649dd3ff4255616
 SHA512:
-  metadata.gz: dc05010c99f90ea3de5ad8db1afe705a34eaa4b92cebd5254479feabbb31f9d0e249acc5136cd3db2db32b8f30e81e25b182de2ec4e77476e11898f007799401
-  data.tar.gz: 6bd9b43cd3e803ea1e14449f578fd79d1faa458219138e6dc540ddb4421ecff9caa2c59c34341d049f2bd871d0998a3aef1d9260adc794e036397cf83e4bf1d8
+  metadata.gz: 60b0ceb4a7c163819531c6043782970a82cd7fcbd57220ecdb4859714538a3641c254c8fe5a2c1cbbebf2a1a6dc4bce3f376591551702f0d2d6c80fe35dc850d
+  data.tar.gz: 64e4b904035974b2aeff3316a2250048f294269518a218c7d56186b38065e72e7679ace9aa22c890e1d8cba3fa0ec64cbebc6e751447e9ecb0b09923ef47e380

data/lib/rspec-xml/version.rb

@@ -1,3 +1,3 @@
 module RSpecXML
-  VERSION = "0.0.9"
+  VERSION = "0.1.0"
 end

data/lib/rspec-xml/xml_matchers/have_xpath/attr_matcher.rb

@@ -12,16 +12,22 @@ module RSpecXML
         end
 
         def matches?(xml)
-          attr.each do |k, v|
-            ::Nokogiri::XML(xml).xpath(xpath).attr(k.to_s).value == v.to_s
+          node = ::Nokogiri::XML(xml).xpath(xpath)
+          !node.empty? && attr.all? do |k, v|
+            attr_value = node.attr(k.to_s)
+            !attr_value.nil? && attr_value.value == v.to_s
           end
         end
 
-        def failure_message_for_should
-          "expected #{xpath} to contain #{attr}"
+        def description
+          "have xpath #{xpath} with attribute: #{attr}"
         end
 
-        def failure_message_for_should_not
+        def failure_message
+          "expected #{xpath} to contain attribute: #{attr}"
+        end
+
+        def failure_message_when_negated
           "expected #{xpath} to not exist with attribute: #{attr}"
         end
 

data/spec/features/have_path.feature

@@ -18,3 +18,13 @@ Feature: "some xml".should have_xpath('//something').with_text('Budweiser').with
     Given the best node contains the attribute Category with value: Alcohol
     When I test for the attribute: "Category" to be "Alcohol" within the best node
     Then the test should pass
+
+  Scenario: the matcher should fail when the node doesn't contains the attribute
+    Given the best node contains the attribute Category with value: Alcohol
+    When I test for the attribute: "Type" to be "Alcohol" within the best node
+    Then the test should fail
+
+  Scenario: the matcher should fail when the node doesn't contains the attribute value
+    Given the best node contains the attribute Category with value: Alcohol
+    When I test for the attribute: "Category" to be "Soft Drink" within the best node
+    Then the test should fail

data/spec/features/steps/have_path_steps.rb

@@ -8,7 +8,7 @@ steps_for :have_path do
   end
 
   step 'I test for the text: :text within the :node_name node' do |text, node_name|
-    @test = lambda { @xml.should have_xpath("//#{node_name}").with_text(text) }
+    @test = lambda { expect(@xml).to have_xpath("//#{node_name}").with_text(text) }
   end
 
   step 'the :node_name node contains the attribute :key with value: :value' do |node_name, key, value|
@@ -16,15 +16,15 @@ steps_for :have_path do
   end
 
   step 'I test for the attribute: :key to be :value within the :node_name node' do |key, value, node_name|
-    @test = lambda { @xml.should have_xpath("//#{node_name}").with_attr({key => value}) }
+    @test = lambda { expect(@xml).to have_xpath("//#{node_name}").with_attr({key => value}) }
   end
 
   step 'the test should pass' do
-    @test.should_not raise_error
+    expect(@test).not_to raise_error
   end
 
   step 'the test should fail' do
-    @test.should raise_error(RSpec::Expectations::ExpectationNotMetError)
+    expect(@test).to raise_error(RSpec::Expectations::ExpectationNotMetError)
   end
 
 end

data/spec/features/steps/within_steps.rb

@@ -13,7 +13,7 @@ steps_for :within do
       within('xml') do
         within('/elem') do
           table.hashes.each do |hash|
-            @xml.should have_xpath("/#{hash["node"]}").with_text(hash["text"])
+            expect(@xml).to have_xpath("/#{hash["node"]}").with_text(hash["text"])
           end
         end
       end
@@ -21,11 +21,11 @@ steps_for :within do
   end
 
   step 'the test should pass' do
-    @test.should_not raise_error
+    expect(@test).not_to raise_error
   end
 
   step 'the test should fail' do
-    @test.should raise_error(RSpec::Expectations::ExpectationNotMetError)
+    expect(@test).to raise_error(RSpec::Expectations::ExpectationNotMetError)
   end
 end
 

data/spec/rspec-xml/xml_matchers/have_xpath/attr_matcher_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe RSpecXML::XMLMatchers::HaveXPath::AttrMatcher do
+  describe '#initialize' do
+    it 'should accept an xpath' do
+      matcher = subject.class.new(:xpath => 'not a real xpath')
+      expect(matcher.send(:xpath)).to eq 'not a real xpath'
+    end
+
+    it 'should accept attr' do
+      matcher = subject.class.new(:attr => {'foo' => 'bar', 'x' => 2})
+      expect(matcher.send(:attr)).to eq({'foo' => 'bar', 'x' => 2})
+    end
+
+  end
+
+  describe '#matches?' do
+    # TODO mock out Nokogiri
+
+    it 'should return true if the supplied xml contains the xpath with supplied attributes' do
+      matcher = subject.class.new(:xpath => '//hi', :attr => {'foo' => 'bar', 'x' => 2})
+      expect(matcher.matches?('<hi foo="bar" x="2"/>')).to be_truthy
+    end
+
+    it 'should return false if the supplied xml contains the xpath but not the one of the attibutes' do
+      matcher = subject.class.new(:xpath => '//hi', :attr => {'foo' => 'bar', 'x' => 2, 'y' => 3})
+      expect(matcher.matches?('<hi foo="bar" x="2"/>')).to be_falsey
+    end
+
+    it 'should return false if the supplied xml contains the xpath but one of the attibutes has a wrong value' do
+      matcher = subject.class.new(:xpath => '//hi', :attr => {'foo' => 'bar', 'x' => 3})
+      expect(matcher.matches?('<hi foo="bar" x="2"/>')).to be_falsey
+    end
+
+    it 'should return false if the supplied xml does not contain the xpath' do
+      matcher = subject.class.new(:xpath => '//hi', :attr => {'foo' => 'bar', 'x' => 2})
+      expect(matcher.matches?('<no></no>')).to be_falsey
+    end
+
+  end
+
+  describe '#failure_message' do
+    it 'should turn a message about the xpath not existing when the supplied text' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.stubs(:attr).returns({'foo' => 'bar', 'x' => 2})
+      expect(subject.failure_message).to eq "expected xpath to contain attribute: {\"foo\"=>\"bar\", \"x\"=>2}"
+    end
+  end
+
+  describe '#failure_message_when_negated' do
+    it 'should turn a message about the xpath existing when it should not' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.stubs(:attr).returns({'foo' => 'bar', 'x' => 2})
+      expect(subject.failure_message_when_negated).to eq "expected xpath to not exist with attribute: {\"foo\"=>\"bar\", \"x\"=>2}"
+    end
+  end
+
+  describe '#description' do
+    it 'should return a message describing the text matcher' do
+      subject.stubs(:xpath).returns('/expr')
+      subject.stubs(:attr).returns({'foo' => 'bar', 'x' => 2})
+      expect(subject.description).to eq "have xpath /expr with attribute: {\"foo\"=>\"bar\", \"x\"=>2}"
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-xml
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Dan Carper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-04 00:00:00.000000000 Z
+date: 2014-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: turnip
@@ -92,6 +92,7 @@ files:
 - spec/features/steps/have_path_steps.rb
 - spec/features/steps/within_steps.rb
 - spec/features/within.feature
+- spec/rspec-xml/xml_matchers/have_xpath/attr_matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath/matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath/text_matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath_matcher_spec.rb
@@ -125,6 +126,7 @@ test_files:
 - spec/features/steps/have_path_steps.rb
 - spec/features/steps/within_steps.rb
 - spec/features/within.feature
+- spec/rspec-xml/xml_matchers/have_xpath/attr_matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath/matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath/text_matcher_spec.rb
 - spec/rspec-xml/xml_matchers/have_xpath_matcher_spec.rb