rspec-xml 0.0.3 → 0.0.4

data/Gemfile

@@ -2,6 +2,5 @@ source "http://rubygems.org"
 
 # bundler doesn't require this from the .gemspec
 # https://github.com/carlhuda/bundler/issues/1041
-gem 'pry'
 
 gemspec

data/lib/rspec-xml/version.rb

@@ -1,3 +1,3 @@
 module RSpecXML
-	VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/rspec-xml/xml_matchers/have_xpath/matcher.rb

@@ -0,0 +1,27 @@
+module RSpecXML
+  module XMLMatchers
+    class HaveXPath
+      private
+
+      class Matcher
+        def initialize(options={})
+          self.xpath = options[:xpath]
+        end
+
+        def matches?(xml)
+          ::Nokogiri::XML(xml).xpath(@xpath).count > 0
+        end
+
+        def failure_message_for_should
+          "expected #{xpath} to exist" 
+        end
+
+        def failure_message_for_should_not
+          "expected #{xpath} to not exist"
+        end
+
+        attr_accessor :xpath
+      end
+    end
+  end
+end

data/lib/rspec-xml/xml_matchers/have_xpath/text_matcher.rb

@@ -0,0 +1,32 @@
+module RSpecXML
+  module XMLMatchers
+    class HaveXPath
+        
+      private
+
+      class TextMatcher
+
+        def initialize(options={})
+          self.xpath = options[:xpath]
+          self.text = options[:text]
+        end
+
+        def matches?(xml)
+          ::Nokogiri::XML(xml).xpath(xpath).text == text
+        end
+
+        def failure_message_for_should
+          "expected #{xpath} to contain #{text}"
+        end
+
+        def failure_message_for_should_not
+          "expected #{xpath} to not exist with text: #{text}"
+        end
+
+        private
+
+        attr_accessor :text, :xpath
+      end
+    end
+  end
+end

data/lib/rspec-xml/xml_matchers/have_xpath.rb

@@ -0,0 +1,33 @@
+module RSpecXML
+  module XMLMatchers
+    class HaveXPath
+        
+      def initialize(xpath)
+        self.matcher = Matcher.new(:xpath => xpath)
+      end 
+
+      def with_text(text)
+        self.matcher = TextMatcher.new(
+          :xpath => matcher.xpath, 
+          :text => text.to_s )
+        self
+      end
+
+      def matches?(xml)
+        matcher.matches?(xml)
+      end
+
+      def failure_message_for_should
+        matcher.failure_message_for_should
+      end
+
+      def failure_message_for_should_not
+        matcher.failure_message_for_should_not
+      end
+
+      private
+
+      attr_accessor :matcher
+    end
+  end
+end

data/lib/rspec-xml/xml_matchers.rb

@@ -1,84 +1,14 @@
-module RSpecXML
-	module XMLMatchers
-		class HaveXPath
-				
-			def initialize(xpath)
-				self.xpath = xpath 
-				@matcher = Matcher.new(:xpath => xpath)
-			end 
-
-			def with_text(text)
-				@matcher = TextMatcher.new(:xpath => xpath, :text => text)
-				self
-			end
-
-			def matches?(xml)
-				@matcher.matches?(xml)
-			end
-
-			def failure_message_for_should
-				@matcher.failure_message_for_should
-			end
-
-			def failure_message_for_should_not
-				@matcher.failure_message_for_should_not
-			end
-
-			private
-
-			attr_accessor :xpath
-
-			class Matcher
-
-				def initialize(options={})
-					self.xpath = options[:xpath]
-				end
-
-				def matches?(xml)
-					::Nokogiri::XML(xml).xpath(@xpath).count > 0
-				end
-
-				def failure_message_for_should
-					"expected #{xpath} to exist" 
-				end
+root =  File.dirname(__FILE__)
+require "#{root}/xml_matchers/have_xpath/matcher"
+require "#{root}/xml_matchers/have_xpath/text_matcher"
+require "#{root}/xml_matchers/have_xpath"
 
-				def failure_message_for_should_not
-					"expected #{xpath} to not exist"
-				end
-
-				private
-
-				attr_accessor :xpath
-
-			end
-
-			class TextMatcher
-
-				def initialize(options)
-					self.xpath = options[:xpath]
-					self.text = options[:text]
-				end
-
-				def matches?(xml)
-					::Nokogiri::XML(xml).xpath(xpath).text == text
-				end
-
-				def failure_message_for_should
-					"expected #{xpath} to contain #{text}"
-				end
-
-				def failure_message_for_should_not
-					"expected #{xpath} to contain #{text}"
-				end
-
-				private
+module RSpecXML
+  module XMLMatchers
 
-				attr_accessor :text, :xpath
-			end
-		end
+    def have_xpath(xpath)
+      HaveXPath.new(xpath)
+    end
 
-		def have_xpath(xpath)
-			HaveXPath.new(xpath)
-		end
-	end
+  end
 end

data/license.txt

@@ -0,0 +1,22 @@
+(The MIT License)
+
+Copyright (c) 2005-2010 The RSpec Development Team
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/readme.md

@@ -2,11 +2,32 @@
 *spec your xml*
 
 ## installation
-```ruby
+```
+# Gemfile
 gem 'rspec-xml'
 ```
 
 ## Usage
+
 ```ruby
+# some_spec.rb
+"<something>else</something>".should have_xpath('/something')
 "<something>else</something>".should have_xpath('/something').with_text('else')
+
+"<something>else</something>".should_not have_xpath('/what')
+"<something>else</something>".should_not have_xpath('/something').with_text('what')
 ```
+
+### Builder
+
+```ruby
+xml = ''
+builder = Builder::XmlMarkup.new(:target => xml)
+builder.instruct!
+
+builder.some_xml do |xml|
+  xml.inner 'stuff'
+end
+
+xml.should have_xpath('//some_xml/inner').with_text('stuff')
+```

data/rspec-xml.gemspec

@@ -17,7 +17,8 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = ["lib"]
 
-	s.add_development_dependency 'turnip'
+  s.add_development_dependency 'turnip'
+  s.add_development_dependency 'mocha'
 
   s.add_runtime_dependency 'rspec'
   s.add_runtime_dependency 'nokogiri'

data/spec/features/have_path.feature

@@ -1,15 +1,14 @@
 Feature: "some xml".should have_xpath('//something').with_text('Budweiser') ---
 
-	Background:
-		Given there is a string of XML
+  Background:
+    Given there is a string of XML
 
-	@wip
-	Scenario: the matcher should pass when the node contains the text
-		Given the best node contains the text: Budweiser
-		When I test for the text: Budweiser within the best node
-		Then the test should pass
-	@wop
-	Scenario: the matcher should fail when the node doesn't contain the text
-		Given the best node contains the text: Budweiser
-		When I test for the text: Miller within the best node
-		Then the test should fail
+  Scenario: the matcher should pass when the node contains the text
+    Given the best node contains the text: Budweiser
+    When I test for the text: Budweiser within the best node
+    Then the test should pass
+
+  Scenario: the matcher should fail when the node doesn't contain the text
+    Given the best node contains the text: Budweiser
+    When I test for the text: Miller within the best node
+    Then the test should fail

data/spec/features/steps/have_path_steps.rb

@@ -1,22 +1,22 @@
 steps_for :have_path do
-	step 'there is a string of XML' do
-		@xml = lambda { |insides| "<xml>#{insides}</xml>" }
-	end
+  step 'there is a string of XML' do
+    @xml = lambda { |insides| "<xml>#{insides}</xml>" }
+  end
 
-	step 'the :node_name node contains the text: :text' do |node_name, text|
-		@xml = @xml.call "<#{node_name}>#{text}</#{node_name}>"
-	end
+  step 'the :node_name node contains the text: :text' do |node_name, text|
+    @xml = @xml.call "<#{node_name}>#{text}</#{node_name}>"
+  end
 
-	step 'I test for the text: :text within the :node_name node' do |text, node_name|
-		@test = lambda { @xml.should have_xpath("//#{node_name}").with_text(text) }
-	end
+  step 'I test for the text: :text within the :node_name node' do |text, node_name|
+    @test = lambda { @xml.should have_xpath("//#{node_name}").with_text(text) }
+  end
 
-	step 'the test should pass' do
-		@test.should_not raise_error(RSpec::Expectations::ExpectationNotMetError)
-	end
+  step 'the test should pass' do
+    @test.should_not raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
 
-	step 'the test should fail' do
-		@test.should raise_error(RSpec::Expectations::ExpectationNotMetError)
-	end
+  step 'the test should fail' do
+    @test.should raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
 
 end

data/spec/rspec-xml/xml_matchers/have_xpath/matcher_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe RSpecXML::XMLMatchers::HaveXPath::Matcher do
+  describe '#initialize' do
+    it 'should accept an xpath' do
+      matcher = subject.class.new(:xpath => 'not a real xpath')
+      matcher.xpath.should == 'not a real xpath'
+    end
+  end
+
+  describe '#matches?' do
+    # TODO mock out Nokogiri
+    
+    it 'should return true if the supplied xml contains the xpath' do
+      matcher = subject.class.new(:xpath => '//hi')
+      matcher.matches?('<hi></hi>').should be_true
+    end
+
+    it 'should return false if the supplied xml contains the xpath' do
+      matcher = subject.class.new(:xpath => '//hi')
+      matcher.matches?('<no></no>').should be_false
+    end
+  end
+
+  describe '#failure_message_for_should' do
+    it 'should turn a message about the xpath not existing when it should' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.failure_message_for_should.should == "expected xpath to exist"
+    end
+  end
+
+  describe '#failure_message_for_should_not' do
+    it 'should turn a message about the xpath existing when it should not' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.failure_message_for_should_not.should == "expected xpath to not exist"
+    end
+  end
+end

data/spec/rspec-xml/xml_matchers/have_xpath/text_matcher_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe RSpecXML::XMLMatchers::HaveXPath::TextMatcher do
+  describe '#initialize' do
+    it 'should accept an xpath' do
+      matcher = subject.class.new(:xpath => 'not a real xpath')
+      matcher.send(:xpath).should == 'not a real xpath'
+    end
+
+    it 'should accept text' do
+      matcher = subject.class.new(:text => 'text')
+      matcher.send(:text).should == 'text'
+    end
+
+  end
+
+  describe '#matches?' do
+    # TODO mock out Nokogiri
+    
+    it 'should return true if the supplied xml contains the xpath with supplied text' do
+      matcher = subject.class.new(:xpath => '//hi', :text => 'hi')
+      matcher.matches?('<hi>hi</hi>').should be_true
+    end
+
+    it 'should return false if the supplied xml contains the xpath but not the text' do
+      matcher = subject.class.new(:xpath => '//hi', :text => 'what')
+      matcher.matches?('<hi></hi>').should be_false
+    end
+
+    it 'should return false if the supplied xml does not contain the xpath' do
+      matcher = subject.class.new(:xpath => '//hi', :text => 'what')
+      matcher.matches?('<no></no>').should be_false
+    end
+
+  end
+
+  describe '#failure_message_for_should' do
+    it 'should turn a message about the xpath not existing when the supplied text' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.stubs(:text).returns('text')
+      subject.failure_message_for_should.should == "expected xpath to contain text"
+    end
+  end
+
+  describe '#failure_message_for_should_not' do
+    it 'should turn a message about the xpath existing when it should not' do
+      subject.stubs(:xpath).returns('xpath')
+      subject.stubs(:text).returns('text')
+      subject.failure_message_for_should_not.should == "expected xpath to not exist with text: text"
+    end
+  end
+
+end

data/spec/rspec-xml/xml_matchers/have_xpath_matcher_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+module Factory
+  def self.xpath_matcher(xpath)
+    RSpecXML::XMLMatchers::HaveXPath.new(xpath)
+  end
+end
+
+describe RSpecXML::XMLMatchers::HaveXPath do
+  describe '#intialize' do
+    it 'should build and save a matcher containing the supplied xpath' do
+      
+      RSpecXML::XMLMatchers::HaveXPath::Matcher.
+        expects(:new).
+        with(:xpath => 'fake xpath').
+        returns(:flag)
+
+      xpath_matcher = Factory.xpath_matcher('fake xpath')
+      xpath_matcher.send(:matcher).should == :flag
+
+    end
+  end
+
+  describe '#with_text' do
+    it 'should build a new text matcher containing supplied xpath and text' do
+
+      RSpecXML::XMLMatchers::HaveXPath::TextMatcher.
+        expects(:new).
+        with(:xpath => 'fake xpath', :text => 'blah').
+        returns(:flag)
+
+      xpath_matcher = Factory.xpath_matcher('fake xpath').with_text('blah')
+      xpath_matcher.send(:matcher).should == :flag
+
+    end
+  end
+
+  describe '#failure_message_for_should' do
+    it 'should delegate to the matcher' do
+      xpath_matcher = Factory.xpath_matcher('whatever')
+      xpath_matcher.stubs(:matcher).
+        returns(stub( :failure_message_for_should => 'woo!' ))
+
+      xpath_matcher.failure_message_for_should.should == 'woo!'
+    end
+  end
+
+  describe '#failure_message_for_should' do
+    it 'should delegate to the matcher' do
+      xpath_matcher = Factory.xpath_matcher('whatever')
+      xpath_matcher.stubs(:matcher).
+        returns(stub( :failure_message_for_should_not => 'woo!' ))
+
+      xpath_matcher.failure_message_for_should_not.should == 'woo!'
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,2 +1,5 @@
 require File.expand_path('../../lib/rspec-xml', __FILE__)
-require 'pry'
+
+RSpec.configure do |config|
+  config.mock_with :mocha
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-xml
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-07 00:00:00.000000000 Z
+date: 2012-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: turnip
@@ -27,6 +27,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -72,12 +88,18 @@ files:
 - lib/rspec-xml.rb
 - lib/rspec-xml/version.rb
 - lib/rspec-xml/xml_matchers.rb
+- lib/rspec-xml/xml_matchers/have_xpath.rb
+- lib/rspec-xml/xml_matchers/have_xpath/matcher.rb
+- lib/rspec-xml/xml_matchers/have_xpath/text_matcher.rb
+- license.txt
 - readme.md
 - rspec-xml.gemspec
 - spec/features/have_path.feature
 - spec/features/steps/have_path_steps.rb
+- spec/rspec-xml/xml_matchers/have_xpath/matcher_spec.rb
+- spec/rspec-xml/xml_matchers/have_xpath/text_matcher_spec.rb
+- spec/rspec-xml/xml_matchers/have_xpath_matcher_spec.rb
 - spec/spec_helper.rb
-- spec/xml_matchers_spec.rb
 homepage: ''
 licenses: []
 post_install_message: 
@@ -105,5 +127,7 @@ summary: Spec your XML
 test_files:
 - spec/features/have_path.feature
 - spec/features/steps/have_path_steps.rb
+- spec/rspec-xml/xml_matchers/have_xpath/matcher_spec.rb
+- spec/rspec-xml/xml_matchers/have_xpath/text_matcher_spec.rb
+- spec/rspec-xml/xml_matchers/have_xpath_matcher_spec.rb
 - spec/spec_helper.rb
-- spec/xml_matchers_spec.rb

data/spec/xml_matchers_spec.rb

@@ -1,32 +0,0 @@
-require 'spec_helper'
-
-describe RSpecXML::XMLMatchers do
-  describe '#have_xpath' do
-		context '#with_text' do
-			it 'should pass if the xpath exists containing the supplied text' do
-				"<node>HAI</node>".should have_xpath('/node').with_text('HAI')
-			end
-
-			it "should fail if the xpath does not exist" do
-				lambda { "<node>HAI</node>".should have_xpath('/ne').with_text('HAI')}.
-					should raise_error(RSpec::Expectations::ExpectationNotMetError)
-			end
-
-			it 'should fail if the xpath does not contain the supplied text' do
-				lambda { "<node>HAI</node>".should have_xpath('/ne').with_text('HI')}.
-					should raise_error(RSpec::Expectations::ExpectationNotMetError)
-			end
-		end
-
-		context 'without specifying text' do
-			it 'should pass if the node exists' do
-				'<node>something</node>'.should have_xpath('/node')
-			end
-
-			it 'should fail if the node does not exist' do
-				lambda { "<node>HAI</node>".should have_xpath('/ne')}.
-					should raise_error(RSpec::Expectations::ExpectationNotMetError)
-			end
-		end
-  end
-end