rspec-webservice_matchers 4.2.0 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd87176a90aab44a6391d401105e413741b50f56
-  data.tar.gz: e5b968adb8506a6c1d53080d97ad5394675112f7
+  metadata.gz: 74cae05a568aaf50d4a5024783e63f569416dde2
+  data.tar.gz: 6ff3a433c3867e935422a9ad9b8d175cc9104299
 SHA512:
-  metadata.gz: c58d717c4f4958d8d9c6974ae3d28115c776063ff6ba318541a9f9c8a1a260f49ace18f351eee60b88996997de803136f403c7003d5bc8a63957b9d52513db82
-  data.tar.gz: a0a3f88037789e31e8d92cbd03456e4c92dff3ae997970b136d64bc444fc821b8f73c73e4132c731bcde2aeb4e77c4d095af0fe5d8317fd9c6f92a00f99b46f8
+  metadata.gz: 63d78bb3502bdcbf84758a7962da667fdba8a83f7732bd4a05d746e8d424ca6c3312bd8f025202aebbc7b7f908494ff1544c9e2c91b3c46c78843a297eccb5fa
+  data.tar.gz: cdb219e308ec0c5402f304e49247bcdfe011fa489e0f48dd013e41388c798cd8c1c2cd201327b50b43e164b39b33debf4ec958d675873ff43afb167ec4947ab5

data/README.md

@@ -28,10 +28,11 @@ These new RSpec matchers:
 
                                | Notes
 -------------------------------|------------------------------------------------
-**be_status**                  | A low-level matcher to explicitly check for a 200, 503, or any other code
 **be_up**                      | Looks for a 200, but will follow up to four redirects
+**be_fast**                    | Checks for Google [PageSpeed](https://developers.google.com/speed/pagespeed/insights/) score >= 90. Requires a [Google website API key](https://developers.google.com/speed/docs/insights/v2/getting-started) in the environment variable `WEBSERVICE_MATCHER_INSIGHTS_KEY`.
+**enforce_https_everywhere**   | Passes if the site will _only_ allow SSL connections. See the [EFF project, HTTPS Everywhere](https://www.eff.org/https-everywhere)
 **have_a_valid_cert**          | Will fail if there's no cert, or it's expired or incorrectly configured
-**enforce_https_everywhere**   | Passes if the site will _only_ allow SSL connections. See the [EFF project, HTTP Everywhere](https://www.eff.org/https-everywhere)
+**be_status**                  | A low-level matcher to explicitly check for a 200, 503, or any other code
 **redirect_permanently_to**    | Checks for 301 and a correct destination URL
 **redirect_temporarily_to**    | Checks for 302 or 307 and a correct destination
 
@@ -47,6 +48,7 @@ require 'rspec/webservice_matchers'
 describe 'My app' do
   context 'www.myapp.com' do
     it { should be_up }
+    it { should be_fast }
     it { should have_a_valid_cert }
   end
 

data/lib/rspec/webservice_matchers/be_fast.rb

@@ -15,8 +15,13 @@ module RSpec
       def self.page_speed_score(url:)
         url_param = CGI.escape(Util.make_url(url))
         key       = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
+        if key.nil?
+          fail 'be_fast requires the WEBSERVICE_MATCHER_INSIGHTS_KEY '\
+               'environment variable to be set to a Google PageSpeed '\
+               'Insights API key.'
+        end
         endpoint  = 'https://www.googleapis.com/pagespeedonline/v2/runPagespeed'
-        api_url = "#{endpoint}?url=#{url_param}&screenshot=false&key=#{key}"
+        api_url   = "#{endpoint}?url=#{url_param}&screenshot=false&key=#{key}"
         BeFast.parse(json: Excon.get(api_url).body)[:score]
       end
 

data/lib/rspec/webservice_matchers/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module WebserviceMatchers
-    VERSION = '4.2.0'
+    VERSION = '4.3.0'
   end
 end

data/spec/rspec/webservice_matchers/page_speed_spec.rb

@@ -19,5 +19,18 @@ describe RSpec::WebserviceMatchers::BeFast do
     it 'performs a Google PageSpeed Insights API query on a slow site' do
       expect('nonstop.qa').not_to be_fast
     end
+
+    it 'raises a friendly error if the api key has not been set' do
+      # Remove the key
+      key = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
+      ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY'] = nil
+
+      expect {
+        expect('nonstop.qa').not_to be_fast
+      }.to raise_error(RuntimeError, /API keyx/)
+
+      # Replace the key
+      ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY'] = key
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-webservice_matchers
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.3.0
 platform: ruby
 authors:
 - Robb Shecter