rspec-sorbet 1.8.3 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d40a0e2d4b22ec8c7a7809fea36e467492bd7c649ac7de5ac3e09130ac7e180
-  data.tar.gz: a39fe8993182ca260861e2d583e68ce9fb332e9557d376210583f33be7042208
+  metadata.gz: 88e13e13b30f81692eee4f6e0733cb8382c177df738040fd973b800976940459
+  data.tar.gz: 9e655229ec0b953a8bd0839d9f28f2be66d9553d5c6854fbe83dcdd323586f7d
 SHA512:
-  metadata.gz: daa20d80ec931a565cdec2dbcd25a72c781a319b0760d5896e0470ad35cd789eb90a8d543aebb01e282fa11f512882c1ccff03832ec7865d18d1627974857a45
-  data.tar.gz: bb6bc7ea8e5f088f73eea5c72498ba4839c3aecc6dc83fb727135d15abdf24cb9ce3454de689fd7f31662e8fc65d0868ad2157c671ff55f23c7aeb5b434583b6
+  metadata.gz: 754248f96d753ca1069284780ff3cabb11700f3f224ab28a3336df5261ed9935371948cd4e40cb992177796a21c7fcb95d0a49d3474db6f33a1a0612f3c3f121
+  data.tar.gz: ad16625d96aa2acd2c3d4fba8b7b8f5bb11988ae6a0fb2075b78b7dd53db7106abba8b3a91a063adb8d4201e412735e39ed4b93db01c7c591bd6aa7cc5e32d26

data/.github/workflows/ci.yml

@@ -1,5 +1,7 @@
 ---
 name: Continuous Integration
+env:
+  SLACK_CHANNEL_ID: C0317P7C9C2
 on:
   push:
     branches-ignore:
@@ -38,9 +40,9 @@ jobs:
         || github.ref == 'refs/heads/stable')
       uses: pullreminders/slack-action@a5a262c896a1cc80dcbae59ba95513e2dfb21439
       env:
-        SLACK_BOT_TOKEN: "${{ secrets.SLACK_BOT_TOKEN }}"
+        SLACK_BOT_TOKEN: "${{ secrets.BELLROY_SLACK_TOKEN }}"
       with:
-        args: '{\"channel\":\"C33574SJJ\",\"text\":\"* ${{ github.repository }} BUILD
+        args: '{\"channel\":\"${{ env.SLACK_CHANNEL_ID }}\",\"text\":\"* ${{ github.repository }} BUILD
           FAILURE*\", \"attachments\": [{ \"fallback\": \"Failure summary\", \"color\":
           \"#ff0000\", \"fields\": [{\"title\": \"Branch\", \"value\":\"${{ steps.extract_branch.outputs.branch
           }}\"}, {\"title\": \"Who broke it\", \"value\":\"${{ github.actor }}\"},

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+1.9.0
+
+* Allow specification of a custom validation handler (thanks [@bmalinconico](https://github.com/bmalinconico))
+
 1.8.3
 
 * Make sorbet a development dependency

data/README.md

@@ -34,3 +34,16 @@ RSpec::Sorbet.allow_doubles!
 ### `eq` matcher usage with `T::Struct`'s
 
 Using the [`eq` matcher](https://www.rubydoc.info/github/rspec/rspec-expectations/RSpec%2FMatchers:eq) to compare [`T::Struct`'s](https://sorbet.org/docs/tstruct) might not behave as you'd expect whereby two separate instances of the same struct class with identical attributes are not `==` out of the box. The standalone [sorbet-struct-comparable](https://github.com/tricycle/sorbet-struct-comparable) gem may be of interest if you are looking for a simple attribute based comparison that will help make the `eq` matcher behave as you expect.
+
+### Specifying a custom validation handler
+
+You can customise the handler of Sorbet validation errors if you so desire.
+
+
+```ruby
+def handler(signature, opts)
+  raise MyCustomException, "The options were #{opts}"
+end
+
+T::Configuration.call_validation_error_handler = handler
+```

data/lib/rspec/sorbet/doubles.rb

@@ -11,6 +11,8 @@ module RSpec
           inline_type_error_handler(error)
         end
 
+        @existing_handler = T::Configuration.instance_variable_get(:@call_validation_error_handler)
+
         T::Configuration.call_validation_error_handler = proc do |signature, opts|
           call_validation_error_handler(signature, opts)
         end
@@ -23,6 +25,13 @@ module RSpec
       INLINE_DOUBLE_REGEX =
         /T.(?:let|cast): Expected type (?:T.(?<t_method>any|nilable|class_of)\()?(?<expected_types>[a-zA-Z0-9:: ,]*)(\))?, got (?:type .* with value )?#<(?<double_type>Instance|Class|Object)?Double([\(]|[ ])(?<doubled_type>[a-zA-Z0-9:: ,]*)(\))?/.freeze
 
+
+      def handle_call_validation_error(signature, opts)
+        raise TypeError, opts[:pretty_message] unless @existing_handler 
+
+        @existing_handler.call(signature, opts)
+      end
+
       def inline_type_error_handler(error)
         case error
         when TypeError
@@ -75,7 +84,7 @@ module RSpec
         message.match?(TYPED_ARRAY_MESSAGE)
       end
 
-      def call_validation_error_handler(_signature, opts)
+      def call_validation_error_handler(signature, opts)
         should_raise = true
 
         message = opts.fetch(:pretty_message, opts.fetch(:message, ''))
@@ -108,7 +117,7 @@ module RSpec
           end
         end
 
-        raise TypeError, opts[:pretty_message] if should_raise
+        handle_call_validation_error(signature, opts) if should_raise
       end
     end
   end

data/lib/rspec/sorbet/version.rb

@@ -3,6 +3,6 @@
 
 module RSpec
   module Sorbet
-    VERSION = '1.8.3'
+    VERSION = '1.9.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-sorbet
 version: !ruby/object:Gem::Version
-  version: 1.8.3
+  version: 1.9.0
 platform: ruby
 authors:
 - Samuel Giles