rspec-search-and-destroy 0.0.2 → 0.0.3

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 rvm:
   - "1.9.3"
-script: cucumber
+script: rake test

data/README.md

@@ -28,6 +28,9 @@ rspec-sad
 
 # If you have a particular ordering that creates issues
 SPEC_OPTIONS="--seed 12345" rspec-sad
+
+# If you have a complicated script
+rspec-sad --rspec-command "/path/to/script"
 ```
 
 # Search and destroy mode

data/Rakefile

@@ -1 +1,11 @@
 require "bundler/gem_tasks"
+
+require "cucumber"
+require "cucumber/rake/task"
+Cucumber::Rake::Task.new(:features)
+
+require "rspec/core/rake_task"
+RSpec::Core::RakeTask.new(:spec)
+
+desc "Run all tests"
+task test: [:features, :spec]

data/bin/rspec-sad

@@ -1,6 +1,5 @@
 #!/usr/bin/env ruby
 
-$LOAD_PATH << "$PWD/../lib/"
 require 'rspec-sad'
 
 require 'rspec-search-and-destroy/binary_chop_example_selector'
@@ -17,9 +16,29 @@ class TTYOutput
   end
 end
 
+require 'optparse'
+
+driver_options = {}
+
+option_parser = OptionParser.new do |opts|
+  opts.banner = <<BANNER
+Find RSpec test order bugs
+
+Usage: #{opts.program_name} [options]
+
+BANNER
+
+  opts.on("--rspec-command COMMAND",
+          "Command to run instead of `rspec`") do |cmd|
+    driver_options[:command] = cmd
+  end
+end
+option_parser.parse!
+
+
 output = TTYOutput.new
 selector = BinaryChopExampleSelector.new
-driver = RSpecDriver.new
+driver = RSpecDriver.new(driver_options)
 
 driver.initial_run
 results = driver.load_run_results

data/features/alternate_command.feature

@@ -0,0 +1,31 @@
+Feature: A command other than `rspec` can be run
+
+Scenario: Run it
+  Given a configured spec/spec_helper.rb
+  And a file named "intermediate_runner.sh" with:
+    """
+    echo 'Running the intermediate script'
+    rspec
+    """
+  And a file named "spec/example_spec.rb" with:
+    """ruby
+    require 'spec_helper'
+
+    describe "Tests that fail when run in a specific order" do
+      it "leaves bad global state" do
+        $global_state = true
+        expect($global_state).to be true
+      end
+
+      it "just takes up space" do
+        expect(true).to be true
+      end
+
+      it "fails when run last" do
+        expect($global_state).to be false
+      end
+    end
+    """
+  When I run `rspec-sad --rspec-command='bash ./intermediate_runner.sh'`
+  Then the output should contain "Running the intermediate script"
+  And the output should contain "Culprit found"

data/features/before_all_blocks_are_disabled.feature

@@ -1,14 +1,7 @@
 Feature: `before(:all)` blocks are disabled when all of the examples are also disabled
 
 Scenario: Run it
-  Given a file named "spec/spec_helper.rb" with:
-    """ruby
-    require 'rspec-sad'
-
-    RSpec.configure do |config|
-      RSpecSearchAndDestroy.configure(config)
-    end
-    """
+  Given a configured spec/spec_helper.rb
   And a file named "spec/before_all_spec.rb" with:
     """ruby
     require 'spec_helper'

data/features/bisecting_a_single_file.feature

@@ -1,14 +1,7 @@
 Feature: Bisecting a single file
 
 Scenario: Run it
-  Given a file named "spec/spec_helper.rb" with:
-    """ruby
-    require 'rspec-sad'
-
-    RSpec.configure do |config|
-      RSpecSearchAndDestroy.configure(config)
-    end
-    """
+  Given a configured spec/spec_helper.rb
   And a file named "spec/single_file_spec.rb" with:
     """ruby
     require 'spec_helper'

data/features/bisecting_multiple_files.feature

@@ -1,14 +1,7 @@
 Feature: Bisecting multiple files
 
 Scenario: Run it
-  Given a file named "spec/spec_helper.rb" with:
-    """ruby
-    require 'rspec-sad'
-
-    RSpec.configure do |config|
-      RSpecSearchAndDestroy.configure(config)
-    end
-    """
+  Given a configured spec/spec_helper.rb
   And a file named "spec/file_1_spec.rb" with:
     """ruby
     require 'spec_helper'

data/features/running_rspec_without_sad.feature

@@ -0,0 +1,10 @@
+Feature: Running RSpec when SAD is configured
+
+Scenario: Run it
+  Given a configured spec/spec_helper.rb
+  And a file named "spec/empty_spec.rb" with:
+    """ruby
+    require 'spec_helper'
+    """
+  When I run `rspec`
+  Then the exit status should be 0

data/features/support/steps.rb

@@ -1,3 +1,15 @@
+Given(/^a configured spec\/spec_helper\.rb$/) do
+  config = <<CONFIG
+require 'rspec-sad'
+
+RSpec.configure do |config|
+  RSpecSearchAndDestroy.configure(config)
+end
+CONFIG
+
+  write_file("spec/spec_helper.rb", config )
+end
+
 Then(/^the output should contain "(.*?)" (\d+) times?$/) do |expected_output, expected_count|
   actual_count = all_output.scan(expected_output).length
   expect(actual_count).to eql expected_count.to_i

data/lib/rspec-search-and-destroy/order_formatter.rb

@@ -3,8 +3,10 @@ require 'rspec/core/formatters/base_formatter'
 module RSpecSearchAndDestroy
   class OrderFormatter < RSpec::Core::Formatters::BaseFormatter
     def stop
-      File.open(filename, 'wb') do |f|
-        Marshal.dump(results, f)
+      if enabled?
+        File.open(filename, 'wb') do |f|
+          Marshal.dump(results, f)
+        end
       end
 
       super
@@ -12,8 +14,12 @@ module RSpecSearchAndDestroy
 
     private
 
+    def enabled?
+      filename
+    end
+
     def filename
-      ENV['RSPEC_SAD_RESULTS'] or raise "No result filename provided"
+      ENV['RSPEC_SAD_RESULTS']
     end
 
     def results

data/lib/rspec-search-and-destroy/rspec_driver.rb

@@ -1,10 +1,17 @@
 require_relative 'rspec_results'
+require 'childprocess'
 
 module RSpecSearchAndDestroy
   class RSpecDriver
     RESULT_FILE = '/tmp/example-results'
     EXAMPLE_FILE = '/tmp/examples-to-run'
 
+    attr_reader :rspec_command
+
+    def initialize(options = {})
+      @rspec_command = options.fetch(:command, 'rspec').split(/\s/)
+    end
+
     def load_run_results
       unless File.exist? RESULT_FILE
         raise <<ERR
@@ -42,15 +49,13 @@ ERR
     private
 
     def run_rspec
-      env = {
-        "RSPEC_SAD_EXAMPLES" => EXAMPLE_FILE,
-        "RSPEC_SAD_RESULTS" => RESULT_FILE
-      }
-      cmd = "rspec"
-
-      success = system(env, cmd)
+      process = ChildProcess.build(*rspec_command)
+      process.io.inherit!
+      process.environment["RSPEC_SAD_EXAMPLES"] = EXAMPLE_FILE
+      process.environment["RSPEC_SAD_RESULTS"] = RESULT_FILE
 
-      raise "unable to run command: #{cmd}" if success.nil?
+      process.start
+      process.wait
     end
   end
 end

data/lib/rspec-search-and-destroy/version.rb

@@ -1,3 +1,3 @@
 module RSpecSearchAndDestroy
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/rspec-search-and-destroy.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
+  gem.add_dependency('childprocess', '~> 0.3')
   gem.add_dependency('rspec', '~> 2.12')
 
   gem.add_development_dependency('rspec', '~> 2.14')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-search-and-destroy
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-01 00:00:00.000000000 Z
+date: 2013-09-08 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: childprocess
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -75,9 +91,11 @@ files:
 - README.md
 - Rakefile
 - bin/rspec-sad
+- features/alternate_command.feature
 - features/before_all_blocks_are_disabled.feature
 - features/bisecting_a_single_file.feature
 - features/bisecting_multiple_files.feature
+- features/running_rspec_without_sad.feature
 - features/support/env.rb
 - features/support/steps.rb
 - lib/rspec-sad.rb
@@ -120,9 +138,11 @@ signing_key:
 specification_version: 3
 summary: Finds RSpec test ordering bugs
 test_files:
+- features/alternate_command.feature
 - features/before_all_blocks_are_disabled.feature
 - features/bisecting_a_single_file.feature
 - features/bisecting_multiple_files.feature
+- features/running_rspec_without_sad.feature
 - features/support/env.rb
 - features/support/steps.rb
 - spec/binary_chop_example_selector_spec.rb