rspec-request_snapshot 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5bffec0454199a549825263f59398d7e9c0f47f
-  data.tar.gz: f1f1bbf6607178b0645c96f2256379d143adedd7
+  metadata.gz: 064a2bd24422bf55dec9a6e2272481a14fbc8819
+  data.tar.gz: ad9e88a9e83e8216135d7b57d6eb7eaefadd00fb
 SHA512:
-  metadata.gz: 10f841bec8937ad4e04ad1717c3ed438a70e9bdf446f17292fb48ecf4c9a41f987b30269b9299a3be9cd4cd610db336c06f34ee6f0192c86b321a5a1e876ee9a
-  data.tar.gz: c969d609dbbf508d04ed51d3c57e72150914c54411ac795b9530cff145f223629d886a56409738001baf1a0e2dc743a323e6e877d2dda2b91460694d760e43cc
+  metadata.gz: 6773e770587d2ad04ea6d3e049d0bca8bcc9663473801aebaeb6da9701df471b8e0f3b2fc0ed83147e449c57d8e3d3a5cf6219f027ba6ac186cf9db6a181c991
+  data.tar.gz: 5676af26f46bf00e36b6f4edfe95b2a5490dc9a1e20cce010ee5ea7f06f2a25be9dedeff5aabf14507274a25aafc2c49327840d270be53abe2380db5007a2de4

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [v0.6.2]
+
+### Fixed
+- Fixed issue where array responses would fail to match snapshots
+
 ## [v0.6.1]
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rspec-request_snapshot (0.6.1)
+    rspec-request_snapshot (0.6.2)
       rspec (~> 3.0)
 
 GEM
@@ -15,15 +15,15 @@ GEM
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
       rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
+    rspec-core (3.8.1)
       rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.3)
+    rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
+    rspec-support (3.8.2)
     simplecov (0.16.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)

data/lib/rspec/request_snapshot/handlers/json.rb

@@ -6,7 +6,7 @@ class Rspec::RequestSnapshot::Handlers::JSON < Rspec::RequestSnapshot::Handlers:
   end
 
   def comparable(str)
-    deep_transform_values(JSON.parse(str).dup)
+    deep_transform_json(JSON.parse(str).dup)
   end
 
   def writable(str)
@@ -15,7 +15,18 @@ class Rspec::RequestSnapshot::Handlers::JSON < Rspec::RequestSnapshot::Handlers:
 
   private
 
-  def deep_transform_values(hash)
+  def deep_transform_json(json)
+    case json
+    when Array
+      deep_transform_array(json)
+    when Hash
+      deep_transform_hash(json)
+    else
+      json
+    end
+  end
+
+  def deep_transform_hash(hash)
     hash.each_key do |key|
       if dynamic_attributes.include?(key)
         handle_dynamic_attribute(hash, key)
@@ -23,22 +34,28 @@ class Rspec::RequestSnapshot::Handlers::JSON < Rspec::RequestSnapshot::Handlers:
       end
 
       if hash[key].is_a?(Hash)
-        deep_transform_values(hash[key])
+        deep_transform_hash(hash[key])
         next
       end
 
-      deep_transform_array(hash, key) if hash[key].is_a?(Array)
+      deep_transform_hash_array(hash, key) if hash[key].is_a?(Array)
     end
   end
 
-  def deep_transform_array(hash, key)
+  def deep_transform_hash_array(hash, key)
     hash[key].each do |value|
-      deep_transform_values(value) if value.is_a?(Hash)
+      deep_transform_hash(value) if value.is_a?(Hash)
     end
 
     sort_elements(hash, key) if ignore_order.include?(key)
   end
 
+  def deep_transform_array(array)
+    array.map do |element|
+      deep_transform_json(element)
+    end
+  end
+
   def sort_elements(hash, key)
     hash[key].first.is_a?(Hash) ? hash[key].sort_by! { |e| e.keys.map { |k| e[k] } } : hash[key].sort_by!(&:to_s)
   end

data/lib/rspec/request_snapshot/version.rb

@@ -3,7 +3,7 @@
 # rubocop:disable Style/ClassAndModuleChildren
 module Rspec
   module RequestSnapshot
-    VERSION = "0.6.1"
+    VERSION = "0.6.2"
   end
 end
 # rubocop:enable Style/ClassAndModuleChildren

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-request_snapshot
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Bruno Campos
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-16 00:00:00.000000000 Z
+date: 2019-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec