rspec-rails 2.11.4 → 2.12.0

data/Capybara.md

@@ -8,7 +8,7 @@ Note that you need to require "capybara/rspec" for this integration to work.
 ## Capybara::DSL
 
 Adds the `visit` and `page` methods, which work together to simulate a
-`get` and provide access to the result (via `page`).
+GET request and provide access to the result (via `page`).
 
 ## Capybara::RSpecMatchers
 
@@ -50,7 +50,7 @@ Capybara::RSpecMatchers is added to examples in:
 Many users have been confused by the co-existence of the the
 Capybara::DSL (visit/page) alongside the rack-test DSL
 (get|post|put|delete|head/response.body) in examples in spec/requests
-and spec/controllers. As of rspec-2.11.1 and capybara-2.0.0.beta2, these
+and spec/controllers. As of rspec-rails-2.11.1 and capybara-2.0.0.beta2, these
 are separated as follows:
 
 * Capybara::DSL is included `spec/features`

data/Changelog.md

@@ -1,3 +1,24 @@
+### 2.12.0 / 2012-11-12
+[full changelog](http://github.com/rspec/rspec-rails/compare/v2.11.4...2.12.0)
+
+Enhancements
+
+* Support validation contexts when using `#errors_on` (Woody Peterson)
+* Include RequestExampleGroup in groups in spec/api
+
+Bug fixes
+
+* Add `should` and `should_not` to `CollectionProxy` (Rails 3.1+) and
+  `AssociationProxy` (Rails 3.0).  (Myron Marston)
+* `controller.controller_path` is set correctly for view specs in Rails 3.1+.
+  (Andy Lindeman)
+* Generated specs support module namespacing (e.g., in a Rails engine).
+  (Andy Lindeman)
+* `render` properly infers the view to be rendered in Rails 3.0 and 3.1
+  (John Firebaugh)
+* AutoTest mappings involving config/ work correctly (Brent J. Nordquist)
+* Failures message for `be_new_record` are more useful (Andy Lindeman)
+
 ### 2.11.4 / 2012-10-14
 [full changelog](http://github.com/rspec/rspec-rails/compare/v2.11.0...v2.11.4)
 
@@ -7,7 +28,7 @@ Capybara-2.0 integration support:
 * include Capybara::DSL and Capybara::RSpecMatchers in spec/features
 
 See [https://github.com/jnicklas/capybara/pull/809](https://github.com/jnicklas/capybara/pull/809)
-and [http://rubydoc.info/gems/rspec-rails/file/CAPYBARA.md](http://rubydoc.info/gems/rspec-rails/file/CAPYBARA.md)
+and [http://rubydoc.info/gems/rspec-rails/file/Capybara.md](http://rubydoc.info/gems/rspec-rails/file/Capybara.md)
 for background.
 
 2.11.1, .2, .3 were yanked due to errant documentation.
@@ -21,6 +42,9 @@ Enhancements
   specs run in random order by default.
 * rename `render_template` to `have_rendered` (and alias to `render_template`
   for backward compatibility)
+* The controller spec generated with `rails generate scaffold namespaced::model`
+  matches the spec generated with `rails generate scaffold namespaced/model`
+  (Kohei Hasegawa)
 
 Bug fixes
 

data/README.md

@@ -112,6 +112,7 @@ intent is to specify one or more request/response cycles from end to end using
 a black box approach.
 
 ```ruby
+require 'spec_helper'
 describe "home page" do
   it "displays the user's username after successful login" do
     user = User.create!(:username => "jdoe", :password => "secret")
@@ -129,9 +130,10 @@ end
 ```
 
 This example uses only standard Rails and RSpec API's, but many RSpec/Rails
-users like to use extension libraries like FactoryGirl and Capybara:
+users like to use extension libraries like [FactoryGirl](https://github.com/thoughtbot/factory_girl) and [Capybara](https://github.com/jnicklas/capybara):
 
 ```ruby
+require 'spec_helper'
 describe "home page" do
   it "displays the user's username after successful login" do
     user = FactoryGirl.create(:user, :username => "jdoe", :password => "secret")
@@ -140,7 +142,7 @@ describe "home page" do
     fill_in "Password", :with => "secret"
     click_button "Log in"
 
-    page.should have_selector(".header .username", :text => "jdoe")
+    expect(page).to have_selector(".header .username", :text => "jdoe")
   end
 end
 ```
@@ -167,13 +169,14 @@ tests.
 ## with fixtures
 
 ```ruby
+require 'spec_helper'
 describe WidgetsController do
   describe "GET index" do
     fixtures :widgets
 
     it "assigns all widgets to @widgets" do
       get :index
-      assigns(:widgets).should eq(Widget.all)
+      expect(assigns(:widgets)).to eq(Widget.all)
     end
   end
 end
@@ -182,12 +185,13 @@ end
 ## with a factory
 
 ```ruby
+require 'spec_helper'
 describe WidgetsController do
   describe "GET index" do
     it "assigns all widgets to @widgets" do
       widget = FactoryGirl.create(:widget)
       get :index
-      assigns(:widgets).should eq([widget])
+      expect(assigns(:widgets)).to eq([widget])
     end
   end
 end
@@ -196,13 +200,14 @@ end
 ## with stubs
 
 ```ruby
+require 'spec_helper'
 describe WidgetsController do
   describe "GET index" do
     it "assigns all widgets to @widgets" do
       widget = stub_model(Widget)
       Widget.stub(:all) { [widget] }
       get :index
-      assigns(:widgets).should eq([widget])
+      expect(assigns(:widgets)).to eq([widget])
     end
   end
 end
@@ -214,10 +219,10 @@ In addition to the stock matchers from rspec-expectations, controller
 specs add these matchers, which delegate to rails' assertions:
 
 ```ruby
-response.should render_template(*args)
+expect(response).to render_template(*args)
 # => delegates to assert_template(*args)
 
-response.should redirect_to(destination)
+expect(response).to redirect_to(destination)
 # => delegates to assert_redirected_to(destination)
 ```
 
@@ -240,6 +245,7 @@ functional tests, you can tell controller groups to render the views in the
 app with the `render_views` declaration:
 
 ```ruby
+require 'spec_helper'
 describe WidgetsController do
   render_views
   # ...
@@ -256,7 +262,7 @@ assigns to the view in the course of an action:
 
 ```ruby
 get :index
-assigns(:widgets).should eq(expected_value)
+expect(assigns(:widgets)).to eq(expected_value)
 ```
 
 # View specs
@@ -264,11 +270,12 @@ assigns(:widgets).should eq(expected_value)
 View specs live in spec/views, and mix in ActionView::TestCase::Behavior.
 
 ```ruby
+require 'spec_helper'
 describe "events/index" do
   it "renders _event partial for each event" do
     assign(:events, [stub_model(Event), stub_model(Event)])
     render
-    view.should render_template(:partial => "_event", :count => 2)
+    expect(view).to render_template(:partial => "_event", :count => 2)
   end
 end
 
@@ -278,7 +285,7 @@ describe "events/show" do
       :location => "Chicago"
     ))
     render
-    rendered.should contain("Chicago")
+    expect(rendered).to include("Chicago")
   end
 end
 ```
@@ -344,7 +351,7 @@ This represents the rendered view.
 
 ```ruby
 render
-rendered.should =~ /Some text expected to appear on the page/
+expect(rendered).to match /Some text expected to appear on the page/
 ```
 
 ### Upgrade note
@@ -357,6 +364,10 @@ response.should xxx
 # rspec-rails-2.x
 render
 rendered.should xxx
+
+# rspec-rails-2.x with expect syntax
+render
+expect(rendered).to xxx
 ```
 
 # Model specs
@@ -364,21 +375,22 @@ rendered.should xxx
 Model specs live in spec/models.
 
 ```ruby
+require 'spec_helper'
 describe Article do
   describe ".recent" do
     it "includes articles published less than one week ago" do
       article = Article.create!(:published_at => Date.today - 1.week + 1.second)
-      Article.recent.should eq([article])
+      expect(Article.recent).to eq([article])
     end
 
     it "excludes articles published at midnight one week ago" do
       article = Article.create!(:published_at => Date.today - 1.week)
-      Article.recent.should be_empty
+      expect(Article.recent).to be_empty
     end
 
     it "excludes articles published more than one week ago" do
       article = Article.create!(:published_at => Date.today - 1.week - 1.second)
-      Article.recent.should be_empty
+      expect(Article.recent).to be_empty
     end
   end
 end
@@ -389,9 +401,10 @@ end
 Routing specs live in spec/routing.
 
 ```ruby
+require 'spec_helper'
 describe "routing to profiles" do
   it "routes /profile/:username to profile#show for username" do
-    { :get => "/profiles/jsmith" }.should route_to(
+    expect(:get => "/profiles/jsmith").to route_to(
       :controller => "profiles",
       :action => "show",
       :username => "jsmith"
@@ -399,7 +412,7 @@ describe "routing to profiles" do
   end
 
   it "does not expose a list of profiles" do
-    { :get => "/profiles" }.should_not be_routable
+    expect(:get => "/profiles").not_to be_routable
   end
 end
 ```
@@ -416,13 +429,14 @@ Provides a `helper` object which mixes in the helper module being spec'd, along
 with `ApplicationHelper` (if present).
 
 ```ruby
+require 'spec_helper'
 describe EventsHelper do
   describe "#link_to_event" do
     it "displays the title, and formatted date" do
       event = Event.new("Ruby Kaigi", Date.new(2010, 8, 27))
       # helper is an instance of ActionView::Base configured with the
       # EventsHelper and all of Rails' built-in helpers
-      helper.link_to_event.should =~ /Ruby Kaigi, 27 Aug, 2010/
+      expect(helper.link_to_event).to match /Ruby Kaigi, 27 Aug, 2010/
     end
   end
 end
@@ -438,7 +452,7 @@ of them simply delegate to Rails' assertions.
 * Primarily intended for controller specs
 
 ```ruby
-object.should be_a_new(Widget)
+expect(object).to be_a_new(Widget)
 ```
 
 
@@ -451,13 +465,13 @@ Passes if the object is a `Widget` and returns true for `new_record?`
 In request and controller specs, apply to the response object:
 
 ```ruby
-response.should render_template("new")
+expect(response).to render_template("new")
 ```
 
 In view specs, apply to the view object:
 
 ```ruby
-view.should render_template(:partial => "_form", :locals => { :widget => widget } )
+expect(view).to render_template(:partial => "_form", :locals => { :widget => widget } )
 ```
 
 ## `redirect_to`
@@ -465,7 +479,7 @@ view.should render_template(:partial => "_form", :locals => { :widget => widget
 * Available in request and controller specs.
 
 ```ruby
-response.should redirect_to(widgets_path)
+expect(response).to redirect_to(widgets_path)
 ```
 
 ## `route_to`
@@ -474,21 +488,43 @@ response.should redirect_to(widgets_path)
 * Available in routing and controller specs.
 
 ```ruby
-{ :get => "/widgets" }.should route_to(:controller => "widgets", :action => "index")
+expect(:get => "/widgets").to route_to(:controller => "widgets", :action => "index")
 ```
 
 ## `be_routable`
 
 Passes if the path is recognized by Rails' routing. This is primarily intended
-to be used with `should_not` to specify routes that should not be routable.
+to be used with `not_to` to specify routes that should not be routable.
 
 ```ruby
-{ :get => "/widgets/1/edit" }.should_not be_routable
+expect(:get => "/widgets/1/edit").not_to be_routable
+```
+
+# `rake` tasks
+
+`rspec-rails` defines rake tasks to run the entire test suite (`rake spec`)
+and subsets of tests (e.g., `rake spec:models`).
+
+A full list of the available rake tasks can be seen by running `rake -T | grep
+rspec`.
+
+## Customizing `rake` tasks
+
+If you want to customize the behavior of `rake spec`, you may [define your own
+task in the `Rakefile` for your
+project](https://www.relishapp.com/rspec/rspec-core/docs/command-line/rake-task).
+However, you must first clear the task that rspec-rails defined:
+
+```ruby
+task("spec").clear
 ```
 
 # Contribute
 
-See [http://github.com/rspec/rspec-dev](http://github.com/rspec/rspec-dev)
+See [http://github.com/rspec/rspec-dev](http://github.com/rspec/rspec-dev).
+
+For `rspec-rails`-specific development information, see
+[DEV-README](https://github.com/rspec/rspec-rails/blob/master/DEV-README.md).
 
 # Also see
 

data/features/controller_specs/anonymous_controller.feature

@@ -21,7 +21,7 @@ Feature: anonymous controller
 
   Scenario: specify error handling in ApplicationController
     Given a file named "spec/controllers/application_controller_spec.rb" with:
-      """
+      """ruby
       require "spec_helper"
 
       class ApplicationController < ActionController::Base
@@ -46,7 +46,7 @@ Feature: anonymous controller
         describe "handling AccessDenied exceptions" do
           it "redirects to the /401.html page" do
             get :index
-            response.should redirect_to("/401.html")
+            expect(response).to redirect_to("/401.html")
           end
         end
       end
@@ -56,7 +56,7 @@ Feature: anonymous controller
 
   Scenario: specify error handling in subclass of ApplicationController
     Given a file named "spec/controllers/application_controller_subclass_spec.rb" with:
-      """
+      """ruby
       require "spec_helper"
 
       class ApplicationController < ActionController::Base
@@ -84,7 +84,7 @@ Feature: anonymous controller
         describe "handling AccessDenied exceptions" do
           it "redirects to the /401.html page" do
             get :index
-            response.should redirect_to("/401.html")
+            expect(response).to redirect_to("/401.html")
           end
         end
       end
@@ -94,7 +94,7 @@ Feature: anonymous controller
 
   Scenario: infer base class from the described class
     Given a file named "spec/controllers/base_class_can_be_inferred_spec.rb" with:
-      """
+      """ruby
       require "spec_helper"
 
       RSpec.configure do |c|
@@ -113,7 +113,7 @@ Feature: anonymous controller
         end
 
         it "creates an anonymous controller derived from ApplicationControllerSubclass" do
-          controller.should be_a_kind_of(ApplicationControllerSubclass)
+          expect(controller).to be_a_kind_of(ApplicationControllerSubclass)
         end
       end
       """
@@ -122,7 +122,7 @@ Feature: anonymous controller
 
   Scenario: invoke around filter in base class
     Given a file named "spec/controllers/application_controller_around_filter_spec.rb" with:
-      """
+      """ruby
       require "spec_helper"
 
       class ApplicationController < ActionController::Base
@@ -144,7 +144,7 @@ Feature: anonymous controller
         it "invokes the callback" do
           get :index
 
-          assigns[:callback_invoked].should be_true
+          expect(assigns[:callback_invoked]).to be_true
         end
       end
       """
@@ -153,7 +153,7 @@ Feature: anonymous controller
 
   Scenario: anonymous controllers only create resource routes
     Given a file named "spec/controllers/application_controller_spec.rb" with:
-    """
+    """ruby
     require "spec_helper"
 
     describe ApplicationController do
@@ -194,36 +194,36 @@ Feature: anonymous controller
       describe "#index" do
         it "responds to GET" do
           get :index
-          response.body.should == "index called"
+          expect(response.body).to eq "index called"
         end
 
         it "also responds to POST" do
           post :index
-          response.body.should == "index called"
+          expect(response.body).to eq "index called"
         end
 
         it "also responds to PUT" do
           put :index
-          response.body.should == "index called"
+          expect(response.body).to eq "index called"
         end
 
         it "also responds to DELETE" do
           delete :index
-          response.body.should == "index called"
+          expect(response.body).to eq "index called"
         end
       end
 
       describe "#create" do
         it "responds to POST" do
           post :create
-          response.body.should == "create called"
+          expect(response.body).to eq "create called"
         end
 
         # And the rest...
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :create)
-            response.body.should == "create called"
+            expect(response.body).to eq "create called"
           end
         end
       end
@@ -231,14 +231,14 @@ Feature: anonymous controller
       describe "#new" do
         it "responds to GET" do
           get :new
-          response.body.should == "new called"
+          expect(response.body).to eq "new called"
         end
 
         # And the rest...
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :new)
-            response.body.should == "new called"
+            expect(response.body).to eq "new called"
           end
         end
       end
@@ -246,7 +246,7 @@ Feature: anonymous controller
       describe "#edit" do
         it "responds to GET" do
           get :edit, :id => "anyid"
-          response.body.should == "edit called"
+          expect(response.body).to eq "edit called"
         end
 
         it "requires the :id parameter" do
@@ -257,7 +257,7 @@ Feature: anonymous controller
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :edit, {:id => "anyid"})
-            response.body.should == "edit called"
+            expect(response.body).to eq "edit called"
           end
         end
       end
@@ -265,7 +265,7 @@ Feature: anonymous controller
       describe "#show" do
         it "responds to GET" do
           get :show, :id => "anyid"
-          response.body.should == "show called"
+          expect(response.body).to eq "show called"
         end
 
         it "requires the :id parameter" do
@@ -276,7 +276,7 @@ Feature: anonymous controller
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :show, {:id => "anyid"})
-            response.body.should == "show called"
+            expect(response.body).to eq "show called"
           end
         end
       end
@@ -284,7 +284,7 @@ Feature: anonymous controller
       describe "#update" do
         it "responds to PUT" do
           put :update, :id => "anyid"
-          response.body.should == "update called"
+          expect(response.body).to eq "update called"
         end
 
         it "requires the :id parameter" do
@@ -295,7 +295,7 @@ Feature: anonymous controller
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :update, {:id => "anyid"})
-            response.body.should == "update called"
+            expect(response.body).to eq "update called"
           end
         end
       end
@@ -303,7 +303,7 @@ Feature: anonymous controller
       describe "#destroy" do
         it "responds to DELETE" do
           delete :destroy, :id => "anyid"
-          response.body.should == "destroy called"
+          expect(response.body).to eq "destroy called"
         end
 
         it "requires the :id parameter" do
@@ -314,7 +314,7 @@ Feature: anonymous controller
         %w{get post put delete}.each do |calltype|
           it "responds to #{calltype}" do
             send(calltype, :destroy, {:id => "anyid"})
-            response.body.should == "destroy called"
+            expect(response.body).to eq "destroy called"
           end
         end
       end