rspec-rabl 1.1.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 53940a4a41092ab090cda50e3b4aa9c7c5e34b60
-  data.tar.gz: 4e50171150a0e9819439e807f8ef3361131b5512
+  metadata.gz: 2811294d13480463ba3441a92c72ce976e17e64a
+  data.tar.gz: bdbd8415e5fb173d4899720b83c1a8b97797fa0a
 SHA512:
-  metadata.gz: 51e74dad39d51f02879c2f4a6cecc438b630971596009f4cee8fc901ff445c01f457595b1b2f7309a842c29318a9f4788c6306be4392f69f650fab355fd009e3
-  data.tar.gz: f5322992ad11e2bd1d567698f9e8d50bea8c5af592698a07b1319a4087502f0586db780600bf24f9829402f80b9b1151bcd7253aec05f784b74477cae761aea3
+  metadata.gz: 451dca70d53640adde76d2eb06fceb233f3edc88bc915594e804dd1db967d34600c709078ff320c75e5f3cc93fd5008370c661ff6a78d572df9ef8893e1467a7
+  data.tar.gz: a3e97e32630e5fa644d46841719c1d31a01c2df0b29108a263daba2c5c160006d46a63dc286d3782de8611d99f00e9975b2176e429212b1fb07ee659e096a04a

data/lib/rspec/rabl/attribute_matcher.rb

@@ -11,12 +11,21 @@ module RSpec
       end
 
       def failure_message
-        "expected #{expected_value.inspect} in #{attribute_path}\n  got #{rendered_value.inspect}"
+        if implicit_nil_value?
+          "nil value when testing.\n expected #{expected_value.inspect} in #{attribute_path}\n  got #{rendered_value.inspect}\n If you want to test for a nil value, please use `with_value(nil)`"
+        else
+          "expected #{expected_value.inspect} in #{attribute_path}\n  got #{rendered_value.inspect}"
+        end
       end
 
       def matches?(subject)
         @subject = subject
-        attribute_rendered? && (!expected_value_set || rendered_value == expected_value)
+        attribute_rendered? && (!expected_value_set || rendered_value == expected_value) && !implicit_nil_value?
+      end
+
+      def implicit_nil_value?
+        return false if expected_value_set
+        rendered_value.nil? || expected_value.nil?
       end
 
       def with(model_attribute)

data/lib/rspec/rabl/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module Rabl
-    VERSION = "1.1.1"
+    VERSION = "2.0.0"
   end
 end

data/spec/functional/matcher_errors_spec.rb

@@ -45,4 +45,23 @@ describe "Error Messages" do
     expect(lines).to include("  expected \"Imma derp derp\" in [\"users\"][\"user\"][\"guid\"]")
     expect(lines).to include("    got \"abc\"")
   end
+
+  it "renders a helpful error message for nil tests" do
+    example = nil
+    group = RSpec.describe "index.rabl" do
+      include_context "user_context"
+      rabl_data(:root => "users", :object_root => "user"){ [user] }
+      example = it "tries to render nil attribute" do 
+        allow(user).to receive(:foo).and_return(nil)
+        expect(subject).to render_attribute(:foo)
+      end
+    end
+    group.run
+    lines = RSpec::Core::Notifications::FailedExampleNotification.new(example).message_lines.join("\n")
+
+    expect(lines).to include("nil value when testing.")
+    expect(lines).to include("  expected nil in [\"users\"][\"user\"][\"foo\"]")
+    expect(lines).to include("  got nil")
+    expect(lines).to include("  If you want to test for a nil value, please use `with_value(nil)`")
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-rabl
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Michael Ries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-21 00:00:00.000000000 Z
+date: 2016-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Provides a more declarative form of view testing for users of rabl