rspec-puppet-facts 1.9.2 → 1.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3cc1e0c2d29c71210af4d52cd12eb0cf9be062dedd4a6eb59f931379acb12b57
-  data.tar.gz: b16313f97d45b158fec32cabf3e69519c28b64739964b9856249c24786f595a3
+  metadata.gz: 643de41b550424eb4cf57cdb3b2c7a68ee9391b80df3eedb29f0896d0b88bd70
+  data.tar.gz: e9db928178faccb9a8825f27a655d33d2488197985211b22ff78b48bdfd4d8bb
 SHA512:
-  metadata.gz: 0b3e3465f50d1a9b2b2043aede40cfdc4345c9bf3c6be392b7c9dd7b898b9f4a6352bfde02c5e74761b737a55cb20af6a60cb781c359d2d0108c959bf18be755
-  data.tar.gz: f5935b8d432442845fa5cd64490cc480ee46ebd341f6be3041f76e20dadc259395d41a28cbcf382531c1a4e27014d850751800afe4a6824f86d41ea773e03615
+  metadata.gz: afe0f40872939558ac3112ac26c1cb2186203174d5a68247d01a8559bb9054b6f8f2f0538359f609149e95b7cac755b21c2823e12e97f86096814846855c6d5d
+  data.tar.gz: a5d72718244ef7dd72d667660e21f7e958c2d5025d2da6818f9dde169e7a8841aa6389a281294da28dfbb0f3fe972f7e6de82db81eaa17b2c048d1b3c59f1ecc

data/.travis.yml

@@ -1,27 +1,29 @@
----
 language: ruby
 sudo: false
 cache: bundler
 script:
-  - bundle exec rake spec
+- bundle exec rake spec
+- bundle exec rake build
 rvm:
-  - 1.8.7
-  - 1.9.3
-  - 2.0.0
-  - 2.1.5
-env:
-  - FACTER_GEM_VERSION="~> 1.6.0"
-  - FACTER_GEM_VERSION="~> 1.7.0"
-  - FACTER_GEM_VERSION="~> 2.0.0"
-  - FACTER_GEM_VERSION="~> 2.1.0"
-  - FACTER_GEM_VERSION="~> 2.2.0"
-  - FACTER_GEM_VERSION="~> 2.3.0"
-  - FACTER_GEM_VERSION="~> 2.4.0"
-  - FACTER_GEM_VERSION="~> 2.0"
+- 2.1
+- 2.2
+- 2.3
+- 2.4
+- 2.5
 matrix:
   fast_finish: true
-  allow_failures:
-    - rvm: 1.8.7
-    - rvm: 1.9.3
+  include:
+    - rvm: 2.6
+      env: COVERAGE=true
 notifications:
   email: false
+deploy:
+  provider: rubygems
+  api_key:
+    secure: EGvtHfBYUSjhZjLPGZHHH7Exsu9xyYSNlbI/F9SNRDmY568tBZs1Pw05Pr9dhUXajs3xXPkHQwMEBgNs2Rg2SPc6+dCyvabbNM2U58yj5R5D7+ZdUWC1APgjiDvBhm0N5hihmAnoBKPlmPKMh91OQwKI/8/GOhWAQaIZRnNBzMQ+gwHQ8xIkqt3unxJ/LtRybFDzTF5aMtIHrfE8kV08BLaKUzJptzj7Wt5Ms1zE/2UV1S7DhSvZnxWaWtNZwaQPo9NFhjHr5k3nLIoWi6Ge3khVSukZcAki9cR37Tjeyms5B10hp6jW5c6EgCDQp5VNcD/1LgtTs8fWI6mvTsa3YCyaQdVy2SvhUD88/CohFvLXbGcdkFFzwhPa57aCKazq14fh5epScRzAfGpJojkPcxdc5/fiuZiaPg+jmT/OMFqNjQW1C6m2S+VltlXVCyjT83Ri9J9/AEu708akErhz7XjcspxJL8//KVvS/3o4hjtoef1OXxRN+oh3VGwbEZSiqOmjxr6/AigaYsrWOTdz+OZa4fGYbUb9hMHnq314cjgGUMyzZ9tQN8v4mMZb1ZKZPuqrP6um1Y7WbHQJvwl3sXEUuDN68eyWp103M1nyma6hON4+F+r58kTuoWRmy06ZsaEjz57bFxdnDjB8It8V7pI0bcmfs/q5tMIPw6Gh14w=
+  gem: rspec-puppet-facts
+  on:
+    tags: true
+    repo: mcanevet/rspec-puppet-facts
+    all_branches: true
+    rvm: 2.6

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+## 2019-07-29 - Release 1.9.5
+- The default version of Facter to search for is now configurable with
+  `RSpec.configuration.default_facter_version`.
+- When passing a `:supported_os` hash to `on_supported_os()`, single
+  `operatingsystemrelease` values can now be specified as a String rather than
+  an Array with a single String.
+- Dependency on the `mcollective-client` gem removed. The `mco_version` fact
+  will now optionally be set if the gem is installed.
+- The fact names can now be provided to tests as Strings instead of Symbols by
+  setting `RSpec.configuration.facterdb_string_keys` to `true`.
+- Dropped support for Ruby < 2.1.0
+
+## 2019-03-22 - Release 1.9.4
+- Take two on getting rubygems autodeploy going. So much for docs,
+    looking at other projects for this one.
+## 2019-03-22 - Release 1.9.3
+- Various CI updates - [Garrett Honeycutt](https://github.com/ghoneycutt/)
+- Symbolize hash keys in `register_custom_fact`
+  [https://github.com/mcanevet/rspec-puppet-facts/pull/77](https://github.com/mcanevet/rspec-puppet-facts/pull/77)
+
 ## 2018-10-24 - Release 1.9.2
 - Catch the right `LoadError` on missing augeas gem. Thanks to [baurmatt](https://github.com/baurmatt) for the quick fix, and [rodjek](https://github.com/rodjek) for dealing with the testing
 

data/Gemfile

@@ -7,9 +7,3 @@ if facterversion = ENV['FACTER_GEM_VERSION']
 else
   gem 'facter', :require => false
 end
-
-platforms :ruby_18, :ruby_19 do
-  gem 'json', '~> 1.0'
-  gem 'json_pure', '~> 1.0'
-  gem 'tins', '~> 1.6.0'
-end

data/README.md

@@ -16,7 +16,7 @@ If you're using Bundler to manage gems in your module repository, install `rspec
 1. Add the following line to your `Gemfile`:
 
 ```ruby
-gem 'rspec-puppet-facts', '~> 1.7', :require => false
+gem 'rspec-puppet-facts', :require => false
 ```
 
 2. Run `bundle install`.
@@ -71,6 +71,19 @@ describe 'myclass::debian' do
 end
 ```
 
+## Specifying a default Facter version
+
+By default, `os_supported_os` will return the facts for the version of Facter
+that it has loaded (usually this is Facter 2.5.1). This behaviour can be
+overridden by setting the `default_facter_version` RSpec setting in your
+`spec/spec_helper.rb` file.
+
+```ruby
+RSpec.configure do |c|
+  c.default_facter_version = '3.14.0'
+end
+```
+
 ## Usage
 
 Use the `on_supported_os` iterator to loop through all of your module's supported operating systems. This allows you to simplify your tests and remove a lot of duplicate code.

data/lib/rspec-puppet-facts.rb

@@ -2,7 +2,11 @@ require 'puppet'
 require 'facter'
 require 'facterdb'
 require 'json'
-require 'mcollective'
+
+RSpec.configure do |c|
+  c.add_setting :default_facter_version, :default => Facter.version
+  c.add_setting :facterdb_string_keys, :default => false
+end
 
 # The purpose of this module is to simplify the Puppet
 # module's RSpec tests by looping through all supported
@@ -31,7 +35,7 @@ module RspecPuppetFacts
     opts[:hardwaremodels] ||= ['x86_64']
     opts[:hardwaremodels] = [opts[:hardwaremodels]] unless opts[:hardwaremodels].is_a? Array
     opts[:supported_os] ||= RspecPuppetFacts.meta_supported_os
-    opts[:facterversion] ||= Facter.version
+    opts[:facterversion] ||= RSpec.configuration.default_facter_version
 
     unless (facterversion = opts[:facterversion]) =~ /\A\d+\.\d+(?:\.\d+)*\z/
       raise ArgumentError, ":facterversion must be in the format 'n.n' or " \
@@ -52,7 +56,7 @@ module RspecPuppetFacts
     filter = []
     opts[:supported_os].map do |os_sup|
       if os_sup['operatingsystemrelease']
-        os_sup['operatingsystemrelease'].map do |operatingsystemmajrelease|
+        Array(os_sup['operatingsystemrelease']).map do |operatingsystemmajrelease|
           opts[:hardwaremodels].each do |hardwaremodel|
 
             os_release_filter = "/^#{operatingsystemmajrelease.split(' ')[0]}/"
@@ -81,7 +85,6 @@ module RspecPuppetFacts
             end
 
             filter << {
-                :facterversion          => facter_version_filter,
                 :operatingsystem        => os_sup['operatingsystem'],
                 :operatingsystemrelease => os_release_filter,
                 :hardwaremodel          => hardwaremodel,
@@ -91,7 +94,6 @@ module RspecPuppetFacts
       else
         opts[:hardwaremodels].each do |hardwaremodel|
           filter << {
-              :facterversion   => facter_version_filter,
               :operatingsystem => os_sup['operatingsystem'],
               :hardwaremodel   => hardwaremodel,
           }
@@ -99,20 +101,39 @@ module RspecPuppetFacts
       end
     end
 
+    # FacterDB may have newer versions of facter data for which it contains a subset of all possible
+    # facter data (see FacterDB 0.5.2 for Facter releases 3.8 and 3.9). In this situation we need to
+    # cycle through and downgrade Facter versions per platform type until we find matching Facter data.
+    filter.each do |filter_spec|
+      facter_version_filter = RspecPuppetFacts.facter_version_to_filter(facterversion)
+      db = FacterDB.get_facts(filter_spec.merge({ :facterversion =>  facter_version_filter }))
+
+      version = facterversion
+      while db.empty? && version !~ /\d+\.0($|\.\d+)/
+        version = RspecPuppetFacts.down_facter_version(version)
+        facter_version_filter = RspecPuppetFacts.facter_version_to_filter(version)
+        db = FacterDB.get_facts(filter_spec.merge({ :facterversion =>  facter_version_filter }))
+      end
+
+      next if db.empty?
+
+      unless version == facterversion
+        if RspecPuppetFacts.spec_facts_strict?
+          raise ArgumentError, "No facts were found in the FacterDB for Facter v#{facterversion}, aborting"
+        else
+          RspecPuppetFacts.warning "No facts were found in the FacterDB for Facter v#{facterversion}, using v#{version} instead"
+        end
+      end
+
+      filter_spec[:facterversion] = facter_version_filter
+    end
+
     received_facts = FacterDB::get_facts(filter)
     unless received_facts.any?
       RspecPuppetFacts.warning "No facts were found in the FacterDB for: #{filter.inspect}"
       return {}
     end
 
-    unless version == facterversion
-      if RspecPuppetFacts.spec_facts_strict?
-        raise ArgumentError, "No facts were found in the FacterDB for Facter v#{facterversion}, aborting"
-      else
-        RspecPuppetFacts.warning "No facts were found in the FacterDB for Facter v#{facterversion}, using v#{version} instead"
-      end
-    end
-
     os_facts_hash = {}
     received_facts.map do |facts|
       # Fix facter bug
@@ -134,9 +155,16 @@ module RspecPuppetFacts
       facts.merge! RspecPuppetFacts.common_facts
       os_facts_hash[os] = RspecPuppetFacts.with_custom_facts(os, facts)
     end
+
+    return stringify_keys(os_facts_hash) if RSpec.configuration.facterdb_string_keys
+
     os_facts_hash
   end
 
+  def stringify_keys(hash)
+    Hash[hash.collect { |k,v| [k.to_s, v.is_a?(Hash) ? stringify_keys(v) : v] }]
+  end
+
   # Register a custom fact that will be included in the facts hash.
   # If it should be limited to a particular OS, pass a :confine option
   # that contains the operating system(s) to confine to.  If it should
@@ -211,12 +239,13 @@ module RspecPuppetFacts
   def self.common_facts
     return @common_facts if @common_facts
     @common_facts = {
-        :mco_version   => MCollective::VERSION,
-        :puppetversion => Puppet.version,
-        :rubysitedir   => RbConfig::CONFIG['sitelibdir'],
-        :rubyversion   => RUBY_VERSION,
+      :puppetversion => Puppet.version,
+      :rubysitedir   => RbConfig::CONFIG['sitelibdir'],
+      :rubyversion   => RUBY_VERSION,
     }
 
+    @common_facts[:mco_version] = MCollective::VERSION if mcollective?
+
     if augeas?
       @common_facts[:augeasversion] = Augeas.open(nil, nil, Augeas::NO_MODL_AUTOLOAD).get('/augeas/version')
     end
@@ -227,6 +256,7 @@ module RspecPuppetFacts
   # Determine if the Augeas gem is available.
   # @api private
   # @return [Boolean] true if the augeas gem could be loaded.
+  # :nocov:
   def self.augeas?
     require 'augeas'
     true
@@ -234,6 +264,19 @@ module RspecPuppetFacts
     RspecPuppetFacts.warning "Failed to retrieve Augeas version: #{e}"
     false
   end
+  # :nocov:
+
+  # Determine if the mcollective gem is available
+  # @api private
+  # @return [Boolean] true if the mcollective gem could be loaded.
+  # :nocov:
+  def self.mcollective?
+    require 'mcollective'
+    true
+  rescue LoadError
+    false
+  end
+  # :nocov:
 
   # Get the "operatingsystem_support" structure from
   # the parsed metadata.json file

data/lib/rspec-puppet-facts/version.rb

@@ -2,6 +2,6 @@ module RspecPuppetFacts
   # This module contains the current version constant
   module Version
     # The current version of this gem
-    STRING = '1.9.2'
+    STRING = '1.9.5'
   end
 end

data/rspec-puppet-facts.gemspec

@@ -1,26 +1,26 @@
 # -*- encoding: utf-8 -*-
-$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
-require "rspec-puppet-facts/version"
+
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+require 'rspec-puppet-facts/version'
 
 Gem::Specification.new do |s|
-  s.name        = "rspec-puppet-facts"
+  s.name        = 'rspec-puppet-facts'
   s.version     = RspecPuppetFacts::Version::STRING
-  s.authors     = ["Mickaël Canévet"]
-  s.email       = ["mickael.canevet@camptocamp.com"]
-  s.homepage    = "http://github.com/mcanevet/rspec-puppet-facts"
-  s.summary     = "Standard facts fixtures for Puppet"
-  s.description = "Contains facts from many Facter version on many Operating Systems"
+  s.authors     = ['Mickaël Canévet']
+  s.email       = ['mickael.canevet@camptocamp.com']
+  s.homepage    = 'http://github.com/mcanevet/rspec-puppet-facts'
+  s.summary     = 'Standard facts fixtures for Puppet'
+  s.description = 'Contains facts from many Facter version on many Operating Systems'
   s.licenses    = 'Apache-2.0'
 
+  # see .travis.yml for the supported ruby versions
+  s.required_ruby_version = '>= 2.1.0'
+
   s.files       = `git ls-files`.split("\n")
   s.test_files  = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
 
-  if RUBY_VERSION =~ /^1\./
-    s.add_development_dependency 'mime-types', '< 3.0'
-  else
-    s.add_development_dependency 'mime-types'
-  end
+  s.add_development_dependency 'mime-types'
   s.add_development_dependency 'coveralls'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
@@ -29,5 +29,4 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'json'
   s.add_runtime_dependency 'facter'
   s.add_runtime_dependency 'facterdb', '>= 0.5.0'
-  s.add_runtime_dependency 'mcollective-client'
 end

data/spec/rspec_puppet_facts_spec.rb

@@ -7,6 +7,48 @@ describe RspecPuppetFacts do
   end
 
   describe '#on_supported_os' do
+    context 'With RSpec.configuration.facterdb_string_keys' do
+      subject(:result) do
+        on_supported_os(
+          {
+            :supported_os => [
+              {
+                "operatingsystem"        => "Debian",
+                "operatingsystemrelease" => ['7'],
+              },
+            ],
+          }
+        )
+      end
+
+      let(:get_keys) do
+        proc { |r| r.keys + r.select { |_,v| v.is_a?(Hash) }.map { |_,v| get_keys.call(v) }.flatten }
+      end
+
+      context 'set to true' do
+        before(:each) do
+          RSpec.configuration.facterdb_string_keys = true
+        end
+
+        after(:each) do
+          RSpec.configuration.facterdb_string_keys = false
+        end
+
+        it 'returns a fact set with all the keys as Strings' do
+          expect(get_keys.call(result['debian-7-x86_64'])).to all(be_a(String))
+        end
+      end
+
+      context 'set to false' do
+        before(:each) do
+          RSpec.configuration.facterdb_string_keys = false
+        end
+
+        it 'returns a fact set with all the keys as Symbols or Strings' do
+          expect(get_keys.call(result['debian-7-x86_64'])).to all(be_a(Symbol).or(be_a(String)))
+        end
+      end
+    end
 
     context 'Without specifying supported_os' do
       subject { on_supported_os }
@@ -142,6 +184,30 @@ describe RspecPuppetFacts do
       end
     end
 
+    context 'When specifying a supported_os with a single release as a String' do
+      subject(:factsets) do
+        on_supported_os(
+          {
+            :supported_os => [
+              { 'operatingsystem' => 'RedHat', 'operatingsystemrelease' => '7' },
+            ]
+          }
+        )
+      end
+
+      it 'returns a Hash' do
+        expect(factsets).to be_a(Hash)
+      end
+
+      it 'returns a single fact set' do
+        expect(factsets.size).to eq(1)
+      end
+
+      it 'returns a fact set for the specified release' do
+        expect(factsets).to include('redhat-7-x86_64' => include(:operatingsystemmajrelease => '7'))
+      end
+    end
+
     context 'When testing Ubuntu' do
       subject {
         on_supported_os(
@@ -161,17 +227,13 @@ describe RspecPuppetFacts do
       }
 
       let(:expected_fact_sets) do
-        if Facter.version.to_f < 1.7
-          ['ubuntu-12.04-x86_64', 'ubuntu-14.04-x86_64']
-        else
-          ['ubuntu-12.04-x86_64', 'ubuntu-14.04-x86_64', 'ubuntu-16.04-x86_64']
-        end
+        ['ubuntu-12.04-x86_64', 'ubuntu-14.04-x86_64', 'ubuntu-16.04-x86_64']
       end
 
       it 'should return a hash' do
         expect(subject.class).to eq Hash
       end
-      it 'should have 4 elements' do
+      it 'should have 3 elements' do
         expect(subject.size).to eq(expected_fact_sets.size)
       end
       it 'should return supported OS' do
@@ -420,17 +482,38 @@ describe RspecPuppetFacts do
         expect(subject.size).to eq 2
       end
       it 'should return supported OS' do
-        expect(subject.keys.sort).to eq %w(
-          archlinux-3-x86_64
-          debian-8-x86_64
-        )
+        expect(subject.keys.sort).to include(a_string_matching(/\Aarchlinux-\d+-x86_64/), 'debian-8-x86_64')
       end
     end
 
     context 'Without a custom facterversion in the options hash' do
+      subject do
+        on_supported_os(
+          supported_os: [
+            { 'operatingsystem' => 'CentOS', 'operatingsystemrelease' => %w[7] }
+          ]
+        )
+      end
+
+      it 'returns facts from the loaded facter version' do
+        facter_version = Facter.version.split('.')
+        is_expected.to match(
+          'centos-7-x86_64' => include(
+            :facterversion => /\A#{facter_version[0]}\.#{facter_version[1]}\./
+          )
+        )
+      end
+    end
+
+    context 'With a default Facter version specified in the RSpec configuration' do
       before(:each) do
-        allow(Facter).to receive(:version).and_return('2.4.5')
+        RSpec.configuration.default_facter_version = '3.1.0'
+      end
+
+      after(:each) do
+        RSpec.configuration.default_facter_version = Facter.version
       end
+
       subject do
         on_supported_os(
           supported_os: [
@@ -439,10 +522,10 @@ describe RspecPuppetFacts do
         )
       end
 
-      it 'returns facts from the loaded facter version' do
+      it 'returns facts from the specified default Facter version' do
         is_expected.to match(
           'centos-7-x86_64' => include(
-            facterversion: /\A2\.4\./
+            :facterversion => /\A3\.1\./
           )
         )
       end
@@ -466,7 +549,7 @@ describe RspecPuppetFacts do
         major, minor = Facter.version.split('.')
         is_expected.to match(
           'centos-7-x86_64' => include(
-            facterversion: /\A#{major}\.[#{minor}#{minor.to_i + 1}]\./
+            :facterversion => /\A#{major}\.[#{minor}#{minor.to_i + 1}]\./
           )
         )
       end
@@ -493,7 +576,7 @@ describe RspecPuppetFacts do
 
       it 'returns facts from a facter version matching 3.1' do
         is_expected.to match(
-          'centos-7-x86_64' => include(facterversion: '3.1.6')
+          'centos-7-x86_64' => include(:facterversion => '3.1.6')
         )
       end
     end
@@ -510,7 +593,7 @@ describe RspecPuppetFacts do
 
       it 'returns facts from a facter version matching 3.1' do
         is_expected.to match(
-          'centos-7-x86_64' => include(facterversion: '3.1.6')
+          'centos-7-x86_64' => include(:facterversion => '3.1.6')
         )
       end
     end
@@ -527,7 +610,7 @@ describe RspecPuppetFacts do
 
       it 'returns facts from a facter version matching 3.3' do
         is_expected.to match(
-          'centos-7-x86_64' => include(facterversion: '3.3.0')
+          'centos-7-x86_64' => include(:facterversion => '3.3.0')
         )
       end
     end
@@ -544,7 +627,7 @@ describe RspecPuppetFacts do
 
       it 'returns facts from a facter version matching 3.3' do
         is_expected.to match(
-          'centos-7-x86_64' => include(facterversion: '3.3.0')
+          'centos-7-x86_64' => include(:facterversion => '3.3.0')
         )
       end
     end
@@ -564,6 +647,36 @@ describe RspecPuppetFacts do
                                               /:facterversion must be in the /)
       end
     end
+
+    context 'Downgrades to a facter version with facts per OS' do
+      subject do
+        on_supported_os(
+          supported_os: [
+            { 'operatingsystem' => 'CentOS', 'operatingsystemrelease' => %w[7] },
+            { 'operatingsystem' => 'OpenSuSE', 'operatingsystemrelease' => %w[42] }
+          ],
+          facterversion: '3.9.5'
+        )
+      end
+
+      before(:each) do
+        allow(FacterDB).to receive(:get_facts).and_call_original
+        allow(FacterDB).to receive(:get_facts).with(
+          a_hash_including(facterversion: "/\\A3\\.9\\./", operatingsystem: 'CentOS')
+        ).and_return([])
+      end
+
+      it 'returns CentOS facts from a facter version matching 3.8' do
+        is_expected.to include(
+          'centos-7-x86_64' => include(:facterversion => '3.8.0')
+        )
+      end
+      it 'returns OpenSuSE facts from a facter version matching 3.9' do
+        is_expected.to include(
+          'opensuse-42-x86_64' => include(:facterversion => '3.9.2')
+        )
+      end
+    end
   end
 
   context '#add_custom_fact' do
@@ -620,7 +733,7 @@ describe RspecPuppetFacts do
     it 'should not add "augeasversion" if Augeas is supported' do
       allow(described_class).to receive(:augeas?).and_return(false)
       RspecPuppetFacts.reset
-      expect(subject.common_facts).not_to include :augeasversion
+      expect(subject.common_facts).not_to include(:augeasversion)
     end
 
     it 'should determine the Augeas version if Augeas is supported' do
@@ -643,6 +756,33 @@ describe RspecPuppetFacts do
     it 'can output a warning message' do
       expect { RspecPuppetFacts.warning('test') }.to output(/test/).to_stderr_from_any_process
     end
+
+    context 'when mcollective is available' do
+      module MCollective_stub
+        VERSION = 'my_version'
+      end
+
+      before(:each) do
+        allow(described_class).to receive(:mcollective?).and_return(true)
+        stub_const('MCollective', MCollective_stub)
+        described_class.reset
+      end
+
+      it 'includes an "mco_version" fact' do
+        expect(subject.common_facts).to include(:mco_version => 'my_version')
+      end
+    end
+
+    context 'when mcollective is not available' do
+      before(:each) do
+        allow(described_class).to receive(:mcollective?).and_return(false)
+        described_class.reset
+      end
+
+      it 'does not include an "mco_version" fact' do
+        expect(subject.common_facts).not_to include(:mco_version)
+      end
+    end
   end
 
   describe '.facter_version_to_filter' do

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
-require 'coveralls'
-Coveralls.wear!
+if ENV['COVERAGE']
+  require 'coveralls'
+  Coveralls.wear!
+end
 
 require 'rspec'
 require 'rspec-puppet-facts'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-puppet-facts
 version: !ruby/object:Gem::Version
-  version: 1.9.2
+  version: 1.9.5
 platform: ruby
 authors:
 - Mickaël Canévet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-24 00:00:00.000000000 Z
+date: 2019-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mime-types
@@ -136,20 +136,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.5.0
-- !ruby/object:Gem::Dependency
-  name: mcollective-client
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Contains facts from many Facter version on many Operating Systems
 email:
 - mickael.canevet@camptocamp.com
@@ -184,7 +170,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -192,8 +178,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Standard facts fixtures for Puppet
-test_files: []
+test_files:
+- spec/fixtures/metadata.json
+- spec/fixtures/metadata.json_with_missing_operatingsystem_support
+- spec/rspec_puppet_facts_spec.rb
+- spec/spec_helper.rb