rspec-puppet-facts 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 785242ffa008d8289d585447477c09447bda5d8b
-  data.tar.gz: 0f112311ebf40c1b3272e6276d1341eb1aa51eec
+  metadata.gz: 601e63e42c9bd47dcfa7a4595770e4b2f75638f1
+  data.tar.gz: 86c454040c79b8dc060e197fa0ca2a810edafaa7
 SHA512:
-  metadata.gz: 017a8282b68844be3988ec6b514bff9311c0fe953474ba8db434a5f83481f6adcf981c1a15b2a87f9bb2855655de9f0eaed03f5cac839dd10808c990682bd644
-  data.tar.gz: e4f609545cfefa58d7b8779c1741f4db8ce8294a08bff965fc0a767895fa715d57f09b61ccb664bd5b78e2697aadc126772350b79a70202e3ac6ed1ab42a72eb
+  metadata.gz: fba02b4a1a05373922f6686bd606e328918f443e528934fd0b056c128d51f01c60a3fdb70c2db309f697cdcbe7a0a538eb8e3e0dee3558940311955977bc01d0
+  data.tar.gz: 62e87c175fd6280657886628b371b457cde4a6452f9558f931db0f83be3ceaecba05340e728f39003246a57e191c927b612ad64e6ad9be5384a86a62dbc7a67c

data/CHANGELOG.md

@@ -1,140 +1,158 @@
-##2017-06-23 - Release 1.8.0
+## 2018-01-31 - Release 1.9.0
+- Bumps facterdb requirement to 0.5.0
+- Adds docs for using custom external facts
+- hardwaremodel output changed on Windows with Facter 3.x
+- Add additional rqspec tests
+- Correctly select windows releases that contain spaces
+- Facter < 3.4 does not return a proper release name for Windows 2016
+- Strip 'Server' prefix from windows release name if present
+- Downcase windows to match facter output
+- Fix specs for current facterdb release
+- Make version fallback testing independent of installed facter gem
+- Add SPEC_FACTS_STRICT setting
+- Cleanup README
+- Add specific test to test minor version ahead of current facter version
+- Update test to check for range in case facter version is not currently in FacterDB
+- Step down through versions if the current version is not available
+- Fix wrong example in README
+
+## 2017-06-23 - Release 1.8.0
 - Support specifying facter version
 
-##2017-01-04 - Release 1.7.1
+## 2017-01-04 - Release 1.7.1
 - Ignore case when choosing H/W models
 
-##2016-09-16 - Release 1.7.0
+## 2016-09-16 - Release 1.7.0
 - Support custom facts defined by spec_helper
 
-##2016-05-19 - Release 1.6.1
+## 2016-05-19 - Release 1.6.1
 - Fix a bug where not all specified Ubuntu or OpenBSD were captured
 
-##2016-05-17 - Release 1.6.0
+## 2016-05-17 - Release 1.6.0
 - Cleanup and refactor methods
 - Add YARD documentation
 - Refactor and fix rspec
 - Add the OS filter support
 
-##2016-03-29 - Release 1.5.0
+## 2016-03-29 - Release 1.5.0
 - Add some Microsft Windows support
 
-##2016-02-04 - Release 1.4.1
+## 2016-02-04 - Release 1.4.1
 - Add missing mcollective-client dependency
 
-##2016-02-04 - Release 1.4.0
+## 2016-02-04 - Release 1.4.0
 - Dynamically set mco_version
 
-##2015-11-12 - Release 1.3.0
+## 2015-11-12 - Release 1.3.0
 - Dynamically set rubysitedir
 
-##2015-11-05 - Release 1.2.0
+## 2015-11-05 - Release 1.2.0
 - Requires facterdb 0.3.0
 
-##2015-09-15 - Release 1.1.1
+## 2015-09-15 - Release 1.1.1
 - Fix OpenBSD support
 
-##2015-09-09 - Release 1.1.0
+## 2015-09-09 - Release 1.1.0
 - Populate augeasversion, puppetversion and rubyversion
 
-##2015-09-03 - Release 1.0.3
+## 2015-09-03 - Release 1.0.3
 - Fix FreeBSD support
 
-##2015-08-31 - Release 1.0.2
+## 2015-08-31 - Release 1.0.2
 - Keys where not symbolized anymore since v1.0.0
 
-##2015-08-29 - Release 1.0.1
+## 2015-08-29 - Release 1.0.1
 - Fix for old versions of Facter that does not provide operatingsystemmajrelease for some OSes
 
-##2015-08-27 - Release 1.0.0
+## 2015-08-27 - Release 1.0.0
 - Use facterdb
 
-##2015-08-10 - Release 0.12.0
+## 2015-08-10 - Release 0.12.0
 - Add Facter3 support
 
-##2015-06-16 - Release 0.11.0
+## 2015-06-16 - Release 0.11.0
 - Add facts for OpenBSD 5.7
 
-##2015-05-27 - Release 0.10.0
+## 2015-05-27 - Release 0.10.0
 - Add facts for Solaris 11
 
-##2015-05-26 - Release 0.9.0
+## 2015-05-26 - Release 0.9.0
 - Add facts for Ubuntu 14.10
 - Add facts for Ubuntu 15.04
 
-##2015-04-27 - Release 0.8.0
+## 2015-04-27 - Release 0.8.0
 - Remove support for Operating System minor release (causes problems with Ubuntu naming)
 - Add Gentoo support
 
-##2015-04-26 - Release 0.7.0
+## 2015-04-26 - Release 0.7.0
 - Add support for Operating System minor release
 - Update README.md
 
-##2015-03-06 - Release 0.6.0
+## 2015-03-06 - Release 0.6.0
 - Add facts for FreeBSD 9
 
-##2015-03-06 - Release 0.5.0
+## 2015-03-06 - Release 0.5.0
 - Add facts for FreeBSD 10
 
-##2015-02-22 - Release 0.4.1
+## 2015-02-22 - Release 0.4.1
 - Really useless release :-)
 
-##2015-01-23 - Release 0.4.0
+## 2015-01-23 - Release 0.4.0
 - Add facts for facter 2.4
 - Format json with python's json.tool
 - Improve code coverage in unit tests
 - Test on more version of facter in travis matrix
 
-##2015-01-05 - Release 0.3.3
+## 2015-01-05 - Release 0.3.3
 - Add facts for OpenSuse 12
 - Add facts for OpenSuse 13
 
-##2015-01-04 - Release 0.3.2
+## 2015-01-04 - Release 0.3.2
 * Symbolize hash keys
 
-##2015-01-03 - Release 0.3.1
+## 2015-01-03 - Release 0.3.1
 - Set fqdn to foo.example.com
 - Add json as runtime dependency
 
-##2015-01-02 - Release 0.3.0
+## 2015-01-02 - Release 0.3.0
 - Use json output for facter
 
-##2014-12-20 - Release 0.2.5
+## 2014-12-20 - Release 0.2.5
 - Don't fail if facts not found
 
-##2014-12-20 - Release 0.2.4
+## 2014-12-20 - Release 0.2.4
 - Add facts for SLES 11
 - Add facts for Ubuntu 10.04
 - Fix for SLES 11 SP1
 
-##2014-12-20 - Release 0.2.3
+## 2014-12-20 - Release 0.2.3
 - Add facts for ArchLinux
 
-##2014-12-19 - Release 0.2.2
+## 2014-12-19 - Release 0.2.2
 - Fix some bugs
 - Add unit tests
 
-##2014-12-19 - Release 0.2.1
+## 2014-12-19 - Release 0.2.1
 - Add facts for Debian 8
 
-##2014-12-15 - Release 0.2.0
+## 2014-12-15 - Release 0.2.0
 - Add opts hash parameter
 - Tests only with x86_64 by default
 
-##2014-12-12 - Release 0.1.4
+## 2014-12-12 - Release 0.1.4
 - Fix for Ubuntu
 
-##2014-12-12 - Release 0.1.4
+## 2014-12-12 - Release 0.1.4
 - Fix for Fedora
 
-##2014-12-12 - Release 0.1.3
+## 2014-12-12 - Release 0.1.3
 - Add facts for Fedora 19
 
-##2014-12-12 - Release 0.1.2
+## 2014-12-12 - Release 0.1.2
 - Add facts for Scientific Linux
 
-##2014-12-12 - Release 0.1.1
+## 2014-12-12 - Release 0.1.1
 - Add more facts
 
-##2014-12-12 - First Release 0.1.0
+## 2014-12-12 - First Release 0.1.0
 - Initial release

data/README.md

@@ -65,6 +65,7 @@ describe 'myclass::debian' do
   }
 
   on_supported_os(test_on).each do |os, facts|
+    let (:facts) { facts }
     it { is_expected.to compile.with_all_deps }
   end
 end
@@ -218,7 +219,7 @@ end
 
 ### Testing a function
 
-As with testing manifests, types, or providers, `on_supported_os` iteration simplifies your function unit tests. 
+As with testing manifests, types, or providers, `on_supported_os` iteration simplifies your function unit tests.
 
 **Specifying each operating system**:
 
@@ -274,7 +275,7 @@ describe 'myfunction' do
 end
 ```
 
-### Adding custom fact values 
+### Adding custom fact values
 
 By adding custom fact values, you can:
 
@@ -351,11 +352,75 @@ In addition to the static fact values shown in the previous examples, you can cr
 To do this, pass a lambda as the value for the custom fact. The lambda is passed the same values for operating system name and fact values that your tests are provided by `on_supported_os`.
 
 ```ruby
-add_custom_fact :root_home, lambda { |os,facts| "/tmp/#{facts['hostname']" }
+add_custom_fact :root_home, lambda { |os,facts| "/tmp/#{facts['hostname']}" }
 ```
 
-Running your tests
-------------------
+### Suppling Custom External Facts through FacterDB
+Rspec-puppet-facts uses a gem called facterdb that contains many fact sets of various combinations that are pre generated.  Rspec-puppet-facts queries
+facterdb to pull out a specific fact set to use when testing. 
+
+The default facts are great for many things but there will be times when you need to have custom
+fact sets that only make sense in your environment or might contain sensitive information.
+
+To supply external facts to facterdb just set the `FACTERDB_SEARCH_PATHS` environment variable with one or more
+paths to your facts.
+
+When separating paths please use the default path separator character supported by your OS.  
+* Unix/Linux/OSX = `:` 
+* Windows = `;`
+
+This means you will need to supply your own fact sets in addition to the ones contained in facterdb.
+So each fact set you create must meet the following requirements:
+
+1. A JSON serialized file containing a single Hash of all the facts.
+2. The facts file must end in `.facts`
+3. Must be placed inside some directory.  You can organize this directory however you like.
+
+[Example file](https://github.com/camptocamp/facterdb/blob/master/facts/3.5/oraclelinux-5-i386.facts)
+
+Facterdb is smart enough the search your supplied directories for files ending with '.facts'.  You can even supply
+multiple directories.
+
+Example:
+
+`FACTERDB_SEARCH_PATHS="/var/opt/lib/custom_facts"`
+
+or
+
+`FACTERDB_SEARCH_PATHS="/var/opt/lib/custom_facts:/tmp/custom_facts:/home/user1/custom_facts"`
+
+
+You can create these files via many methods.
+
+* `puppet facts | jq '.values' > /tmp/custom_facts/datacenter_a/2.4/os_x.facts`  # must have jq command
+* Via puppetdb queries
+* hand crafted
+
+
+Additionally you can skip the default FacterDB facts completely by setting the environment variable `FACTERDB_SKIP_DEFAULTDB`.
+This will instruct facterdb to not look at its built-in facts which can be useful should you need to completely replace which facts are used.
+
+
+Setting the variable `FACTERDB_SKIP_DEFAULTDB` to anything will disable the internal facts used by facterdb.  You would most likely use this in combination
+with the `FACTERDB_SEARCH_PATHS` environment variable.
+
+Example:
+
+```
+FACTERDB_SEARCH_PATHS="/var/opt/lib/custom_facts:/tmp/custom_facts:/home/user1/custom_facts"
+FACTERDB_SKIP_DEFAULTDB='yes'
+```
+
+We recommend placing custom external facts under spec/fixtures/facts directory.
+
+Additionally, if you plan on using these custom facts everytime you should set the following in your spec helper.
+
+```ruby
+module_spec_dir = File.dirname(__FILE__)
+custom_facts = File.join(module_spec_dir, 'fixtures', 'facts')
+ENV['FACTERDB_SEARCH_PATHS'] = custom_facts
+```
+## Running your tests
 
 For most cases, there is no change to how you run your tests. Running `rake spec` will run all the tests against the facts for all the supported operating systems.
 
@@ -364,3 +429,5 @@ If you want to run the tests against the facts for specific operating systems, y
 ```bash
 SPEC_FACTS_OS='ubuntu-14' rake spec
 ```
+
+When no facts are available for the specific facter/operating system combination, the library will fall back to facts from earlier versions of the requested operating system, to allow testing to continue when new versions of facter are released. Set `SPEC_FACTS_STRICT=yes` to instead trigger a failure.

data/Rakefile

@@ -5,3 +5,10 @@ begin
     YARD::Rake::YardocTask.new
 rescue LoadError
 end
+
+desc 'Produce Commit history since last tag'
+task :dump_commit do
+  last_tag = `git describe --tags $(git rev-list --tags --max-count=1)`.chomp
+  puts "############ Commits since #{last_tag} ######"
+  puts `git log --pretty=format:"- %s" #{last_tag}..HEAD`
+end

data/lib/rspec-puppet-facts.rb

@@ -39,6 +39,15 @@ module RspecPuppetFacts
     end
 
     facter_version_filter = RspecPuppetFacts.facter_version_to_filter(facterversion)
+    db = FacterDB.get_facts({ :facterversion =>  facter_version_filter })
+
+    version = facterversion
+    while db.empty? && version !~ /\d+\.0\.\d+/
+      version = RspecPuppetFacts.down_facter_version(version)
+      facter_version_filter = RspecPuppetFacts.facter_version_to_filter(version)
+      db = FacterDB.get_facts({ :facterversion =>  facter_version_filter})
+    end
+
 
     filter = []
     opts[:supported_os].map do |os_sup|
@@ -46,18 +55,28 @@ module RspecPuppetFacts
         os_sup['operatingsystemrelease'].map do |operatingsystemmajrelease|
           opts[:hardwaremodels].each do |hardwaremodel|
 
+            os_release_filter = "/^#{operatingsystemmajrelease.split(' ')[0]}/"
             if os_sup['operatingsystem'] =~ /BSD/i
               hardwaremodel = 'amd64'
             elsif os_sup['operatingsystem'] =~ /Solaris/i
               hardwaremodel = 'i86pc'
             elsif os_sup['operatingsystem'] =~ /Windows/i
-              hardwaremodel = 'x64'
+              hardwaremodel = version =~ /^[12]\./ ? 'x64' : 'x86_64'
+              os_sup['operatingsystem'] = os_sup['operatingsystem'].downcase
+              operatingsystemmajrelease = operatingsystemmajrelease[/\A(?:Server )?(.+)/i, 1]
+
+              # force quoting because windows releases can contain spaces
+              os_release_filter = "\"#{operatingsystemmajrelease}\""
+
+              if operatingsystemmajrelease == '2016' && Puppet::Util::Package.versioncmp(version, '3.4') < 0
+                os_release_filter = '/^10\\.0\\./'
+              end
             end
 
             filter << {
                 :facterversion          => facter_version_filter,
                 :operatingsystem        => os_sup['operatingsystem'],
-                :operatingsystemrelease => "/^#{operatingsystemmajrelease.split(' ')[0]}/",
+                :operatingsystemrelease => os_release_filter,
                 :hardwaremodel          => hardwaremodel,
             }
           end
@@ -79,6 +98,14 @@ module RspecPuppetFacts
       return {}
     end
 
+    unless version == facterversion
+      if RspecPuppetFacts.spec_facts_strict?
+        raise ArgumentError, "No facts were found in the FacterDB for Facter v#{facterversion}, aborting"
+      else
+        RspecPuppetFacts.warning "No facts were found in the FacterDB for Facter v#{facterversion}, using v#{version} instead"
+      end
+    end
+
     os_facts_hash = {}
     received_facts.map do |facts|
       # Fix facter bug
@@ -86,6 +113,8 @@ module RspecPuppetFacts
         operatingsystemmajrelease = facts[:operatingsystemrelease].split('.')[0..1].join('.')
       elsif facts[:operatingsystem] == 'OpenBSD'
         operatingsystemmajrelease = facts[:operatingsystemrelease]
+      elsif facts[:operatingsystem] == 'windows' && facts[:operatingsystemrelease].start_with?('10.0.')
+        operatingsystemmajrelease = '2016'
       else
         if facts[:operatingsystemmajrelease].nil?
           operatingsystemmajrelease = facts[:operatingsystemrelease].split('.')[0]
@@ -161,6 +190,13 @@ module RspecPuppetFacts
     ENV['SPEC_FACTS_OS']
   end
 
+  # If SPEC_FACTS_STRICT is set to `yes`, RspecPuppetFacts will error on missing FacterDB entries, instead of warning & skipping the tests, or using an older facter version.
+  # @return [Boolean]
+  # @api private
+  def self.spec_facts_strict?
+    ENV['SPEC_FACTS_STRICT'] == 'yes'
+  end
+
   # These facts are common for all OS'es and will be
   # added to the facts retrieved from the FacterDB
   # @api private
@@ -238,4 +274,15 @@ module RspecPuppetFacts
     major, minor = version.split('.')
     "/\\A#{major}\\.#{minor}\\./"
   end
+  # Subtracts from the minor version passed and returns a string representing
+  # the next minor version down
+  # @return [String] next version below
+  # @param version [String] the Facter version
+  # @param minor_subtractor [int] the value which to subtract by
+  # @api private
+  def self.down_facter_version(version, minor_subtractor = 1)
+      major, minor, z = version.split('.')
+      minor = (minor.to_i - minor_subtractor).to_s
+      "#{major}.#{minor}.#{z}"
+  end
 end

data/lib/rspec-puppet-facts/version.rb

@@ -2,6 +2,6 @@ module RspecPuppetFacts
   # This module contains the current version constant
   module Version
     # The current version of this gem
-    STRING = '1.8.0'
+    STRING = '1.9.0'
   end
 end

data/rspec-puppet-facts.gemspec

@@ -28,6 +28,6 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'puppet'
   s.add_runtime_dependency 'json'
   s.add_runtime_dependency 'facter'
-  s.add_runtime_dependency 'facterdb', '>= 0.3.0'
+  s.add_runtime_dependency 'facterdb', '>= 0.5.0'
   s.add_runtime_dependency 'mcollective-client'
 end

data/spec/fixtures/metadata.json

@@ -15,8 +15,8 @@
     {
       "operatingsystem": "Debian",
       "operatingsystemrelease": [
-        "6",
-        "7"
+        "7",
+        "8"
       ]
     },
     {

data/spec/rspec_puppet_facts_spec.rb

@@ -47,8 +47,8 @@ describe RspecPuppetFacts do
 
           it 'should return supported OS' do
             expect(subject.keys.sort).to eq %w(
-              debian-6-x86_64
               debian-7-x86_64
+              debian-8-x86_64
               redhat-5-x86_64
               redhat-6-x86_64
               redhat-7-x86_64
@@ -100,8 +100,8 @@ describe RspecPuppetFacts do
               {
                 "operatingsystem" => "Debian",
                 "operatingsystemrelease" => [
-                  "6",
-                  "7"
+                  "7",
+                  "8",
                 ]
               },
               {
@@ -126,8 +126,8 @@ describe RspecPuppetFacts do
 
       it 'should return supported OS' do
         expect(subject.keys.sort).to eq %w(
-          debian-6-x86_64
           debian-7-x86_64
+          debian-8-x86_64
           redhat-5-x86_64
           redhat-6-x86_64
         )
@@ -150,29 +150,32 @@ describe RspecPuppetFacts do
               {
                 "operatingsystem" => "Ubuntu",
                 "operatingsystemrelease" => [
+                  "12.04",
                   "14.04",
-                  "14.10",
-                  "15.04",
-                  "15.10",
+                  "16.04",
                 ],
               },
             ],
           }
         )
       }
+
+      let(:expected_fact_sets) do
+        if Facter.version.to_f < 1.7
+          ['ubuntu-12.04-x86_64', 'ubuntu-14.04-x86_64']
+        else
+          ['ubuntu-12.04-x86_64', 'ubuntu-14.04-x86_64', 'ubuntu-16.04-x86_64']
+        end
+      end
+
       it 'should return a hash' do
         expect(subject.class).to eq Hash
       end
       it 'should have 4 elements' do
-        expect(subject.size).to eq 4
+        expect(subject.size).to eq(expected_fact_sets.size)
       end
       it 'should return supported OS' do
-        expect(subject.keys.sort).to eq [
-          'ubuntu-14.04-x86_64',
-          'ubuntu-14.10-x86_64',
-          'ubuntu-15.04-x86_64',
-          'ubuntu-15.10-x86_64',
-        ]
+        expect(subject.keys.sort).to eq(expected_fact_sets)
       end
     end
 
@@ -188,6 +191,7 @@ describe RspecPuppetFacts do
                 ],
               },
             ],
+            :facterversion => '2.4',
           }
         )
       }
@@ -216,6 +220,7 @@ describe RspecPuppetFacts do
                 ],
               },
             ],
+            :facterversion => '2.4',
           }
         )
       }
@@ -260,31 +265,50 @@ describe RspecPuppetFacts do
       end
     end
 
-    context 'When testing Windows 7', :if => Facter.version.to_f >= 2.4 do
-      subject {
+    context 'When testing Windows', :if => Facter.version.to_f >= 2.4 do
+      subject do
         on_supported_os(
           {
             :supported_os => [
               {
-                "operatingsystem" => "windows",
-                "operatingsystemrelease" => [
-                  "7",
-                ],
-              },
+                'operatingsystem'        => 'Windows',
+                'operatingsystemrelease' => release,
+              }
             ],
           }
         )
-      }
-      it 'should return a hash' do
-        expect(subject.class).to eq Hash
       end
-      it 'should have 1 elements' do
-        expect(subject.size).to eq 1
+
+      context 'with a standard release' do
+        let(:release) { ['7'] }
+
+        it { is_expected.to be_a(Hash) }
+        it { is_expected.to have_attributes(:size => 1) }
+        it { is_expected.to include('windows-7-x64' => an_instance_of(Hash)) }
       end
-      it 'should return supported OS' do
-        expect(subject.keys.sort).to eq [
-          'windows-7-x64',
-        ]
+
+      context 'with a revision release' do
+        let(:release) { ['2012 R2'] }
+
+        it { is_expected.to be_a(Hash) }
+        it { is_expected.to have_attributes(:size => 1) }
+        it { is_expected.to include('windows-2012 R2-x64' => an_instance_of(Hash)) }
+      end
+
+      context 'with a Server prefixed release' do
+        let(:release) { ['Server 2012'] }
+
+        it { is_expected.to be_a(Hash) }
+        it { is_expected.to have_attributes(:size => 1) }
+        it { is_expected.to include('windows-2012-x64' => an_instance_of(Hash)) }
+      end
+
+      context 'with a 2016 release' do
+        let(:release) { ['2016'] }
+
+        it { is_expected.to be_a(Hash) }
+        it { is_expected.to have_attributes(:size => 1) }
+        it { is_expected.to include('windows-2016-x64' => an_instance_of(Hash)) }
       end
     end
 
@@ -352,7 +376,8 @@ describe RspecPuppetFacts do
               {
                 "operatingsystem" => "Archlinux",
               },
-            ]
+            ],
+            :facterversion => '2.4',
           }
         )
       }
@@ -372,6 +397,9 @@ describe RspecPuppetFacts do
     end
 
     context 'Without a custom facterversion in the options hash' do
+      before(:each) do
+        allow(Facter).to receive(:version).and_return('2.4.5')
+      end
       subject do
         on_supported_os(
           supported_os: [
@@ -381,13 +409,45 @@ describe RspecPuppetFacts do
       end
 
       it 'returns facts from the loaded facter version' do
+        is_expected.to match(
+          'centos-7-x86_64' => include(
+            facterversion: /\A2\.4\./
+          )
+        )
+      end
+    end
+
+    context 'With a version that is above the current gem' do
+      before(:each) do
+        allow(Facter).to receive(:version).and_return('2.4.5')
+      end
+
+      subject do
+        on_supported_os(
+          supported_os: [
+            { 'operatingsystem' => 'CentOS', 'operatingsystemrelease' => %w[7] }
+          ],
+          facterversion: "2.6"
+        )
+      end
+
+      it 'returns facts from a facter version matching future and below' do
         major, minor = Facter.version.split('.')
         is_expected.to match(
           'centos-7-x86_64' => include(
-            facterversion: /\A#{major}\.#{minor}\./
+            facterversion: /\A#{major}\.[#{minor}#{minor.to_i + 1}]\./
           )
         )
       end
+
+      context 'With SPEC_FACTS_STRICT set to `yes`' do
+        before(:each) do
+          allow(RspecPuppetFacts).to receive(:spec_facts_strict?).and_return(true)
+        end
+        it 'errors' do
+          expect { subject }.to raise_error ArgumentError, /No facts were found in the FacterDB.*aborting/
+        end
+      end
     end
 
     context 'With a custom facterversion (3.1) in the options hash' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-puppet-facts
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Mickaël Canévet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-23 00:00:00.000000000 Z
+date: 2018-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mime-types
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: mcollective-client
   requirement: !ruby/object:Gem::Requirement
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.2.2
 signing_key: 
 specification_version: 4
 summary: Standard facts fixtures for Puppet