rspec-puppet-facts 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ebd9e64a0bba7f5e7381949dc436ef5ae4da1543
-  data.tar.gz: 23c1a430c563890b36834ce7ab399fe8692082c8
+  metadata.gz: 854e99fe14fb999a75972ef8514595b06ff02ec6
+  data.tar.gz: 74aff87a118d7f8d93786acf2d6d26f2d5f8aefc
 SHA512:
-  metadata.gz: 424b45f45292cf9a60f8e015814263e64ea71328c97f07b0696d1876d8fde4698e8df5d560000a268ca3a29fc8b2181433160dc7c603950aabb31646a2d30aaa
-  data.tar.gz: c7d7b91798b60e2f6c5715b1ae7644513162561e77c172616b28d9a4bc1be42bcd73968f6b42a0628bdb04cba0f0208efd06c99b8f0190b3551e9601b6108115
+  metadata.gz: 9bee90cd268e6193725f2daa5158f8bcf724ccde3222eb581e6bbd7a409d022a157df3855b19789182f9ab767ad5ea6f995a8584aef6f53e922ca52690d8f3f8
+  data.tar.gz: dd59f80cae1f4c2bf41ed9eecf680657b6f117c630f665c22aca4d22b19498226a889dd0f0484d90583557d38ece37a01467b0dc343b0b8ba712a8f9805ffca3

data/.gitignore

@@ -1,3 +1,5 @@
 *.gem
+*.swp
 Gemfile.lock
 .vagrant/
+.bundle/

data/.rspec

@@ -0,0 +1,4 @@
+--format
+d
+--colour
+--backtrace

data/.travis.yml

@@ -0,0 +1,25 @@
+---
+language: ruby
+sudo: false
+cache:
+  directories:
+    - vendor/bundle
+bundler_args: --path vendor/bundle
+script:
+  - bundle exec rake spec
+rvm:
+  - 1.8.7
+  - 1.9.3
+  - 2.0.0
+  - 2.1.5
+env:
+  - FACTER_GEM_VERSION="~> 1.6.0"
+  - FACTER_GEM_VERSION="~> 1.7.0"
+  - FACTER_GEM_VERSION="~> 2.0.0"
+  - FACTER_GEM_VERSION="~> 2.1.0"
+  - FACTER_GEM_VERSION="~> 2.2.0"
+  - FACTER_GEM_VERSION="~> 2.3.0"
+matrix:
+  fast_finish: true
+notifications:
+  email: false

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+##2014-12-19 - Release 0.2.2
+- Fix some bugs
+- Add unit tests
+
 ##2014-12-19 - Release 0.2.1
 - Add facts for Debian 8
 

data/Gemfile

@@ -1,7 +1,10 @@
 source ENV['GEM_SOURCE'] || "https://rubygems.org"
 
 group :development, :test do
-  gem 'test-unit', :require => false
+  gem 'json',  :require => false
+  gem 'mocha', :require => false
+  gem 'rake',  :require => false
+  gem 'rspec', :require => false
 end
 
 if facterversion = ENV['FACTER_GEM_VERSION']

data/README.md

@@ -1,6 +1,8 @@
 rspec-puppet-facts
 ==================
 
+[![Build Status](https://travis-ci.org/mcanevet/rspec-puppet-facts.png?branch=master)](https://travis-ci.org/mcanevet/rspec-puppet-facts)
+
 Based on an original idea from [apenney](https://github.com/apenney/puppet_facts/).
 
 Simplify your unit tests by looping on every supported Operating System and populating facts.
@@ -81,7 +83,22 @@ describe 'myclass' do
 
   on_supported_os({
     :hardwaremodels => ['i386', 'x86_64'],
-    :supported_os   => ['debian-7', 'redhat-6']
+    :supported_os   => [
+      {
+        "operatingsystem" => "Debian",
+        "operatingsystemrelease" => [
+          "6",
+          "7"
+        ]
+      },
+      {
+        "operatingsystem" => "RedHat",
+        "operatingsystemrelease" => [
+          "5",
+          "6"
+        ]
+      }
+    ],
   }).each do |os, facts|
     context "on #{os}" do
       let(:facts) do
@@ -156,8 +173,32 @@ matrix:
 ...
 ```
 
-Add new facts
--------------
+Operating Systems and facter versions supported
+-----------------------------------------------
+
+             | 1.6 | 1.7 | 2.0 | 2.1 | 2.2 | 2.3
+-------------|-----|-----|-----|-----|-----|-----
+CentOS 5     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+CentOS 6     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+CentOS 7     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Debian 6     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Debian 7     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Debian 8     |  N  |  N  |  Y  |  Y  |  Y  |  Y
+Fedora 19    |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Oracle 5     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Oracle 6     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Oracle 7     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+RedHat 5     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+RedHat 6     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+RedHat 7     |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Scientific 5 |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Scientific 6 |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Scientific 7 |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Ubuntu 12.04 |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+Ubuntu 14.04 |  Y  |  Y  |  Y  |  Y  |  Y  |  Y
+
+Add new Operating System support
+--------------------------------
 
 There is `Vagrantfile` to automagically populate `facts` directory by spawning a new VM and launches a provisioning scripts.
 

data/Rakefile

@@ -0,0 +1,5 @@
+begin
+    require 'rspec/core/rake_task'
+      RSpec::Core::RakeTask.new(:spec)
+rescue LoadError
+end

data/lib/rspec-puppet-facts.rb

@@ -3,12 +3,10 @@ require 'json'
 
 module RspecPuppetFacts
 
-  def on_supported_os(
-    opts = {
-      :hardwaremodels => ['x86_64'],
-      :supported_os   => RspecPuppetFacts.meta_supported_os,
-    }
-  )
+  def on_supported_os( opts = {} )
+    opts[:hardwaremodels] ||= ['x86_64']
+    opts[:supported_os] ||= RspecPuppetFacts.meta_supported_os
+
     h = {}
 
     opts[:supported_os].map do |os_sup|
@@ -20,6 +18,9 @@ module RspecPuppetFacts
           # TODO: use SemVer here
           facter_minor_version = Facter.version[0..2]
           file = File.expand_path(File.join(File.dirname(__FILE__), "../facts/#{facter_minor_version}/#{os}.facts"))
+          if ! File.file?(file)
+            fail StandardError, "Can't find facts for '#{os}' for facter #{facter_minor_version}"
+          end
           File.read(file).each_line do |line|
             key, value = line.split(' => ')
             facts[key.to_sym] = value.chomp unless value.nil?

data/lib/rspec-puppet-facts/version.rb

@@ -1,5 +1,5 @@
 module RspecPuppetFacts
   module Version
-    STRING = '0.2.1'
+    STRING = '0.2.2'
   end
 end

data/spec/fixtures/metadata.json

@@ -0,0 +1,42 @@
+{
+  "name": "mcanevet-mymodule",
+  "version": "1.0.0",
+  "author": "Mickaël Canévet",
+  "summary": "My puppet modules",
+  "license": "Apache-2.0",
+  "source": "https://github.com/mcanevet/puppet-mymodule",
+  "project_page": "https://github.com/mcanevet/puppet-mymodule",
+  "issues_url": "https://github.com/mcanevet/puppet-mymodule/issues",
+  "dependencies": [
+  ],
+  "requirements": [
+  ],
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "Debian",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "5",
+        "6",
+        "7"
+      ]
+    }
+  ],
+  "puppet_version": [
+    "2.7",
+    "3.0",
+    "3.1",
+    "3.2",
+    "3.3",
+    "3.4",
+    "3.5",
+    "3.6",
+    "3.7"
+  ]
+}

data/spec/rspec_puppet_facts_spec.rb

@@ -0,0 +1,100 @@
+require 'spec_helper'
+
+describe 'RspecPuppetFacts' do
+
+  describe '#on_supported_os' do
+
+    context 'Without parameter' do
+      subject { on_supported_os() }
+
+      context 'Without metadata.json' do
+        it 'should fail' do
+          expect { subject }.to raise_error(StandardError)
+        end
+      end
+
+      context 'With a metadata.json' do
+        fixture = File.read('spec/fixtures/metadata.json')
+        File.stubs('file?')
+        File.stubs('read')
+        File.expects('file?').with('metadata.json').returns true
+        File.expects('read').with('metadata.json').returns fixture
+        it 'should return a hash' do
+          expect( on_supported_os().class ).to eq Hash
+        end
+        it 'should have 5 elements' do
+          expect(subject.size).to eq 5
+        end
+        it 'should return supported OS' do
+          expect(subject.keys.sort).to eq [
+            'debian-6-x86_64',
+            'debian-7-x86_64',
+            'redhat-5-x86_64',
+            'redhat-6-x86_64',
+            'redhat-7-x86_64',
+          ]
+        end
+      end
+    end
+
+    context 'When specifying supported_os' do
+      subject {
+        on_supported_os(
+          {
+            :supported_os => [
+              {
+                "operatingsystem" => "Debian",
+                "operatingsystemrelease" => [
+                  "6",
+                  "7"
+                ]
+              },
+              {
+                "operatingsystem" => "RedHat",
+                "operatingsystemrelease" => [
+                  "5",
+                  "6"
+                ]
+              }
+            ]
+          }
+        )
+      }
+      it 'should return a hash' do
+        expect(subject.class).to eq Hash
+      end
+      it 'should have 4 elements' do
+        expect(subject.size).to eq 4
+      end
+      it 'should return supported OS' do
+        expect(subject.keys.sort).to eq [
+          'debian-6-x86_64',
+          'debian-7-x86_64',
+          'redhat-5-x86_64',
+          'redhat-6-x86_64',
+        ]
+      end
+    end
+
+    context 'When specifying wrong supported_os' do
+      subject {
+        on_supported_os(
+          {
+            :supported_os => [
+              {
+                "operatingsystem" => "Debian",
+                "operatingsystemrelease" => [
+                  "4",
+                ],
+              },
+            ]
+          }
+        )
+      }
+
+      it 'should fail' do
+        expect { subject }.to raise_error(StandardError, /Can't find facts for 'debian-4-x86_64'/)
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,8 @@
+require 'rspec'
+require 'mocha/api'
+require 'rspec-puppet-facts'
+include RspecPuppetFacts
+
+RSpec.configure do |config|
+   config.mock_framework = :mocha
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-puppet-facts
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Mickaël Canévet
@@ -18,9 +18,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - README.md
+- Rakefile
 - Vagrantfile
 - facts/1.6/centos-5-i386.facts
 - facts/1.6/centos-5-x86_64.facts
@@ -238,6 +241,9 @@ files:
 - lib/rspec-puppet-facts.rb
 - lib/rspec-puppet-facts/version.rb
 - rspec-puppet-facts.gemspec
+- spec/fixtures/metadata.json
+- spec/rspec_puppet_facts_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/mcanevet/rspec-puppet-facts
 licenses:
 - Apache-2.0