rspec-page-regression 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16be31d2cd913d4f1c0e4d8e8cfe17236478aafe
-  data.tar.gz: 3cfc21083eb4dc17b28f4ba4496d9d437eb76401
+  metadata.gz: 1847e77587cf7d17aa62ef348dcf6d727a0f7d69
+  data.tar.gz: 8e6d648fa23c69519fee4b9da629076161e491f9
 SHA512:
-  metadata.gz: bbe34659c64d36c19ae203ea9ce0bbea48505009ec7cc9b984c45412a9e17e2602954eac59892b67e7582960a638e490b619217cf8985f275a865f46949eec75
-  data.tar.gz: 9a271da665070a549833b805294f5ddf8d6a8495d3c986debdd72d2d045f99a133bee974a00e3885ee9466ef63e1a705badde5e86ceb2ab9bd0769dcffac4576
+  metadata.gz: dd8f790e145225044a389b346f9dcf474397ee7d3d0b2293ec50aedc4c6ec798d15ceafb5c0dc6af0100956ed705edad3a7e77eaa52fe192f788a6903088efd5
+  data.tar.gz: ef4d7943130cd145f991fc5d8f9a77d648955c1d323365304682d95f9b2fc6be38f453fd09cb96da1175c55791778f75f77e6a2f6c589f19e03b0ab57fedc86d

data/README.md

@@ -168,6 +168,8 @@ Don't forget to include specs (`rake spec`) to verify your functionality.  Code
 
 Release Notes:
 
+* 0.4.1 - Bug fix: wasn't including example name in file path.  Thanks to [@kurtisnelson](https://github.com/kurtisnelson)
+
 * 0.4.0 - Add difference threshold.  Thanks to [@abersager](https://github.com/abersager)
 
 * 0.3.0 - Compatibility with rspec 3.0

data/lib/rspec/page-regression/file_paths.rb

@@ -10,9 +10,11 @@ module RSpec::PageRegression
       expected_path = Pathname.new(expected_path) if expected_path
 
       descriptions = description_ancestry(example.metadata[:example_group])
-      descriptions.pop if descriptions.last =~ %r{
+      descriptions.push example.description unless example.description.parameterize('_') =~ %r{
         ^
-        (then_+)? (page_+)? (should_+)? match_expectation
+        (then_+)?
+        ( (expect_+) (page_+) (to_+) (not_+)? | (page_+) (should_+)? )
+        match_expectation
         (_#{Regexp.escape(expected_path.to_s)})?
           $
       }xi

data/lib/rspec/page-regression/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module PageRegression
-    VERSION = "0.4.0"
+    VERSION = "0.4.1"
   end
 end

data/spec/match_expectation_spec.rb

@@ -13,6 +13,15 @@ describe "match_expectation" do
     @match_argument = nil
   }
 
+  context "helpers" do
+    it "use proper paths" do
+      expect(expected_path).to eq Pathname.new("spec/expectation/match_expectation/helpers/use_proper_paths/expected.png")
+      expect(test_path).to eq Pathname.new("tmp/spec/expectation/match_expectation/helpers/use_proper_paths/test.png")
+      expect(difference_path).to eq Pathname.new("tmp/spec/expectation/match_expectation/helpers/use_proper_paths/difference.png")
+    end
+  end
+
+
   context "using expect().to" do
 
     When {

data/spec/support/helpers.rb

@@ -13,7 +13,11 @@ module Helpers
   end
 
   def getpath(root, base)
-    (root + "expectation" + group_path(RSpec.current_example.metadata[:example_group]) + "#{base}.png").relative_path_from Pathname.getwd
+    (root + "expectation" + example_path(RSpec.current_example) + "#{base}.png").relative_path_from Pathname.getwd
+  end
+
+  def example_path(example)
+    group_path(example.metadata[:example_group]) + example.description.parameterize("_")
   end
 
   def group_path(metadata)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-page-regression
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - ronen barzel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-22 00:00:00.000000000 Z
+date: 2015-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport