rspec-junklet 2.1.0 → 2.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NTBkNmE5YzhiNjBkZTE5MTE4OWM5YzAxMzI1NzIwMmUxMjEzNTljOA==
+    Y2JjYzc5MDljNGNlMjQwNWI0ZjA3YjM3NWM0NTQwYTVmZjc2ZWFkYg==
   data.tar.gz: !binary |-
-    ZWIxZjZkNTg2NmVhMmVlYjYzYTdkMWJhMDdhYTc4YTIwZmY5MzhkNg==
+    ODRiNWRkZjg5MDNmOTlhMGVkYmE4MzA5ZDdjMWNkMWQyOTc4ZDc3MQ==
 SHA512:
   metadata.gz: !binary |-
-    NmEzM2E4OWJiMWUyOGY4MDM0YWNjN2ZhODlhN2ZkOWM4NjEyOThhMjFkMjM3
-    MmYyOWVkMzU4ZDc2ODIzYTZhYzVmZTdhZTM3YjkyNzE0MmRkNjhmYzAxOTBh
-    OTg1ZjI0ZTk5ODE4NWRmOTA1ZmY1NDA3ODE1Zjg5ZDc2YWEyNWU=
+    ZDNiODg5ZDhiYTFmMTc0M2VjNWU4MGVhZjgyNjJmYzQxN2NjNjk5MzllNWFj
+    ZTQ3NTkxMzAzNTZlOGE2MDhkMWEyYjVmYTI3Y2I1ZmY3MmFiOTlkYTM2NzFj
+    MmVhNzhlZGUzOTM4ZTI3Yzc4NjE3NDAwYTBhODg3MjVjZmU4YWY=
   data.tar.gz: !binary |-
-    YjVhMjU5ODEwNzYzZTg3MTk5YzZhODA4MWU1NTA3NjY5NjRmMGM0ZDdjMjc5
-    NzhiMzJjYjgwYTEyMTcxNzlhYTEyMTA4ODRlOTg0YWE5MWZhOTVlZDBjYWE2
-    OTg3MzdkMmUxZGY2OGE0NjEwZGNlYjg0Y2Y1YWE0ZTllMTBlZmU=
+    YWUzYTRjZTkxMWRjYTVkYTI1ZmYxODZjY2NiOTBhOGUwZDQwMjFlMzA2ZDI0
+    ZDdiZGZmZGE5OThhZjgwNWY4ZjFlNDhkMDkzODFhMWI0NmEzN2Y3NDEyMWIw
+    Mjk4ZTBlMmM4YjQ2MDY3ZDRiYzZjM2I1ZGJlMTA4MmJhMDc1ZmE=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rspec-junklet (2.0.0)
+    rspec-junklet (2.1.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -42,13 +42,16 @@ and varied types of junk data. The former is meant to be used as part of the DSL
 to declare pieces of data to be junk, while the latter is intended to be used
 anywhere inside RSpec to supply the junk data itself.
 
-To illustrate, these statements are functionally identical:
+To illustrate, these statements are essentially identical:
 
 ```ruby
 junklet :pigtruck
 let(:pigtruck) { junk }
 ```
 
+_Caveat: they are slightly different; `junklet :pigtruck` is actually identical
+to `let(:pigtruck) { "pigtruck-" + junk }`_
+
 ## Junklet
 
 `junklet` declares a memoized variable containing random junk.

data/lib/rspec/junklet/junklet.rb

@@ -15,12 +15,12 @@ module RSpec
         names = names.map {|name| name.gsub(/_/, separator)}
 
         args.zip(names).each do |arg, name|
-          make_junklet arg, name, separator, junk
+          make_junklet arg, name, separator
         end
       end
 
-      def make_junklet(let_name, name, separator, junk_data)
-        let(let_name) { "#{name}#{separator}#{junk_data}" }
+      def make_junklet(let_name, name, separator)
+        let(let_name) { "#{name}#{separator}#{junk}" }
       end
     end
   end

data/lib/rspec/junklet/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module Junklet
-    VERSION = "2.1.0"
+    VERSION = "2.1.1"
   end
 end

data/spec/lib/rspec/examples_spec.rb

@@ -15,8 +15,8 @@ describe RSpec::Junklet do
       specify { expect(trash).to match /^trash_/ }
       specify { expect(trash).to match hex_regex }
 
-      describe "memoization" do
-        specify { expect(trash).to eq(trash) }
+      it "memoizes so subsequent calls do not change" do
+        expect(trash).to eq(trash)
       end
     end
 
@@ -168,16 +168,6 @@ describe RSpec::Junklet do
       end
     end
 
-    # begin
-    #   $caught_bad_junklet_error = false
-    #   junklet :cheesy_bad_junklet, cheese: true
-    # rescue INVALID_JUNKLET_ERROR => e
-    #   raise "junklet got invalid option" unless e.message == "junklet options must be one of #{VALID_JUNKLET_ARGS.map(&:inspect) * ', '}"
-    #   $caught_bad_junklet_error = true
-    # else
-    #   raise "junklet got an invalid argument but didn't catch it" unless $caught_bad_junklet_error
-    # end
-
     context "with exclude: val" do
       let(:heads) { 0 }
       let(:tails) { 1 }
@@ -188,12 +178,45 @@ describe RSpec::Junklet do
       specify { expect(coin_tails).to eq(tails) }
     end
 
+    context "with format" do
+      context "format: :string" do
+        let(:age_string) { junk :int, size: 2, format: :string }
+        it "changes junk to a string" do
+          expect(age_string).to match /^\d\d$/
+        end
+      end
+
+      context "format: <string>" do
+        let(:birthday) { junk :int, max: 9, format: "03/15/20%02d" }
+        it "formats using the string as a sprintf format" do
+          expect(birthday).to match %r{^03/15/200\d$}
+        end
+      end
+
+      context "format: SomeClass" do
+        class Birthday
+          def initialize(day)
+            @day = day
+          end
+          def format
+            "%02d/%02d/20%02d" % [@day, @day, @day]
+          end
+        end
+
+        let(:birthday) { junk :int, max: 12, format: Birthday }
+        it "uses the class as a formatter instance with .new(junk).format" do
+          expect(birthday).to match %r{^\d\d/\d\d/20\d\d$}
+        end
+      end
+    end
+
     # TODO: Formats here
 
     # format: :string -> calls .to_s
     # format: "format_string" -> calls sprintf(junkval, format_string)
     # format: Klass -> passes junkval to Klass.new
     # format: Proc -> passes junkval to Proc
+    # format: :sym -> calls .to_sym
     #
     # format: with exclude: - runs exclude AFTER running format. This is the whole point of formatters; it allows us to say junk().to_s, exclude: :otherval
 
@@ -205,4 +228,24 @@ describe RSpec::Junklet do
       specify { expect(metaname).to be }
     end
   end
+
+
+  # describe '.junks' do
+  #   junks :age, :size, :weight, type: :int, format: :string
+
+  #   it "makes all the defined junk objects the same type" do
+  #     expect(age).to be_a String
+  #     expect(size).to be_a String
+  #     expect(weight).to be_a String
+  #   end
+
+  #   it "formats all the junk objects per the formatter" do
+  #     # This is why it's not just an extra param to junklet: junklet
+  #     # prepends the name of the symbol.
+  #     expect(age).to match /^\d+$/
+  #     expect(size).to match /^\d+$/
+  #     expect(weight).to match /^\d+$/
+  #   end
+  # end
+
 end

data/spec/lib/rspec/junklet/junklet_spec.rb

@@ -25,15 +25,15 @@ describe JunkletSpy do
     end
 
     it 'delegates junk generation to junk' do
-      expect(subject).to receive(:make_junklet).with(:pig_truck, 'pig_truck', '_', 'junkety_junky_junk')
-      expect(subject).to receive(:make_junklet).with(:cow_truck, 'cow_truck', '_', 'junkety_junky_junk')
+      expect(subject).to receive(:make_junklet).with(:pig_truck, 'pig_truck', '_')
+      expect(subject).to receive(:make_junklet).with(:cow_truck, 'cow_truck', '_')
       subject.junklet :pig_truck, :cow_truck
     end
 
     context "with separator" do
       it 'converts separator in name' do
-        expect(subject).to receive(:make_junklet).with(:pig_truck, 'pig~truck', '~', 'junkety_junky_junk')
-        expect(subject).to receive(:make_junklet).with(:cow_truck, 'cow~truck', '~', 'junkety_junky_junk')
+        expect(subject).to receive(:make_junklet).with(:pig_truck, 'pig~truck', '~')
+        expect(subject).to receive(:make_junklet).with(:cow_truck, 'cow~truck', '~')
         subject.junklet :pig_truck, :cow_truck, separator: '~'
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-junklet
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - David Brady
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-01 00:00:00.000000000 Z
+date: 2016-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler