rspec-javascript-matchers 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5621b81fccffce58668b9cff5c8b5f61177426c38225130f71c0d4c936cfffa5
-  data.tar.gz: 2ade56d8c32eea63c745b9f27b7b231448b158d022c74b07fd0cae8f589c7693
+  metadata.gz: d8c355d142407b9e1634ea013dd57c207c6a5e0933e4f9e0c69dd8b7790b6c98
+  data.tar.gz: 557309a850c23478d55f67e6645df925face50f3905135635dc13dbf72cb7e9f
 SHA512:
-  metadata.gz: 6589ba9dd6db1df2c56af1a83b0fbed4946412caf5f483610cba6292722a8de789176369e1de00604fd74748f0fa14d93f0056f00d7da39c422d01394f04b630
-  data.tar.gz: 301bbd4313254501ddaec75b4f8c9b226ce2a8eb45a4f08fb9a5d0a7f2117a82c46a56800a220e76e9c9b3e2cb09d316c035f40e425dc074741929f1dd507ff1
+  metadata.gz: 2a528441d63ec13e2aa9993c565ae45e54c858a8d98b42685e5858180c0fda9ca7a8f39319c94e0330b744488505e820c918c15364428235f1cfdebf462222ce
+  data.tar.gz: d95a016a7674c4beec883e253f10d66d081aad67fbdc986b8c13a0fccd919bcaca05991a9beecc9bcb3ddac49d7929698dfa2c5339f10ebe56e77a2e5fa7eb2c

data/lib/rspec-javascript-matchers.rb

@@ -16,9 +16,14 @@ RSpec::Matchers.define :be_valid_javascript do
         cxt.eval(actual)
         ''
       rescue V8::Error => e
+        #e.in_javascript? => true
+
+        # this looks more like a runtime error rather than parse error
+        return '' if e.root_cause.to_s.include?('is not defined')
+
         # Because <eval> doesn't provide any meaningful context info here:k:w
         # Invalid regular expression: missing / at <eval>:4:12
-        e.root_cause.message.gsub('<eval>:', '')
+        e.root_cause.message.gsub('<eval>:', '') + "\nActual:\n#{actual}"
       end
     elsif defined?(MiniRacer)
       context = MiniRacer::Context.new
@@ -28,7 +33,10 @@ RSpec::Matchers.define :be_valid_javascript do
       rescue MiniRacer::ParseError => e
         # Because default is:
         # "Uncaught SyntaxError: Invalid regular expression: missing / at undefined:4:10"
-        e.message.gsub('Uncaught SyntaxError: ', '').gsub(' undefined:', ' ')
+        e.message.gsub('Uncaught SyntaxError: ', '').gsub(' undefined:', ' ') + "\nActual:\n#{actual}"
+      rescue MiniRacer::RuntimeError => e
+        # Most likely smth like: "ReferenceError: $ is not defined" which we don't care about in specs
+        ''
       end
     else
       %(Maker sure you have "mini_racer" or "therubyracer" gem in your Gemfile dependencies)

data/lib/version.rb

@@ -14,7 +14,7 @@ module RSpecJavascriptMatchers
 
     # @return [Integer]
     def patch
-      1
+      2
     end
 
     # @return [Hash]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-javascript-matchers
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Nikita Fedyashev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-16 00:00:00.000000000 Z
+date: 2018-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec