rspec-its 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4627e0d122f6f6d60961135154b6068ff823fa63
-  data.tar.gz: 245f30f1298a86c8da41930d50bef0f01bee090c
+  metadata.gz: ab33dd1641758cc1d81b57418e598d6d41fc739a
+  data.tar.gz: 9235487eef7281417d50bc7342e71baa66779914
 SHA512:
-  metadata.gz: 47f4f6c32e9df24cfc6710fe5c96e81d82b5dcb3e4ee487065e20809e27ca64b7bf64a7516ef80bf82b74c6d113f3950a80aec890f410277f29df7530911b88a
-  data.tar.gz: d8716722becc4400ae94f15ef310336e52cedcd2cb4041de1f9c3fe22904121e23e3cbceb9ff3b6323eab48e7992f03c95a1c45a55a4de395dcee262b63011b8
+  metadata.gz: f6ed4e65790cb3c9a2a21bc7a9493dba9e41c890f19ebea44489de827da75ec5a22a0626bffcbcba8f4929d33879892cb5f05faab4a0dd60f5fe3c57dc9c5c76
+  data.tar.gz: bcf65bcdad2fb1b8398817728e20f88b0494906e8f0a9b374042092caccf7a3e7314ef9f1238a24cf5c9bf212c707d99c6bebb29b222e36729e77f3850329b59

data/.travis.yml

@@ -7,14 +7,17 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.1
+  - 2.1.2
+  - ruby-head
   - ree
   - jruby-18mode
   - jruby
+  - jruby-head
   - rbx
-env:
-  - BRANCH=master
-  - BRANCH=2-99-maintenance
 matrix:
   allow_failures:
-    - rvm: jruby-18mode
+    - rvm: jruby-head
+    - rvm: ruby-head
+    - rvm: rbx
 

data/Changelog.md

@@ -1,3 +1,16 @@
+### 1.1.0 / 2014-04-13
+[full changelog](http://github.com/rspec/rspec-its/compare/v1.0.1...v1.1.0)
+
+Breaking Changes:
+
+Enhancements:
+* For hashes, multiple array elements are treated as successive access keys
+* Metadata arguments are now supported
+
+Bug fixes:
+* Enable `its` example selection by line number in command line
+
+
 ### 1.0.1 / 2014-04-13
 [full changelog](http://github.com/rspec/rspec-its/compare/v1.0.0...v1.0.1)
 

data/Gemfile

@@ -4,8 +4,7 @@ source 'https://rubygems.org'
 gemspec
 
 %w[rspec rspec-core rspec-expectations rspec-mocks rspec-support].each do |lib|
-  branch = ENV.fetch('BRANCH','master')
-  next if branch == '2-99-maintenance' && lib == 'rspec-support'
+  branch = ENV.fetch('BRANCH','3-1-maintenance')
   library_path = File.expand_path("../../#{lib}", __FILE__)
   if File.exist?(library_path)
     gem lib, :path => library_path
@@ -24,4 +23,4 @@ eval File.read('Gemfile-custom') if File.exist?('Gemfile-custom')
 
 platform :rbx do
   gem 'rubysl'
-end
+end

data/README.md

@@ -16,6 +16,10 @@ Or install it yourself as:
 
     $ gem install rspec-its
 
+And require it as:
+
+    require 'rspec/its'
+
 ## Usage
 
 Use the `its` method to generate a nested example group with
@@ -32,11 +36,25 @@ attribute of the attribute of the subject).
 
     its("phone_numbers.size") { should_not eq(0) }
 
-When the subject is a hash, you can pass in an array with a single key to
-access the value at that key in the hash.
+When the subject implements the `[]` operator, you can pass in an array with a single key to
+refer to the value returned by that operator when passed that key as an argument.
 
     its([:key]) { is_expected.to eq(value) }
 
+For hashes, multiple keys within the array will result in successive accesses into the hash. For example:
+
+    subject { {key1: {key2: 3} } }
+    its([:key1, :key2]) { is_expected.to eq(3)
+
+For other objects, multiple keys within the array will be passed as separate arguments in a single method call to [], as in:
+
+    subject { Matrix[ [:a, :b], [:c, :d] ] }
+    its([1,1]) { should eq(:d) }
+
+Metadata arguments are supported.
+
+    its(:size, focus: true) { should eq(1) }
+
 ## Contributing
 
 1. Fork it

data/features/its.feature

@@ -96,3 +96,27 @@ Feature: attribute of subject
     When I run rspec
     Then the output should contain "Failure/Error: its(:size) { should_not eq(0) }"
       And the output should not match /#[^\n]*rspec[\x2f]its/
+
+ Scenario: examples can be specified by exact line number
+    Given a file named "example_spec.rb" with:
+      """ruby
+      describe Array do
+        context "when first created" do
+          its(:size) { should eq(0) }
+        end
+      end
+      """
+    When I run rspec specifying line number 3
+    Then the examples should all pass
+
+  Scenario: examples can be specified by line number within containing block
+    Given a file named "example_spec.rb" with:
+    """ruby
+      describe Array do
+        context "when first created" do
+          its(:size) { should eq(0) }
+        end
+      end
+      """
+    When I run rspec specifying line number 2
+    Then the examples should all pass

data/features/step_definitions/additional_cli_steps.rb

@@ -6,6 +6,14 @@ When /^I run rspec( with the documentation option)?$/ do |documentation|
   step "I run `#{rspec_command}`"
 end
 
+When /^I run rspec specifying line number (\d+)$/ do |line_number|
+  rspec_its_gem_location = File.expand_path('../../../lib/rspec/its', __FILE__)
+  require_option = "--require #{rspec_its_gem_location}"
+  file_specification = "example_spec.rb:#{line_number}"
+  rspec_command = ['rspec', require_option, file_specification].join(' ')
+  step "I run `#{rspec_command}`"
+end
+
 Then /^the example(?:s)? should(?: all)? pass$/ do
   step %q{the output should contain "0 failures"}
   step %q{the output should not contain "0 examples"}

data/lib/rspec/its.rb

@@ -47,11 +47,13 @@ module RSpec
     #   describe "a configuration Hash" do
     #     subject do
     #       { :max_users => 3,
-    #         'admin' => :all_permissions }
+    #         'admin' => :all_permissions.
+    #         'john_doe' => {:permissions => [:read, :write]}}
     #     end
     #
     #     its([:max_users]) { should eq(3) }
     #     its(['admin']) { should eq(:all_permissions) }
+    #     its(['john_doe', :permissions]) { should eq([:read, :write]) }
     #
     #     # You can still access to its regular methods this way:
     #     its(:keys) { should include(:max_users) }
@@ -67,6 +69,25 @@ module RSpec
     #     its(:size) { is_expected.to eq(0) }
     #   end
     #
+    # You can pass more than one arguments on the `its` block to add
+    # some options to the generated example
+    #
+    # @example
+    #
+    #   # This ...
+    #   describe Array do
+    #     its(:size, :focus) { should eq(0) }
+    #   end
+    #
+    #   # ... generates the same runtime structure as this:
+    #   describe Array do
+    #     describe "size" do
+    #       it "should eq(0)", :focus do
+    #         subject.size.should eq(0)
+    #       end
+    #     end
+    #   end
+    #
     # Note that this method does not modify `subject` in any way, so if you
     # refer to `subject` in `let` or `before` blocks, you're still
     # referring to the outer subject.
@@ -78,12 +99,17 @@ module RSpec
     #     before { subject.age = 25 }
     #     its(:age) { should eq(25) }
     #   end
-    def its(attribute, &block)
-      describe(attribute.to_s) do
-        if Array === attribute
-          let(:__its_subject) { subject[*attribute] }
-        else
-          let(:__its_subject) do
+    def its(attribute, *options, &block)
+      its_caller = caller.select {|file_line| file_line !~ %r(/lib/rspec/its) }
+      describe(attribute.to_s, :caller => its_caller) do
+        let(:__its_subject) do
+          if Array === attribute
+            if Hash === subject
+              attribute.inject(subject) {|inner, attr| inner[attr] }
+            else
+              subject[*attribute]
+            end
+          else
             attribute_chain = attribute.to_s.split('.')
             attribute_chain.inject(subject) do |inner_subject, attr|
               inner_subject.send(attr)
@@ -103,8 +129,8 @@ module RSpec
           RSpec::Expectations::NegativeExpectationHandler.handle_matcher(__its_subject, matcher, message)
         end
 
-        its_caller = caller.select {|file_line| file_line !~ %r(/lib/rspec/its) }
-        example(nil, :caller => its_caller, &block)
+        options << { :caller => its_caller }
+        example(nil, *options, &block)
 
       end
     end

data/lib/rspec/its/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module Its
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

data/rspec-its.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["palfvin@gmail.com"]
   spec.description   = %q{RSpec extension gem for attribute matching}
   spec.summary       = %q{Provides "its" method formally part of rspec-core}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/rspec/rspec-its"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)
@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'rspec-core', '>= 2.99.0.beta1'
-  spec.add_runtime_dependency 'rspec-expectations', '>= 2.99.0.beta1'
+  spec.add_runtime_dependency 'rspec-core', '>= 3.0.0'
+  spec.add_runtime_dependency 'rspec-expectations', '>= 3.0.0'
   spec.add_development_dependency 'bundler',  '~> 1.3'
   spec.add_development_dependency 'rake',     '~> 10.1.0'
   spec.add_development_dependency 'cucumber', '~> 1.3.8'

data/spec/rspec/its_spec.rb

@@ -22,6 +22,14 @@ module RSpec
           end.new
         end
 
+        before(:each, :meta) do
+          subject.call_count
+        end
+
+        context "with some metadata" do
+          its(:call_count, :meta) { should eq(2) }
+        end
+
         context "with a call counter" do
           its(:call_count) { should eq(1) }
         end
@@ -86,6 +94,20 @@ module RSpec
               end
             end
           end
+
+          context "when it's a hash" do
+            subject { {:a => {:deep => {:key => "value"}}} }
+
+            its([:a]) { should eq({:deep => {:key => "value"}}) }
+            its([:a, :deep]) { should eq({:key => "value"}) }
+            its([:a, :deep, :key]) { should eq("value") }
+
+            context "when referring to a key that doesn't exist" do
+              its([:not_here]) { should be_nil }
+              its([:a, :ghost]) { should be_nil }
+              its([:deep, :ghost]) { expect { should eq("missing") }.to raise_error(NoMethodError) }
+            end
+          end
         end
 
         context "when it does not respond to #[]" do
@@ -182,8 +204,11 @@ module RSpec
             end
 
             group.run(NullFormatter.new)
-            # Using to_h[:status].to_sym in following instead of .status due to need to run in RSpec 2.99
-            expect(group.children.first.examples.first.execution_result.to_h[:status].to_sym).to eq(:passed)
+
+            result = group.children.first.examples.first.execution_result
+            # Following conditional needed to work across mix of RSpec and ruby versions without warning
+            status = result.respond_to?(:status) ? result.status : result[:status].to_sym
+            expect(status).to eq(:passed)
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-its
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Peter Alfvin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-13 00:00:00.000000000 Z
+date: 2014-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.99.0.beta1
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.99.0.beta1
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.99.0.beta1
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.99.0.beta1
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -119,7 +119,7 @@ files:
 - script/test_all
 - spec/rspec/its_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/rspec/rspec-its
 licenses:
 - MIT
 metadata: {}