rspec-its 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e89242dc146a5c9573f8d63e6562cdfb2d737af
-  data.tar.gz: 633f5d342cec24bf1ccf5333aea83790450aaed8
+  metadata.gz: 4627e0d122f6f6d60961135154b6068ff823fa63
+  data.tar.gz: 245f30f1298a86c8da41930d50bef0f01bee090c
 SHA512:
-  metadata.gz: 228935be4ec664600e892ad3db85744beb98d4838926ae799c8004a34477e0edb62a80f488a8b85addf19cc0863207907f94867f29d9afdda3fd5beb13072549
-  data.tar.gz: d3d25104450cdfd1d699d3737d1dfabf3481c2cbc31ae216d6926af99e5b16d199912f6720067d92036242e75ca2245fa28d79c237bfb9d03ed879a8e049be2a
+  metadata.gz: 47f4f6c32e9df24cfc6710fe5c96e81d82b5dcb3e4ee487065e20809e27ca64b7bf64a7516ef80bf82b74c6d113f3950a80aec890f410277f29df7530911b88a
+  data.tar.gz: d8716722becc4400ae94f15ef310336e52cedcd2cb4041de1f9c3fe22904121e23e3cbceb9ff3b6323eab48e7992f03c95a1c45a55a4de395dcee262b63011b8

data/.travis.yml

@@ -5,16 +5,16 @@ rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
+  - 2.0.0
+  - 2.1.0
   - ree
   - jruby-18mode
-  - jruby-19mode
+  - jruby
   - rbx
-  - 2.0.0
-  - 2.1.0
 env:
   - BRANCH=master
   - BRANCH=2-99-maintenance
 matrix:
   allow_failures:
-    - rvm: rbx-19mode
-    - rvm: rbx-18mode
+    - rvm: jruby-18mode
+

data/Changelog.md

@@ -1,5 +1,11 @@
+### 1.0.1 / 2014-04-13
+[full changelog](http://github.com/rspec/rspec-its/compare/v1.0.0...v1.0.1)
+
+Bug fixes:
+* Maintain implicit subject in all cases (addresses problem with latest RSpec 3 version)
+
 ### 1.0.0 / 2014-02-07
-[full changelog](http://github.com/rspec/rspec-its/compare/v1.0.0.pre...master)
+[full changelog](http://github.com/rspec/rspec-its/compare/v1.0.0.pre...v1.0.0)
 
 Breaking Changes:
 

data/Gemfile

@@ -3,20 +3,18 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in rspec-its.gemspec
 gemspec
 
-%w[rspec rspec-core rspec-expectations rspec-mocks].each do |lib|
+%w[rspec rspec-core rspec-expectations rspec-mocks rspec-support].each do |lib|
+  branch = ENV.fetch('BRANCH','master')
+  next if branch == '2-99-maintenance' && lib == 'rspec-support'
   library_path = File.expand_path("../../#{lib}", __FILE__)
   if File.exist?(library_path)
     gem lib, :path => library_path
   else
     gem lib, :git => "git://github.com/rspec/#{lib}.git",
-             :branch => ENV.fetch('BRANCH','master')
+             :branch => branch
   end
 end
 
-# only pull rspec-support from master
-
-gem "rspec-support", :git => "git://github.com/rspec/rspec-support.git"
-
 # test coverage
 # gem 'simplecov', :require => false
 

data/README.md

@@ -18,7 +18,7 @@ Or install it yourself as:
 
 ## Usage
 
-Use the `its` method  to generate a nested example group with
+Use the `its` method to generate a nested example group with
 a single example that specifies the expected value of an attribute of the
 subject using `should`, `should_not` or `is_expected`.
 

data/features/its.feature

@@ -83,3 +83,16 @@ Feature: attribute of subject
       """
     When I run rspec
     Then the examples should all pass
+
+ Scenario: failures are correctly reported as coming from the `its` line
+    Given a file named "example_spec.rb" with:
+      """ruby
+      describe Array do
+        context "when first created" do
+          its(:size) { should_not eq(0) }
+        end
+      end
+      """
+    When I run rspec
+    Then the output should contain "Failure/Error: its(:size) { should_not eq(0) }"
+      And the output should not match /#[^\n]*rspec[\x2f]its/

data/lib/rspec/its.rb

@@ -79,7 +79,7 @@ module RSpec
     #     its(:age) { should eq(25) }
     #   end
     def its(attribute, &block)
-      describe(attribute) do
+      describe(attribute.to_s) do
         if Array === attribute
           let(:__its_subject) { subject[*attribute] }
         else
@@ -103,7 +103,9 @@ module RSpec
           RSpec::Expectations::NegativeExpectationHandler.handle_matcher(__its_subject, matcher, message)
         end
 
-        example(&block)
+        its_caller = caller.select {|file_line| file_line !~ %r(/lib/rspec/its) }
+        example(nil, :caller => its_caller, &block)
+
       end
     end
 
@@ -112,6 +114,7 @@ end
 
 RSpec.configure do |rspec|
   rspec.extend RSpec::Its
+  rspec.backtrace_exclusion_patterns << %r(/lib/rspec/its)
 end
 
 RSpec::SharedContext.send(:include, RSpec::Its)

data/lib/rspec/its/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module Its
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/spec/rspec/its_spec.rb

@@ -3,179 +3,188 @@ require 'spec_helper'
 module RSpec
   describe Its do
     describe "#its" do
-      subject do
-        Class.new do
-          def initialize
-            @call_count = 0
-          end
-
-          def call_count
-            @call_count += 1
-          end
-        end.new
-      end
-
-      context "with a call counter" do
-        its(:call_count) { should eq(1) }
+      context "with implicit subject" do
+        context "preserves described_class" do
+          its(:symbol) { expect(described_class).to be Its}
+          its([]) { expect(described_class).to be Its }
+        end
       end
-
-      context "with nil value" do
+      context "with explicit subject" do
         subject do
           Class.new do
-            def nil_value
-              nil
+            def initialize
+              @call_count = 0
             end
-          end.new
-        end
-        its(:nil_value) { should be_nil }
-      end
 
-      context "with nested attributes" do
-        subject do
-          Class.new do
-            def name
-              "John"
+            def call_count
+              @call_count += 1
             end
           end.new
         end
-        its("name")            { should eq("John") }
-        its("name.size")       { should eq(4) }
-        its("name.size.class") { should eq(Fixnum) }
 
-        context "using should_not" do
-          its("name")          { should_not eq("Paul") }
+        context "with a call counter" do
+          its(:call_count) { should eq(1) }
         end
 
-        context "using is_expected" do
-          its("name")          { is_expected.to eq("John") }
+        context "with nil value" do
+          subject do
+            Class.new do
+              def nil_value
+                nil
+              end
+            end.new
+          end
+          its(:nil_value) { should be_nil }
         end
 
-      end
+        context "with nested attributes" do
+          subject do
+            Class.new do
+              def name
+                "John"
+              end
+            end.new
+          end
+          its("name")            { should eq("John") }
+          its("name.size")       { should eq(4) }
+          its("name.size.class") { should eq(Fixnum) }
 
-      context "when it responds to #[]" do
-        subject do
-          Class.new do
-            def [](*objects)
-              objects.map do |object|
-                "#{object.class}: #{object.to_s}"
-              end.join("; ")
-            end
+          context "using should_not" do
+            its("name")          { should_not eq("Paul") }
+          end
+
+          context "using is_expected" do
+            its("name")          { is_expected.to eq("John") }
+          end
 
-            def name
-              "George"
-            end
-          end.new
         end
-        its([:a]) { should eq("Symbol: a") }
-        its(['a']) { should eq("String: a") }
-        its([:b, 'c', 4]) { should eq("Symbol: b; String: c; Fixnum: 4") }
-        its(:name) { should eq("George") }
-        context "when referring to an attribute that doesn't exist" do
-          context "it raises an error" do
-            its(:age) do
-              expect do
-                should eq(64)
-              end.to raise_error(NoMethodError)
+
+        context "when it responds to #[]" do
+          subject do
+            Class.new do
+              def [](*objects)
+                objects.map do |object|
+                  "#{object.class}: #{object.to_s}"
+                end.join("; ")
+              end
+
+              def name
+                "George"
+              end
+            end.new
+          end
+          its([:a]) { should eq("Symbol: a") }
+          its(['a']) { should eq("String: a") }
+          its([:b, 'c', 4]) { should eq("Symbol: b; String: c; Fixnum: 4") }
+          its(:name) { should eq("George") }
+          context "when referring to an attribute that doesn't exist" do
+            context "it raises an error" do
+              its(:age) do
+                expect do
+                  should eq(64)
+                end.to raise_error(NoMethodError)
+              end
             end
           end
         end
-      end
 
-      context "when it does not respond to #[]" do
-        subject { Object.new }
+        context "when it does not respond to #[]" do
+          subject { Object.new }
 
-        context "it raises an error" do
-          its([:a]) do
-            expect do
-              should eq("Symbol: a")
-            end.to raise_error(NoMethodError)
+          context "it raises an error" do
+            its([:a]) do
+              expect do
+                should eq("Symbol: a")
+              end.to raise_error(NoMethodError)
+            end
           end
         end
-      end
 
-      context "calling and overriding super" do
-        it "calls to the subject defined in the parent group" do
-          group = RSpec::Core::ExampleGroup.describe(Array) do
-            subject { [1, 'a'] }
+        context "calling and overriding super" do
+          it "calls to the subject defined in the parent group" do
+            group = RSpec::Core::ExampleGroup.describe(Array) do
+              subject { [1, 'a'] }
 
-            its(:last) { should eq("a") }
+              its(:last) { should eq("a") }
 
-            describe '.first' do
-              def subject; super().first; end
+              describe '.first' do
+                def subject; super().first; end
 
-              its(:next) { should eq(2) }
+                its(:next) { should eq(2) }
+              end
             end
+
+            expect(group.run(NullFormatter.new)).to be_truthy
           end
+        end
 
-          expect(group.run(NullFormatter.new)).to be_truthy
+        context "with nil subject" do
+          subject do
+            Class.new do
+              def initialize
+                @counter = -1
+              end
+              def nil_if_first_time
+                @counter += 1
+                @counter == 0 ? nil : true
+              end
+            end.new
+          end
+          its(:nil_if_first_time) { should be(nil) }
         end
-      end
 
-      context "with nil subject" do
-        subject do
-          Class.new do
-            def initialize
-              @counter = -1
-            end
-            def nil_if_first_time
-              @counter += 1
-              @counter == 0 ? nil : true
-            end
-          end.new
+        context "with false subject" do
+          subject do
+            Class.new do
+              def initialize
+                @counter = -1
+              end
+              def false_if_first_time
+                @counter += 1
+                @counter > 0
+              end
+            end.new
+          end
+          its(:false_if_first_time) { should be(false) }
         end
-        its(:nil_if_first_time) { should be(nil) }
-      end
 
-      context "with false subject" do
-        subject do
-          Class.new do
-            def initialize
-              @counter = -1
-            end
-            def false_if_first_time
-              @counter += 1
-              @counter > 0
-            end
-          end.new
+        describe 'accessing `subject` in `before` and `let`' do
+          subject { 'my subject' }
+          before { @subject_in_before = subject }
+          let(:subject_in_let) { subject }
+          let!(:eager_loaded_subject_in_let) { subject }
+
+          # These examples read weird, because we're actually
+          # specifying the behaviour of `its` itself
+          its(nil) { expect(subject).to eq('my subject') }
+          its(nil) { expect(@subject_in_before).to eq('my subject') }
+          its(nil) { expect(subject_in_let).to eq('my subject') }
+          its(nil) { expect(eager_loaded_subject_in_let).to eq('my subject') }
         end
-        its(:false_if_first_time) { should be(false) }
-      end
 
-      describe 'accessing `subject` in `before` and `let`' do
-        subject { 'my subject' }
-        before { @subject_in_before = subject }
-        let(:subject_in_let) { subject }
-        let!(:eager_loaded_subject_in_let) { subject }
-
-        # These examples read weird, because we're actually
-        # specifying the behaviour of `its` itself
-        its(nil) { expect(subject).to eq('my subject') }
-        its(nil) { expect(@subject_in_before).to eq('my subject') }
-        its(nil) { expect(subject_in_let).to eq('my subject') }
-        its(nil) { expect(eager_loaded_subject_in_let).to eq('my subject') }
-      end
+        describe "in shared_context" do
+          shared_context "shared stuff" do
+            subject {Array}
+            its(:name) {should eq "Array"}
+          end
 
-      describe "in shared_context" do
-        shared_context "shared stuff" do
-          subject {Array}
-          its(:name) {should eq "Array"}
+          include_context "shared stuff"
         end
 
-        include_context "shared stuff"
-      end
+        describe "when extending SharedContext" do
+          it 'works with an implicit subject' do
+            shared = Module.new do
+              extend RSpec::SharedContext
+              its(:size) { should eq 0 }
+            end
+            group = RSpec::Core::ExampleGroup.describe(Array) do
+              include shared
+            end
 
-      describe "when extending SharedContext" do
-        it 'works with an implicit subject' do
-          shared = Module.new do
-            extend RSpec::SharedContext
-            its(:size) { should eq 0 }
-          end
-          group = RSpec::Core::ExampleGroup.describe(Array) do
-            include shared
+            group.run(NullFormatter.new)
+            # Using to_h[:status].to_sym in following instead of .status due to need to run in RSpec 2.99
+            expect(group.children.first.examples.first.execution_result.to_h[:status].to_sym).to eq(:passed)
           end
-
-          group.run(NullFormatter.new)
-          expect(group.children.first.examples.first.execution_result).to include(:status => "passed")
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-its
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Peter Alfvin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core