rspec-hue 0.1.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db7485876728c2deada251978bbb3ccd5eebc587
-  data.tar.gz: dbae4d22680eba2060bfd454f64541991ec07236
+  metadata.gz: 618121b3d95864794a80ba1afcd03e187660a3e3
+  data.tar.gz: 1cebc7b4f076a9ce9dc3d61077cb38df75e1fe28
 SHA512:
-  metadata.gz: a4787aa3ad6a2006088fe3d364aef5ffee0df78a0bf11b82e0709de9debcd1784c6f4bcdcb1df8cdb699ed41debf9321fd1b7fb08cc5f8f31c246890783cc277
-  data.tar.gz: ca764b3797ac88c79e9a3eb85b774f4e5349357a98479de4c7ebf2a532f31701d53e20d25e0db902b47d41dce2e2564ef626eece6ca4045c7bcd8c74c0723936
+  metadata.gz: 9085c5d629e4ca2932d779ef5bbbf574199154597798bd79be875670e4e97bd77c91d121a3049602bcad61bcc56658dc1453d8658866dc2b89f667472678b1be
+  data.tar.gz: 49e51ac9ae2dc45aca445dc6caa67a2076593c2c7c23c444708e087ed9c503ce4533306100d5536de27d87834540294e9147e2cb010b4d9e67fbfcb2656ad9c5

data/lib/philips_hue_controller.rb

@@ -2,6 +2,7 @@ require 'huey'
 require 'null_bulb'
 
 class PhilipsHueController
+
 	def initialize options = {}
 		@configuration = default_options.merge options
 		if configuration.has_key? :bulb_id_to_use
@@ -10,18 +11,23 @@ class PhilipsHueController
 			@bulb = passed_bulb_or_null_bulb
 		end
 	end
+
 	def failed
-		bulb.update(configuration[:failed_color])		
+		bulb.update(configuration[:failed_color])
 	end
+
 	def passed
-		bulb.update(configuration[:passed_color])		
+		bulb.update(configuration[:passed_color])
 	end
+
 	private
+
 	def configuration
 		@configuration
 	end
+
 	def default_options
-		{ 
+		{
 			hue_ip: nil,
 			ssdp_ip: '239.255.255.250',
 			ssdp_port: 1900,
@@ -33,25 +39,30 @@ class PhilipsHueController
 			passed_color: { bri: 57, ct: 500, xy: [ 0.408, 0.517 ] }
 		}
 	end
+
 	def output
 		configuration[:output]
 	end
+
 	def bulb
 		@bulb
 	end
+
 	def passed_bulb_or_null_bulb
 		configuration.fetch(:bulb, NullBulb.new )
 	end
+
 	def init_bulb
 		@bulb = Huey::Bulb.find(configuration[:bulb_id_to_use]) if configuration.has_key? :bulb_id_to_use
 		@bulb = passed_bulb_or_null_bulb if @bulb.nil? #Huey return nil if not found
 		@bulb.on = true
 		@bulb.transitiontime = configuration[:bulb_transition_time]
 	end
+
 	def init_philips_hue
 	 	# Must do this, othwerwise Huey starts pushing out debug messages
 	 	Huey::Config.logger = ::Logger.new(nil)
-		begin		
+		begin
 			Huey.configure do |config|
 				if configuration[:hue_ip].nil?
 					config.ssdp = true
@@ -79,7 +90,7 @@ class PhilipsHueController
 		rescue Huey::Errors::PressLinkButton
 			if STDIN.tty?
 				output.puts "RspecHue: Not authorized, press linkbutton on Philips Hue, then press enter here to continue, or q and enter to skip."
-				input = gets.strip 
+				input = gets.strip
 				unless input.downcase == "q"
 					init_philips_hue
 				else
@@ -91,4 +102,4 @@ class PhilipsHueController
 			end
 		end
 	end
-end
+end

data/lib/rspec_hue.rb

@@ -1,49 +1,79 @@
 require 'rspec'
 require 'philips_hue_controller'
 
-class RspecHue 
-	def initialize output, additional_args = {}
+class RspecHue
+
+	# ::RSpec::Core::Formatters.register self,
+ #    :example_passed,
+ #    :example_pending,
+ #    :example_failed,
+ #    :example_group_started,
+ #    :example_group_finished,
+ #    :dump_summary,
+ #    :seed
+
+	::RSpec::Core::Formatters.register self,
+		:example_failed,
+    :dump_summary
+
+	attr_reader :output, :failure_count, :bulb_controller
+
+	class << self
+		def configure_rspec_for_settings
+			RSpec.configure do |c|
+				c.add_setting :rspec_hue_light_id
+				c.add_setting :rspec_hue_ip
+				c.add_setting :rspec_hue_failed_color
+				c.add_setting :rspec_hue_passed_color
+				c.add_setting :rspec_hue_api_user
+			end
+		end
+	end
+
+	def initialize(output, additional_args = {})
 		@output = output || StringIO.new
 		@additional_args = additional_args
 		@failure_count = 0
-	end
-	#called by rspec
-	def dump_summary duration, example_count, failure_count, pending_count
+
 		@bulb_controller = @additional_args.fetch(:controller) { setup_philips_hue_controller }
-		@failure_count = failure_count
-	end
-	# Catch everything else rspec throws at us, and swallow it.
-	def method_missing m, *args, &block; end
-
-	def self.configure_rspec_for_settings
-		RSpec.configure do |c|
-			c.add_setting :rspec_hue_light_id
-			c.add_setting :rspec_hue_ip
-			c.add_setting :rspec_hue_failed_color
-			c.add_setting :rspec_hue_passed_color
-			c.add_setting :rspec_hue_api_user
-		end
 	end
 
-	# called by rspec when finished
-	def close()
+	def example_passed(notification)
+  end
+
+  def example_pending(notification)
+  end
+
+  def example_failed(notification)
+    @failure_count += 1
+  end
+
+	def dump_summary(summary)
 		init_bulb_controller
-		if failed 
-			bulb_controller.failed 
-		else 
+
+		if failed?
+			bulb_controller.failed
+		else
 			bulb_controller.passed
 		end
 	end
 
+
 	private
+
 	def init_bulb_controller
 		@bulb_controller = @additional_args.fetch(:controller) { setup_philips_hue_controller }
 	end
-	def failed
+
+	def failed?
 		@failure_count > 0
 	end
+
 	def setup_philips_hue_controller
-		options = { bulb_id_to_use: RSpec.configuration.rspec_hue_light_id, output: output }
+		options = {
+			bulb_id_to_use: ENV["RSPEC_HUE_LIGHT_ID"] || RSpec.configuration.rspec_hue_light_id,
+			output: output
+		}
 		failed_color = RSpec.configuration.rspec_hue_failed_color
 		passed_color = RSpec.configuration.rspec_hue_passed_color
 		hue_ip = RSpec.configuration.rspec_hue_ip
@@ -54,12 +84,7 @@ class RspecHue
 		options[:api_user] = api_user unless api_user.nil?
 		PhilipsHueController.new options
 	end
-	def output
-		@output
-	end
-	def bulb_controller
-		@bulb_controller
-	end
-end	
+end
+
 # Must call to add setting-possibilty to RSpec
 RspecHue.configure_rspec_for_settings

data/rspec-hue.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "rspec-hue"
-  spec.version       = '0.1.3' 
+  spec.version       = '1.0.0'
   spec.authors       = ["larskrantz"]
   spec.email         = ["lars.krantz@alaz.se"]
   spec.description   = %q{Light up Philips Hue when testing}

data/spec/philips_hue_controller_spec.rb

@@ -8,13 +8,13 @@ describe PhilipsHueController do
 
 	context "when telling controller to light bulb for failing test" do
 		it "the bulb should receive update with failcolor" do
-			bulb.should_receive(:update).with(failed_color)
+			expect(bulb).to receive(:update).with(failed_color)
 			controller.failed
 		end
 	end
 	context "when telling controller to light bulb for passing test" do
 		it "the bulb should receive update with passcolor" do
-			bulb.should_receive(:update).with(passed_color)
+			expect(bulb).to receive(:update).with(passed_color)
 			controller.passed
 		end
 	end
@@ -39,4 +39,4 @@ describe PhilipsHueController do
 			end
 		end
 	end
-end
+end

data/spec/rspec_hue_spec.rb

@@ -7,35 +7,43 @@ describe RspecHue do
 				config.send (setting.to_s + "=").to_sym, RSpec.configuration.send(setting)
 			end
 		end
+
 		it "should be able to set :rspec_hue_light_id" do
 			expect { set_rspec_setting :rspec_hue_light_id }.to_not raise_exception
 		end
+
 		it "should be able to set :rspec_hue_ip" do
 			expect { set_rspec_setting :rspec_hue_ip }.to_not raise_exception
 		end
+
 		it "should be able to set :rspec_hue_failed_color" do
 			expect { set_rspec_setting :rspec_hue_failed_color }.to_not raise_exception
 		end
+
 		it "should be able to set :rspec_hue_passed_color" do
 			expect { set_rspec_setting :rspec_hue_passed_color }.to_not raise_exception
 		end
+
 		it "should be able to set :rspec_hue_api_user" do
 			expect { set_rspec_setting :rspec_hue_api_user }.to_not raise_exception
 		end
 	end
+
 	context "when corresponding to the formatter interface" do
 		let(:controller) do
-			c = double("controller")
-			c.stub(:failed)
-			c.stub(:passed)
-			c
+			double("controller").tap do |c|
+				allow(c).to receive(:failed)
+				allow(c).to receive(:passed)
+			end
 		end
 		let(:formatter) { RspecHue.new StringIO.new, controller: controller }
+
 		it "should respond dump_summary" do
-			expect { formatter.dump_summary 123,2,1,1 }.to_not raise_exception
+			expect { formatter.dump_summary "foo" }.to_not raise_exception
 		end
-		it "should not raise error if calling close() before dump_summary" do
-			expect { formatter.close() }.to_not raise_exception
+
+		it "should increment #failed_count by 1" do
+			expect { formatter.example_failed(nil) }.to change { formatter.failure_count }.by(1)
 		end
 	end
-end
+end

data/spec/spec_helper.rb

@@ -6,7 +6,6 @@ require 'rspec_hue'
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.filter_run_excluding :integration

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-hue
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 1.0.0
 platform: ruby
 authors:
 - larskrantz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-20 00:00:00.000000000 Z
+date: 2015-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Let your Philips Hue indicate if tests are passing or not